[Bug 706070] Review Request: keytool-maven-plugin - A plugin that wraps the keytool program and allows to manipulate keystores
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706070 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Blocks|652183(FE-JAVASIG) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706070] Review Request: keytool-maven-plugin - A plugin that wraps the keytool program and allows to manipulate keystores
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706070 Jaromír Cápík jca...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Last Closed||2011-05-23 07:58:38 --- Comment #7 from Jaromír Cápík jca...@redhat.com 2011-05-23 07:58:38 EDT --- The package built successfuly: https://koji.fedoraproject.org/koji/buildinfo?buildID=244856 Thanks for the review and git repo. Closing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706070] Review Request: keytool-maven-plugin - A plugin that wraps the keytool program and allows to manipulate keystores
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706070 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||akurt...@redhat.com AssignedTo|nob...@fedoraproject.org|akurt...@redhat.com Flag||fedora-review? --- Comment #1 from Alexander Kurtakov akurt...@redhat.com 2011-05-20 04:12:49 EDT --- I would do this one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706070] Review Request: keytool-maven-plugin - A plugin that wraps the keytool program and allows to manipulate keystores
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=706070
--- Comment #2 from Alexander Kurtakov akurt...@redhat.com 2011-05-20
04:23:50 EDT ---
Package Review
==
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Rpmlint output:
keytool-maven-plugin.noarch: W: spelling-error Summary(en_US) keystores -
keystones, key stores, key-stores
keytool-maven-plugin.noarch: W: spelling-error %description -l en_US keystores
- keystones, key stores, key-stores
keytool-maven-plugin.noarch: W: spelling-error %description -l en_US genkey -
gen key, gen-key, monkey
keytool-maven-plugin.noarch: W: non-conffile-in-etc
/etc/maven/fragments/keytool-maven-plugin
OK
[x] Package is named according to the Package Naming Guidelines[1].
[x] Spec file name must match the base package name, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines[2].
[x] Package successfully compiles and builds into binary rpms.
[x] Buildroot definition is not present
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging
Guidelines[3,4].
[!] License field in the package spec file matches the actual license.
License type: According to the license file it's MIT but all the source files
have ASL 2.0 headers. So I should say License: MIT and ASL 2.0 and contact
upstream to fix the cituation.
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] All independent sub-packages have license of their own
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines[5].
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package does NOT have a %clean section which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT). (not needed anymore)
[x] Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT
mixing)
[x] Package contains code, or permissable content.
[x] Fully versioned dependency in subpackages, if present.
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
[x] Javadoc documentation files are generated and included in -javadoc
subpackage
[x] Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks)
[x] Packages have proper BuildRequires/Requires on jpackage-utils
[x] Javadoc subpackages have Require: jpackage-utils
[x] Package uses %global not %define
[x] If package uses tarball from VCS include comment how to re-create that
tarball (svn export URL, git clone URL, ...)
[-] If source tarball includes bundled jar/class files these need to be
removed prior to building
[x] All filenames in rpm packages must be valid UTF-8.
[x] Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details)
[x] If package contains pom.xml files install it (including depmaps) even when
building with ant
[x] pom files has correct add_to_maven_depmap call which resolves to the pom
file (use JPP. and JPP- correctly)
=== Maven ===
[x] Use %{_mavenpomdir} macro for placing pom files instead of
%{_datadir}/maven2/poms
[-] If package uses -Dmaven.test.skip=true explain why it was needed in a
comment
[-] If package uses custom depmap -Dmaven2.jpp.depmap.file=* explain why
it's needed in a comment
[x] Package uses %update_maven_depmap in %post/%postun
[x] Packages have Requires(post) and Requires(postun) on jpackage-utils (for
%update_maven_depmap macro)
=== Other suggestions ===
[x] If possible use upstream build method (maven/ant/javac)
[x] Avoid having BuildRequires on exact NVR unless necessary
[x] Package has BuildArch: noarch (if possible)
[x] Latest version is packaged.
[x] Reviewer should test that the package builds in mock.
=== Issues ===
1. License field is not correct.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706070] Review Request: keytool-maven-plugin - A plugin that wraps the keytool program and allows to manipulate keystores
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706070 --- Comment #3 from Jaromír Cápík jca...@redhat.com 2011-05-20 07:13:28 EDT --- Spec URL: http://jcapik.fedorapeople.org/files/keytool-maven-plugin/2/keytool-maven-plugin.spec SRPM URL: http://jcapik.fedorapeople.org/files/keytool-maven-plugin/2/keytool-maven-plugin-1.0-2.fc14.src.rpm Fixed ... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706070] Review Request: keytool-maven-plugin - A plugin that wraps the keytool program and allows to manipulate keystores
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706070 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Alexander Kurtakov akurt...@redhat.com 2011-05-20 07:29:52 EDT --- Looks good. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706070] Review Request: keytool-maven-plugin - A plugin that wraps the keytool program and allows to manipulate keystores
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706070 Jaromír Cápík jca...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Jaromír Cápík jca...@redhat.com 2011-05-20 07:45:09 EDT --- New Package SCM Request === Package Name: keytool-maven-plugin Short Description: A plugin that wraps the keytool program and allows to manipulate keystores Owners: jcapik Branches: f15 InitialCC: java-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706070] Review Request: keytool-maven-plugin - A plugin that wraps the keytool program and allows to manipulate keystores
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706070 --- Comment #6 from Kevin Fenzi ke...@scrye.com 2011-05-20 18:33:06 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706070] Review Request: keytool-maven-plugin - A plugin that wraps the keytool program and allows to manipulate keystores
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706070 Jaromír Cápík jca...@redhat.com changed: What|Removed |Added Blocks||652183(FE-JAVASIG) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
