[Bug 707002] Review Request: freemedforms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 Michael Schwendt changed: What|Removed |Added CC||mschwe...@gmail.com --- Comment #28 from Michael Schwendt 2011-09-29 19:47:03 EDT --- To the reviewer: please notice bug 742396 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: freemedforms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 Fedora Update System changed: What|Removed |Added Fixed In Version|freemedforms-0.5.9-0.1.alph |freemedforms-0.5.9-0.1.alph |a1.fc14 |a1.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: freemedforms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 --- Comment #27 from Fedora Update System 2011-07-22 15:36:48 EDT --- freemedforms-0.5.9-0.1.alpha1.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: freemedforms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 Fedora Update System changed: What|Removed |Added Fixed In Version||freemedforms-0.5.9-0.1.alph ||a1.fc14 Resolution|CURRENTRELEASE |ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: freemedforms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 --- Comment #26 from Fedora Update System 2011-07-22 15:28:39 EDT --- freemedforms-0.5.9-0.1.alpha1.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: freemedforms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 Ankur Sinha changed: What|Removed |Added Status|ON_QA |CLOSED Resolution||CURRENTRELEASE Last Closed||2011-07-17 10:23:39 --- Comment #25 from Ankur Sinha 2011-07-17 10:23:39 EDT --- Built and pushed to repos for testing. Closing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: freemedforms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 --- Comment #24 from Ankur Sinha 2011-07-12 09:05:33 EDT --- Yep. I left them in the debuginfo package. I'll push an updated version once the package hits stable. I just want to make sure it's working nicely :) Thanks Eric and Lakshmi :) Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: freemedforms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 Lakshmi Narasimhan changed: What|Removed |Added Flag|needinfo? | --- Comment #23 from Lakshmi Narasimhan 2011-07-12 08:57:19 EDT --- Thanks for the clarifications Eric. Ankur, we could leave the .moc folders as it is for the debuginfo package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: freemedforms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 Eric Maeker changed: What|Removed |Added Flag||needinfo? --- Comment #22 from Eric Maeker 2011-07-12 07:34:58 EDT --- Oooohhh I'm tired. > I'd to suggest some answer (as upstreamer) to your questionnings. I'd like to suggest some answers (as upstreamer) to your questionnings. > All these dirs are created by the qmake step (build step) and are included in > the original source. All these dirs are created by the qmake step (build step) and are *not* included in the original source tarball. Eric -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: freemedforms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 --- Comment #21 from Eric Maeker 2011-07-12 07:32:07 EDT --- Hello, Thanks for your work. It is great success to represented in Fedora repositories. I'd to suggest some answer (as upstreamer) to your questionnings. - [?]MUST: The package must contain code, or permissible content. Pixmaps, sqlite databases and following text files /usr/share/freemedforms/textfiles/boys_surnames.csv /usr/share/freemedforms/textfiles/default_user_footer.htm /usr/share/freemedforms/textfiles/default_user_header.htm /usr/share/freemedforms/textfiles/girls_surnames.csv /usr/share/freemedforms/textfiles/listemotsfr.txt /usr/share/freemedforms/textfiles/pays.txt /usr/share/freemedforms/textfiles/surnames.txt /usr/share/freemedforms/textfiles/zipcodes.csv Do those text files come under permissable content category, especially those containing zip codes of places and surnames? - All data files, databases and extra content is licenced with the GPLv3. We can not add headers in files while these files are automatically processed by the app. - freemedforms-devel.i686: W: non-standard-group Development/Libraries/C and C++ The value of the Group tag in the package is not valid. Valid groups are: "Amusements/Games", "Amusements/Graphics", "Applications/Archiving", "Applications/Communications", "Applications/Databases", "Applications/Editors", "Applications/Emulators", "Applications/Engineering", "Applications/File", "Applications/Internet", "Applications/Multimedia", "Applications/Productivity", "Applications/Publishing", "Applications/System", "Applications/Text", "Development/Debug", "Development/Debuggers", "Development/Languages", "Development/Libraries", "Development/System", "Development/Tools", "Documentation", "System Environment/Base", "System Environment/Daemons", "System Environment/Kernel", "System Environment/Libraries", "System Environment/Shells", "Unspecified", "User Interface/Desktops", "User Interface/X", "User Interface/X Hardware Support". - Can I suggest the "Applications/Productivity" group. The FreeMedForms EMR, for medical doctors, is like OOo that a book writer will need to work. - freemedforms-debuginfo.i686: W: hidden-file-or-dir - All these dirs are created by the qmake step (build step) and are included in the original source. Another information, there is a new upstream version available: 0.5.9~alpha2 ready for packaging. Thanks for your work and time. Eric -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: freemedforms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #20 from Fedora Update System 2011-07-12 01:18:35 EDT --- freemedforms-0.5.9-0.1.alpha1.fc15 has been pushed to the Fedora 15 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: freemedforms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: freemedforms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 --- Comment #19 from Fedora Update System 2011-07-11 00:11:05 EDT --- freemedforms-0.5.9-0.1.alpha1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/freemedforms-0.5.9-0.1.alpha1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: freemedforms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 --- Comment #18 from Fedora Update System 2011-07-11 00:10:57 EDT --- freemedforms-0.5.9-0.1.alpha1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/freemedforms-0.5.9-0.1.alpha1.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: freemedforms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 --- Comment #17 from Jon Ciesla 2011-07-10 16:47:13 EDT --- Git done (by process-git-requests). Awesome, thanks for clarifying. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: freemedforms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 Ankur Sinha changed: What|Removed |Added Alias|FreeMedForms|freemedforms -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: freemedforms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 Ankur Sinha changed: What|Removed |Added Flag||fedora-cvs? --- Comment #16 from Ankur Sinha 2011-07-10 09:34:54 EDT --- New Package SCM Request === Package Name: freemedforms Short Description: An open Electronic Medical Record Manager Owners: ankursinha Branches: f14 f15 InitialCC: susmit mrceresa -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: freemedforms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 Ankur Sinha changed: What|Removed |Added Summary|Review Request: |Review Request: |FreeMedForms - An open |freemedforms - An open |Electronic Medical Record |Electronic Medical Record |Manager |Manager --- Comment #15 from Ankur Sinha 2011-07-10 09:34:15 EDT --- Lower case please. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: FreeMedForms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 --- Comment #14 from Jon Ciesla 2011-07-10 09:03:04 EDT --- SCM request says freemedforms, summary says FreeMedForms. It looks like most things upstream are FreeMedForms, but the source file is lower case. Which do you intend to use? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: FreeMedForms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 Ankur Sinha changed: What|Removed |Added Flag||fedora-cvs? --- Comment #13 from Ankur Sinha 2011-07-10 06:04:34 EDT --- New Package SCM Request === Package Name: freemedforms Short Description: An open Electronic Medical Record Manager Owners: ankursinha Branches: f14 f15 InitialCC: susmit mrceresa -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: FreeMedForms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 Lakshmi Narasimhan changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #12 from Lakshmi Narasimhan 2011-07-10 04:56:58 EDT --- >The latest quazip sources do not have the global files. Eric has written these >as a simple wrapper around quazip and therefore can license them as he wishes. >I don't think there's an issue here. Ok I see. Then looks fine. > The .moc folders are created by QT compiler. Yeah. If it doesn't harm the build process. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: FreeMedForms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 --- Comment #10 from Ankur Sinha 2011-07-10 00:28:43 EDT --- > > Two issues. > > 1) Files under contrib/quazip are licensed as GPLv3. If these files are > modifications of LPGL code from quazip, can they be relicensed as GPLv3? The latest quazip sources do not have the global files. Eric has written these as a simple wrapper around quazip and therefore can license them as he wishes. I don't think there's an issue here. > 2) Do those text files come under permissable content category, especially > those containing zip codes of places and surnames? They're generic lists, not pertaining to persons individually. Highly unlikely there's an issue here too :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: FreeMedForms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 --- Comment #11 from Ankur Sinha 2011-07-10 00:30:09 EDT --- (In reply to comment #7) > Ignore HTTP errors. > > Needs fixing: > 1) freemedforms-devel.i686: W: non-standard-group Development/Libraries/C and > C++. > Probably put Applications/Databases. Okay. Corrected. (In reply to comment #8) > The .moc folders are created by QT compiler. Should I delete these, or let them be? Thank you, Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: FreeMedForms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 --- Comment #9 from Lakshmi Narasimhan 2011-07-09 12:55:41 EDT --- Also internal rpaths are allowed according to http://fedoraproject.org/wiki/Packaging:Guidelines#Rpath_for_Internal_Libraries -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: FreeMedForms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 --- Comment #7 from Lakshmi Narasimhan 2011-07-09 12:45:14 EDT --- Ignore HTTP errors. Needs fixing: 1) freemedforms-devel.i686: W: non-standard-group Development/Libraries/C and C++. Probably put Applications/Databases. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: FreeMedForms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 --- Comment #8 from Lakshmi Narasimhan 2011-07-09 12:47:15 EDT --- The .moc folders are created by QT compiler. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: FreeMedForms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 --- Comment #6 from Lakshmi Narasimhan 2011-07-09 12:42:32 EDT --- rpmlint output freemedforms.i686: E: devel-dependency freemedforms-devel Your package has a dependency on a devel package but it's not a devel package itself. freemedforms.i686: W: spelling-error %description -l en_US plugins -> plug ins, plug-ins, plugging The value of this tag appears to be misspelled. Please double-check. freemedforms.i686: W: incoherent-version-in-changelog 0.5.9-0.1alpha1 ['0.5.9-0.1.alpha1.fc14', '0.5.9-0.1.alpha1'] The latest entry in %changelog contains a version identifier that is not coherent with the epoch:version-release tuple of the package. freemedforms.i686: E: binary-or-shlib-defines-rpath /usr/lib/freemedforms/libUtils.so.1.0.0 ['$ORIGIN', '/usr/lib/freemedforms'] The binary or shared library defines `RPATH'. Usually this is a bad thing because it hardcodes the path to search libraries and so makes it difficult to move libraries around. Most likely you will find a Makefile with a line like: gcc test.o -o test -Wl,--rpath. Also, sometimes configure scripts provide a --disable-rpath flag to avoid this. freemedforms.i686: E: binary-or-shlib-defines-rpath /usr/lib/freemedforms/libMedicalUtils.so.1.0.0 ['$ORIGIN', '/usr/lib/freemedforms'] The binary or shared library defines `RPATH'. Usually this is a bad thing because it hardcodes the path to search libraries and so makes it difficult to move libraries around. Most likely you will find a Makefile with a line like: gcc test.o -o test -Wl,--rpath. Also, sometimes configure scripts provide a --disable-rpath flag to avoid this. freemedforms.i686: E: binary-or-shlib-defines-rpath /usr/lib/freemedforms/libExtensionSystem.so.1.0.0 ['$ORIGIN', '/usr/lib/freemedforms'] The binary or shared library defines `RPATH'. Usually this is a bad thing because it hardcodes the path to search libraries and so makes it difficult to move libraries around. Most likely you will find a Makefile with a line like: gcc test.o -o test -Wl,--rpath. Also, sometimes configure scripts provide a --disable-rpath flag to avoid this. freemedforms.i686: E: binary-or-shlib-defines-rpath /usr/lib/freemedforms/libAggregation.so.1.0.0 ['$ORIGIN', '/usr/lib/freemedforms'] The binary or shared library defines `RPATH'. Usually this is a bad thing because it hardcodes the path to search libraries and so makes it difficult to move libraries around. Most likely you will find a Makefile with a line like: gcc test.o -o test -Wl,--rpath. Also, sometimes configure scripts provide a --disable-rpath flag to avoid this. freemedforms.i686: E: binary-or-shlib-defines-rpath /usr/bin/FreeMedForms ['$ORIGIN', '/usr/lib/freemedforms'] The binary or shared library defines `RPATH'. Usually this is a bad thing because it hardcodes the path to search libraries and so makes it difficult to move libraries around. Most likely you will find a Makefile with a line like: gcc test.o -o test -Wl,--rpath. Also, sometimes configure scripts provide a --disable-rpath flag to avoid this. freemedforms.i686: E: binary-or-shlib-defines-rpath /usr/lib/freemedforms/libTranslationUtils.so.1.0.0 ['$ORIGIN', '/usr/lib/freemedforms'] The binary or shared library defines `RPATH'. Usually this is a bad thing because it hardcodes the path to search libraries and so makes it difficult to move libraries around. Most likely you will find a Makefile with a line like: gcc test.o -o test -Wl,--rpath. Also, sometimes configure scripts provide a --disable-rpath flag to avoid this. freemedforms.i686: W: no-manual-page-for-binary FreeMedForms Each executable in standard binary directories should have a man page. freemedforms-devel.i686: W: non-standard-group Development/Libraries/C and C++ The value of the Group tag in the package is not valid. Valid groups are: "Amusements/Games", "Amusements/Graphics", "Applications/Archiving", "Applications/Communications", "Applications/Databases", "Applications/Editors", "Applications/Emulators", "Applications/Engineering", "Applications/File", "Applications/Internet", "Applications/Multimedia", "Applications/Productivity", "Applications/Publishing", "Applications/System", "Applications/Text", "Development/Debug", "Development/Debuggers", "Development/Languages", "Development/Libraries", "Development/System", "Development/Tools", "Documentation", "System Environment/Base", "System Environment/Daemons", "System Environment/Kernel", "System Environment/Libraries", "System Environment/Shells", "Unspecified", "User Interface/Desktops", "User Interface/X", "User Interface/X Hardware Support". freemedforms-devel.i686: E: binary-or-shlib-defines-rpath /usr/lib/freemedforms/libICD.so ['$ORIGIN', '$ORIGIN/..'] The binary or shared library defines `RPATH'. Usually this is a bad thing because it hardcodes the path to search libraries and s
[Bug 707002] Review Request: FreeMedForms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=707002
Lakshmi Narasimhan changed:
What|Removed |Added
Status|NEW |ASSIGNED
--- Comment #5 from Lakshmi Narasimhan 2011-07-09
12:28:10 EDT ---
[+]MUST: rpmlint must be run on every package. The output should be posted in
the review.
[+]MUST: The package must be named according to the Package Naming Guidelines.
[+]MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec
[+]MUST: The package must meet the Packaging Guidelines.
Naming-Yes
Version-release - Matches the guidelines related to prerelease
software.
No prebuilt external bits - OK
Spec legibity - OK
Package template - OK
Arch support - OK
Libexecdir - OK
rpmlint - yes
changelogs - OK
Source url tag - OK, validated.
Build Requires list - OK
Summary and description - OK
API documentation - OK
[?]MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
Files under contrib/quazip are licensed as GPLv3. If these files are
modifications of LPGL code from quazip,
can they be relicensed as GPLv3?
[+]MUST: The License field in the package spec file must match the actual
license.
Dual licensed file.
[+]MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
COPYING.txt included.
[+]MUST: The spec file must be written in American English.
[+]MUST: The spec file for the package MUST be legible.
[+]MUST: The sources used to build the package must match the upstream
source,as provided in the spec URL. Reviewers should use md5sum for this task.
md5sum freemedformsfullsources-0.5.9~alpha1.tgz
78e5ddf14f9decce9c466fc8bb2b12b1 freemedformsfullsources-0.5.9~alpha1.tgz
md5sum ~/Downloads/freemedformsfullsources-0.5.9~alpha1.tgz
78e5ddf14f9decce9c466fc8bb2b12b1
/home/lvaikunt/Downloads/freemedformsfullsources-0.5.9~alpha1.tgz
[+]MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
Built on i686.
[+]MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[+]MUST: All build dependencies must be listed in BuildRequires.
[NA]MUST: The spec file MUST handle locales properly using the %find_lang macro
[NA]MUST: Packages stores shared library files must call ldconfig in %post and
%postun.
[+]MUST: Packages must NOT bundle copies of system libraries.
Checked with rpmquery --list
[NA]MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review.
[+]MUST: A package must own all directories that it creates.
Checked with rpmquery --whatprovides
[+]MUST: A Fedora package must not list a file more than once in the spec
file's %files listings.
[+]MUST: Permissions on files must be set properly.
Checked with ls -LR
[+]MUST: Each package must consistently use macros.
[?]MUST: The package must contain code, or permissible content.
Pixmaps, sqlite databases and following text files
/usr/share/freemedforms/textfiles/boys_surnames.csv
/usr/share/freemedforms/textfiles/default_user_footer.htm
/usr/share/freemedforms/textfiles/default_user_header.htm
/usr/share/freemedforms/textfiles/girls_surnames.csv
/usr/share/freemedforms/textfiles/listemotsfr.txt
/usr/share/freemedforms/textfiles/pays.txt
/usr/share/freemedforms/textfiles/surnames.txt
/usr/share/freemedforms/textfiles/zipcodes.csv
[+]MUST: Large documentation files must go in a -doc subpackage.
[+]MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[NA]MUST: Header files must be in a -devel package.
[NA]MUST: Static libraries must be in a -static package.
[NA]MUST: If a package contains library files with a suffix
(e.g.libfoo.so.1.1), then library files that end in .so (without suffix) must
go in a -devel package.
[+]MUST: devel packages must require the base package using a fully versioned
dependency: Requires: {name} = %{version}-%{release}
freemedforms = 0.5.9 is needed by (installed)
freemedforms-devel-0.5.9-0.1.alpha1.fc14.i686
[NA]MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
[NA]MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section
[+]MUST: Packages must not own files or directories already owned by other
packages.
[+]MUST: All filenames in rpm packages must be valid U
[Bug 707002] Review Request: FreeMedForms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 --- Comment #4 from Ankur Sinha 2011-06-15 11:10:40 EDT --- I've built and tested it. It works :) A scratch build for x86_64 is here: http://koji.fedoraproject.org/koji/taskinfo?taskID=3132734 Updated spec: http://ankursinha.fedorapeople.org/freemedforms/freemedforms.spec Updated srpm: http://ankursinha.fedorapeople.org/freemedforms/freemedforms-0.5.9-0.1.alpha1.fc15.src.rpm Thanks, Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: FreeMedForms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=707002
--- Comment #3 from Ankur Sinha 2011-06-15 06:34:27
EDT ---
(In reply to comment #2)
> Hi Ankur,
Hi Eric!
>
> Thanks for this great work. We are greatly pleased to be included in Fedora
> Medical and in Fedora in general.
Thank you for taking time out to give us these hints :D
>
> Just some comments on the presentation:
> - license is mainly GPLv3 + LGPL (for some parts)
Corrected.
> - need Qt v4.6.2 at least
Yes. I'm building against 4.7.2:
[root@ankur ~]# repoquery qt-devel
qt-devel-1:4.7.2-8.fc15.i686
>
> For the spec:
> - in order to create the translation add in the %build tag (before the qmake
> step)
> lrelease global_resources/translations/*.ts
> - LOWERED_APPNAME=FreeMedForms --> needs to be lowered ;) so
> LOWERED_APPNAME="freemedforms". Then libs and plugs should be installed in
> %{_libdir}/freemedforms
Corrected.
>
> I saw a problem with rpath, 0.5.9~alpha2 should solve it (idem for the debian
> packages).
I'll update the package once you release alpha2 :)
>
> There should be a small issue with the version numbering (because the version
> is parsed in the code). Can't you use 0.5.9~alpha1 instead of 0.5.9-0.1.alpha1
> ? Otherwise I need to patch the 0.5.9~alpha2 code ;)
Uhm, I'll have to ask around. From the guidelines, it should be "0.1.alpha2".
Are you sure the versioning of the rpm has an affect on the package? I haven't
changed the versioning in the build anywhere. It's only for the rpm.
>
> Can you add a link to our main website: http://www.freemedforms.com/
>
Added :)
> Fell free to contact us at any time for any question at
> freemedfo...@googlegroups.com
I just joined the google groups :)
>
> Thanks for your work
> Eric Maeker
I noticed that freemedforms also bundles quazip. However, the version bundled
has a "global.h" file, which the latest quazip does not have:
http://sourceforge.net/projects/quazip/files%2Fquazip%2F0.4.1%2Fquazip-0.4.1.tar.gz/download
What version of quazip is being used here? Is this include from quazip, or a
modification required only for freemedforms?
In the meantime, I cannot build freemedforms :/ (due to the missing global.h
file in the fedora quazip libraries)
[root@ankur ~]# repoquery -l quazip-devel quazip | egrep "\.h$"
/usr/include/quazip/JlCompress.h
/usr/include/quazip/quaadler32.h
/usr/include/quazip/quachecksum32.h
/usr/include/quazip/quacrc32.h
/usr/include/quazip/quazip.h
/usr/include/quazip/quazipfile.h
/usr/include/quazip/quazipfileinfo.h
/usr/include/quazip/quazipnewinfo.h
/usr/include/quazip/JlCompress.h
/usr/include/quazip/quaadler32.h
/usr/include/quazip/quachecksum32.h
/usr/include/quazip/quacrc32.h
/usr/include/quazip/quazip.h
/usr/include/quazip/quazipfile.h
/usr/include/quazip/quazipfileinfo.h
/usr/include/quazip/quazipnewinfo.h
Thank you Eric :)
Ankur
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: FreeMedForms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=707002
Eric Maeker changed:
What|Removed |Added
CC||eric.mae...@gmail.com
--- Comment #2 from Eric Maeker 2011-06-15 02:49:59 EDT
---
Hi Ankur,
Thanks for this great work. We are greatly pleased to be included in Fedora
Medical and in Fedora in general.
Just some comments on the presentation:
- license is mainly GPLv3 + LGPL (for some parts)
- need Qt v4.6.2 at least
For the spec:
- in order to create the translation add in the %build tag (before the qmake
step)
lrelease global_resources/translations/*.ts
- LOWERED_APPNAME=FreeMedForms --> needs to be lowered ;) so
LOWERED_APPNAME="freemedforms". Then libs and plugs should be installed in
%{_libdir}/freemedforms
I saw a problem with rpath, 0.5.9~alpha2 should solve it (idem for the debian
packages).
There should be a small issue with the version numbering (because the version
is parsed in the code). Can't you use 0.5.9~alpha1 instead of 0.5.9-0.1.alpha1
? Otherwise I need to patch the 0.5.9~alpha2 code ;)
Can you add a link to our main website: http://www.freemedforms.com/
Fell free to contact us at any time for any question at
freemedfo...@googlegroups.com
Thanks for your work
Eric Maeker
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: FreeMedForms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 Ankur Sinha changed: What|Removed |Added Alias||FreeMedForms -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: FreeMedForms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 Lakshmi Narasimhan changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: FreeMedForms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 --- Comment #1 from Ankur Sinha 2011-06-03 02:51:20 EDT --- Hey Lakshmi, If you're going to review this, can you please set the review flag to "?". Thanks! :) Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: FreeMedForms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 Lakshmi Narasimhan changed: What|Removed |Added CC||lakshminaras2...@gmail.com AssignedTo|nob...@fedoraproject.org|lakshminaras2...@gmail.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: FreeMedForms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 Ankur Sinha changed: What|Removed |Added Blocks||673841(fedora-medical) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
