[Bug 707389] Review Request: libwebp - Library and tools for the WebP graphics format
https://bugzilla.redhat.com/show_bug.cgi?id=707389 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version||libwebp-0.4.3-3.el6 Resolution|RAWHIDE |ERRATA --- Comment #22 from Fedora Update System upda...@fedoraproject.org --- libwebp-0.4.3-3.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707389] Review Request: libwebp - Library and tools for the WebP graphics format
https://bugzilla.redhat.com/show_bug.cgi?id=707389 --- Comment #21 from Fedora Update System upda...@fedoraproject.org --- libwebp-0.4.3-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/libwebp-0.4.3-3.el6 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707389] Review Request: libwebp - Library and tools for the WebP graphics format
https://bugzilla.redhat.com/show_bug.cgi?id=707389 --- Comment #18 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707389] Review Request: libwebp - Library and tools for the WebP graphics format
https://bugzilla.redhat.com/show_bug.cgi?id=707389 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707389] Review Request: libwebp - Library and tools for the WebP graphics format
https://bugzilla.redhat.com/show_bug.cgi?id=707389 --- Comment #19 from Fedora Update System upda...@fedoraproject.org --- libwebp-0.4.3-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/libwebp-0.4.3-1.el6 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707389] Review Request: libwebp - Library and tools for the WebP graphics format
https://bugzilla.redhat.com/show_bug.cgi?id=707389 --- Comment #20 from Fedora Update System upda...@fedoraproject.org --- libwebp-0.4.3-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/libwebp-0.4.3-2.el6 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707389] Review Request: libwebp - Library and tools for the WebP graphics format
https://bugzilla.redhat.com/show_bug.cgi?id=707389 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added CC||or...@cora.nwra.com --- Comment #16 from Orion Poplawski or...@cora.nwra.com --- Note that libwebp is in RHEL7 proper, so no epel branch should be made. But thanks! -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707389] Review Request: libwebp - Library and tools for the WebP graphics format
https://bugzilla.redhat.com/show_bug.cgi?id=707389 Sandro Mani manisan...@gmail.com changed: What|Removed |Added CC||manisan...@gmail.com Flags|fedora-cvs+ |fedora-cvs? --- Comment #15 from Sandro Mani manisan...@gmail.com --- Package Change Request == Package Name: libwebp New Branches: el6 epel7 Owners: smani InitialCC: -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707389] Review Request: libwebp - Library and tools for the WebP graphics format
https://bugzilla.redhat.com/show_bug.cgi?id=707389 --- Comment #17 from Sandro Mani manisan...@gmail.com --- Oh, ok, thanks for pointing out! Package Change Request == Package Name: libwebp New Branches: el6 Owners: smani InitialCC: -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707389] Review Request: libwebp - Library and tools for the WebP graphics format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707389 --- Comment #14 from John Ellson john.ell...@comcast.net 2012-02-02 10:39:07 EST --- Just FYI.At http://www.graphviz.org/ there are new development snapshot rpms of graphviz for fc17 that now include a libwebp plugin (graphviz-webp). Thanks for packaging libwebp. Now its up to me to get a stable release of graphviz posted. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707389] Review Request: libwebp - Library and tools for the WebP graphics format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707389 --- Comment #7 from Peter Lemenkov lemen...@gmail.com 2012-02-01 12:43:08 EST --- (In reply to comment #6) (In reply to comment #5) Peter, I'm waiting for Rahul to respond to comment 3. I then plan to approve this. Ok, understood. Scott, if anything went wrong, then we would flip roles - I'm willing to review it if you take over this package. I really want to see this in Fedora. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707389] Review Request: libwebp - Library and tools for the WebP graphics format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707389 --- Comment #8 from Scott Tsai scottt...@gmail.com 2012-02-01 13:31:15 EST --- (In reply to comment #7) Peter, I've mailed Rahul privately, asking if he has time to look at this or if he'd object to me taking over package submission. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707389] Review Request: libwebp - Library and tools for the WebP graphics format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707389 Rahul Sundaram methe...@gmail.com changed: What|Removed |Added Flag|needinfo?(methe...@gmail.co | |m) | --- Comment #9 from Rahul Sundaram methe...@gmail.com 2012-02-01 19:12:07 EST --- Sorry for the delay folks. I submitted this review many months back and forgot about it entirely. Thanks to Scott Tsai for the spec file changes and dropping me a reminder offlist. http://sundaram.fedorapeople.org/packages/libwebp.spec http://sundaram.fedorapeople.org/packages/libwebp-0.1.3-1.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707389] Review Request: libwebp - Library and tools for the WebP graphics format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707389 Scott Tsai scottt...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #10 from Scott Tsai scottt...@gmail.com 2012-02-01 19:22:34 EST --- Successful koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3753938 APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707389] Review Request: libwebp - Library and tools for the WebP graphics format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707389 Rahul Sundaram methe...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707389] Review Request: libwebp - Library and tools for the WebP graphics format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707389 --- Comment #11 from Rahul Sundaram methe...@gmail.com 2012-02-01 19:48:12 EST --- Thanks. Looks like it is going to be a dependency for a few packages and if anyone wants to be a co-maintainer, feel free to apply. I don't expect it to be a big burden. New Package SCM Request === Package Name: libwebp Short Description: Library and tools for the WebP graphics format Owners: sundaram Branches: f17 f16 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707389] Review Request: libwebp - Library and tools for the WebP graphics format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707389 --- Comment #12 from Jon Ciesla limburg...@gmail.com 2012-02-01 21:52:40 EST --- Git done (by process-git-requests). f17==devel, at least for a week for so yet. . . -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707389] Review Request: libwebp - Library and tools for the WebP graphics format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707389 Rahul Sundaram methe...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2012-02-01 23:42:23 --- Comment #13 from Rahul Sundaram methe...@gmail.com 2012-02-01 23:42:23 EST --- @John Ellson, I have built for Rawhide and Fedora 16 as well. Do let me know if you need any further help from me. https://admin.fedoraproject.org/updates/libwebp-0.1.3-1.fc16 Closing this review request. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707389] Review Request: libwebp - Library and tools for the WebP graphics format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707389 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added CC||lemen...@gmail.com Flag||needinfo?(methe...@gmail.co ||m) --- Comment #5 from Peter Lemenkov lemen...@gmail.com 2012-01-30 15:03:13 EST --- Hello. Folks, what's the current status of this ticket? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707389] Review Request: libwebp - Library and tools for the WebP graphics format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707389 --- Comment #6 from Scott Tsai scottt...@gmail.com 2012-01-30 16:47:34 EST --- (In reply to comment #5) Peter, I'm waiting for Rahul to respond to comment 3. I then plan to approve this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707389] Review Request: libwebp - Library and tools for the WebP graphics format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707389 --- Comment #4 from John Ellson john.ell...@comcast.net 2012-01-19 14:00:21 EST --- If this library could be released for f16 f17, I could use it for the next release of graphviz. Upstream coding is completed and tested. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707389] Review Request: libwebp - Library and tools for the WebP graphics format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707389 --- Comment #2 from Scott Tsai scottt...@gmail.com 2012-01-15 19:25:39 EST --- Created attachment 555405 -- https://bugzilla.redhat.com/attachment.cgi?id=555405 libwebp_jni_example.java -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707389] Review Request: libwebp - Library and tools for the WebP graphics format
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=707389
Scott Tsai scottt...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||scottt...@gmail.com
AssignedTo|nob...@fedoraproject.org|scottt...@gmail.com
Flag||fedora-review?
--- Comment #3 from Scott Tsai scottt...@gmail.com 2012-01-15 19:54:32 EST ---
I've made a copy of the SPEC with all my recommendations applied here:
http://scottt.tw/fedora/libwebp.spec for your convenience.
1. Please update to libwebp-0.1.3
Upstream released libwebp-0.1.3 in September 2011.
I've verified that simply bumping the version in the SPEC file works with the
new tarball:
http://code.google.com/p/webp/downloads/detail?name=libwebp-0.1.3.tar.gzcan=2q=
0.1.3 contains an ABI compatibility break and soname change from 0.1.2
(libwebp.so.0.0.0 - libwebp.so.2.0.0)
Thus packaging 0.1.3 directly avoids a soname change in the future.
2. Package the SWIG generated Java bindings:
@@ -6,8 +6,11 @@ URL: http://webmproject.org/
Summary: Library and tools for the WebP graphics format
# Additional IPR is licensed as well. See PATENTS file for details
License: BSD
-Source: http://webp.googlecode.com/files/%{name}-%{version}.tar.gz
-BuildRequires: libjpeg-devel libpng-devel libtool
+Source0: http://webp.googlecode.com/files/%{name}-%{version}.tar.gz
+Source1: libwebp_jni_example.java
+BuildRequires: libjpeg-devel libpng-devel libtool swig
+BuildRequires: java-devel
+BuildRequires: jpackage-utils
%description
WebP is an image format that does lossy compression of digital
@@ -39,6 +42,16 @@ container based on RIFF. Webmasters, web developers and
browser
developers can use WebP to compress, archive and distribute digital
images more efficiently.
+%package java
+Group: Development/Libraries
+Summary: Java bindings for libwebp, a library for the WebP format
+Requires: %{name}%{?_isa} = %{version}-%{release}
+Requires: java
+Requires: jpackage-utils
+
+%description java
+Java bindings for libwebp.
+
%prep
%setup -q
@@ -48,10 +61,35 @@ mkdir -p m4
%configure --disable-static
make %{?_smp_mflags}
+# swig generated Java bindings
+cp %{SOURCE1} .
+cd swig
+rm -rf libwebp.jar libwebp_java_wrap.c
+mkdir -p java/com/google/webp
+swig -ignoremissing -I../src -java \
+ -package com.google.webp \
+ -outdir java/com/google/webp \
+ -o libwebp_java_wrap.c libwebp.i
+
+gcc %{optflags} -shared -fPIC -fno-strict-aliasing \
+ -I/usr/lib/jvm/java/include \
+ -I/usr/lib/jvm/java/include/linux \
+ -I../src \
+ -L../src/.libs -lwebp libwebp_java_wrap.c \
+ -o libwebp_jni.so
+
+cd java
+javac com/google/webp/libwebp.java
+jar cvf ../libwebp.jar com/google/webp/*.class
+
%install
make install DESTDIR=%{buildroot}
find %{buildroot}/%{_libdir} -type f -name *.la -delete
+# swig generated Java bindings
+mkdir -p %{buildroot}/%{_libdir}/%{name}-java
+cp swig/*.jar swig/*.so %{buildroot}/%{_libdir}/%{name}-java/
+
%post -n %{name} -p /sbin/ldconfig
%postun -n %{name} -p /sbin/ldconfig
@@ -69,6 +107,10 @@ find %{buildroot}/%{_libdir} -type f -name *.la
-delete
%{_includedir}/*
%{_libdir}/pkgconfig/*
+%files java
+%doc libwebp_jni_example.java
+%{_libdir}/%{name}-java/
The libwebp_jni_example.java file is attached to this bug.
3. Fix the dist tag:
-Release: 1%{dist}
+Release: 1%{?dist}
4. Fix the version number in the chanagelog:
-* Wed May 25 2011 Rahul Sundaram sunda...@fedoraproject.org - 1.0.2-1
+* Wed May 25 2011 Rahul Sundaram sunda...@fedoraproject.org - 0.1.3-1
As pointed out by Veeti.
5. Drop autoconf, automake from BuildRequires as pointed out by Veeti.
libtool already requires both autoconf and automake.
-BuildRequires: libjpeg-devel, libpng-devel autoconf automake libtool
+BuildRequires: libjpeg-devel libpng-devel libtool
6. Fix libwebp-devel's Require line as pointed out by Veeti:
-Requires: %{name} = %version
+Requires: %{name}%{?_isa} = %{version}-%{release}
See: http://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package
7. Enclose RPM macros with curly braces as pointed out by Veeti:
-make install DESTDIR=%buildroot
-find %buildroot/%_libdir -type f -name *.la -delete
+make install DESTDIR=%{buildroot}
+find %{buildroot}/%{_libdir} -type f -name *.la -delete
-%post -n %name -p /sbin/ldconfig
+%post -n %{name} -p /sbin/ldconfig
-%postun -n %name -p /sbin/ldconfig
+%postun -n %{name} -p /sbin/ldconfig
%files tools
-%_bindir/*
-%_mandir/man*/*
+%{_bindir}/*
+%{_mandir}/man*/*
%files -n %{name}
%doc README PATENTS COPYING NEWS AUTHORS
-%_libdir/%{name}*.so.*
[Bug 707389] Review Request: libwebp - Library and tools for the WebP graphics format
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=707389
Veeti Paananen veeti.paana...@rojekti.fi changed:
What|Removed |Added
CC||veeti.paana...@rojekti.fi
--- Comment #1 from Veeti Paananen veeti.paana...@rojekti.fi 2011-07-21
12:19:35 EDT ---
rpmlint:
[veeti@veeti-pc result]$ rpmlint *.rpm
libwebp.src: W: spelling-error %description -l en_US WebP - Web P, Web, Webb
libwebp.src: W: spelling-error %description -l en_US lossy - loss, glossy,
flossy
libwebp.src: W: spelling-error %description -l en_US codec - codex, code,
codes
libwebp.x86_64: W: spelling-error %description -l en_US WebP - Web P, Web,
Webb
libwebp.x86_64: W: spelling-error %description -l en_US lossy - loss, glossy,
flossy
libwebp.x86_64: W: spelling-error %description -l en_US codec - codex, code,
codes
libwebp.x86_64: W: incoherent-version-in-changelog 1.0.2-1 ['0.1.2-1.fc15',
'0.1.2-1']
libwebp-devel.x86_64: W: spelling-error %description -l en_US WebP - Web P,
Web, Webb
libwebp-devel.x86_64: W: spelling-error %description -l en_US lossy - loss,
glossy, flossy
libwebp-devel.x86_64: W: spelling-error %description -l en_US codec - codex,
code, codes
libwebp-devel.x86_64: W: no-documentation
libwebp-tools.x86_64: W: spelling-error %description -l en_US WebP - Web P,
Web, Webb
libwebp-tools.x86_64: W: spelling-error %description -l en_US lossy - loss,
glossy, flossy
libwebp-tools.x86_64: W: spelling-error %description -l en_US codec - codex,
code, codes
5 packages and 0 specfiles checked; 0 errors, 14 warnings.
---
Some informal comments:
- As mentioned by rpmlint, the changelog has an invalid version number.
- The build requirement for automake is unnecessary.
- The build requirements should probably be listed one per line.
- The devel package's base requirement should be fully versioned (Requires:
%{name}%{?_isa} = %{version}-%{release}).
- The tools package should also require the base package.
- You should enclose all the macros like %buildroot, etc. in curly braces (
%{buildroot} ).
- libjpeg-devel and libpng-devel are probably needed for using libwebp-devel,
so those should be explicit requirements. (?)
- The files for the base package should be listed first. The -n %{name} part
would then be unnecessary.
- The files should be selected more verbosely:
- Since the development headers are all contained in one folder, replace the
%_includedir/* line with %{_includedir}/webp/.
- Since there is only one pkgconfig file, just list it as libwebp.pc.
- The tools package should use something like %{_bindir}/*webp.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
