[Bug 708670] Review Request: hawtjni - Code generator that produces the JNI code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708670 Bug 708670 depends on bug 708645, which changed state. Bug 708645 Summary: Review Request: fusesource-pom - Parent POM for FuseSource Maven projects https://bugzilla.redhat.com/show_bug.cgi?id=708645 What|Old Value |New Value Resolution||RAWHIDE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708670] Review Request: hawtjni - Code generator that produces the JNI code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708670 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED CC||akurt...@redhat.com Resolution||RAWHIDE Last Closed||2011-06-30 03:37:50 Bug 708670 depends on bug 708669, which changed state. Bug 708669 Summary: xbean doesn't contain xbean-finder and xbean-bundleutils submodules https://bugzilla.redhat.com/show_bug.cgi?id=708669 What|Old Value |New Value Resolution||ERRATA Status|ON_QA |CLOSED --- Comment #12 from Alexander Kurtakov akurt...@redhat.com 2011-06-30 03:37:50 EDT --- Build in rawhide since long ago. http://koji.fedoraproject.org/koji/buildinfo?buildID=245729 Closing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708670] Review Request: hawtjni - Code generator that produces the JNI code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708670 --- Comment #11 from Jens Petersen peter...@redhat.com 2011-05-31 03:25:58 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708670] Review Request: hawtjni - Code generator that produces the JNI code needed to implement java native methods
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708670 Stanislav Ochotnicky socho...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||socho...@redhat.com AssignedTo|nob...@fedoraproject.org|socho...@redhat.com Flag||fedora-review? --- Comment #2 from Stanislav Ochotnicky socho...@redhat.com 2011-05-30 05:51:00 EDT --- Gonna review this one -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708670] Review Request: hawtjni - Code generator that produces the JNI code needed to implement java native methods
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708670 Stanislav Ochotnicky socho...@redhat.com changed: What|Removed |Added Depends on||708645 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708670] Review Request: hawtjni - Code generator that produces the JNI code needed to implement java native methods
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708670
--- Comment #3 from Stanislav Ochotnicky socho...@redhat.com 2011-05-30
07:28:03 EDT ---
Package Review
==
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[!] Rpmlint output:
hawtjni.noarch: W: summary-ended-with-dot C Code generator that produces the
JNI code needed to implement java native methods.
hawtjni.noarch: E: summary-too-long C Code generator that produces the JNI code
needed to implement java native methods.
hawtjni.noarch: W: spelling-error %description -l en_US jnigen - Nigerien
hawtjni.noarch: W: non-conffile-in-etc /etc/maven/fragments/hawtjni
hawtjni.src: W: summary-ended-with-dot C Code generator that produces the JNI
code needed to implement java native methods.
hawtjni.src: E: summary-too-long C Code generator that produces the JNI code
needed to implement java native methods.
hawtjni.src: W: spelling-error %description -l en_US jnigen - Nigerien
hawtjni.src: W: invalid-url Source0: hawtjni-1.1.tar.gz
hawtjni-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs - Java docs,
Java-docs, Avocados
3 packages and 0 specfiles checked; 2 errors, 7 warnings.
Fixing the summary is needed :-)
[x] Package is named according to the Package Naming Guidelines[1].
[x] Spec file name must match the base package name, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines[2].
[x] Package successfully compiles and builds into binary rpms.
[x] Buildroot definition is not present
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging
Guidelines[3,4].
[!] License field in the package spec file matches the actual license.
License type: ASL 2.0 and EPL
There is actually BSD file inside (stdint.h). Correct license for the package
is most probably ASL 2.0 and EPL 1.0 and BSD. It would be good to let
upstream know that their licensing situation is not clear from their licensing
file. It's usually good idea to put such information into readme or separate
file listing all files with different licensing from the main one.
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] All independent sub-packages have license of their own
javadoc subpackage needs included license file
[x] Spec file is legible and written in American English.
[!] Sources used to build the package matches the upstream source, as provided
in the spec URL.
MD5SUM this package: d3c43b608bfe48b313e34b747983d1ae
MD5SUM upstream package: b437a1b8d84c5755bfd2b12b7dacde90
Your instructions to create tarball are not exactly incorrect, but they change
the md5sum each time archive is created. I'd suggest using lzma (xz)
compression instead of gzip. It doesn't add timestamps into tarball so it won't
change md5sum and it compresses better. If you need to support EPEL 5 with
this, then you can use bzip2 to prevent md5sum changes.
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines[5].
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package does NOT have a %clean section which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT). (not needed anymore)
[x] Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT
mixing)
[x] Package contains code, or permissable content.
[x] Fully versioned dependency in subpackages, if present.
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
[x] Javadoc documentation files are generated and included in -javadoc
subpackage
[x] Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks)
[x] Packages have proper BuildRequires/Requires on jpackage-utils
[x] Javadoc subpackages have Require: jpackage-utils
[x] Package uses %global not %define
[x] If package uses tarball from VCS include comment how to re-create that
tarball (svn export URL, git clone URL, ...)
[-] If source tarball includes bundled jar/class files these need to be
removed prior to building
[x] All filenames in rpm packages must be valid UTF-8.
[x] Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details)
[x] If package contains pom.xml files install it (including depmaps) even when
building with ant
[x] pom files has correct add_to_maven_depmap call which resolves to the pom
file (use JPP. and JPP- correctly)
=== Maven ===
[x] Use %{_mavenpomdir} macro for placing pom files
[Bug 708670] Review Request: hawtjni - Code generator that produces the JNI code needed to implement java native methods
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708670 --- Comment #4 from Marek Goldmann mgold...@redhat.com 2011-05-30 09:16:45 EDT --- Thanks for taking this review! Updated files with your comments applied: Spec URL: http://goldmann.fedorapeople.org/package_review/hawtjni/3/hawtjni.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/hawtjni/3/hawtjni-1.1-3.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708670] Review Request: hawtjni - Code generator that produces the JNI code needed to implement java native methods
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708670
Stanislav Ochotnicky socho...@redhat.com changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #5 from Stanislav Ochotnicky socho...@redhat.com 2011-05-30
09:56:23 EDT ---
tarball is now OK (md5sum dc1a98b5cf60e90fb79a33fc003c2af9)
javadoc subpackage should have license file included as well.
maven plugin subpackage should have separate Group tag (even if it's the same
as in this case).
You now also have this in file section:
%{_mavendepmapfragdir}/
i.e. you own whole subdir, whereas you should only own file inside it i.e.
%{_mavendepmapfragdir}/%{name} (or *)
Otherwise the package looks OK now, so just fix those 3 small issues and you're
good to go. In good faith: APPROVED :-)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708670] Review Request: hawtjni - Code generator that produces the JNI code needed to implement java native methods
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708670 Stanislav Ochotnicky socho...@redhat.com changed: What|Removed |Added Blocks|652183(FE-JAVASIG) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708670] Review Request: hawtjni - Code generator that produces the JNI code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708670 Marek Goldmann mgold...@redhat.com changed: What|Removed |Added Summary|Review Request: hawtjni - |Review Request: hawtjni - |Code generator that |Code generator that |produces the JNI code |produces the JNI code |needed to implement java| |native methods | Flag||fedora-cvs? --- Comment #6 from Marek Goldmann mgold...@redhat.com 2011-05-30 10:10:55 EDT --- Thank you! I've applied your comments to this package: Spec URL: http://goldmann.fedorapeople.org/package_review/hawtjni/3a/hawtjni.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/hawtjni/3a/hawtjni-1.1-3.fc15.src.rpm New Package SCM Request === Package Name: hawtjni Short Description: Code generator that produces the JNI code Owners: goldmann Branches: f15 InitialCC: java-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708670] Review Request: hawtjni - Code generator that produces the JNI code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708670 Stanislav Ochotnicky socho...@redhat.com changed: What|Removed |Added Flag|fedora-review+, fedora-cvs? |fedora-review? --- Comment #7 from Stanislav Ochotnicky socho...@redhat.com 2011-05-30 10:26:34 EDT --- Bah, I somehow missed maven-shade-plugin being used to bundle all dependencies inside generator jar. You'll have to remove shade plugin use before proceeding. Removing cvs? and review+ in the meantime. Sorry -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708670] Review Request: hawtjni - Code generator that produces the JNI code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708670 --- Comment #8 from Marek Goldmann mgold...@redhat.com 2011-05-30 11:10:02 EDT --- Removed the maven-shade-plugin dependency. Spec URL: http://goldmann.fedorapeople.org/package_review/hawtjni/4/hawtjni.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/hawtjni/4/hawtjni-1.1-4.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708670] Review Request: hawtjni - Code generator that produces the JNI code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708670 Stanislav Ochotnicky socho...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #9 from Stanislav Ochotnicky socho...@redhat.com 2011-05-30 11:20:52 EDT --- Yup, all OK now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708670] Review Request: hawtjni - Code generator that produces the JNI code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708670 Marek Goldmann mgold...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from Marek Goldmann mgold...@redhat.com 2011-05-30 11:21:49 EDT --- Thank you! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708670] Review Request: hawtjni - Code generator that produces the JNI code needed to implement java native methods
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708670 --- Comment #1 from Marek Goldmann mgold...@redhat.com 2011-05-29 13:44:22 EDT --- Updated spec and srpm files to include maven-hawtjni-plugin: Spec URL: http://goldmann.fedorapeople.org/package_review/hawtjni/2/hawtjni.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/hawtjni/2/hawtjni-1.1-2.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708670] Review Request: hawtjni - Code generator that produces the JNI code needed to implement java native methods
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708670 Marek Goldmann mgold...@redhat.com changed: What|Removed |Added Blocks||708836 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708670] Review Request: hawtjni - Code generator that produces the JNI code needed to implement java native methods
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708670 Marek Goldmann mgold...@redhat.com changed: What|Removed |Added Blocks||652183(FE-JAVASIG) Depends on||708669 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
