[Bug 708711] Review Request: nomnom - The graphical video download tool
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708711
--- Comment #1 from Jussi Lehtola 2011-05-28 23:47:10
EDT ---
Please don't mix $RPM_BUILD_ROOT and %{buildroot}.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708711] Review Request: nomnom - The graphical video download tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708711 --- Comment #2 from Nicoleau Fabien 2011-05-29 07:23:28 EDT --- Updated : Spec URL: http://rpms.nicoleau-fabien.net/SPECS/nomnom.spec SRPM URL: http://rpms.nicoleau-fabien.net/SRPMS/nomnom-0.1.3-2.fc15.src.rpm %changelog * Sun May 29 2011 Nicoleau Fabien 0.1.3-2 - Only use RPM_BUILD_ROOT -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708711] Review Request: nomnom - The graphical video download tool
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708711
Thomas Spura changed:
What|Removed |Added
CC||toms...@fedoraproject.org
Depends on||708554
--- Comment #3 from Thomas Spura 2011-05-30
17:15:46 EDT ---
The compression of the man pages could change, so %{_mandir}/man1/%{name}.1.*
would be better.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708711] Review Request: nomnom - The graphical video download tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708711 --- Comment #4 from Nicoleau Fabien 2011-05-31 14:48:33 EDT --- Updated : Spec URL: http://rpms.nicoleau-fabien.net/SPECS/nomnom.spec SRPM URL: http://rpms.nicoleau-fabien.net/SRPMS/nomnom-0.1.3-3.fc15.src.rpm %changelog * Tue May 31 2011 Nicoleau Fabien 0.1.3-3 - Manage a all compression of the man pages About the default video player used (the xdg-open command), it was discussed here : http://www.spinics.net/lists/fedora-devel/msg151512.html But I'm still not sure if it's a better solution than "totem". -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708711] Review Request: nomnom - The graphical video download tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708711 --- Comment #5 from Nicoleau Fabien 2011-06-24 16:01:20 EDT --- Updated : Spec URL: http://rpms.nicoleau-fabien.net/SPECS/nomnom.spec SRPM URL: http://rpms.nicoleau-fabien.net/SRPMS/nomnom-0.1.4-1.fc15.src.rpm %changelog * Fri Jun 24 2011 Nicoleau Fabien 0.1.4-1 - Update to 0.1.4 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708711] Review Request: nomnom - The graphical video download tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708711 Nathan Owe changed: What|Removed |Added CC||ndowen...@gmail.com --- Comment #6 from Nathan Owe 2011-08-10 23:09:13 EDT --- Do you need a sponsor? If so add FE-NEEDSPONSOR to Blocks -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708711] Review Request: nomnom - The graphical video download tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708711 --- Comment #7 from Nicoleau Fabien 2011-08-14 13:52:55 EDT --- Hi, I don't need a sponsor. I've already been approved. https://admin.fedoraproject.org/pkgdb/users/packages/eponyme -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708711] Review Request: nomnom - The graphical video download tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708711 Volker Fröhlich changed: What|Removed |Added CC||volke...@gmx.at Bug 708711 depends on bug 708554, which changed state. Bug 708554 Summary: Review Request: umph - Command line tool for parsing video links from Youtube feeds https://bugzilla.redhat.com/show_bug.cgi?id=708554 What|Old Value |New Value Status|NEW |ASSIGNED Status|ASSIGNED|MODIFIED Status|MODIFIED|ON_QA Resolution||ERRATA Status|ON_QA |CLOSED --- Comment #8 from Volker Fröhlich 2011-08-27 03:06:23 EDT --- License is GPLv3+, according to the headers. Buildroot, clean section and the rm in the install section are only necessary, when you plan to go for EPEL5 or older. Defattr is no longer necessary. Please handle the locales as described in http://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files. You won't need gettext though, but you'll have to append --with-qt to the %find_lang call. I recommend putting each BuildRequires and Requires on a separate line. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708711] Review Request: nomnom - The graphical video download tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708711 --- Comment #9 from Nicoleau Fabien 2011-08-27 13:21:10 EDT --- Updates : Spec URL: http://rpms.nicoleau-fabien.net/SPECS/nomnom.spec SRPM URL: http://rpms.nicoleau-fabien.net/SRPMS/nomnom-0.1.4-2.fc15.src.rpm Changelog : - License fix - Remove unnecessary commands - Handle locales properly -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708711] Review Request: nomnom - The graphical video download tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708711 Volker Fröhlich changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|volke...@gmx.at Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708711] Review Request: nomnom - The graphical video download tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708711 --- Comment #10 from Volker Fröhlich 2011-08-29 17:58:45 EDT --- I don't seem to get the program working with Youtube on Fedora 15. error: /usr/share/quvi/lua/website/youtube.lua:114: no match: fmt_url_map --> https://bugzilla.redhat.com/show_bug.cgi?id=728646 Looks like the 2.16.1 doesn't work either: "Expected Perl-style regular expression, e.g. /pattern/flags" Concerning %config(noreplace): I don't know NomNom, but I don't consider using noreplace a disadvantage. If the user made a change in that case, the old configuration stays in place and the new configuration is saved as .rpmnew. http://fedoraproject.org/wiki/Packaging:Guidelines#Configuration_files Do you think keeping the old version's configuration might stop the new package's version from working? You can also include a copy of the configuration file as an additional source, instead of specifying it line by line in the spec file. A more elegant way to do it, if you want to keep it in the spec for some reason: cat > file_to_write_to < 0.1.4-2 - License fix - Remove unnecessary commands - Handle locales properly * Fri Jun 24 2011 Nicoleau Fabien 0.1.4-1 - "Remove unnecessary commands" is pretty generic and nobody reading only the changelog can guess what changed. Please be more specific! From a packaging point of view, nothing is blocking the package. I'll make the formal review after we've sorted out, whether it is a quvi or NomNom problem. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708711] Review Request: nomnom - The graphical video download tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708711 --- Comment #11 from Nicoleau Fabien 2011-08-30 07:19:36 EDT --- I have the bug too, with nomnom, but not with clive or cclive, so I guess it's a nomnom bug. I'll report it to upstream. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708711] Review Request: nomnom - The graphical video download tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708711 --- Comment #12 from Nicoleau Fabien 2011-09-02 16:11:09 EDT --- Update : Spec URL: http://rpms.nicoleau-fabien.net/SPECS/nomnom.spec SRPM URL: http://rpms.nicoleau-fabien.net/SRPMS/nomnom-0.1.4-3.fc15.src.rpm About the bug : there was an error when a configuration parameter had no default value. So I've updated the default configuration file, and the 0.1.5 will fix the bug (no error if the parameter has no default value). I followed all your advices. Changelog : - Use noreplace for configuration file - Update default configuration file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708711] Review Request: nomnom - The graphical video download tool
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708711
--- Comment #13 from Volker Fröhlich 2011-09-02 16:37:59 EDT
---
warning: File listed twice: /usr/share/nomnom/tr/nomnom_de.qm
warning: File listed twice: /usr/share/nomnom/tr/nomnom_fi.qm
Once by %{_datadir}/%{name}, which includes everything below that directory and
once by findlang. If you just left out %{_datadir}/%{name}, the files are only
listed once, but the directories are unowned. So let's make it:
%files -f %{name}.lang
%doc COPYING NEWS README doc/HowtoTranslate
%{_bindir}/%{name}
%dir %{_datadir}/%{name}
%dir %{_datadir}/%{name}/tr
%{_datadir}/applications/%{name}.desktop
%{_datadir}/pixmaps/%{name}.xpm
%config(noreplace) %{_sysconfdir}/NomNom.conf
%{_mandir}/man1/%{name}.1.*
Besides that, all is fine.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708711] Review Request: nomnom - The graphical video download tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708711 --- Comment #14 from Nicoleau Fabien 2011-09-02 17:14:45 EDT --- Update : Spec URL: http://rpms.nicoleau-fabien.net/SPECS/nomnom.spec SRPM URL: http://rpms.nicoleau-fabien.net/SRPMS/nomnom-0.1.4-4.fc15.src.rpm Changelog : - Fix files section to avoid files listed twice -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708711] Review Request: nomnom - The graphical video download tool
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708711
Volker Fröhlich changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #15 from Volker Fröhlich 2011-09-02 18:03:15 EDT
---
Review:
[+] Good
[-] Needs work
[0] Does not apply
MUST:
=
[+] rpmlint:
[makerpm@fedora15 rpmbuild]$ rpmlint SRPMS/nomnom-0.1.4-4.fc15.src.rpm
RPMS/x86_64/nomnom-*0.1.4-4*
3 packages and 0 specfiles checked; 0 errors, 0 warnings.
It's the same after having the package installed.
[+] Naming according to the Package Naming Guidelines
[+] Spec file matches base package name
[+] Packaging guidelines met
[+] License approved for Fedora
[+] License field in spec matches code
[+] License file included, if source package includes it
[+] Spec in American English
[+] Spec is legible
[+] Sources match upstream md5sum: 9104c74746aa1e6c9014c53b4b067bbd
[+] Compiles and builds into binary RPMs on at least one primary architecture:
x86_64, i386
[0] ExcludeArch is specified and commented
[+] Locales are handled correctly
[+] All build dependencies listed
[0] Calls ldconfig for its shared libraries
[+] No bundled system libraries
[0] Stated as relocatable package
[+] Owns all its directories or requires package that does
[+] No file listing duplicates
[+] File permissions correct
[+] Consistent use of macros
[+] Code or permissible content
[0] Large documentation in -doc subpackage
[+] No runtime dependency of files listed as %doc
[0] Header files in -devel subpackage
[0] Static files in -static subpackage
[0] Library files without suffix in -devel subpackage
[0] Devel-package requires base package
[0] No .la libtool archives
[+] GUI application includes properly installed %{name}.desktop file
[+] No files or directories owned, that other packages own
[+] Filenames in packages are UTF-8
SHOULD:
===
[0] Query upstream if no license text is included
[+] Package builds in mock:
fedora-rawhide-x86_64, fedora-15-i386
[+] Package works as described
[0] Scriptlets are sane, if used
[0] Subpackages other than -devel should require base package (versioned)
[0] pkgconfig files in -devel subpackage
[0] Dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider
requiring the package which provides the file instead of the file itself
[+] Contain man pages, where they make sense
===APPROVED===
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708711] Review Request: nomnom - The graphical video download tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708711 Nicoleau Fabien changed: What|Removed |Added Flag||fedora-cvs? --- Comment #16 from Nicoleau Fabien 2011-09-02 18:34:58 EDT --- Thank you for this review Volker. New Package SCM Request === Package Name: nomnom Short Description: The graphical video download tool Owners: eponyme Branches: f15 f16 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708711] Review Request: nomnom - The graphical video download tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708711 --- Comment #17 from Jon Ciesla 2011-09-03 12:49:03 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708711] Review Request: nomnom - The graphical video download tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708711 --- Comment #18 from Fedora Update System 2011-09-04 13:08:31 EDT --- nomnom-0.1.4-4.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/nomnom-0.1.4-4.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708711] Review Request: nomnom - The graphical video download tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708711 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708711] Review Request: nomnom - The graphical video download tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708711 --- Comment #19 from Fedora Update System 2011-09-04 13:09:53 EDT --- nomnom-0.1.4-4.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/nomnom-0.1.4-4.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708711] Review Request: nomnom - The graphical video download tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708711 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #20 from Fedora Update System 2011-09-06 14:06:59 EDT --- nomnom-0.1.4-4.fc16 has been pushed to the Fedora 16 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708711] Review Request: nomnom - The graphical video download tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708711 --- Comment #21 from Fedora Update System 2011-09-14 18:33:13 EDT --- nomnom-0.1.4-4.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708711] Review Request: nomnom - The graphical video download tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708711 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||nomnom-0.1.4-4.fc15 Resolution||ERRATA Last Closed||2011-09-14 18:33:19 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708711] Review Request: nomnom - The graphical video download tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708711 --- Comment #22 from Fedora Update System 2011-09-30 14:33:09 EDT --- nomnom-0.1.4-4.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708711] Review Request: nomnom - The graphical video download tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708711 Fedora Update System changed: What|Removed |Added Fixed In Version|nomnom-0.1.4-4.fc15 |nomnom-0.1.4-4.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
