[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328
Bug 709328 depends on bug 1234209, which changed state.

Bug 1234209 Summary: RFE: Support for Qt5
https://bugzilla.redhat.com/show_bug.cgi?id=1234209

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are always notified about changes to this product and component

___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328
Bug 709328 depends on bug 1234209, which changed state.

Bug 1234209 Summary: RFE: Support for Qt5
https://bugzilla.redhat.com/show_bug.cgi?id=1234209

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|NEXTRELEASE |---



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #167 from Fedora Update System  ---
psi-plus-0.16-0.21.20141205git440.el7 has been pushed to the Fedora EPEL 7
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328

Ivan Romanov  changed:

   What|Removed |Added

 Depends On|1234207 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1234207
[Bug 1234207] RFE: qjson support for Qt5
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328
Bug 709328 depends on bug 1234207, which changed state.

Bug 1234207 Summary: RFE: qjson support for Qt5
https://bugzilla.redhat.com/show_bug.cgi?id=1234207

   What|Removed |Added

 Status|CLOSED  |ASSIGNED
 Resolution|WORKSFORME  |---



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #165 from Fedora Update System  ---
psi-plus-0.16-0.21.20141205git440.fc23 has been pushed to the Fedora 23 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2015-11-01 20:20:48



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #164 from Fedora Update System  ---
psi-plus-0.16-0.21.20141205git440.el7 has been pushed to the Fedora EPEL 7
testing repository. If problems still persist, please make note of it in this
bug report.
If you want to test the update, you can install it with
$ su -c 'yum --enablerepo=epel-testing update psi-plus'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-d64344c4bf

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #163 from Fedora Update System  ---
psi-plus-0.16-0.21.20141205git440.fc22 has been pushed to the Fedora 22 testing
repository. If problems still persist, please make note of it in this bug
report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update psi-plus'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-05b934b5dd

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #159 from Fedora Update System  ---
psi-plus-0.16-0.21.20141205git440.fc23 has been submitted as an update to
Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-5e712581b5

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #160 from Fedora Update System  ---
psi-plus-0.16-0.21.20141205git440.fc22 has been submitted as an update to
Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-05b934b5dd

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #161 from Fedora Update System  ---
psi-plus-0.16-0.21.20141205git440.el7 has been submitted as an update to Fedora
EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-d64344c4bf

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #156 from Ivan Romanov  ---
Spec URL:
https://raw.githubusercontent.com/RussianFedora/psi-plus/9f674f9de47ff41f344c89b6dadd5deed1721d7d/psi-plus.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/8386/11508386/psi-plus-0.16-0.20.20141205git440.fc24.src.rpm

koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=11508384

- set correct plugins permissions
- Filter out plugins from provides

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #155 from Upstream Release Monitoring 
 ---
ivanromanov's scratch build of psi-plus-0.16-0.20.20141205git440.fc22.src.rpm
for rawhide completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11508384

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328

Raphael Groner  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #157 from Raphael Groner  ---
It looks now good to me. APPROVED

Please be aware about the following, did you forget to upload new spec file?

[!]: Spec file according to URL is the same as in SRPM.
 Note: Spec file as given by url is not the same as in SRPM (see
 attached diff).

Diff spec file in url and in SRPM
-
--- /home/builder/fedora-review/709328-psi-plus/srpm/psi-plus.spec   
2015-10-20 13:23:30.707744057 +0200
+++ /home/builder/fedora-review/709328-psi-plus/srpm-unpacked/psi-plus.spec   
2015-10-20 04:50:22.0 +0200
@@ -91,12 +91,4 @@
 This package adds internationalization to Psi+.

-%packagecommon
-Summary:Noarch resources for Psi+
-BuildArch:  noarch
-
-%descriptioncommon
-Psi+ - Psi IM Mod by psi-...@conference.jabber.ru
-This package contains huge of base mandatory resources for Psi+.
-
 %packageplugins
 Summary:Plugins pack for Psi+
@@ -106,6 +98,12 @@
 License:GPLv2+ and BSD and Beerware
 Requires:   %{name}%{?_isa} = %{epoch}:%{version}-%{release}
-# Filter out plugins from provides
-%global __provides_exclude_from ^%{_libdir}/psi-plus
+
+%packagecommon
+Summary:Noarch resources for Psi+
+BuildArch:  noarch
+
+%descriptioncommon
+Psi+ - Psi IM Mod by psi-...@conference.jabber.ru
+This package contains huge of base mandatory resources for Psi+.


@@ -380,5 +378,4 @@
 * Tue Oct 20 2015 Ivan Romanov  - 1:0.16-0.20.20141205git440
 - set correct plugins permissions
-- Filter out plugins from provides

 * Mon Oct 19 2015 Ivan Romanov  - 1:0.16-0.19.20141205git440

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #158 from Upstream Release Monitoring 
 ---
ivanromanov's scratch build of psi-plus-0.16-0.20.20141205git440.fc22.src.rpm
for rawhide completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11516038

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #150 from Ivan Romanov  ---
> - You could use the new %make_build and %make_install macros.
I can't. No %make_build on Epel7. %make_install use DESTDIR but Makefile uses
only INSTALL_ROOT. It is not Makefile generated with autoconf configure script.
For Makefile is used qmake (specific Qt tool).

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #151 from Ivan Romanov  ---
[!]: update-desktop-database is invoked in %post and %postun if package
 contains desktop file(s) with a MimeType: entry.
 Note: desktop file(s) with MimeType entry in psi-plus

%post and %postun allreaded had update-desktop-database. What wrong with this?

[!]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in psi-
 plus-i18n , psi-plus-plugins , psi-plus-common , psi-plus-debuginfo

what wrong here?

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #152 from Upstream Release Monitoring 
 ---
ivanromanov's scratch build of psi-plus-0.16-0.19.20141205git440.fc22.src.rpm
for rawhide completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11500512

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #153 from Raphael Groner  ---
(In reply to Ivan Romanov from comment #151)
> [!]: update-desktop-database is invoked in %post and %postun if package
>  contains desktop file(s) with a MimeType: entry.
>  Note: desktop file(s) with MimeType entry in psi-plus
> 
> %post and %postun allreaded had update-desktop-database. What wrong with
> this?

Sorry, my fault. You're right.

> [!]: Fully versioned dependency in subpackages if applicable.
>  Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in psi-
>  plus-i18n , psi-plus-plugins , psi-plus-common , psi-plus-debuginfo
> 
> what wrong here?

Requires:   %{name}%{?_isa} = %{epoch}:%{version}-%{release}

Add it like that to all sub packages (like already done so for plugins), please
mind the inclusion of %{?_isa} everywhere. Maybe f-r gets also confused cause
of epoch given in plugins, not sure if needed at all in Requires.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #154 from Ivan Romanov  ---
Spec URL:
https://raw.githubusercontent.com/RussianFedora/psi-plus/e7c8cb2ce2a23ec270642fcea58cc9739c1237b1/psi-plus.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/513/11500513/psi-plus-0.16-0.19.20141205git440.fc24.src.rpm

koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=11500512

- Dropped .R suffix from changelog for Fedora review purposes
- Added license test to common subpackage

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #141 from Upstream Release Monitoring 
 ---
ivanromanov's scratch build of psi-plus-0.16-0.17.20141205git440.fc22.src.rpm
for epel7 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11491478

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #142 from Upstream Release Monitoring 
 ---
ivanromanov's scratch build of psi-plus-0.16-0.17.20141205git440.fc22.src.rpm
for epel7 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11491497

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #143 from Upstream Release Monitoring 
 ---
ivanromanov's scratch build of psi-plus-0.16-0.17.20141205git440.fc22.src.rpm
for epel7 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11491503

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #144 from Upstream Release Monitoring 
 ---
ivanromanov's scratch build of psi-plus-0.16-0.17.20141205git440.fc22.src.rpm
for epel7 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11491510

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #145 from Upstream Release Monitoring 
 ---
ivanromanov's scratch build of psi-plus-0.16-0.17.20141205git440.fc22.src.rpm
for epel7 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11491517

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #146 from Upstream Release Monitoring 
 ---
ivanromanov's scratch build of psi-plus-0.16-0.17.20141205git440.fc22.src.rpm
for epel7 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11491532

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #147 from Upstream Release Monitoring 
 ---
ivanromanov's scratch build of psi-plus-0.16-0.18.20141205git440.fc22.src.rpm
for epel7 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11491569

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328

Raphael Groner  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1264110,
   ||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1234217
 Depends On|1234217 (qconf-qt5),|
   |1264110 (iris-qt5)  |



--- Comment #138 from Raphael Groner  ---
Initial package is going to be release with Qt4, removing RFE of qt5 packages
as blockers.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1234217
[Bug 1234217] Qt5 support is available as a snapshot from GitHub
https://bugzilla.redhat.com/show_bug.cgi?id=1264110
[Bug 1264110] RFE: Support for Qt5
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #148 from Ivan Romanov  ---
Spec URL:
https://raw.githubusercontent.com/RussianFedora/psi-plus/a9842cc833cc140fb99f88ec5f6b12c523f47927/psi-plus.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/1620/11491620/psi-plus-0.16-0.18.20141205git440.fc24.src.rpm

koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=11491619

fixes for epel7

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #139 from Upstream Release Monitoring 
 ---
ivanromanov's scratch build of psi-plus-0.16-0.17.20141205git440.fc22.src.rpm
for rawhide completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11491354

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #140 from Ivan Romanov  ---
Spec URL:
https://raw.githubusercontent.com/RussianFedora/psi-plus/f3d4663796af88f9d7a04f1f113817fc0d95a283/psi-plus.spec
SRPM URL:

https://kojipkgs.fedoraproject.org//work/tasks/1355/11491355/psi-plus-0.16-0.17.20141205git440.fc24.src.rpm

koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=11491354

- dropped version for bundled iris
- added hicolor-icon-theme to Requires
- fixed post, postun and posttrans scriptlets
- moved noarch resources to common subpackage
- moved desktop-file-validate to %%check section
- use %%global instead of %%define
- preserve timestamp
- use modern %%make_build
- some fixes with licensies
- fixed %%{_libdir}/psi-plus is not owned any package
- fix duplicated /usr/share/psi-plus
- remove bundled jdns
- fix rpmlint spurious-executable-perm

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #134 from Raphael Groner  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines
=> Ignore, something general seems to be b0rken in my build system.
- gtk-update-icon-cache is invoked in %postun and %posttrans if package
  contains icons.
  Note: icons in psi-plus
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
=> Incomplete implementation, please use snippets as given in the link.
- update-desktop-database is invoked in %post and %postun if package
  contains desktop file(s) with a MimeType: entry.
  Note: desktop file(s) with MimeType entry in psi-plus
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-
  database
- Are you sure about licenses? You do not need to mention licenses of stuff
  that doesn't make it into built packages (binary RPM).
 
https://fedoraproject.org/wiki/Licensing:FAQ?rd=Licensing/FAQ#Does_the_License:_tag_cover_the_SRPM_or_the_binary_RPM.3F
- You could use the new %make_build and %make_install macros.
- psi-plus-snapshot has revision 475, maybe you want to update. My experience
  is though 454 was the last one with support for Qt4 only.
- Add desktop-file-validate to %check, Requires: desktop-file-utils
 
https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage
- Please use cp -p to preserve timestamps.
- Please replace %define with %global.
- Please create a subpackage for huge content in /usr/share/psi
  with BuildArch: noarch.
- Output of rpmlint needs to be fixed,
  at least the errors (e.g. E: fsf-incorrect-address).


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[?]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[?]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "*No copyright* GPL (v2 or later) (with incorrect FSF
 address)", "GPL (v2 or later)", "Unknown or generated", "MIT/X11 (BSD
 like)", "zlib/libpng", "BSD (3 clause)", "GPL (v2.0)", "Beerware",
 "LGPL (v2.1)", "GPL (v2 or later) (with incorrect FSF address)", "LGPL
 (v2.1 or later)", "GPL (v2)". 1602 files have unknown license.
 Detailed output of licensecheck in /home/builder/fedora-review/709328
 -psi-plus/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[!]: Package must own all directories that it creates.
 Note: Directories without known owners:
 /usr/share/icons/hicolor/64x64/apps,
 /usr/share/icons/hicolor/48x48/apps,
 /usr/share/icons/hicolor/32x32/apps,
 /usr/share/icons/hicolor/16x16/apps, /usr/share/icons/hicolor/16x16,
 /usr/share/icons/hicolor/128x128/apps,
 /usr/share/icons/hicolor/128x128, /usr/share/icons/hicolor/64x64,
 /usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor/32x32,
 /usr/share/icons/hicolor
=> Those folders are managed in hicolor-icon-theme, please add as Requires.
https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_also_owned_by_a_package_implementing_required_functionality_of_your_package

[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
=> Provides: bundled(iris), issue is reported to upstream.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification 

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #123 from Ivan Romanov  ---
Due new bundled politics can we now use bundled iris? And continue review
process of initial package (with some updates).

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #124 from Raphael Groner  ---
Ivan, what about migration to Qt5 as requested in comment #112 and comment
#116?

Any new thoughts about usages of
- newer qconf (comment #111),
- optipng integration (comment #112),
- autodownloader (comment #106)?

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #127 from Ivan Romanov  ---
> Any new thoughts about usages of
> - newer qconf (comment #111)
I can't update qconf just now. But I will do this as can found free time.

> - optipng integration (comment #112)
I don't think that this has matter. But I can do this for you.

> - autodownloader (comment #106)?
Hm. How user can know that him now must use alternative way to download
resources?

> - Are you sure bundled iris version will always be in conjunction with 
> psi[-plus] main version given in psi-plus.spec file?
Iris has no version now. Probably version can be dropped at all.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #128 from Ivan Romanov  ---
I checked optipng didn't reduce psi-plus images size. So I wont add it to spec.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #126 from Ivan Romanov  ---
> Ivan, what about migration to Qt5 as requested in comment #112 and comment 
> #116?
Migration requires new qconf. After qconf will be released I updated psi-plus
and rebuild against Qt5.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #125 from Raphael Groner  ---
- Please make use of %license macro.
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text

- Are you sure bundled iris version will always be in conjunction with
psi[-plus] main version given in psi-plus.spec file?
> Provides:   bundled(iris) = %{version}

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #129 from Upstream Release Monitoring 
 ---
ivanromanov's scratch build of psi-plus-0.16-0.16.20141205git440.fc22.src.rpm
for rawhide completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11441037

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #136 from Upstream Release Monitoring 
 ---
raphgro's scratch build of psi-plus-0.16-0.16.20141205git440.fc24.src.rpm for
rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11447272

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #137 from Ivan Romanov  ---
rpmlint errors fixed in upstream

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #130 from Ivan Romanov  ---
Fixed %%license

Spec URL:
https://raw.githubusercontent.com/RussianFedora/psi-plus/98f3a369e8728346db0b994487f1554ebaebebf5/psi-plus.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/1038/11441038/psi-plus-0.16-0.16.20141205git440.fc24.src.rpm

koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=11441037

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328

Raphael Groner  changed:

   What|Removed |Added

   Assignee|rdie...@math.unl.edu|projects...@smart.ms
  Flags|fedora-review?  |



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #132 from Raphael Groner  ---
For the autodl topic, please read:
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Syntax

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #131 from Raphael Groner  ---
(In reply to Ivan Romanov from comment #127)
> > Any new thoughts about usages of
> > - newer qconf (comment #111)
> I can't update qconf just now. But I will do this as can found free time.

Please notice my proposed patch in bug #1234217.

…
> > - autodownloader (comment #106)?
> Hm. How user can know that him now must use alternative way to download
> resources?

You could invoke autodl
a. in %post to let the user optionally download and install the additional
files as well as in %postun rm those, OR: 
b. provide a wrapper script that checks for first launch of psi-plus binary by
looking for a special folder, for empty or non-existing folder call autodl,
analogously rm that folder like for option a.

Check the bolzplatz sample how autodownloader works there. We need at least a
.autodlrc configuration file and a small scriptlet to call autodl binary
somewhere. Please let me know if you need further help, I'd glad to can help
more.
http://pkgs.fedoraproject.org/cgit/bolzplatz2006.git/tree/bolzplatz2006.autodlrc
http://pkgs.fedoraproject.org/cgit/bolzplatz2006.git/tree/bolzplatz2006-functions.sh
http://pkgs.fedoraproject.org/cgit/bolzplatz2006.git/tree/bolzplatz2006.spec#n205


> > - Are you sure bundled iris version will always be in conjunction with 
> > psi[-plus] main version given in psi-plus.spec file?
> Iris has no version now. Probably version can be dropped at all.

That's okay for me.

(In reply to Ivan Romanov from comment #128)
> I checked optipng didn't reduce psi-plus images size. So I wont add it to
> spec.

Hmm, okay. It was worth a try.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328

Raphael Groner  changed:

   What|Removed |Added

 Whiteboard|NotReady|



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328

Raphael Groner  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #133 from Ivan Romanov  ---
> You could invoke autodl
autodownloader is good when there is some mandatory staff which is required for
normal application working. Psi+ uses icons, etc the most of them users never
will use. As I see autodownloader will be started only one time and load all
staff. This does not fit.. Anyway Content Downloader is working for me. I don't
see any problems. Now I don't see good reasons why Content Downloader should be
replaced with autodownloader.

> Please notice my proposed patch in bug #1234217.
Which the patch?

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328

Raphael Groner  changed:

   What|Removed |Added

 Depends On|737304  |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=737304
[Bug 737304] Psi bundle libs
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #121 from Upstream Release Monitoring 
 ---
ivanromanov's scratch build of psi-plus-0.16-0.15.20141205git440.fc22.src.rpm
for rawhide completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11433722

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #122 from Ivan Romanov  ---
Spec URL:
https://raw.githubusercontent.com/RussianFedora/psi-plus/3ba9a05da1d7c8e8eb1aa192261ed14004fb50d9/psi-plus.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/3723/11433723/psi-plus-0.16-0.15.20141205git440.fc24.src.rpm

koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=11433722

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328

Raphael Groner  changed:

   What|Removed |Added

 Depends On||1264110



--- Comment #120 from Raphael Groner  ---
(In reply to Raphael Groner from comment #118)
> Unbundle iris.

(In reply to Raphael Groner from comment #116)
> IMHO a build for Qt4 does not make much sense. Upstream tries hard to
> provide patches for Qt5 respectively.

We need iris-qt5: bug #1264110


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1264110
[Bug 1264110] Support for Qt5
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #119 from Raphael Groner projects...@smart.ms ---
Yet another user copr:
https://copr.fedoraproject.org/coprs/region51/psi-plus-snapshots/

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328
Bug 709328 depends on bug 1234207, which changed state.

Bug 1234207 Summary: RFE: qjson support for Qt5
https://bugzilla.redhat.com/show_bug.cgi?id=1234207

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |DEFERRED



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328
Bug 709328 depends on bug 1234209, which changed state.

Bug 1234209 Summary: RFE: Support for Qt5
https://bugzilla.redhat.com/show_bug.cgi?id=1234209

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328

Raphael Groner projects...@smart.ms changed:

   What|Removed |Added

 Depends On||1234207, 1234209



--- Comment #116 from Raphael Groner projects...@smart.ms ---
IMHO a build for Qt4 does not make much sense. Upstream tries hard to provide
patches for Qt5 respectively.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1234207
[Bug 1234207] RFE: Support for Qt5
https://bugzilla.redhat.com/show_bug.cgi?id=1234209
[Bug 1234209] RFE: Support for Qt5
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328

Raphael Groner projects...@smart.ms changed:

   What|Removed |Added

 Blocks|737304  |
 Depends On||737304



--- Comment #118 from Raphael Groner projects...@smart.ms ---
Unbundle iris.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=737304
[Bug 737304] Psi bundle libs
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328

Raphael Groner projects...@smart.ms changed:

   What|Removed |Added

 Depends On||1234217



--- Comment #117 from Raphael Groner projects...@smart.ms ---


/usr/lib64/qt4/bin/moc -DHAVE_MODULES -DQT_NO_DEBUG -DQT_CORE_LIB
-DQT_SHARED -I/usr/lib64/qt4/mkspecs/linux-g++ -I. -I/usr/include/QtCore
-I/usr/include -I. conf4.cpp -o conf4.moc
g++ -c -pipe -O2 -g -pipe -Wall -Werror=format-security
-Wp,-D_FORTIFY_SOURCE=2 -fstack-protector-strong --param=ssp-buffer-size=4
-grecord-gcc-switches -m64 -mtune=generic -O2 -Wall -W -D_REENTRANT
-DHAVE_MODULES -DQT_NO_DEBUG -DQT_CORE_LIB -DQT_SHARED
-I/usr/lib64/qt4/mkspecs/linux-g++ -I. -I/usr/include/QtCore -I/usr/include -I.
-o conf4.o conf4.cpp
In file included from conf4.cpp:703:0:
buildmodeapp.qcm: In member function 'virtual bool
qc_buildmodeapp::exec()':
buildmodeapp.qcm:48:8: warning: variable 'staticmode' set but not used
[-Wunused-but-set-variable]
In file included from conf4.cpp:703:0:
qca.qcm: In function 'bool qca_try(Conf*, const QString, const QString,
const QString, bool, bool, QString*)':
qca.qcm:61:42: error: 'class Conf' has no member named 'escapePath'
qca.qcm:61:68: error: 'class Conf' has no member named 'escapePath'
In file included from conf4.cpp:703:0:
qdbus.qcm: In member function 'virtual bool qc_qdbus::exec()':
qdbus.qcm:33:17: warning: statement has no effect [-Wunused-value]
In file included from conf4.cpp:703:0:
whiteboarding.qcm: In member function 'virtual bool
qc_whiteboarding::exec()':
whiteboarding.qcm:23:14: warning: zero-length gnu_printf format string
[-Wformat-zero-length]
whiteboarding.qcm:24:14: warning: zero-length gnu_printf format string
[-Wformat-zero-length]
In file included from conf4.cpp:703:0:
plugins.qcm: In member function 'virtual bool qc_plugins::exec()':
plugins.qcm:23:14: warning: zero-length gnu_printf format string
[-Wformat-zero-length]
plugins.qcm:24:14: warning: zero-length gnu_printf format string
[-Wformat-zero-length]
In file included from conf4.cpp:703:0:
recursiveprl.qcm: In member function 'bool qc_recursiveprl::writeConf()':
recursiveprl.qcm:95:37: error: 'class Conf' has no member named
'escapedIncludes'
recursiveprl.qcm:97:30: error: 'class Conf' has no member named
'escapedLibs'
In file included from conf4.cpp:703:0:
qca.qcm: At global scope:
qca.qcm:102:13: warning: 'bool qca_try_framework(Conf*, const QString,
bool, bool, QString*)' defined but not used [-Wunused-function]
Makefile:216: recipe for target 'conf4.o' failed
gmake: *** [conf4.o] Error 1

See also https://github.com/psi-plus/main/issues/624


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1234217
[Bug 1234217] Version 1.5 is available
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328

Raphael Groner projects...@smart.ms changed:

   What|Removed |Added

 Depends On||512000



--- Comment #115 from Raphael Groner projects...@smart.ms ---
For the record, qca2 is renamed to qca. Should be fixed in the spec file.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=512000
[Bug 512000] rename qca2 - qca
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #114 from Rex Dieter rdie...@math.unl.edu ---
Re: comment #113

Thanks, but I think the comment was directed more at the submitter of this
review (and eventual package maintainer), drizt

That is, unless you're willing to help maintain psi-plus?

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #112 from Raphael Groner projects...@smart.ms ---
Additional Hints:

- Qt4 development is going to be discontinued with Qt 4.8.7 as the final
release:
https://blog.qt.io/blog/2015/05/26/qt-4-8-7-released/

- Theres a suggestion to use optipng:
https://github.com/psi-im/psi/pull/181

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328

uak...@gmail.com changed:

   What|Removed |Added

 CC||uak...@gmail.com



--- Comment #113 from uak...@gmail.com ---
(In reply to Raphael Groner from comment #109)
 Is there still interest to have an official psi-plus package?
Hello. I'm still interested in it.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #111 from Raphael Groner projects...@smart.ms ---
(In reply to Raphael Groner from comment #110)
 psi-plus snapshot of revision 457 currently is FTBFS cause of too old qmake.

s/qmake/qconf/

We are waiting for qconf 1.5 from upstream.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328

Raphael Groner projects...@smart.ms changed:

   What|Removed |Added

 Whiteboard||NotReady



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328

Raphael Groner projects...@smart.ms changed:

   What|Removed |Added

  Flags|needinfo?(dr...@land.ru)|
   |needinfo?   |



--- Comment #110 from Raphael Groner projects...@smart.ms ---
psi-plus snapshot of revision 457 currently is FTBFS cause of too old qmake.

...
+ qconf-qt4
Project name: Psi
Profile: psi.pro
Deps: qt4* buildmodeapp* idn* qca* zlib* qjdns* x11* universal qdbus webkit
growl whiteboarding xss aspell enchant spell* plugins conf* psimedia
recursiveprl*
'configure' written.
+ ./configure --prefix=/usr --bindir=/usr/bin --libdir=/usr/lib64
--datadir=/usr/share --release --no-separate-debug-info --enable-webkit
--enable-plugins --enable-whiteboarding
--psimedia-path=/usr/lib64/psi/plugins/libgstprovider.so
Configuring Psi ...
Verifying Qt 4 build environment ... fail
Reason: There was an error compiling 'conf'.  See conf.log for details.
Be sure you have a proper Qt 4.0 build environment set up.  This means not
just Qt, but also a C++ compiler, a make tool, and any other packages
necessary for compiling C++ programs.
If you are certain everything is installed, then it could be that Qt 4 is not
being recognized or that a different version of Qt is being detected by
mistake (for example, this could happen if $QTDIR is pointing to a Qt 3
installation).  At least one of the following conditions must be satisfied:
 1) --qtdir is set to the location of Qt
 2) $QTDIR is set to the location of Qt
 3) QtCore is in the pkg-config database
 4) qmake is in the $PATH
This script will use the first one it finds to be true, checked in the above
order.  #3 and #4 are the recommended options.  #1 and #2 are mainly for
overriding the system configuration.


https://github.com/psi-plus/main/issues/624

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328

Raphael Groner projects...@smart.ms changed:

   What|Removed |Added

  Flags||needinfo?



--- Comment #109 from Raphael Groner projects...@smart.ms ---
Is there still interest to have an official psi-plus package? I see currently
two blockers:
- bundled iris (e.g. iris in Fedora is too old for unbundling)
-- can we patch the official iris package? Upstream of iris is the same as of
psi.
- official release for psi 0.16 is awaited at upstream, so it will obsolete a
psi-plus 0.16-0.X.foobar
-- when this will happen is in the stars still ...

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #108 from Raphael Groner projects...@smart.ms ---
Upstream plans to officially release Psi 0.16 (and move Psi+ towards 0.17?):
https://github.com/psi-plus/main/issues/560

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328

Raphael Groner projects...@smart.ms changed:

   What|Removed |Added

  Flags||needinfo?(dr...@land.ru)



--- Comment #107 from Raphael Groner projects...@smart.ms ---
Ping?

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #106 from Raphael Groner projects...@smart.ms ---
Use autodownloader and remove content downloader plugin:

https://admin.fedoraproject.org/pkgdb/package/autodownloader/

1) Plugin has bad usability and does not work properly.
2) Autodownloader will ask the user if it should download additional stuff like
icons etc., this is without legal issue cause of the manual question to confirm
by the individual user.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328

Raphael Groner projects...@smart.ms changed:

   What|Removed |Added

 Blocks||737304




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=737304
[Bug 737304] Psi bundle libs
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #103 from Ivan Romanov dr...@land.ru ---
Sorry. I mean QCA-2.1.0

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #104 from Raphael Groner projects...@smart.ms ---
(In reply to Ivan Romanov from comment #101)
 Skip it. cmake-2.1.0 now is in Fedora repo. 

(In reply to Ivan Romanov from comment #103)
 Sorry. I mean QCA-2.1.0

You probably mean cmake v2.8.x as in Fedora 20, and Fedora 21 has alreade cmake
v3.0.x …

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #105 from Ivan Romanov dr...@land.ru ---
I mean exactly I mean

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #101 from Ivan Romanov dr...@land.ru ---
Skip it. cmake-2.1.0 now is in Fedora repo. So no any problems. Now we need to
have unbundled iris.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #102 from Raphael Groner projects...@smart.ms ---
(In reply to Ivan Romanov from comment #101)
…
 to have unbundled iris.

Yeah, we wait for that upstream fix with the official psi package, too.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #100 from Raphael Groner projects...@smart.ms ---
(In reply to Ivan Romanov from comment #99)
 Ah ... first issue it is to have QCA 2.1.0 with cmake rules. But there is a
 critical bug ... I am fixing this now ...

Usage of cmake would be a great improvement, also in general. What bug are you
struggling with? Can we help somehow?

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

  Flags||needinfo?(dr...@land.ru)



--- Comment #97 from Rex Dieter rdie...@math.unl.edu ---
Ping, need answer to question posed in comment #95 if you're still interested.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328

Ivan Romanov dr...@land.ru changed:

   What|Removed |Added

  Flags|needinfo?(dr...@land.ru)|



--- Comment #98 from Ivan Romanov dr...@land.ru ---
(In reply to Rex Dieter from comment #95)
 If you want this review to pass, options include:
 * build iris packages from here, so they are shareable and usable elsewhere
 (like kopete) see comment #83 , or
 * use separate unbundled iris, which you seemed to prefer in comment #84
I am working on this.

 but continuing to use a non-shared, bundled iris here is not an option.
Yeah I know.

Before I knew that all Kopete patches go to original iris. So now it is not a
problem. Need only to put in order iris sources. Now Psi (I mean original Psi)
seems uses some private iris headers. It's not a good. Also need to move some
Psi+ iris patches to iris repo.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #99 from Ivan Romanov dr...@land.ru ---
Ah ... first issue it is to have QCA 2.1.0 with cmake rules. But there is a
critical bug ... I am fixing this now ...

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328

Raphael Groner projects...@smart.ms changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=737304



--- Comment #96 from Raphael Groner projects...@smart.ms ---
There's a similiar issue with iris also for the normal psi package: bug
#737304.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328

Raphael Groner projects...@smart.ms changed:

   What|Removed |Added

 Blocks||504493
   ||(DuplicSysLibsTracker)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=504493
[Bug 504493] Tracker: Duplication of system libraries
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #93 from Rex Dieter rdie...@math.unl.edu ---
Re: comment #91 and #92, this is a package review, not an appropriate venue to
report unrelated bugs.

The new spec/src.rpm looks nice, but it appears to still bundle iris.  That
seems to be the last primary blocker.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #94 from Ivan Romanov dr...@land.ru ---
In RFRemix I am using psi-plus with bundled iris.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #95 from Rex Dieter rdie...@math.unl.edu ---
If you want this review to pass, options include:
* build iris packages from here, so they are shareable and usable elsewhere
(like kopete) see comment #83 , or
* use separate unbundled iris, which you seemed to prefer in comment #84

but continuing to use a non-shared, bundled iris here is not an option.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #91 from Raphael Groner projects...@smart.ms ---
Bug Report:

https://github.com/psi-plus/plugins/blob/c5a6119f13e6182ba5564a1f2adb007cc1b83de5/generic/contentdownloaderplugin/form.cpp#L259

QFile fd(fullFileName);

if(!fd.open(QIODevice::WriteOnly) || fd.write(reply-readAll()) == -1) {
qDebug()  Content Downloader Plugin:  fd.errorString()  fullFileName;
}

You should change WriteOnly to (hopefully) ReadWrite, because my Qt doesn't
seem to open a file as WriteOnly by default. I don't know what's the logic
behind.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #92 from Raphael Groner projects...@smart.ms ---
(In reply to Raphael Groner from comment #91)

And read this:
http://stackoverflow.com/questions/17686561/qt-qnetworkreply-is-always-empty

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328

Ivan Romanov dr...@land.ru changed:

   What|Removed |Added

  Flags|needinfo?(dr...@land.ru)|



--- Comment #90 from Ivan Romanov dr...@land.ru ---
I updated my RFRemix package. 
SPEC:
https://raw.githubusercontent.com/RussianFedora/psi-plus/6184c2ae9d31c828ceeb44b0db438d037367f641/psi-plus.spec
SRPM:
http://koji.russianfedora.pro/kojifiles/packages/psi-plus/0.16/0.11.20140611git366.fc20.R/src/psi-plus-0.16-0.11.20140611git366.fc20.R.src.rpm

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

  Flags||needinfo?(dr...@land.ru)



--- Comment #89 from Rex Dieter rdie...@math.unl.edu ---
ok, jdns is unbundled, please update psi-plus.spec to use it, and we can
continue/finish the review.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #88 from Raphael Groner raph...@web.de ---
bug #1096442

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328
Bug 709328 depends on bug 1084397, which changed state.

Bug 1084397 Summary: Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #87 from Ivan Romanov dr...@land.ru ---
Rex, I submited review request for jdns package.
https://bugzilla.redhat.com/show_bug.cgi?id=1084397

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

 Depends On||1084397 (jdns)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1084397
[Bug 1084397] Review Request: jdns - A simple DNS queries library
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328

Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info changed:

   What|Removed |Added

 Depends On|1084397 (jdns)  |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1084397
[Bug 1084397] Review Request: jdns - A simple DNS queries library
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

 Depends On||1084397 (jdns)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1084397
[Bug 1084397] Review Request: jdns - A simple DNS queries library
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #86 from Ivan Romanov dr...@land.ru ---
I made jdns as shared standalone library
https://github.com/psi-im/jdns 
Need some work more and will be source tarball and release version.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #85 from Rex Dieter rdie...@math.unl.edu ---
You could do all separate tarballs (and packaging) if you want, but that will
be more work and isn't necessarily.  Creating subpkgs from psi-plus (which
includes those items already) as suggested here is sufficient.

For example, we'll likely end up back having problems where psi-plus using
internal headers/apis, and having to worry about fixing all that.  Not that
fixing such things would be bad, but it would likely mean even more time/work
before psi-plus would pass review and get into fedora.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328

Ivan Romanov dr...@land.ru changed:

   What|Removed |Added

  Flags|needinfo?(dr...@land.ru)|



--- Comment #82 from Ivan Romanov dr...@land.ru ---
You don't want to use common iris for Psi+ and Kopete?
Your way looks like a workaround for Fedora Bundled Libraries rules. No
different to use static or shared libraries with such implementation.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=709328



--- Comment #83 from Rex Dieter rdie...@math.unl.edu ---
We *do* want to use a common iris, the one from this package.  Sorry if that
wasn't clear.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review