[Bug 710917] Review Request: vmpk - Virtual MIDI Piano Keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710917 Robin Lee changed: What|Removed |Added Flag||needinfo?(oget.fedora@gmail ||.com) Bug 710917 depends on bug 744492, which changed state. Bug 744492 Summary: Review Request: rtmidi - Library for realtime MIDI input/output https://bugzilla.redhat.com/show_bug.cgi?id=744492 What|Old Value |New Value Status|NEW |ASSIGNED Status|ASSIGNED|MODIFIED Status|MODIFIED|ON_QA Resolution||ERRATA Status|ON_QA |CLOSED --- Comment #11 from Robin Lee 2011-12-16 05:04:28 EST --- Do you still work on this review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 710917] Review Request: vmpk - Virtual MIDI Piano Keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710917 Orcan Ogetbil changed: What|Removed |Added Flag|needinfo?(oget.fedora@gmail | |.com) | --- Comment #12 from Orcan Ogetbil 2011-12-16 08:22:27 EST --- Sorry, I forgot about it. I'll get to this this weekend. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 710917] Review Request: vmpk - Virtual MIDI Piano Keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710917 Orcan Ogetbil changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #13 from Orcan Ogetbil 2011-12-18 23:00:56 EST --- This package is good to go. Sorry again for the delay. But please keep an eye on qticonloader. If it becomes an independent project we will have to make a separate package for it. --- This package (vmpk) is APPROVED by oget --- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 710917] Review Request: vmpk - Virtual MIDI Piano Keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710917 Robin Lee changed: What|Removed |Added Flag||fedora-cvs? --- Comment #14 from Robin Lee 2011-12-18 23:08:11 EST --- New Package SCM Request === Package Name: vmpk Short Description: Virtual MIDI Piano Keyboard Owners: cheeeselee Branches: f15 f16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 710917] Review Request: vmpk - Virtual MIDI Piano Keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710917 --- Comment #15 from Jon Ciesla 2011-12-19 08:02:41 EST --- Git done (by process-git-requests). Corrected FAS account name. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 710917] Review Request: vmpk - Virtual MIDI Piano Keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710917 --- Comment #16 from Fedora Update System 2011-12-19 09:41:09 EST --- vmpk-0.4.0-4.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/vmpk-0.4.0-4.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 710917] Review Request: vmpk - Virtual MIDI Piano Keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710917 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 710917] Review Request: vmpk - Virtual MIDI Piano Keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710917 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #17 from Fedora Update System 2011-12-21 11:55:52 EST --- vmpk-0.4.0-4.fc15 has been pushed to the Fedora 15 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 710917] Review Request: vmpk - Virtual MIDI Piano Keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710917 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||vmpk-0.4.0-4.fc15 Resolution||ERRATA Last Closed||2011-12-29 19:59:50 --- Comment #18 from Fedora Update System 2011-12-29 19:59:50 EST --- vmpk-0.4.0-4.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 710917] Review Request: vmpk - Virtual MIDI Piano Keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710917 Orcan Ogetbil changed: What|Removed |Added Status|NEW |ASSIGNED CC||oget.fed...@gmail.com AssignedTo|nob...@fedoraproject.org|oget.fed...@gmail.com Flag||fedora-review? --- Comment #1 from Orcan Ogetbil 2011-06-20 00:01:29 EDT --- Here is my review for this - rpmlint output is clean ? The package bundles the rtmidi library. Normally, we do not allow bundled libraries in Fedora. However as far as I remember, the last time we checked (1-2 years ago?), the rtmidi library was not packagable, so we allowed this as an exception. Did you look into this? * The license tag as GPLv3+ is correct, except the bundled rtmidi library is MIT. Depending on the unbundling situation we might need to add MIT to the license tag. ? Should we build this package with jack support? Jack is the most common sound server used in audio production type applications. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 710917] Review Request: vmpk - Virtual MIDI Piano Keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710917 --- Comment #2 from Robin Lee 2011-06-21 09:55:50 EDT --- (In reply to comment #1) > Here is my review for this > - rpmlint output is clean > > ? The package bundles the rtmidi library. Normally, we do not allow bundled > libraries in Fedora. However as far as I remember, the last time we checked > (1-2 years ago?), the rtmidi library was not packagable, so we allowed this as > an exception. Did you look into this? rtmidi library is still not dynamically linkable. > > * The license tag as GPLv3+ is correct, except the bundled rtmidi library is > MIT. Depending on the unbundling situation we might need to add MIT to the > license tag. According to https://fedoraproject.org/wiki/Licensing/FAQ#How_should_I_handle_multiple_licensing_situations.3F , since MIT is compatible with GPL, so only GPL is needed listed. > > ? Should we build this package with jack support? Jack is the most common > sound > server used in audio production type applications. I prefer upstream default setting. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 710917] Review Request: vmpk - Virtual MIDI Piano Keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710917 --- Comment #3 from Orcan Ogetbil 2011-06-21 11:40:19 EDT --- (In reply to comment #2) > (In reply to comment #1) > > Here is my review for this > > - rpmlint output is clean > > > > ? The package bundles the rtmidi library. Normally, we do not allow bundled > > libraries in Fedora. However as far as I remember, the last time we checked > > (1-2 years ago?), the rtmidi library was not packagable, so we allowed this > > as > > an exception. Did you look into this? > rtmidi library is still not dynamically linkable. > No it is not. But 1- It can be made dynamically linkable. But this might conflict with upstream's intentions. It should better be asked upstream. 2- Even if it should remain static, should we not package it separately? I am not sure if bundling is the correct solution. > > > > * The license tag as GPLv3+ is correct, except the bundled rtmidi library is > > MIT. Depending on the unbundling situation we might need to add MIT to the > > license tag. > According to > https://fedoraproject.org/wiki/Licensing/FAQ#How_should_I_handle_multiple_licensing_situations.3F > , since MIT is compatible with GPL, so only GPL is needed listed. > I know about that guideline, which contradicts what FE-Legal says. I was thinking exactly the same way you are, and a package reviewer asked me to list all the licenses separately in the license tag of a package that all code was compiled into a single binary. I asked FE-Legal, quoting the link you gave above, and they told me to list all the licenses separately: https://www.redhat.com/archives/fedora-legal-list/2009-December/msg00029.html > > > > ? Should we build this package with jack support? Jack is the most common > > sound > > server used in audio production type applications. > I prefer upstream default setting. After you build the "vmpk" binary, you can pass some additional flag to cmake to build another binary with jack support, you can even call the second binary vmpk-jack. Please see the README and CMakeLists.txt files. $ cmake . -DRTMIDI_DRIVER=JACK -DPROGRAM_NAME=vmpk-jack Compiling with jack support is important, since we have a large collection of jack-supporting programs, and this will allow "vmpk" to communicate with all of them. jack is pretty much the standard sound server in Linux audio production software. Do you have an argument why compiling with jack support will be bad for Fedora users? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 710917] Review Request: vmpk - Virtual MIDI Piano Keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710917 --- Comment #4 from Robin Lee 2011-06-21 14:17:18 EDT --- (In reply to comment #3) > (In reply to comment #2) > > (In reply to comment #1) > > > Here is my review for this > > > - rpmlint output is clean > > > > > > ? The package bundles the rtmidi library. Normally, we do not allow > > > bundled > > > libraries in Fedora. However as far as I remember, the last time we > > > checked > > > (1-2 years ago?), the rtmidi library was not packagable, so we allowed > > > this as > > > an exception. Did you look into this? > > rtmidi library is still not dynamically linkable. > > > > No it is not. But > 1- It can be made dynamically linkable. But this might conflict with > upstream's > intentions. It should better be asked upstream. > 2- Even if it should remain static, should we not package it separately? I am > not sure if bundling is the correct solution. > I think we are not necessary to talk about the issue of this library here: 1. The guide line says 'A package should not include or build against a local copy of a library that *exists* on a system.' Since RtMidi doesn't exist in Fedora, we can consider it just part of this very work. 2. We should not choose a shared library name for RtMidi upstream, who doesn't intend to make it a shared library. I will ask RtMidi upstream for this issue later. > > > > > > * The license tag as GPLv3+ is correct, except the bundled rtmidi library > > > is > > > MIT. Depending on the unbundling situation we might need to add MIT to the > > > license tag. > > According to > > https://fedoraproject.org/wiki/Licensing/FAQ#How_should_I_handle_multiple_licensing_situations.3F > > , since MIT is compatible with GPL, so only GPL is needed listed. > > > > I know about that guideline, which contradicts what FE-Legal says. I was > thinking exactly the same way you are, and a package reviewer asked me to list > all the licenses separately in the license tag of a package that all code was > compiled into a single binary. > > I asked FE-Legal, quoting the link you gave above, and they told me to list > all > the licenses separately: > > https://www.redhat.com/archives/fedora-legal-list/2009-December/msg00029.html > I think we can try to ask FPC to make the guidelines for this situation more explicit and detailed. > > > > > > > ? Should we build this package with jack support? Jack is the most common > > > sound > > > server used in audio production type applications. > > I prefer upstream default setting. > > After you build the "vmpk" binary, you can pass some additional flag to cmake > to build another binary with jack support, you can even call the second binary > vmpk-jack. Please see the README and CMakeLists.txt files. > > $ cmake . -DRTMIDI_DRIVER=JACK -DPROGRAM_NAME=vmpk-jack > > Compiling with jack support is important, since we have a large collection of > jack-supporting programs, and this will allow "vmpk" to communicate with all > of > them. jack is pretty much the standard sound server in Linux audio production > software. Do you have an argument why compiling with jack support will be bad > for Fedora users? OK. Actually I don't have a strong position. SRPM URL: http://cheeselee.fedorapeople.org/vmpk-0.4.0-2.fc15.src.rpm Change: - Use JACK driver instead of ALSA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 710917] Review Request: vmpk - Virtual MIDI Piano Keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710917 --- Comment #5 from Orcan Ogetbil 2011-06-26 13:49:39 EDT --- (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > 1. The guide line says 'A package should not include or build against a local > copy of a library that *exists* on a system.' Since RtMidi doesn't exist in > Fedora, we can consider it just part of this very work. > Yes, but the common convention is to get the library first into Fedora, then link to the library dynamically or statically. For instance, clementine was bundling libraries - qtsingleapplication - qtlockedfile - qxt - qtiocompressor - gmock - gtest - libechonest - libprojectM We had to package them one by one, and upstream all the clementine's patches before we released clementine under Fedora. Another example was the java DAW frinika. However, I investigated this further. Unlike rtaudio, rtmidi does not provide any libraries (static or dynamic). They just distribute the source code to be included in other software (as is the case with universalchardet library). So I think we are safe with having it built into vmpk. > > I asked FE-Legal, quoting the link you gave above, and they told me to list > > all the licenses separately: > > > > https://www.redhat.com/archives/fedora-legal-list/2009-December/msg00029.html > > > I think we can try to ask FPC to make the guidelines for this situation more > explicit and detailed. > Let us know what comes out so we can approve the package. Thanks. > > Compiling with jack support is important, since we have a large collection > > of > > jack-supporting programs, and this will allow "vmpk" to communicate with > > all of > > them. jack is pretty much the standard sound server in Linux audio > > production > > software. Do you have an argument why compiling with jack support will be > > bad > > for Fedora users? > OK. Actually I don't have a strong position. > > SRPM URL: http://cheeselee.fedorapeople.org/vmpk-0.4.0-2.fc15.src.rpm > > Change: > - Use JACK driver instead of ALSA You wight as well compile two binaries, one that uses ALSA, one that uses JACK. I leave it up to you. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 710917] Review Request: vmpk - Virtual MIDI Piano Keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710917 --- Comment #6 from Robin Lee 2011-07-29 22:00:54 EDT --- License specified to "GPLv3+ and MIT and (LGPLv2 with exceptions or GPLv3)" Spec URL: http://cheeselee.fedorapeople.org/vmpk.spec SRPM URL: http://cheeselee.fedorapeople.org/vmpk-0.4.0-3.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 710917] Review Request: vmpk - Virtual MIDI Piano Keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710917 Robin Lee changed: What|Removed |Added Flag||needinfo?(oget.fedora@gmail ||.com) --- Comment #7 from Robin Lee 2011-08-22 21:07:48 EDT --- Do you still work on this review? I have made an update a couple of weeks ago. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 710917] Review Request: vmpk - Virtual MIDI Piano Keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710917 Orcan Ogetbil changed: What|Removed |Added Flag|needinfo?(oget.fedora@gmail | |.com) | --- Comment #8 from Orcan Ogetbil 2011-08-22 23:21:06 EDT --- Oh sorry, it slipped out of my mind. I'll get back to it asap. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 710917] Review Request: vmpk - Virtual MIDI Piano Keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710917 --- Comment #9 from Orcan Ogetbil 2011-08-24 22:15:44 EDT --- Sorry again for the delay. The package looks good, except the bundled rtmidi library. I asked about this [1] in the Fedora Devel list and apparently, according to the answer I got, you will need to ask FPC (Fedora Packaging Committee) for an exception. Please see [2] for the complete procedure. [1] http://lists.fedoraproject.org/pipermail/devel/2011-July/153938.html [2] https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Exceptions -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 710917] Review Request: vmpk - Virtual MIDI Piano Keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710917 Robin Lee changed: What|Removed |Added Depends on||744492 --- Comment #10 from Robin Lee 2011-10-08 23:08:02 EDT --- Finally, RtMidi is submitted for review. And vmpk now builds with the shared object. Spec URL: http://cheeselee.fedorapeople.org/vmpk.spec SRPM URL: http://cheeselee.fedorapeople.org/vmpk-0.4.0-4.fc15.src.rpm Changes: - Use the RtMidi shared object - License revised to "GPLv3+ and (LGPLv2 with exceptions or GPLv3)" -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
