[Bug 711047] Review Request: naev - 2d action, RPG space game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711047 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2011-07-08 14:07:03 EDT --- naev-data-0.5.0-4.fc15, naev-0.5.0-3.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711047] Review Request: naev - 2d action, RPG space game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711047 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||naev-data-0.5.0-4.fc15 Resolution||ERRATA Last Closed||2011-07-08 14:07:13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711047] Review Request: naev - 2d action, RPG space game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711047 Jonathan Dieter jdie...@lesbg.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #7 from Jonathan Dieter jdie...@lesbg.com 2011-06-29 02:23:50 EDT --- New Package SCM Request === Package Name: naev Short Description: 2d action, RPG space game Owners: jdieter Branches: f14 f15 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711047] Review Request: naev - 2d action, RPG space game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711047 --- Comment #8 from Jon Ciesla l...@jcomserv.net 2011-06-29 07:59:58 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711047] Review Request: naev - 2d action, RPG space game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711047 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711047] Review Request: naev - 2d action, RPG space game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711047 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2011-06-29 13:38:13 EDT --- naev-data-0.5.0-4.fc15,naev-0.5.0-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/naev-data-0.5.0-4.fc15,naev-0.5.0-3.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711047] Review Request: naev - 2d action, RPG space game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711047 --- Comment #10 from Jonathan Dieter jdie...@lesbg.com 2011-06-29 13:44:57 EDT --- Spot, thanks much for this review! Naev has been built for F14, F15 and EL6 now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711047] Review Request: naev - 2d action, RPG space game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711047 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2011-06-29 17:54:14 EDT --- naev-data-0.5.0-4.fc15, naev-0.5.0-3.fc15 has been pushed to the Fedora 15 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711047] Review Request: naev - 2d action, RPG space game
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=711047
Tom spot Callaway tcall...@redhat.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
Flag||fedora-review+
--- Comment #5 from Tom spot Callaway tcall...@redhat.com 2011-06-28
12:11:01 EDT ---
Huh. The %{_mandir}/man6/* line should be correct, what was unnecessary was the
%doc in front of it.
Good:
- rpmlint checks return clean
- package meets naming guidelines
- package meets packaging guidelines
- license (GPLv3) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
(cbaa09d036188a22c0c9c70f1db6e00923b138ff897cdd37072adf4a438a503d)
- package compiles on F-15
(http://koji.fedoraproject.org/koji/taskinfo?taskID=3164092)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- .desktop file OK
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711047] Review Request: naev - 2d action, RPG space game
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=711047
--- Comment #6 from Jonathan Dieter jdie...@gmail.com 2011-06-28 14:31:12 EDT
---
Updated spec to remove defattr. And, yeah, that was my stupid mistake on the
whole %{_mandir} thing. I just removed the whole thing, and then put it back
without the %doc, without realizing that's what I did.
Spec URL:
http://www.lesloueizeh.com/jdieter/naev.spec
SRPM URL:
http://www.lesloueizeh.com/jdieter/naev-0.5.0-3.fc15.src.rpm
32-bit F15 RPM:
http://www.lesloueizeh.com/jdieter/naev-0.5.0-3.fc15.i686.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711047] Review Request: naev - 2d action, RPG space game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711047 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added CC||tcall...@redhat.com --- Comment #2 from Tom spot Callaway tcall...@redhat.com 2011-06-27 10:29:58 EDT --- *** Bug 713925 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711047] Review Request: naev - 2d action, RPG space game
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=711047
--- Comment #3 from Tom spot Callaway tcall...@redhat.com 2011-06-27
10:43:34 EDT ---
Quick comments:
* You do not need the BuildRoot setting, it is obsolete in all current versions
of Fedora. It is only needed for EPEL branches older than 6.
* You do not need the rm -rf %{buildroot} at the beginning of %install. It is
the default in all current versions of Fedora. It is only needed for EPEL
branches older than 6.
* You do not need the default %clean section. A %clean that simply deletes the
%{buildroot} is the default in all current versions of Fedora. It is only
needed for EPEL branches older than 6.
* configure seems to be searching for libGL and libGLU, perhaps
mesa-libGL-devel, mesa-libGLU-devel should be added as BuildRequires?
* make DESTDIR=%{buildroot} install seems to work fine, perhaps you should use
it (and just run desktop-file-validate
%{buildroot}%{_datadir}/applications/%{name}.desktop)
* You do not need to explicitly mark manpages as %doc, anything in the mandir
is automatically marked as %doc.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711047] Review Request: naev - 2d action, RPG space game
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=711047
--- Comment #4 from Jonathan Dieter jdie...@gmail.com 2011-06-27 11:31:27 EDT
---
(In reply to comment #3)
Quick comments:
* You do not need the BuildRoot setting, it is obsolete in all current
versions
of Fedora. It is only needed for EPEL branches older than 6.
Fixed
* You do not need the rm -rf %{buildroot} at the beginning of %install. It is
the default in all current versions of Fedora. It is only needed for EPEL
branches older than 6.
Fixed
* You do not need the default %clean section. A %clean that simply deletes the
%{buildroot} is the default in all current versions of Fedora. It is only
needed for EPEL branches older than 6.
Fixed
* configure seems to be searching for libGL and libGLU, perhaps
mesa-libGL-devel, mesa-libGLU-devel should be added as BuildRequires?
Fixed
* make DESTDIR=%{buildroot} install seems to work fine, perhaps you should use
it (and just run desktop-file-validate
%{buildroot}%{_datadir}/applications/%{name}.desktop)
Fixed, though I now manually choose the highest quality png in extras/logos as
the icon. The default png is 32x32, which looks pretty bad in gnome-shell.
* You do not need to explicitly mark manpages as %doc, anything in the mandir
is automatically marked as %doc.
I tried this, but got:
Checking for unpackaged file(s): /usr/lib/rpm/check-files
/home/jonathan/rpmbuild/BUILDROOT/naev-0.5.0-2.fc15.i386
error: Installed (but unpackaged) file(s) found:
/usr/share/man/man6/naev.6.gz
RPM build errors:
Installed (but unpackaged) file(s) found:
/usr/share/man/man6/naev.6.gz
Maybe I'm just making a stupid mistake?
Updated packages at:
Spec URL:
http://www.lesloueizeh.com/jdieter/naev.spec
SRPM URL:
http://www.lesloueizeh.com/jdieter/naev-0.5.0-2.fc15.src.rpm
32-bit F15 RPM:
http://www.lesloueizeh.com/jdieter/naev-0.5.0-2.fc15.i686.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711047] Review Request: naev - 2d action, RPG space game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711047 Jonathan Dieter jdie...@gmail.com changed: What|Removed |Added Depends on||711048 --- Comment #1 from Jonathan Dieter jdie...@gmail.com 2011-06-06 07:28:09 EDT --- The data files are at bug #711048 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
