[Bug 711230] Review Request: ruby-rhubarb - simple versioned object-graph persistence for ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711230 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|ruby-rhubarb-0.4.1-1.fc15 |ruby-rhubarb-0.4.1-1.fc16 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2012-01-15 15:02:44 EST --- ruby-rhubarb-0.4.1-1.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711230] Review Request: ruby-rhubarb - simple versioned object-graph persistence for ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711230 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|ruby-rhubarb-0.4.1-1.fc16 |ruby-rhubarb-0.4.1-1.fc15 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2012-01-15 15:09:02 EST --- ruby-rhubarb-0.4.1-1.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711230] Review Request: ruby-rhubarb - simple versioned object-graph persistence for ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711230 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||ruby-rhubarb-0.4.1-1.fc15 Resolution||ERRATA Last Closed||2012-01-13 23:00:53 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2012-01-13 23:00:53 EST --- ruby-rhubarb-0.4.1-1.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711230] Review Request: ruby-rhubarb - simple versioned object-graph persistence for ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711230 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2012-01-05 16:01:22 EST --- Package ruby-rhubarb-0.4.1-1.fc16: * should fix your issue, * was pushed to the Fedora 16 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing ruby-rhubarb-0.4.1-1.fc16' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-0121/ruby-rhubarb-0.4.1-1.fc16 then log in and leave karma (feedback). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711230] Review Request: ruby-rhubarb - simple versioned object-graph persistence for ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711230 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711230] Review Request: ruby-rhubarb - simple versioned object-graph persistence for ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711230 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2012-01-04 17:19:53 EST --- ruby-rhubarb-0.4.1-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/ruby-rhubarb-0.4.1-1.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711230] Review Request: ruby-rhubarb - simple versioned object-graph persistence for ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711230 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2012-01-04 17:21:55 EST --- ruby-rhubarb-0.4.1-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/ruby-rhubarb-0.4.1-1.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711230] Review Request: ruby-rhubarb - simple versioned object-graph persistence for ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711230 --- Comment #8 from Vít Ondruch vondr...@redhat.com 2011-12-23 04:10:04 EST --- (In reply to comment #5) Vit, it is packaged that way so it will work on EL5 (which doesn't have RubyGems). Actually this is not true. RubyGems are available in EPEL5. Moreover, you are requesting just Fedora branches, so this argument is irrelevant for Fedora review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711230] Review Request: ruby-rhubarb - simple versioned object-graph persistence for ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711230 --- Comment #5 from Will Benton wi...@redhat.com 2011-12-22 11:21:02 EST --- Vit, it is packaged that way so it will work on EL5 (which doesn't have RubyGems). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711230] Review Request: ruby-rhubarb - simple versioned object-graph persistence for ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711230 Will Benton wi...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Will Benton wi...@redhat.com 2011-12-22 11:22:17 EST --- New Package SCM Request === Package Name: ruby-rhubarb Short Description: simple object-graph persistence library for Ruby Owners: willb Branches: f15 f16 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711230] Review Request: ruby-rhubarb - simple versioned object-graph persistence for ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711230 --- Comment #7 from Jon Ciesla limburg...@gmail.com 2011-12-22 11:39:35 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711230] Review Request: ruby-rhubarb - simple versioned object-graph persistence for ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711230 Vít Ondruch vondr...@redhat.com changed: What|Removed |Added CC||vondr...@redhat.com --- Comment #4 from Vít Ondruch vondr...@redhat.com 2011-11-08 12:58:41 EST --- Hi, could you please enlighten me why did you packaged the library as Ruby library instead of RubyGem? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711230] Review Request: ruby-rhubarb - simple versioned object-graph persistence for ruby
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=711230
Tom spot Callaway tcall...@redhat.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||tcall...@redhat.com
Blocks|177841(FE-NEEDSPONSOR) |
AssignedTo|nob...@fedoraproject.org|tcall...@redhat.com
Flag||fedora-review+
--- Comment #3 from Tom spot Callaway tcall...@redhat.com 2011-11-04
14:18:04 EDT ---
== Review ==
Good:
- rpmlint checks return:
ruby-rhubarb.noarch: W: spelling-error Summary(en_US) versioned - version ed,
version-ed, version
ruby-rhubarb.src: W: spelling-error Summary(en_US) versioned - version ed,
version-ed, version
ruby-rhubarb.src:21: W: unversioned-explicit-provides ruby(rhubarb/rhubarb)
All safe to ignore, although, I would strongly recommend that you consider
appending = %{version} to that explicit provides, even if you're not planning
on checking version of it at this time.
- package meets naming guidelines
- package meets packaging guidelines
- license (ASL 2.0) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
(288cd1251a41d8daa4dcc081f2f8b65b86eaab246babc3157e0d64eeab552c59)
- package compiles on f16 (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
Looks good, so APPROVED. Consider versioning that explicit provides before
commit (and, like in the previous review, dropping the Requires: ruby).
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711230] Review Request: ruby-rhubarb - simple versioned object-graph persistence for ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711230 --- Comment #2 from Will Benton wi...@redhat.com 2011-10-31 15:46:11 EDT --- The most recent SRPM is available from packages.getwallaby.com. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711230] Review Request: ruby-rhubarb - simple versioned object-graph persistence for ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711230 --- Comment #1 from Will Benton wi...@redhat.com 2011-09-21 22:37:52 EDT --- A new SRPM is available at http://packages.getwallaby.com/ruby-rhubarb-0.4.0-3.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
