[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 Itamar Reis Peixoto changed: What|Removed |Added CC||ita...@ispbrasil.com.br --- Comment #1 from Itamar Reis Peixoto 2011-06-07 16:47:08 EDT --- is this your first package ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 --- Comment #2 from Ryan 2011-06-07 17:58:13 EDT --- indeed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=711547
--- Comment #3 from Itamar Reis Peixoto 2011-06-07
18:30:49 EDT ---
please start reading.
https://fedoraproject.org/wiki/Category:Package_Maintainers
I think no need the flowing lines.
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
BuildRequires: gcc
BuildRequires: flex
BuildRequires: bison
your spec file is missing changelog.
please post here the link of a koji scratch build of your package.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 --- Comment #4 from Ryan 2011-06-07 18:38:01 EDT --- Why is it not necessary? The makefile they create uses those things, if they are for some reason missing... http://koji.fedoraproject.org/koji/taskinfo?taskID=3117116 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 --- Comment #5 from Peter Lemenkov 2011-06-08 03:39:39 EDT --- (In reply to comment #4) > Why is it not necessary? The makefile they create uses those things, if they > are for some reason missing... This isn't required because we have a list of packages installed by default into rpmbuildroot. However explicitly listing them (as you did) is harmless and isn't an issue. > http://koji.fedoraproject.org/koji/taskinfo?taskID=3117116 * Youd package doesn't use CFLAGS - this is a blocker. * Missing COPYING in %doc - this ia a strong requirement. * Also adding Doc as %doc sounds like a generally good idea (as well as "readme" and "updates.htm" files). * What's the purpose of the Data directory? Is it required for normal application's operation or not? I think these are jus an examples so they should be packaged as %doc but I'm not sure. * Correct licensing tag should be GPLv3+ not a "GPLv3 (or later)". -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 --- Comment #7 from Ryan 2011-06-09 15:13:43 EDT --- Ok, i've updated the spec file and the srpm, and posted the rpms as well. http://rhl.fedorapeople.org the Data directory looks like examples, and the Doc directory will eventually be broken out into it's own package sketch-docs, right now I am not building it, as I cannot get them to build currently (I suspect they depend on texlive 2010), and the data there is a carbon copy of what is provided on the sketch website. let me know if there are any more problems. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 --- Comment #8 from Ryan 2011-06-09 15:15:16 EDT --- sorry and here is the koji build against dist-f15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 --- Comment #6 from Ryan 2011-06-09 15:13:29 EDT --- Ok, i've updated the spec file and the srpm, and posted the rpms as well. http://rhl.fedorapeople.org the Data directory looks like examples, and the Doc directory will eventually be broken out into it's own package sketch-docs, right now I am not building it, as I cannot get them to build currently (I suspect they depend on texlive 2010), and the data there is a carbon copy of what is provided on the sketch website. let me know if tehre are any more problems. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 --- Comment #9 from Ryan 2011-06-09 15:15:37 EDT --- http://koji.fedoraproject.org/koji/taskinfo?taskID=3122219 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 Khusro Jaleel changed: What|Removed |Added CC||kernelj...@kerneljack.com --- Comment #10 from Khusro Jaleel 2011-06-22 17:07:57 EDT --- The only thing that stands out to me so far is the missing Changelog entry -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 Ryan H. Lewis (rhl) changed: What|Removed |Added Flag||needinfo?(nobody@fedoraproj ||ect.org) --- Comment #11 from Ryan H. Lewis (rhl) 2011-06-26 13:05:12 EDT --- Updated to add changelog: http://rhl.fedorapeople.org/sketch.spec Corresponding SRPM: http://rhl.fedorapeople.org/sketch-0.3.2-1.fc15.src.rpm Corresponding Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3162258 rpmlint output: 0 packages and 1 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=711547
Richard Shaw changed:
What|Removed |Added
CC||hobbes1...@gmail.com
--- Comment #12 from Richard Shaw 2011-07-02 10:09:19
EDT ---
I can't sponsor you but I can suggest some fixes to your spec.
You still need to update your License tag per comment 5.
You don't need BuildRoot unless you're planning on building for EPEL <= 5
You don't need %clean unless you're planning on building for EPEL, in fact
leaving it in without the accompanying "rm -rf %{buildroot}" is worse.
You don't need "rm -rf %{buildroot}" in %install unless you're planning to
build for EPEL <= 5.
I assume that since you're manually installing the binary that this package
lacks a "make install" target?
All of your "%doc" items can be listed space separated on one line.
You need to add one empty line between your changelog entries, e.g.:
%changelog
* Mon Jun 26 2011 Ryan H. Lewis 1.0-3
- Added ChangeLog
* Mon Jun 9 2011 Ryan H. Lewis 1.0-2
- Fixes https://bugzilla.redhat.com/show_bug.cgi?id=711547#c5
* Mon Jun 7 2011 Ryan H. Lewis 1.0-1
- Created initial spec file
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 --- Comment #13 from Ryan H. Lewis (rhl) 2011-07-02 21:54:02 EDT --- all fixed, not sure why the licence tag ended up 'unfixed' again, but I did fix that once... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 Ryan H. Lewis (rhl) changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 Kevin Fenzi changed: What|Removed |Added CC||ke...@scrye.com --- Comment #14 from Kevin Fenzi 2011-07-05 10:13:07 EDT --- Hey Ryan. Was there another version of the package with the fixes from comment 12? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 --- Comment #15 from Ryan H. Lewis (rhl) 2011-07-05 10:27:02 EDT --- Yes: http://rhl.fedorapeople.org Updated: http://rhl.fedorapeople.org/sketch.spec Corresponding SRPM: http://rhl.fedorapeople.org/sketch-0.3.2-1.fc15.src.rpm the links aren't changing at all, just the content. I'm making sure to update the srpm whenever I modify the spec file... (see timestamps). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 --- Comment #16 from Richard Shaw 2011-07-25 14:18:34 EDT --- I think what Kevin was referring to is that you've incremented the releases appropriately in the changelog but "Release:" in your spec file (and therefore the resulting SRPM) is still "1". Some other thoughts... 1. I would remove "%check" since it's empty. 2. This only aids readability, but I always leave two empty lines between major sections in the spec file, i.e: Between %prep, %build, %install, %files, etc. 3. The last line in your %files section has "#doc Doc/" instead of "%doc Doc/", is this intentional? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 --- Comment #17 from Ryan H. Lewis (rhl) 2011-07-26 20:53:42 EDT --- Ok. I've made these changes, and i've uploaded it to http://rhl.fedorapeople.org spec and srpm, with the new version. at this point repeating koji builds is useless, as nothing is changing but minor details. in regards to your question 3. please read: https://bugzilla.redhat.com/show_bug.cgi?id=711547#c6 I am not sure what the compile issue is with the documentation, I asked the maintainer and they are now using OS X, but again, the information provided there is no different than what is on the web, so once I do get the docs compiling I can break out a sketch-docs sub package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 --- Comment #18 from Richard Shaw 2011-07-27 08:59:14 EDT --- (In reply to comment #17) > in regards to your question 3. please read: > https://bugzilla.redhat.com/show_bug.cgi?id=711547#c6 > > I am not sure what the compile issue is with the documentation, I asked the > maintainer and they are now using OS X, but again, the information provided > there is no different than what is on the web, so once I do get the docs > compiling I can break out a sketch-docs sub package. That's fine, I would handle this by leaving the % on the front of doc so it doesn't look like a mistake (sure rpmlint will complain but we know why it's there) and put a comment above it with a brief description on why it's currently commented out. Really, it's a best practice to put in comments any time you're doing something non-standard so Proven Packagers, co-maintainers, or possible future owners of the package will know why you did something. Richard -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 --- Comment #19 from Richard Shaw 2011-07-27 09:00:43 EDT --- Forgot to say, now we just need to find you a sponsor (if you don't already have one). If you haven't done so recently it wouldn't hurt to email the devel list with a polite request for sponsorship. Richard -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 Luke Macken changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | Flag|needinfo?(nobody@fedoraproj | |ect.org)| --- Comment #20 from Luke Macken 2011-07-27 20:38:07 EDT --- I will be sponsoring Ryan. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 --- Comment #21 from Ryan H. Lewis (rhl) 2011-07-27 23:37:06 EDT --- Ok, so the % has been added, version bumped, spec and new srpm uploaded to fedorapeople.org, again: http://rhl.fedorapeople.org what do I need to do next, as you can see luke has offered to sponsor me, is this package approved yet? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 --- Comment #22 from Richard Shaw 2011-07-28 11:56:44 EDT --- Luke will have to do the full guideline checklist but I'd say you're in pretty good shape. Make sure you're good on everything at: http://fedoraproject.org/wiki/Join_the_package_collection_maintainers Paying specific attention to: http://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Get_Sponsored It wouldn't hurt to do some informal reviews on other open (unassigned) review requests. Richard -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 --- Comment #23 from Ryan H. Lewis (rhl) 2011-07-28 22:33:33 EDT --- great. I've re-read the above link, it appears i've done everything I can for now. I informed Luke that he needs to do the 'full review,' I did an informal review of a font package: https://bugzilla.redhat.com/show_bug.cgi?id=714408 which was unassigned, but then got assigned, and accepted and is now located here: https://admin.fedoraproject.org/pkgdb/acls/name/tlomt-league-gothic-fonts -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 --- Comment #24 from Richard Shaw 2011-07-29 09:23:12 EDT --- We'll all I can tell you is to be patient... I had to learn that the hard way as well :) It can be frustrating when you're excited about becoming a contributor and things seem to be moving at a snail's pace. Richard -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=711547
Luke Macken changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|nob...@fedoraproject.org|lmac...@redhat.com
Flag||fedora-review+
--- Comment #25 from Luke Macken 2011-08-03 22:21:14 EDT
---
MUST Items:
[X] rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.[1]
sketch.x86_64: W: summary-ended-with-dot C A 3D Scene Description
Translator.
sketch.x86_64: W: spelling-error 0%description -l en_US un -> UN, nu,
in
sketch.x86_64: W: unstripped-binary-or-object /usr/bin/sketch
sketch.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/sketch-0.3.2/Data/hand.sk
sketch.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/sketch-0.3.2/Data/buggy.sk
sketch.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/sketch-0.3.2/Data/cone.sk
sketch.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/sketch-0.3.2/Data/2tori.sk
sketch.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/sketch-0.3.2/COPYING.txt
sketch.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/sketch-0.3.2/Data/bunny.sk
sketch.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/sketch-0.3.2/Data/test.sk
sketch.x86_64: W: no-manual-page-for-binary sketch
1 packages and 0 specfiles checked; 0 errors, 11 warnings.
[X] The package must be named according to the Package Naming Guidelines .
[X] The spec file name must match the base package 100%{name}, in the
format %{name}.spec unless your package has an exemption. [2] .
[X] The package must meet the Packaging Guidelines .
[X] The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
[X] The License field in the package spec file must match the actual
license. [3]
[X] If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in 100%doc.[4]
[X] The spec file must be written in American English. [5]
[X] The spec file for the package MUST be legible. [6]
[X] The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
[X] The package MUST successfully compile and build into binary rpms on at
least one primary architecture. [7]
[X] If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line. [8]
[X] All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[X] The spec file MUST handle locales properly. This is done by using the
100%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9]
[X] Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in 100%post and %postun. [10]
[X] Packages must NOT bundle copies of system libraries.[11]
[X] If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker. [12]
[X] A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory. [13]
[X] A Fedora package must not list a file more than once in the spec file's
100%files listings. (Notable exception: license texts in specific
situations)[14]
[X] Permissions on files must be set properly. Executables should be set
with executable permissions, for example. [15]
[X] Each package must consistently use macros. [16]
[X] The package must contain code, or permissable content. [17]
[X] Large documentation files must go in a -doc subpackage. (The definition
of large is left up to the packager's best judgement, but is not restricted to
s
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 Ryan H. Lewis (rhl) changed: What|Removed |Added Flag||fedora-cvs? --- Comment #26 from Ryan H. Lewis (rhl) 2011-08-07 21:30:15 EDT --- New Package SCM Request === Package Name: sketch Short Description: A 3D Scene Description Translator. Owners: rhl Branches: f14 f15 el4 el5 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 --- Comment #27 from Jon Ciesla 2011-08-08 06:09:28 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 --- Comment #28 from Fedora Update System 2011-08-08 09:15:44 EDT --- sketch-0.3.2-6.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/sketch-0.3.2-6.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 --- Comment #29 from Fedora Update System 2011-08-08 09:22:58 EDT --- sketch-0.3.2-6.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/sketch-0.3.2-6.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 --- Comment #30 from Fedora Update System 2011-08-08 09:42:50 EDT --- sketch-0.3.2-6.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/sketch-0.3.2-6.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #31 from Fedora Update System 2011-08-08 21:34:19 EDT --- sketch-0.3.2-6.fc14 has been pushed to the Fedora 14 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 --- Comment #32 from Fedora Update System 2011-08-16 20:54:26 EDT --- sketch-0.3.2-6.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||sketch-0.3.2-6.fc14 Resolution||ERRATA Last Closed||2011-08-16 20:54:32 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 --- Comment #33 from Fedora Update System 2011-08-16 21:12:20 EDT --- sketch-0.3.2-6.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 Fedora Update System changed: What|Removed |Added Fixed In Version|sketch-0.3.2-6.fc14 |sketch-0.3.2-6.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 --- Comment #34 from Fedora Update System 2011-08-26 17:54:34 EDT --- sketch-0.3.2-6.el6 has been pushed to the Fedora EPEL 6 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 Fedora Update System changed: What|Removed |Added Fixed In Version|sketch-0.3.2-6.fc15 |sketch-0.3.2-6.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
