[Bug 712561] Review Request: gnome-shell-theme-atolm - the atolm gnome-shell theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712561 Fabian Affolter changed: What|Removed |Added Status|NEW |ASSIGNED CC||fab...@bernewireless.net AssignedTo|nob...@fedoraproject.org|fab...@bernewireless.net Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712561] Review Request: gnome-shell-theme-atolm - the atolm gnome-shell theme
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=712561
Fabian Affolter changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #1 from Fabian Affolter 2011-06-19
07:50:40 EDT ---
Package Review
==
Package:
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[?] Package is named according to the Package Naming Guidelines
[?] Spec file name must match the base package %{name}, in the format
%{name}.spec
[?] Package meets the Packaging Guidelines
[?] Package successfully compiles and builds into binary RPMs on at least one
supported architecture
Tested:
[!] Rpmlint output:
Source RPM:
[fab@laptop021 SRPMS]$ rpmlint gnome-shell-theme-atolm-1.0-1.fc15.src.rpm
gnome-shell-theme-atolm.src: W: invalid-url URL
http://http://half-left.deviantart.com/art/GNOME-Shell-Atolm-204534789
gnome-shell-theme-atolm.src: W: no-%build-section
gnome-shell-theme-atolm.src:9: W: mixed-use-of-spaces-and-tabs (spaces:
line 6, tab: line 9)
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
Binary RPM(s):
[fab@laptop021 noarch]$ rpmlint
gnome-shell-theme-atolm-1.0-1.fc15.noarch.rpm
gnome-shell-theme-atolm.noarch: W: incoherent-version-in-changelog 1.0
['1.0-1.fc15', '1.0-1']
gnome-shell-theme-atolm.noarch: W: invalid-url URL
http://http://half-left.deviantart.com/art/GNOME-Shell-Atolm-204534789
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
[x] Package is not relocatable
[-] Buildroot is correct (if it's still used)
master : %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
spec file:
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[x] License field in the package spec file matches the actual license
License type: GPLv3
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc
[x] Spec file is legible and written in American English
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL
Upstream source: 0ad23a6261d689d5747fc3b927d261f5
gnome_shellatolm_by_half_left-d3drw1x.zip
Build source:0ad23a6261d689d5747fc3b927d261f5
gnome_shellatolm_by_half_left-d3drw1x.zip
[x] Package is not known to require ExcludeArch
[x] Architecture independent packages have: BuildArch: noarch
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[-] The spec file handles locales properly. %find_lang used for locales
[-] %{optflags} or RPM_OPT_FLAGS are honoured
[-] ldconfig called in %post and %postun if required
[-] %install starts with rm -rf %{buildroot} or $RPM_BUILD_ROOT (if it's
still used)
[-] Package use %makeinstall only when make install DESTDIR=... doesn't work.
[x] Package must own all directories that it creates
[-] Package requires other packages for directories it uses
[x] Package does not own files or directories owned by other packages
[x] Package does not contain duplicates in %files
[-] Permissions on files are set properly. %defattr(-,root,root,-) is in every
%files section
[x] Package uses nothing in %doc for runtime
[-] Package has a %clean section, which contains rm -rf %{buildroot} or
$RPM_BUILD_ROOT (if it's still used)
[-] Included tests passed successfully
[x] Package consistently uses macros
[x] Package contains code, or permissable content
[x] Included filenames are in UTF-8
[-] Large documentation files are in a -doc subpackage, if required
[-] Header files (.h) in -devel subpackage, if present
[-] Fully versioned dependency in subpackage, if present
[-] Static libraries (.a) in -static subpackage, if present
[-] Package requires pkgconfig, if .pc files are present
[-] Development .so files in -devel subpackage, if present
[x] Package does not contain any libtool archives (.la)
[-] -debuginfo subpackage is present and looks complete
[x] No pre-built binaries (.a, .so*, executable)
[-] Package contains a properly installed .desktop file if it is a GUI
application
[-] Follows desktop entry spec
[-] Valid .desktop Name
[-] Valid .desktop GenericName
[-] Valid .desktop Categories
[-] Valid .desktop StartupNotify
[-] .desktop file installed with desktop-file-install in %install
=== SUGGESTED ITEMS ===
[-] Timestamps preserved with cp and install
[x] Spec use %global instead of %define
[-] Uses parallel make (%{?_smp_mflags})
[x] Latest version is packaged
[-] Package does n
[Bug 712561] Review Request: gnome-shell-theme-atolm - the atolm gnome-shell theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712561 --- Comment #2 from Tim Lauridsen 2011-06-19 12:58:43 EDT --- Thanks for the review. I will fix the rpmlint issues before import -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712561] Review Request: gnome-shell-theme-atolm - the atolm gnome-shell theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712561 Tim Lauridsen changed: What|Removed |Added Flag||fedora-cvs? --- Comment #3 from Tim Lauridsen 2011-06-19 12:59:49 EDT --- New Package SCM Request === Package Name: gnome-shell-theme-atolm Short Description: The atolm gnome-shell theme Owners: timlau Branches: f15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712561] Review Request: gnome-shell-theme-atolm - the atolm gnome-shell theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712561 --- Comment #4 from Jon Ciesla 2011-06-19 18:21:14 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712561] Review Request: gnome-shell-theme-atolm - the atolm gnome-shell theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712561 --- Comment #5 from Fedora Update System 2011-06-22 01:44:27 EDT --- gnome-shell-theme-atolm-1.0-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/gnome-shell-theme-atolm-1.0-1.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712561] Review Request: gnome-shell-theme-atolm - the atolm gnome-shell theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712561 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712561] Review Request: gnome-shell-theme-atolm - the atolm gnome-shell theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712561 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System 2011-06-23 23:49:51 EDT --- gnome-shell-theme-atolm-1.0-1.fc15 has been pushed to the Fedora 15 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712561] Review Request: gnome-shell-theme-atolm - the atolm gnome-shell theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712561 --- Comment #7 from Fedora Update System 2011-07-02 15:23:53 EDT --- gnome-shell-theme-atolm-1.0-1.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712561] Review Request: gnome-shell-theme-atolm - the atolm gnome-shell theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712561 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||gnome-shell-theme-atolm-1.0 ||-1.fc15 Resolution||ERRATA Last Closed||2011-07-02 15:23:59 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
