[Bug 712567] Review Request: gnome-shell-theme-ambiance - the ambiance gnome-shell theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712567 --- Comment #15 from Tim Lauridsen t...@rasmil.dk 2012-02-13 12:56:25 EST --- (In reply to comment #14) Wouldn't it be time to feed the Git now...? Git is feeded, but it look like i never pushed it for F16 https://admin.fedoraproject.org/updates/gnome-shell-theme-ambiance -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712567] Review Request: gnome-shell-theme-ambiance - the ambiance gnome-shell theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712567 Tim Lauridsen t...@rasmil.dk changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2012-02-13 12:56:54 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712567] Review Request: gnome-shell-theme-ambiance - the ambiance gnome-shell theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712567 --- Comment #14 from Mario Blättermann mario.blaetterm...@gmail.com 2012-02-12 15:54:19 EST --- Wouldn't it be time to feed the Git now...? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712567] Review Request: gnome-shell-theme-ambiance - the ambiance gnome-shell theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712567 --- Comment #11 from Tim Lauridsen t...@rasmil.dk 2011-10-18 11:06:10 EDT --- Thanks for reviewing :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712567] Review Request: gnome-shell-theme-ambiance - the ambiance gnome-shell theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712567 Tim Lauridsen t...@rasmil.dk changed: What|Removed |Added Flag||fedora-cvs? --- Comment #12 from Tim Lauridsen t...@rasmil.dk 2011-10-18 11:10:36 EDT --- New Package SCM Request === Package Name: gnome-shell-theme-ambiance Short Description: ambiance theme for gnome-shell Owners: timlau Branches: f15 f16 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712567] Review Request: gnome-shell-theme-ambiance - the ambiance gnome-shell theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712567 --- Comment #13 from Jon Ciesla l...@jcomserv.net 2011-10-18 11:18:01 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712567] Review Request: gnome-shell-theme-ambiance - the ambiance gnome-shell theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712567 --- Comment #9 from Tim Lauridsen t...@rasmil.dk 2011-10-17 04:56:51 EDT --- Thanks for reviewing: New spec srpms with the following changes: Add -p to cp commands. fixed changelog versioning fixed typo http://timlau.fedorapeople.org/files/packages/theme-selector/SRPMS/gnome-shell-theme-ambiance-1.0-2.fc16.src.rpm http://timlau.fedorapeople.org/files/packages/theme-selector/SPECS/gnome-shell-theme-ambiance.spec Can't do much about the .zip is not compressed, but it not a big problem :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712567] Review Request: gnome-shell-theme-ambiance - the ambiance gnome-shell theme
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=712567
Mario Blättermann mari...@freenet.de changed:
What|Removed |Added
Status|NEW |ASSIGNED
Flag|fedora-review? |fedora-review+
--- Comment #10 from Mario Blättermann mari...@freenet.de 2011-10-17 14:01:41
EDT ---
Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3437570
$ rpmlint -i -v *
gnome-shell-theme-ambiance.noarch: I: checking
gnome-shell-theme-ambiance.noarch: I: checking-url
http://half-left.deviantart.com/art/GNOME-Shell-Ubuntu-Ambience-210264151
(timeout 10 seconds)
gnome-shell-theme-ambiance.src: I: checking
gnome-shell-theme-ambiance.src: I: checking-url
http://half-left.deviantart.com/art/GNOME-Shell-Ubuntu-Ambience-210264151
(timeout 10 seconds)
gnome-shell-theme-ambiance.src: I: checking-url
http://www.deviantart.com/download/210264151/gnome_shell___ubuntu_ambiance_by_half_left-d3h6ouv.zip
(timeout 10 seconds)
gnome-shell-theme-ambiance.src: W: uncompressed-zip
gnome_shell___ubuntu_ambiance_by_half_left-d3h6ouv.zip
The zip file is not compressed.
gnome-shell-theme-ambiance.spec: I: checking-url
http://www.deviantart.com/download/210264151/gnome_shell___ubuntu_ambiance_by_half_left-d3h6ouv.zip
(timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 1 warnings.
Looks fine so far.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
GPLv3
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ md5sum *
69de62f03b7c5f19f76eac81975c5d43
gnome_shell___ubuntu_ambiance_by_half_left-d3h6ouv.zip
69de62f03b7c5f19f76eac81975c5d43
gnome_shell___ubuntu_ambiance_by_half_left-d3h6ouv.zip.packaged
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
- Succesful Koji build available.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[.] MUST: All build dependencies must be listed in BuildRequires.
Nothing to build at all.
[.] MUST: The spec file MUST handle locales properly.
[.] MUST: If a package installs files below %{_datadir}/icons, the icon cache
must be updated.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates.
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Packages must not provide RPM dependency information when that
information is not global in nature, or are otherwise handled.
[.] MUST: When filtering automatically generated RPM dependency information,
the filtering system implemented by Fedora must be used.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), ...
[.] MUST: devel packages must require the base package using a fully versioned
dependency.
[.] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file
[.] MUST: .desktop files must be properly installed with desktop-file-install
in the %install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.
[.] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream...
[+] SHOULD: Timestamps of files should be preserved.
[+] SHOULD: The reviewer should test that the package builds in mock.
See Koji build
[Bug 712567] Review Request: gnome-shell-theme-ambiance - the ambiance gnome-shell theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712567 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added Blocks|182235(FE-Legal)| --- Comment #7 from Tom spot Callaway tcall...@redhat.com 2011-06-27 12:21:00 EDT --- Lifting FE-Legal, thanks for your effort Tim. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712567] Review Request: gnome-shell-theme-ambiance - the ambiance gnome-shell theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712567 Tim Lauridsen t...@rasmil.dk changed: What|Removed |Added Summary|Review Request: |Review Request: |gnome-shell-theme-ubuntu-am |gnome-shell-theme-ambiance |biance - the|- the ambiance gnome-shell |ubuntu-ambiance gnome-shell |theme |theme | --- Comment #6 from Tim Lauridsen t...@rasmil.dk 2011-06-25 04:09:57 EDT --- Ok, now I have renamed the package to *-ambiance The 3 include theme variant is now named Ambiance-light etc. Review images are replaced, with screen shots under fedora. SPEC: http://timlau.fedorapeople.org/files/packages/theme-selector/SPECS/gnome-shell-theme-ambiance.spec SRPM: http://timlau.fedorapeople.org/files/packages/theme-selector/SRPMS/gnome-shell-theme-ambiance-1.0-1.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
