[Bug 712705] Review Request: gnome-shell-extension-icon-manager - A gnome-shell extension to manage icons in top bar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712705 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||gnome-shell-extension-icon- ||manager-0-0.2.gite9deb2b.fc ||15 Resolution||ERRATA Last Closed||2011-07-04 14:54:57 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712705] Review Request: gnome-shell-extension-icon-manager - A gnome-shell extension to manage icons in top bar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712705 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2011-07-04 14:54:52 EDT --- gnome-shell-extension-icon-manager-0-0.2.gite9deb2b.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712705] Review Request: gnome-shell-extension-icon-manager - A gnome-shell extension to manage icons in top bar
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=712705
Mohamed El Morabity pikachu.2...@gmail.com changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #8 from Mohamed El Morabity pikachu.2...@gmail.com 2011-06-25
06:04:45 EDT ---
Here is the review.
MUST: rpmlint must be run on every package.
-OK, only false-positive spelling issues
MUST: The package must be named according to the Package Naming Guidelines.
-OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
-OK
MUST: The package must meet the Packaging Guidelines.
-OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines.
-OK
MUST: The License field in the package spec file must match the actual license.
-OK, all files under GPL v3 or more
MUST: If (and only if) the source package includes the text of the license(s)
in
its own file, then that file, containing the text of the license(s) for
the package must be included in %doc.
-N/A
MUST: The spec file must be written in American English.
-OK
MUST: The spec file for the package MUST be legible.
-OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL.
-OK, md5sum = 21c385a7c6ae635b27e7b6fdb9c41f0c
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
-OK
MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
-N/A
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional.
-OK
MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
-N/A
MUST: Every binary RPM package (or subpackage) which stores shared library
files
(not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
-N/A
MUST: Packages must NOT bundle copies of system libraries.
-OK
MUST: If the package is designed to be relocatable, the packager must state
this
fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
-N/A
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does
create that directory.
OK
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings.
-OK
MUST: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. Every %files section must include a
%defattr(...) line.
-OK
MUST: Each package must consistently use macros.
-OK
MUST: The package must contain code, or permissable content.
-OK
MUST: Large documentation files must go in a -doc subpackage.
-N/A
MUST: If a package includes something as %doc, it must not affect the runtime
of
the application. To summarize: If it is in %doc, the program must run
properly if it is not present.
-OK
MUST: Header files must be in a -devel package.
-N/A
MUST: Static libraries must be in a -static package.
-N/A
MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
package.
-N/A
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release}.
-N/A
MUST: Packages must NOT contain any .la libtool archives, these must be removed
in the spec if they are built.
-N/A
MUST: Packages containing GUI applications must include a %{name}.desktop file,
and that file must be properly installed with desktop-file-install in the
%install section.
-N/A
MUST: Packages must not own files or directories already owned by other
packages.
-OK
MUST: All filenames in rpm packages must be valid UTF-8.
-OK
Approved.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712705] Review Request: gnome-shell-extension-icon-manager - A gnome-shell extension to manage icons in top bar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712705 Guillaume Kulakowski llaum...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Guillaume Kulakowski llaum...@gmail.com 2011-06-25 08:34:52 EDT --- New Package SCM Request === Package Name: gnome-shell-extension-icon-manager Short Description: A gnome-shell extension to manage icons in top bar Owners: llaumgui Branches: f15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712705] Review Request: gnome-shell-extension-icon-manager - A gnome-shell extension to manage icons in top bar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712705 --- Comment #10 from Jon Ciesla l...@jcomserv.net 2011-06-25 09:24:03 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712705] Review Request: gnome-shell-extension-icon-manager - A gnome-shell extension to manage icons in top bar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712705 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712705] Review Request: gnome-shell-extension-icon-manager - A gnome-shell extension to manage icons in top bar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712705 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2011-06-25 09:56:12 EDT --- gnome-shell-extension-icon-manager-0-0.2.gite9deb2b.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/gnome-shell-extension-icon-manager-0-0.2.gite9deb2b.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712705] Review Request: gnome-shell-extension-icon-manager - A gnome-shell extension to manage icons in top bar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712705 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2011-06-25 16:02:04 EDT --- gnome-shell-extension-icon-manager-0-0.2.gite9deb2b.fc15 has been pushed to the Fedora 15 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712705] Review Request: gnome-shell-extension-icon-manager - A gnome-shell extension to manage icons in top bar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712705 --- Comment #7 from Guillaume Kulakowski llaum...@gmail.com 2011-06-24 14:31:38 EDT --- Updated: Spec URL: http://llaumgui.fedorapeople.org/review/gnome-shell-extension-icon-manager/gnome-shell-extension-icon-manager.spec SRPM URL: http://llaumgui.fedorapeople.org/review/gnome-shell-extension-icon-manager/gnome-shell-extension-icon-manager-0-0.2.gite9deb2b.fc15.src.rpm RPM URL: http://llaumgui.fedorapeople.org/review/gnome-shell-extension-icon-manager/gnome-shell-extension-icon-manager-0-0.2.gite9deb2b.fc15.noarch.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712705] Review Request: gnome-shell-extension-icon-manager - A gnome-shell extension to manage icons in top bar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712705 --- Comment #6 from Guillaume Kulakowski llaum...@gmail.com 2011-06-21 13:49:51 EDT --- Error reporting : https://github.com/MrTheodor/gnome-shell-ext-icon-manager/issues/1 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712705] Review Request: gnome-shell-extension-icon-manager - A gnome-shell extension to manage icons in top bar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712705 Kevin Verma kevinve...@fedoraproject.org changed: What|Removed |Added CC||kevinve...@fedoraproject.or ||g --- Comment #4 from Kevin Verma kevinve...@fedoraproject.org 2011-06-17 07:07:22 EDT --- (In reply to comment #3) Updated : Spec URL: http://llaumgui.fedorapeople.org/review/gnome-shell-extension-icon-manager/gnome-shell-extension-icon-manager.spec SRPM URL: http://llaumgui.fedorapeople.org/review/gnome-shell-extension-icon-manager/gnome-shell-extension-icon-manager-0-0.1.gited463a5.fc15.src.rpm RPM URL: http://llaumgui.fedorapeople.org/review/gnome-shell-extension-icon-manager/gnome-shell-extension-icon-manager-0-0.1.gited463a5.fc15.noarch.rpm I tested the updated RPM and found that this extension does move task tray items out of messageTray into the top-pannel. Following the text of my configuration for org.gnome.shell.extentsions.icon-manager using dconf-editor: --snip-- ['a11y', 'gnote', 'parcellite', 'empathy', 'pidgin', 'workrave'] --snip-- I have only used this rpm to see if this extension works for given purpose, but I have not reviewed the RPM in particular. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712705] Review Request: gnome-shell-extension-icon-manager - A gnome-shell extension to manage icons in top bar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712705 --- Comment #5 from Mohamed El Morabity pikachu.2...@gmail.com 2011-06-17 08:41:46 EDT --- The description is not true: the extension is configured through gsettings, not gconf. Plese fix it... And report the issue upstream. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712705] Review Request: gnome-shell-extension-icon-manager - A gnome-shell extension to manage icons in top bar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712705 Mohamed El Morabity pikachu.2...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|pikachu.2...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712705] Review Request: gnome-shell-extension-icon-manager - A gnome-shell extension to manage icons in top bar
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=712705
Mohamed El Morabity pikachu.2...@gmail.com changed:
What|Removed |Added
CC||pikachu.2...@gmail.com
--- Comment #1 from Mohamed El Morabity pikachu.2...@gmail.com 2011-06-12
11:46:30 EDT ---
* Useless Requires condition on gnome-shell (Fedora 15 provides GS 3.0.2).
* Don't use %{__foo} macros: they make the .spec file harder to read. Using
them is discouraged by the Project:
https://bugzilla.redhat.com/show_bug.cgi?id=669311#c9
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712705] Review Request: gnome-shell-extension-icon-manager - A gnome-shell extension to manage icons in top bar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712705 --- Comment #2 from Mohamed El Morabity pikachu.2...@gmail.com 2011-06-12 13:01:38 EDT --- Remove also the INSTALL file in %doc. Users don't care about manual installation. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712705] Review Request: gnome-shell-extension-icon-manager - A gnome-shell extension to manage icons in top bar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712705 --- Comment #3 from Guillaume Kulakowski llaum...@gmail.com 2011-06-12 14:46:06 EDT --- Updated : Spec URL: http://llaumgui.fedorapeople.org/review/gnome-shell-extension-icon-manager/gnome-shell-extension-icon-manager.spec SRPM URL: http://llaumgui.fedorapeople.org/review/gnome-shell-extension-icon-manager/gnome-shell-extension-icon-manager-0-0.1.gited463a5.fc15.src.rpm RPM URL: http://llaumgui.fedorapeople.org/review/gnome-shell-extension-icon-manager/gnome-shell-extension-icon-manager-0-0.1.gited463a5.fc15.noarch.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
