Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=712921
Toshio Ernie Kuratomi a.bad...@gmail.com changed:
What|Removed |Added
CC||a.bad...@gmail.com
AssignedTo|nob...@fedoraproject.org|a.bad...@gmail.com
--- Comment #1 from Toshio Ernie Kuratomi a.bad...@gmail.com 2011-06-27
14:47:24 EDT ---
Notes: Many of the to-be-fixed items apply to both this package and the main
zabbix package. With the exception of implementing this as alternatives, these
seem to be relatively easy changes. You said something about looking into
using alternatives with the main zabbix package and I'd be willing to approve
this package with the alternatives changes to be implemented when the main
zabbix package implements them if:
1) there's a timetable for that.
2) doing that doesn't seem like it would be an incompatible change that would
keep it from going into EPEL.
Good:
* Package named properly
* spec file named properly
* License is approved, correctly listed in spec, and included in package
* Spec is readable
* Upstream source matches what's in the srpm
* Builds in koji (EL5 target)
* No shared libraries
* Only bundled code that I could find were javascript which are currently
allowed
* Package not relocatable
* Package owns all files and directories it creates
* builds in koji for EL-5
* Consistent use of macros
* Contains code, not content
* Nothing in doc is needed at runtime
* Not a GUI app
* All filenames valid UTF-8
* License text included
* scriptlets almost seem sane -- see below
Mustfix:
* Source0 needs to change from
http://downloads.sourceforge.net/%{name}/%{srcname}-%{version}.tar.gz
to: http://downloads.sourceforge.net/%{srcname}/%{srcname}-%{version}.tar.gz
* Some of the Requires and Provides are still for zabbix-* instead of %{name}-*
* locale files like this are not marked with %lang():
/usr/share/zabbix/include/locales/it_it.inc.php
It looks like zabbix works if some translations are left out.
(locales.php loads the proper locale file for a request and it seems to
detect when a locale file is not present and continue to operate. If that's
correct, they should be marked with the proper
language so that they can be excluded by system administrators that don't
want to install them.
* FPC says that currently it looks like the Conflicts between the various
backends should use alternatives instead of Conflicts. I don't see anything
to prevent this from working.
* I see that we're protecting the %{_sysconfdir}/zabbix/web directory. Should
%{_sysconfdir}/zabbix/web/zabbix.conf.php also have 0640 permissions?
Are these made unreadable because they contain database passwords?
* The scriptlet that's creating the users and groups should create user and
group separately for the reason documented on the official packaging
guideline page:
http://fedoraproject.org/wiki/Packaging/UsersAndGroups
* Each subpackage should Conflict with the equivalent zabbix-* package
ie: zabbix18-web should have Conflict: %{srcname}-web
The main zabbix18 Conflicts on zabbix does this implicitly but explicit is
better here to make things clear. Also, it leaves open the possibility of
creating subpackages that do not Conflict: see below
Questions:
* The various zabbix18-web packages seem to just be there to keep us from
having to download php-mysql or php-pgsql. If so, it seems that the
web-sqlite3 doesn't require anything extra. It feels like the sqlite3
backend can be folded into the main packages so that we always have the
sqlite backend available and just the others are loaded on demand.
* Conflicts: It would be great if the zabbix18-agent and zabbix-agent
packages didn't conflict as that would allow sites that want to upgrade to
run two separate server and have clients talk to both during a transition
period. This is in no way a blocker, just a nice to have feature.
rpmlint:
rpmlint has a long list of items:
* Fix spelling
zabbix18.i386: W: spelling-error %description -l en_US visualisation -
visualization, visualizer, visualize
zabbix18.i386: W: spelling-error %description -l en_US organisations -
organizations, organizational, organization
* Submit upstream:
zabbix18.i386: E: incorrect-fsf-address /usr/share/doc/zabbix18-1.8.5/COPYING
zabbix18-debuginfo.i386: E: incorrect-fsf-address
/usr/src/debug/zabbix-1.8.5/src/libs/zbxmedia/eztexting.c
(and other source files)
* Fix by just chmod 0644 the tarball
http://fedoraproject.org/wiki/Packaging/UsersAndGroups
* MUSTFIX noted above:
zabbix18.src: W: invalid-url Source0:
http://downloads.sourceforge.net/zabbix18/zabbix-1.8.5.tar.gz HTTP Error 404:
Not Found
* May be okay -- see the above question about permissions on config files
