[Bug 712971] Review Request: gnome-shell-extension-pidgin - The components necessary to integrate Pidgin with GNOME Shell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712971 Tim Lauridsen changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712971] Review Request: gnome-shell-extension-pidgin - The components necessary to integrate Pidgin with GNOME Shell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712971 --- Comment #1 from Tim Lauridsen 2011-06-15 04:45:02 EDT --- I will review this package -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712971] Review Request: gnome-shell-extension-pidgin - The components necessary to integrate Pidgin with GNOME Shell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712971 Tim Lauridsen changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712971] Review Request: gnome-shell-extension-pidgin - The components necessary to integrate Pidgin with GNOME Shell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712971 Tim Lauridsen changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|t...@rasmil.dk -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712971] Review Request: gnome-shell-extension-pidgin - The components necessary to integrate Pidgin with GNOME Shell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712971 --- Comment #3 from Tim Lauridsen 2011-06-15 08:02:28 EDT --- Issues: [!] : MUST - Rpmlint output is silent. rpmlint gnome-shell-extension-pidgin-0-0.1.git4ca78b1.fc16.i686.rpm gnome-shell-extension-pidgin.i686: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. rpmlint gnome-shell-extension-pidgin-debuginfo-0-0.1.git4ca78b1.fc16.i686.rpm gnome-shell-extension-pidgin-debuginfo.i686: E: description-line-too-long C This package provides debug information for package gnome-shell-extension-pidgin. 1 packages and 0 specfiles checked; 1 errors, 0 warnings. rpmlint gnome-shell-extension-pidgin-0-0.1.git4ca78b1.fc16.src.rpm gnome-shell-extension-pidgin.src: W: invalid-url Source0: gnome-shell-extension-pidgin-git4ca78b1.tar.bz2 1 packages and 0 specfiles checked; 0 errors, 1 warnings. [!] : MUST - Development .so files in -devel subpackage, if present. gnome-shell-extension-pidgin-0-0.1.git4ca78b1.fc16.i686.rpm : /usr/lib/purple-2/libgnomeshell.so Looks ok, this is a plugin not at development lib. [!] : MUST - Sources used to build the package matches the upstream source, as provided in the spec URL. Makefile.gnomeShellPidgin : MD5SUM this package : 52fd5b3e0fe1afe78c0119408a17d2fe MD5SUM upstream package : upstream source not found gnome-shell-extensions-pidgin-License.txt : MD5SUM this package : d3ea637572fb8f52b510a60876c6f218 MD5SUM upstream package : upstream source not found gnome-shell-extension-pidgin-git4ca78b1.tar.bz2 : MD5SUM this package : 2267235a4e7efdd73a2557b107cd9e64 MD5SUM upstream package : upstream source not found /home/tim/tmp/reviewhelper/712971/gnomeShellPidgin.c : MD5SUM this package : 09c4edcd6a1ce1c7008d942862cf7562 MD5SUM upstream package : 09c4edcd6a1ce1c7008d942862cf7562 Should be OK, this is a git checkout and the other files is license and a Makefile to get it build [!] : MUST - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Little unsure if the Source3 license file should be installed and put into %DOC ? Let me know what you think about the Source3 issue and I will approve it -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712971] Review Request: gnome-shell-extension-pidgin - The components necessary to integrate Pidgin with GNOME Shell
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=712971
--- Comment #2 from Tim Lauridsen 2011-06-15 08:00:47 EDT ---
Package Review
==
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
[x] : MUST - Package successfully compiles and builds into binary rpms on at
least one supported architecture.
[x] : MUST - Spec file lacks Packager, Vendor, PreReq tags.
[x] : MUST - Package does not contain any libtool archives (.la)
[x] : MUST - Package use %makeinstall only when make install DESTDIR=...
doesn't work.
[x] : MUST - Package is named according to the Package Naming Guidelines.
[x] : MUST - Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-] : MUST - %config files are marked noreplace or the reason is justified.
[-] : MUST - Package contains a properly installed %{name}.desktop using
desktop-file-install file if it is a GUI application.
[-] : MUST - Fully versioned dependency in subpackages, if present.
[-] : MUST - Header files in -devel subpackage, if present.
[-] : MUST - ldconfig called in %post and %postun if required.
[-] : MUST - License file installed when any subpackage combination is
installed.
[-] : MUST - The spec file handles locales properly.
[-] : MUST - No %config files under /usr.
[-] : MUST - Static libraries in -static subpackage, if present.
[!] : MUST - Rpmlint output is silent.
rpmlint gnome-shell-extension-pidgin-0-0.1.git4ca78b1.fc16.i686.rpm
gnome-shell-extension-pidgin.i686: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
rpmlint
gnome-shell-extension-pidgin-debuginfo-0-0.1.git4ca78b1.fc16.i686.rpm
gnome-shell-extension-pidgin-debuginfo.i686: E:
description-line-too-long C This package provides debug information for package
gnome-shell-extension-pidgin.
1 packages and 0 specfiles checked; 1 errors, 0 warnings.
rpmlint gnome-shell-extension-pidgin-0-0.1.git4ca78b1.fc16.src.rpm
gnome-shell-extension-pidgin.src: W: invalid-url Source0:
gnome-shell-extension-pidgin-git4ca78b1.tar.bz2
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
[!] : MUST - Development .so files in -devel subpackage, if present.
gnome-shell-extension-pidgin-0-0.1.git4ca78b1.fc16.i686.rpm :
/usr/lib/purple-2/libgnomeshell.so
[!] : MUST - Sources used to build the package matches the upstream source, as
provided in the spec URL.
Makefile.gnomeShellPidgin :
MD5SUM this package : 52fd5b3e0fe1afe78c0119408a17d2fe
MD5SUM upstream package : upstream source not found
gnome-shell-extensions-pidgin-License.txt :
MD5SUM this package : d3ea637572fb8f52b510a60876c6f218
MD5SUM upstream package : upstream source not found
gnome-shell-extension-pidgin-git4ca78b1.tar.bz2 :
MD5SUM this package : 2267235a4e7efdd73a2557b107cd9e64
MD5SUM upstream package : upstream source not found
/home/tim/tmp/reviewhelper/712971/gnomeShellPidgin.c :
MD5SUM this package : 09c4edcd6a1ce1c7008d942862cf7562
MD5SUM upstream package : 09c4edcd6a1ce1c7008d942862cf7562
[x] : MUST - Package is licensed with an open-source compatible license and
meets other legal requirements as defined in the legal section of Packaging
Guidelines.
[x] : MUST - %build honors applicable compiler flags or justifies otherwise.
[x] : MUST - All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x] : MUST - Package contains no bundled libraries.
[x] : MUST - Changelog in prescribed format.
[x] : MUST - Sources contain only permissible code or content.
[x] : MUST - Macros in Summary, %description expandable at SRPM build time.
[x] : MUST - Package requires other packages for directories it uses.
[x] : MUST - Package uses nothing in %doc for runtime.
[x] : MUST - Package is not known to require ExcludeArch.
[x] : MUST - Permissions on files are set properly.
[x] : MUST - Package does not contain duplicates in %files.
[-] : MUST - Large documentation files are in a -doc subpackage, if required.
[!] : MUST - If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is includ
[Bug 712971] Review Request: gnome-shell-extension-pidgin - The components necessary to integrate Pidgin with GNOME Shell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712971 --- Comment #4 from Tom "spot" Callaway 2011-06-15 14:35:43 EDT --- Good catch on the Source3 issue. New SRPM and SPEC: New Spec URL: http://www.auroralinux.org/people/spot/review/new/gnome-shell-extension-pidgin.spec New SRPM URL: http://www.auroralinux.org/people/spot/review/new/gnome-shell-extension-pidgin-0-0.2.git4ca78b1.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712971] Review Request: gnome-shell-extension-pidgin - The components necessary to integrate Pidgin with GNOME Shell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712971 Tim Lauridsen changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from Tim Lauridsen 2011-07-02 09:31:18 EDT --- APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712971] Review Request: gnome-shell-extension-pidgin - The components necessary to integrate Pidgin with GNOME Shell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712971 Peter Robinson changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Peter Robinson 2011-07-06 09:04:09 EDT --- To help spot along New Package GIT Request === Package Name: gnome-shell-extension-pidgin Short Description: GNOME Shell extension for Pidgin integration Owners: spot Branches: F-15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712971] Review Request: gnome-shell-extension-pidgin - The components necessary to integrate Pidgin with GNOME Shell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712971 --- Comment #7 from Jon Ciesla 2011-07-06 09:50:07 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712971] Review Request: gnome-shell-extension-pidgin - The components necessary to integrate Pidgin with GNOME Shell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712971 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712971] Review Request: gnome-shell-extension-pidgin - The components necessary to integrate Pidgin with GNOME Shell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712971 --- Comment #8 from Fedora Update System 2011-07-06 10:06:41 EDT --- gnome-shell-extension-pidgin-0-0.2.git4ca78b1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/gnome-shell-extension-pidgin-0-0.2.git4ca78b1.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712971] Review Request: gnome-shell-extension-pidgin - The components necessary to integrate Pidgin with GNOME Shell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712971 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System 2011-07-06 17:26:02 EDT --- gnome-shell-extension-pidgin-0-0.2.git4ca78b1.fc15 has been pushed to the Fedora 15 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712971] Review Request: gnome-shell-extension-pidgin - The components necessary to integrate Pidgin with GNOME Shell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712971 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||gnome-shell-extension-pidgi ||n-0-0.2.git4ca78b1.fc15 Resolution||ERRATA Last Closed||2011-07-12 18:00:46 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712971] Review Request: gnome-shell-extension-pidgin - The components necessary to integrate Pidgin with GNOME Shell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712971 --- Comment #10 from Fedora Update System 2011-07-12 18:00:40 EDT --- gnome-shell-extension-pidgin-0-0.2.git4ca78b1.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
