[Bug 713461] Review Request: tomahawk - The Social Music Player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713461 Fedora Update System changed: What|Removed |Added Fixed In Version||clementine-0.7.1-4.fc16.1 Resolution|RAWHIDE |ERRATA --- Comment #25 from Fedora Update System 2012-01-19 16:56:04 EST --- clementine-0.7.1-4.fc16.1, tomahawk-0.3.3-4.fc16, libechonest-1.2.1-1.fc16, qca-cyrus-sasl-2.0.0-0.3.beta3.fc16, jreen-1.0.1-4.fc16, iris-1.0.0-0.10.20110904svn812.fc16, qtweetlib-0.3.0-1.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713461] Review Request: tomahawk - The Social Music Player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713461 --- Comment #24 from Fedora Update System 2012-01-10 18:04:36 EST --- clementine-0.7.1-4.fc16.1,tomahawk-0.3.3-4.fc16,libechonest-1.2.1-1.fc16,qca-cyrus-sasl-2.0.0-0.3.beta3.fc16,jreen-1.0.1-4.fc16,iris-1.0.0-0.10.20110904svn812.fc16,qtweetlib-0.3.0-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/clementine-0.7.1-4.fc16.1,tomahawk-0.3.3-4.fc16,libechonest-1.2.1-1.fc16,qca-cyrus-sasl-2.0.0-0.3.beta3.fc16,jreen-1.0.1-4.fc16,iris-1.0.0-0.10.20110904svn812.fc16,qtweetlib-0.3.0-1.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713461] Review Request: tomahawk - The Social Music Player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713461 Bug 713461 depends on bug 731456, which changed state. Bug 731456 Summary: Review Request: jreen - Qt XMPP Library https://bugzilla.redhat.com/show_bug.cgi?id=731456 What|Old Value |New Value Resolution||RAWHIDE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713461] Review Request: tomahawk - The Social Music Player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713461 Rex Dieter changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2012-01-07 12:05:41 --- Comment #23 from Rex Dieter 2012-01-07 12:05:41 EST --- imported, thanks all! (waiting for jreen before doing any builds) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713461] Review Request: tomahawk - The Social Music Player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713461 --- Comment #22 from Jon Ciesla 2012-01-07 11:17:11 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713461] Review Request: tomahawk - The Social Music Player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713461 Rex Dieter changed: What|Removed |Added Flag||fedora-cvs? --- Comment #21 from Rex Dieter 2012-01-07 07:50:53 EST --- thanks! New Package SCM Request === Package Name: tomahawk Short Description: The Social Music Player Owners: rdieter Branches: f16 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713461] Review Request: tomahawk - The Social Music Player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713461 Magnus Tuominen changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #20 from Magnus Tuominen 2012-01-07 03:18:40 EST --- No others, approving. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713461] Review Request: tomahawk - The Social Music Player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713461 --- Comment #19 from Rex Dieter 2012-01-06 18:36:44 EST --- Anyway, enough rambling, I'll be sure to add the dep before doing any official builds. Any other review blockers to consider? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713461] Review Request: tomahawk - The Social Music Player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713461 --- Comment #18 from Rex Dieter 2012-01-06 18:35:55 EST --- Starting to wonder if we should just add the qca-oosl dep to qca2 (keeping in mind bootstrapping issues, of course). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713461] Review Request: tomahawk - The Social Music Player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713461 --- Comment #17 from Rex Dieter 2012-01-06 18:34:59 EST --- jreen already Requires: qca-ossl so it'll get pulled in indirectly, but adding here explicitly wouldn't be wrong either. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713461] Review Request: tomahawk - The Social Music Player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713461 --- Comment #16 from Kevin Kofler 2012-01-06 18:04:23 EST --- If it's a runtime dependency, it needs to be a Requires, not a BuildRequires. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713461] Review Request: tomahawk - The Social Music Player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713461 --- Comment #15 from Magnus Tuominen 2012-01-06 17:08:09 EST --- (In reply to comment #14) > please add qca-ossl to the BR, it is needed for some jabber accounts to > authenticate properly and is so a runtime dep for tomahawk according to the > tomahawk devs. ^nvm that, it is a BR, sorry for the noise -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713461] Review Request: tomahawk - The Social Music Player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713461 --- Comment #14 from Magnus Tuominen 2012-01-06 17:00:12 EST --- please add qca-ossl to the BR, it is needed for some jabber accounts to authenticate properly and is so a runtime dep for tomahawk according to the tomahawk devs. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713461] Review Request: tomahawk - The Social Music Player
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=713461
Magnus Tuominen changed:
What|Removed |Added
Flag||fedora-review?
--- Comment #13 from Magnus Tuominen 2012-01-06
16:44:53 EST ---
Review below:
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.[1]
rpmlint -iv tomahawk.spec
tomahawk.spec: I: checking-url
http://download.tomahawk-player.org/tomahawk-0.3.3.tar.bz2 (timeout 10 seconds)
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint -iv tomahawk-0.3.3-2*.rpm
tomahawk.x86_64: I: checking
tomahawk.x86_64: W: spelling-error %description -l en_US metadata -> meta data,
meta-data, metatarsal
The value of this tag appears to be misspelled. Please double-check.
tomahawk.x86_64: W: spelling-error %description -l en_US playlists -> play
lists, play-lists, stylists
The value of this tag appears to be misspelled. Please double-check.
tomahawk.x86_64: I: checking-url http://tomahawk-player.org/ (timeout 10
seconds)
tomahawk.x86_64: E: invalid-soname /usr/lib64/libtomahawk_siptwitter.so
libtomahawk_siptwitter.so
The soname of the library is neither of the form lib.so. or
lib-.so.
tomahawk.x86_64: E: invalid-soname /usr/lib64/libtomahawk_sipjabber.so
libtomahawk_sipjabber.so
The soname of the library is neither of the form lib.so. or
lib-.so.
tomahawk.x86_64: E: invalid-soname /usr/lib64/libtomahawk_sipzeroconf.so
libtomahawk_sipzeroconf.so
The soname of the library is neither of the form lib.so. or
lib-.so.
tomahawk.x86_64: E: invalid-soname /usr/lib64/libtomahawk_sipgoogle.so
libtomahawk_sipgoogle.so
The soname of the library is neither of the form lib.so. or
lib-.so.
tomahawk.x86_64: E: invalid-soname /usr/lib64/libtomahawk_portfwd.so
libtomahawk_portfwd.so
The soname of the library is neither of the form lib.so. or
lib-.so.
tomahawk.x86_64: E: invalid-soname /usr/lib64/libtomahawklib.so
libtomahawklib.so
The soname of the library is neither of the form lib.so. or
lib-.so.
tomahawk.x86_64: W: shared-lib-calls-exit /usr/lib64/libtomahawklib.so
exit@GLIBC_2.2.5
This library package calls exit() or _exit(), probably in a non-fork()
context. Doing so from a library is strongly discouraged - when a library
function calls exit(), it prevents the calling program from handling the
error, reporting it to the user, closing files properly, and cleaning up any
state that the program has. It is preferred for the library to return an
actual error code and let the calling program decide how to handle the
situation.
tomahawk.x86_64: W: no-manual-page-for-binary tomahawk
Each executable in standard binary directories should have a man page.
1 packages and 0 specfiles checked; 6 errors, 4 warnings.
Not so sure about this one, https://bugzilla.redhat.com/show_bug.cgi?id=235486
and https://bugzilla.redhat.com/show_bug.cgi?id=222388#c4 for reference
OK still
MUST: The package must be named according to the Package Naming Guidelines .
OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. [2] .
OK
MUST: The package must meet the Packaging Guidelines .
OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK, GPLv3
MUST: The License field in the package spec file must match the actual license.
[3]
OK
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.[4]
OK
MUST: The spec file must be written in American English. [5]
OK
MUST: The spec file for the package MUST be legible. [6]
OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
src.rpm:0ee6ff7cd7fcf2dd01db6772902efbb4
upstream: 0ee6ff7cd7fcf2dd01db6772902efbb4
OK
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. [7]
Depends on Jreen BZ #731456
OK
MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line. [8]
OK
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section
[Bug 713461] Review Request: tomahawk - The Social Music Player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713461 Bug 713461 depends on bug 731515, which changed state. Bug 731515 Summary: Review Request: qtweetlib - Qt Twitter library https://bugzilla.redhat.com/show_bug.cgi?id=731515 What|Old Value |New Value Resolution||RAWHIDE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713461] Review Request: tomahawk - The Social Music Player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713461 --- Comment #12 from Rex Dieter 2012-01-06 15:05:03 EST --- http://rdieter.fedorapeople.org/rpms/tomahawk/tomahawk.spec http://rdieter.fedorapeople.org/rpms/tomahawk/tomahawk-0.3.3-1.fc16.src.rpm %changelog * Fri Jan 06 2012 Rex Dieter 0.3.3-1 - 0.3.3 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713461] Review Request: tomahawk - The Social Music Player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713461 --- Comment #11 from Rex Dieter 2011-11-15 09:32:35 EST --- Spec URL: http://rdieter.fedorapeople.org/rpms/tomahawk/tomahawk.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/tomahawk/tomahawk-0.3.0-1.fc16.src.rpm %changelog * Mon Nov 14 2011 Rex Dieter 0.3.0-1 - 0.3.0 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713461] Review Request: tomahawk - The Social Music Player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713461 Magnus Tuominen changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|magnus.tuomi...@gmail.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713461] Review Request: tomahawk - The Social Music Player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713461 --- Comment #10 from Rex Dieter 2011-09-01 14:11:10 EDT --- Spec URL: http://rdieter.fedorapeople.org/rpms/tomahawk/tomahawk.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/tomahawk/tomahawk-0.2.3-1.fc15.src.rpm %changelog * Thu Sep 01 2011 Rex Dieter 0.2.3-1 - 0.2.3 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713461] Review Request: tomahawk - The Social Music Player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713461 Rex Dieter changed: What|Removed |Added Depends on||731515(qtweetlib) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713461] Review Request: tomahawk - The Social Music Player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713461 Rex Dieter changed: What|Removed |Added Alias||tomahawk -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713461] Review Request: tomahawk - The Social Music Player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713461 --- Comment #9 from Rex Dieter 2011-08-17 14:42:13 EDT --- f16 scratch build (using bundled jreen for now, to allow non-bootstrapped building): http://koji.fedoraproject.org/koji/taskinfo?taskID=3280479 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713461] Review Request: tomahawk - The Social Music Player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713461 --- Comment #7 from Rex Dieter 2011-08-17 13:50:15 EDT --- Spec URL: http://rdieter.fedorapeople.org/rpms/tomahawk/tomahawk.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/tomahawk/tomahawk-0.2.1-2.fc15.src.rpm %changelog * Wed Aug 17 2011 Rex Dieter 0.2.1-2 - unbundle jreen, BR: jreen-devel - BR: boost-devel qca2-devel - Requires: qca-ossl -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713461] Review Request: tomahawk - The Social Music Player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713461 Rex Dieter changed: What|Removed |Added Depends on||731456(jreen) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713461] Review Request: tomahawk - The Social Music Player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713461 --- Comment #8 from Rex Dieter 2011-08-17 13:52:21 EDT --- See bug #731456 for jreen review -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713461] Review Request: tomahawk - The Social Music Player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713461 Magnus Tuominen changed: What|Removed |Added CC||magnus.tuomi...@gmail.com --- Comment #6 from Magnus Tuominen 2011-08-17 12:09:21 EDT --- There seems to be missing some build requires: qca2-devel and maybe boost-devel too -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713461] Review Request: tomahawk - The Social Music Player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713461 --- Comment #5 from Rex Dieter 2011-08-16 15:03:04 EDT --- OK, if someone else needs it, I can package it, though it's a little annoying the upstream here has no formal releases as far as I can tell. so, will end up having to package a git snapshot. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713461] Review Request: tomahawk - The Social Music Player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713461 --- Comment #4 from Pavel Alexeev (aka Pahan-Hubbitus) 2011-08-16 14:44:41 EDT --- (In reply to comment #2) > - 20110614 snapshot > - bundle jreen/qtweetlib (for now) Is there explicit exception granted? Why? I'm prefer see it as separate package to link against in in upcoming qutIM update. I also think package jreen... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713461] Review Request: tomahawk - The Social Music Player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713461 --- Comment #3 from Rex Dieter 2011-08-16 13:14:51 EDT --- Spec URL: http://rdieter.fedorapeople.org/rpms/tomahawk/tomahawk.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/tomahawk/tomahawk-0.2.1-1.fc15.src.rpm %changelog * Tue Aug 16 2011 Rex Dieter 0.2.1-1 - 0.2.1 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713461] Review Request: tomahawk - The Social Music Player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713461 --- Comment #2 from Rex Dieter 2011-08-16 13:13:33 EDT --- Spec URL: http://rdieter.fedorapeople.org/rpms/tomahawk/tomahawk.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/tomahawk/tomahawk-0.2.1-1.fc15.src.rpm %changelog * Tue Jun 14 2011 Rex Dieter 0.1.0-3.20110614 - 20110614 snapshot - bundle jreen/qtweetlib (for now) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713461] Review Request: tomahawk - The Social Music Player
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=713461
Rex Dieter changed:
What|Removed |Added
Blocks||656997(kde-reviews)
--- Comment #1 from Rex Dieter 2011-06-15 09:33:31 EDT
---
$ rpmlint *.rpm x86_64/*.rpm
tomahawk.src: W: spelling-error %description -l en_US metadata -> meta data,
meta-data, metatarsus
tomahawk.src: W: spelling-error %description -l en_US playlists -> play lists,
play-lists, playlets
tomahawk.src:12: W: macro-in-comment %{version}
tomahawk.src:17: W: macro-in-comment %{version}
tomahawk.src:17: W: macro-in-comment %{snap}
tomahawk.src:34: W: unversioned-explicit-provides bundled(qtweetlib)
tomahawk.src: W: invalid-url Source0: tomahawk-0.1-20110614.tar.bz2
tomahawk.x86_64: W: spelling-error %description -l en_US metadata -> meta data,
meta-data, metatarsus
tomahawk.x86_64: W: spelling-error %description -l en_US playlists -> play
lists, play-lists, playlets
tomahawk.x86_64: E: invalid-soname /usr/lib64/libtomahawk_sipzeroconf.so
libtomahawk_sipzeroconf.so
tomahawk.x86_64: E: invalid-soname /usr/lib64/libtomahawk_portfwd.so
libtomahawk_portfwd.so
tomahawk.x86_64: E: invalid-soname /usr/lib64/libtomahawklib.so
libtomahawklib.so
tomahawk.x86_64: W: shared-lib-calls-exit /usr/lib64/libtomahawklib.so
exit@GLIBC_2.2.5
tomahawk.x86_64: W: no-manual-page-for-binary tomahawk
tomahawk-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/tomahawk-0.1/x86_64-redhat-linux-gnu/thirdparty/liblastfm2/src/lastfm/AbstractType
3 packages and 0 specfiles checked; 4 errors, 11 warnings.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
