[Bug 713963] Review Request: rpkg - Utility for interacting with rpm+git packaging systems

2011-06-28 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713963

Jesse Keating jkeat...@redhat.com changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||RAWHIDE
Last Closed||2011-06-28 18:43:11

--- Comment #11 from Jesse Keating jkeat...@redhat.com 2011-06-28 18:43:11 
EDT ---
Built for rawhide.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713963] Review Request: rpkg - Utility for interacting with rpm+git packaging systems

2011-06-17 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713963

leigh scott leigh123li...@googlemail.com changed:

   What|Removed |Added

 CC||leigh123li...@googlemail.co
   ||m

--- Comment #1 from leigh scott leigh123li...@googlemail.com 2011-06-17 
13:38:09 EDT ---
this needs changing from

%files -n pyrpkg
%doc COPYING README
# For noarch packages: sitelib
%{python_sitelib}/*



to


%files -n pyrpkg
%defattr(-,root,root,-)
%doc COPYING README
%{python_sitelib}/pyrpkg
%{python_sitelib}/rpkg-1.0-py?.?.egg-info


as far as I know you should remove the comment from rm -rf $RPM_BUILD_ROOT in
the install section.


make these changes and I will approve it

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713963] Review Request: rpkg - Utility for interacting with rpm+git packaging systems

2011-06-17 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713963

--- Comment #2 from leigh scott leigh123li...@googlemail.com 2011-06-17 
13:48:34 EDT ---
Another point 

BuildArch:  noarch
BuildRequires:  python-devel, python-setuptools
# We br these things for man page generation due to imports
BuildRequires:  GitPython, koji, python-pycurl
%if 0%{?rhel} == 5 || 0%{?rhel} == 4
BuildRequires:  python-hashlib
BuildRequires:  python-argparse
%endif


needs to be 


BuildArch:  noarch
BuildRequires:  python-devel, python-setuptools
# We br these things for man page generation due to imports
BuildRequires:  GitPython, koji, python-pycurl
%if 0%{?rhel} == 6 || 0%{?rhel} == 4
BuildRequires:  python-hashlib
BuildRequires:  python-argparse
%endif


to build on RHEL6

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713963] Review Request: rpkg - Utility for interacting with rpm+git packaging systems

2011-06-17 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713963

--- Comment #3 from Jesse Keating jkeat...@redhat.com 2011-06-17 14:20:34 EDT 
---
Good catches.  That's what I get for uploading specs late at night.  New stuff
uploaded:

Spec URL: http://jkeating.fedorapeople.org/review/rpkg.spec
SRPM URL: http://jkeating.fedorapeople.org/review/rpkg-1.0-2.f14.src.rpm

the defattr stuff is actually not necessary anymore.  Rpm since 4.4 has a sane
default.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713963] Review Request: rpkg - Utility for interacting with rpm+git packaging systems

2011-06-17 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713963

--- Comment #4 from leigh scott leigh123li...@googlemail.com 2011-06-17 
14:32:36 EDT ---
(In reply to comment #3)

 the defattr stuff is actually not necessary anymore.  Rpm since 4.4 has a sane
 default.

Thanks for the info.
Sadly rpmlint on el6 still sees it as a error (when I get time I will file a
bugreport against rpmlint).

[leigh@main_pc SPECS]$ rpmlint rpkg-1.0-1.el6.src.rpm
rpkg.src: I: enchant-dictionary-not-found en_US
rpkg.src:74: E: files-attr-not-set
rpkg.src:75: E: files-attr-not-set
rpkg.src:76: E: files-attr-not-set


P.S you forgot to update the spec file

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713963] Review Request: rpkg - Utility for interacting with rpm+git packaging systems

2011-06-17 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713963

--- Comment #5 from Jesse Keating jkeat...@redhat.com 2011-06-17 14:43:12 EDT 
---
Do you have a proxy or something setup?  I did put a new spec file up there,
and just checked it in my browser, it has the right content.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713963] Review Request: rpkg - Utility for interacting with rpm+git packaging systems

2011-06-17 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713963

--- Comment #6 from Jesse Keating jkeat...@redhat.com 2011-06-17 14:53:42 EDT 
---
Make that:

Spec URL: http://jkeating.fedorapeople.org/review/rpkg.spec
SRPM URL: http://jkeating.fedorapeople.org/review/rpkg-1.1-1.f14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713963] Review Request: rpkg - Utility for interacting with rpm+git packaging systems

2011-06-17 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713963

leigh scott leigh123li...@googlemail.com changed:

   What|Removed |Added

   Flag||fedora-review+

--- Comment #8 from leigh scott leigh123li...@googlemail.com 2011-06-17 
15:14:10 EDT ---
source sha1sum matches upstream
spec file conforms to packaging guide lines
licence is acceptable and correct
builds ok @ koji for F16
http://koji.fedoraproject.org/koji/taskinfo?taskID=3139353


Package approved

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713963] Review Request: rpkg - Utility for interacting with rpm+git packaging systems

2011-06-17 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713963

--- Comment #7 from Jesse Keating jkeat...@redhat.com 2011-06-17 15:13:34 EDT 
---
Ahem.

Spec URL: http://jkeating.fedorapeople.org/review/rpkg.spec
SRPM URL: http://jkeating.fedorapeople.org/review/rpkg-1.1-2.f14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713963] Review Request: rpkg - Utility for interacting with rpm+git packaging systems

2011-06-17 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713963

leigh scott leigh123li...@googlemail.com changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|leigh123li...@googlemail.co
   ||m

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713963] Review Request: rpkg - Utility for interacting with rpm+git packaging systems

2011-06-17 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713963

Jesse Keating jkeat...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #9 from Jesse Keating jkeat...@redhat.com 2011-06-17 19:20:19 EDT 
---
New Package SCM Request
===
Package Name: rpkg
Short Description: Utility for interacting with rpm+git packaging systems
Owners: jkeating
Branches: f14 f15 el6 el5
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713963] Review Request: rpkg - Utility for interacting with rpm+git packaging systems

2011-06-17 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713963

--- Comment #10 from Jon Ciesla l...@jcomserv.net 2011-06-17 20:16:18 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review