[Bug 714231] Review Request: mediawiki116-semantic - The semantic extension to mediawiki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714231 Kevin Fenzi changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|ke...@scrye.com Flag||fedora-review? --- Comment #1 from Kevin Fenzi 2011-07-02 12:05:03 EDT --- I'd be happy to review this. Look for a full review in a bit here. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714231] Review Request: mediawiki116-semantic - The semantic extension to mediawiki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714231 --- Comment #2 from Kevin Fenzi 2011-07-02 12:29:42 EDT --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. See below - License See below - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: a436f07cd3be24ae99ff33b748c6c664 SemanticMediaWiki1.5.6.tgz a436f07cd3be24ae99ff33b748c6c664 ../SOURCES/SemanticMediaWiki1.5.6.tgz OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. Looks like the skins/SMW_tooltip.js file is under a different LICENSE. (It's MIT). Also, there's only one file that says GPLv2 or later. So, I would say the License here should be: "GPL+ and GPLv2+ and MIT" 2. rpmlint says: mediawiki116-semantic.noarch: W: spelling-error %description -l en_US spinoff -> spin off, spin-off, Spinoza mediawiki116-semantic.noarch: E: incorrect-fsf-address /usr/share/doc/mediawiki116-semantic-1.5.6/COPYING mediawiki116-semantic.src: W: spelling-error %description -l en_US spinoff -> spin off, spin-off, Spinoza You might mail them about updating COPYING, others can be ignored. So, I think once the License is cleared up we are good to go. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714231] Review Request: mediawiki116-semantic - The semantic extension to mediawiki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714231 --- Comment #3 from James Laska 2011-07-06 10:46:36 EDT --- (In reply to comment #2) > Issues: > > 1. Looks like the skins/SMW_tooltip.js file is under a different LICENSE. > (It's > MIT). > Also, there's only one file that says GPLv2 or later. So, I would say the > License here > should be: "GPL+ and GPLv2+ and MIT" Great catch! I updated my local .spec and will upload corrected .spec and src.rpm files after resolving the following question. > 2. rpmlint says: > mediawiki116-semantic.noarch: W: spelling-error %description -l en_US spinoff > -> spin off, spin-off, Spinoza > mediawiki116-semantic.noarch: E: incorrect-fsf-address > /usr/share/doc/mediawiki116-semantic-1.5.6/COPYING > mediawiki116-semantic.src: W: spelling-error %description -l en_US spinoff -> > spin off, spin-off, Spinoza > > You might mail them about updating COPYING, others can be ignored. I mailed them when submitting the review request (see https://bugzilla.wikimedia.org/show_bug.cgi?id=29458). Upstream responded quickly and has already resolved the problem in svn. Would you like me to include the COPYING file from the upstream trunk branch as a patch, or continue with what is included in the release tarball? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714231] Review Request: mediawiki116-semantic - The semantic extension to mediawiki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714231 --- Comment #4 from Kevin Fenzi 2011-07-06 10:51:20 EDT --- Just use whats in the release until they update it in a new release... changing licensing stuff in a patch is not a good idea IMHO. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714231] Review Request: mediawiki116-semantic - The semantic extension to mediawiki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714231 --- Comment #5 from James Laska 2011-07-06 11:08:32 EDT --- (In reply to comment #4) > Just use whats in the release until they update it in a new release... > changing > licensing stuff in a patch is not a good idea IMHO. Sounds good. Release bumped and new .src and .spec uploaded with the changes discussed. Spec URL: http://jlaska.fedorapeople.org/rpms/mediawiki116-semantic.spec SRPM URL: http://jlaska.fedorapeople.org/rpms/mediawiki116-semantic-1.5.6-2.fc16.src.rpm fyi ... sourceforge seems down/slow at the moment so rpmlint's attempts to download the upstream tarball may fail. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714231] Review Request: mediawiki116-semantic - The semantic extension to mediawiki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714231 Kevin Fenzi changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #6 from Kevin Fenzi 2011-07-06 11:32:48 EDT --- Looks good. This package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714231] Review Request: mediawiki116-semantic - The semantic extension to mediawiki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714231 James Laska changed: What|Removed |Added Flag||fedora-cvs? --- Comment #7 from James Laska 2011-07-06 13:57:27 EDT --- Setting fedora‑cvs=? New Package SCM Request === Package Name: mediawiki116-semantic Short Description: An extension of MediaWiki that improves content organization Owners: jlaska Branches: f14 f15 el5 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714231] Review Request: mediawiki116-semantic - The semantic extension to mediawiki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714231 --- Comment #8 from Jon Ciesla 2011-07-07 06:11:15 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714231] Review Request: mediawiki116-semantic - The semantic extension to mediawiki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714231 James Laska changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Comment #9 from James Laska 2011-07-08 12:13:15 EDT --- (In reply to comment #8) > Git done (by process-git-requests). Resetting fedora‑cvs=? Looks like I will need el6 also. Thank you! New Package SCM Request === Package Name: mediawiki116-semantic Short Description: An extension of MediaWiki that improves content organization Owners: jlaska Branches: el5 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714231] Review Request: mediawiki116-semantic - The semantic extension to mediawiki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714231 Jon Ciesla changed: What|Removed |Added CC||l...@jcomserv.net Flag|fedora-cvs? | --- Comment #10 from Jon Ciesla 2011-07-08 12:39:10 EDT --- Already exists in Fedora, but orphaned. https://admin.fedoraproject.org/pkgdb/acls/name/mediawiki116-semantic -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714231] Review Request: mediawiki116-semantic - The semantic extension to mediawiki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714231 --- Comment #11 from James Laska 2011-07-08 13:09:00 EDT --- (In reply to comment #10) > Already exists in Fedora, but orphaned. > > https://admin.fedoraproject.org/pkgdb/acls/name/mediawiki116-semantic Right, it's orphaned for rawhide and Fedora ... but needed for EPEL5 and EPEL6. I have a build+update for EPEL5 already. But it seems I need some git work to allow EPEL6 builds. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714231] Review Request: mediawiki116-semantic - The semantic extension to mediawiki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714231 --- Comment #12 from Jon Ciesla 2011-07-08 13:15:50 EDT --- So request a Package Change, not New Package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714231] Review Request: mediawiki116-semantic - The semantic extension to mediawiki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714231 James Laska changed: What|Removed |Added Flag||fedora-cvs? --- Comment #13 from James Laska 2011-07-08 13:35:49 EDT --- (In reply to comment #12) > So request a Package Change, not New Package. I believe I requested a SCM change, not a package review. The package review was already completed (see comment#6). The original SCM request (see comment#7) was handled in this bugzilla by using the fedora-cvs? flag. Since I need additional SCM help, I reset the fedora-cvs? flag. New Package SCM Request === Package Name: mediawiki116-semantic Short Description: An extension of MediaWiki that improves content organization Owners: jlaska Branches: el5 el6 InitialCC: Apologies if this wasn't specific, or is not the proper venue. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714231] Review Request: mediawiki116-semantic - The semantic extension to mediawiki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714231 --- Comment #14 from James Laska 2011-07-08 13:40:20 EDT --- (In reply to comment #12) > So request a Package Change, not New Package. Oh I see now ... is it the wording used in the template I cut'n'pasted? Would it suffice to ... s/New Package SCM Request/Package SCM Change Request/ Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714231] Review Request: mediawiki116-semantic - The semantic extension to mediawiki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714231 Jon Ciesla changed: What|Removed |Added Flag|fedora-cvs? | --- Comment #15 from Jon Ciesla 2011-07-08 13:41:48 EDT --- No, it says new package. Try this: https://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure#Package_Change_Requests_for_existing_packages -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714231] Review Request: mediawiki116-semantic - The semantic extension to mediawiki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714231 --- Comment #16 from Jon Ciesla 2011-07-08 13:49:00 EDT --- The reason they need to follow the templates is that the tool we use to execute this parses them differently and do different things as a result. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714231] Review Request: mediawiki116-semantic - The semantic extension to mediawiki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714231 James Laska changed: What|Removed |Added Flag||fedora-cvs? --- Comment #17 from James Laska 2011-07-08 13:51:00 EDT --- (In reply to comment #16) > The reason they need to follow the templates is that the tool we use to > execute > this parses them differently and do different things as a result. I understand now, thank you for clarifying, and apologies for any confusion. Package Change Request == Package Name: mediawiki116-semantic New Branches: el6 Owners: jlaska -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714231] Review Request: mediawiki116-semantic - The semantic extension to mediawiki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714231 --- Comment #18 from Jon Ciesla 2011-07-08 13:59:59 EDT --- Git done (by process-git-requests). Perfect! No worries, sorry for the churn. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
