[Bug 714382] Review Request: aldabra-theme-gnome - Aldabra theme pack for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714382 --- Comment #1 from Elad Alfassa 2011-06-19 02:32:00 EDT --- *** Bug 714383 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714382] Review Request: aldabra-theme-gnome - Aldabra theme pack for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714382 Mario Blättermann changed: What|Removed |Added CC||mari...@freenet.de --- Comment #2 from Mario Blättermann 2011-06-19 15:33:33 EDT --- Where do you've got the license info from? The website at gnome-look.org says: "Anyone is welcome to rename, package, or otherwise distribute the theme (in whole or in part). Constructive feedback is greatly appreciated." Well, the bundled Adwaita part is LGPL, but is not significant in this case. In my mind, the declaration above should point to Public Domain. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714382] Review Request: aldabra-theme-gnome - Aldabra theme pack for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714382 --- Comment #3 from Mohamed El Morabity 2011-06-19 16:06:57 EDT --- (In reply to comment #2) > Where do you've got the license info from? The website at gnome-look.org says: Before packaging this theme, I wrote the author for clarifications about the license. After discussion, he set the license of its work under the LGPLv2 license and put the appropriate COPYING file in its theme archive. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714382] Review Request: aldabra-theme-gnome - Aldabra theme pack for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714382 --- Comment #4 from Mario Blättermann 2011-06-21 14:00:09 EDT --- One issue: Please add the switch -p to cp to keep timestamps. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714382] Review Request: aldabra-theme-gnome - Aldabra theme pack for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714382 --- Comment #5 from Mohamed El Morabity 2011-06-21 14:58:40 EDT --- (In reply to comment #4) > One issue: Please add the switch -p to cp to keep timestamps. According to « man cp »: -a, --archive same as -dR --preserve=all The « -a » preserves timestamps. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714382] Review Request: aldabra-theme-gnome - Aldabra theme pack for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714382 --- Comment #6 from Mario Blättermann 2011-06-21 15:07:28 EDT --- (In reply to comment #5) > (In reply to comment #4) > > One issue: Please add the switch -p to cp to keep timestamps. > According to « man cp »: > -a, --archive > same as -dR --preserve=all > The « -a » preserves timestamps. Ok, you are right. Never used this before, I always use "install -p" or "cp -p". Sorry for the blurb. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714382] Review Request: aldabra-theme-gnome - Aldabra theme pack for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714382 Mario Blättermann changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|mari...@freenet.de Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714382] Review Request: aldabra-theme-gnome - Aldabra theme pack for GNOME
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=714382
Mario Blättermann changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #7 from Mario Blättermann 2011-06-21 15:31:51
EDT ---
Referring to the rpmlint output provided by you:
The "dangling symlinks" are false positive. All of the dependencies are
present.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
LGPLv2
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ md5sum *
abe7f9234ea3842dc78b08643b1f2d51 142247-Aldabra-0.7.5.zip
abe7f9234ea3842dc78b08643b1f2d51 142247-Aldabra-0.7.5.zip.packaged
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
- Build on my own machine was succesful.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[.] MUST: The spec file MUST handle locales properly.
[.] MUST: If a package installs files below %{_datadir}/icons, the icon cache
must be updated.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates.
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Packages must not provide RPM dependency information when that
information is not global in nature, or are otherwise handled.
[.] MUST: When filtering automatically generated RPM dependency information,
the filtering system implemented by Fedora must be used.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), ...
[.] MUST: devel packages must require the base package using a fully versioned
dependency.
[.] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file
[.] MUST: .desktop files must be properly installed with desktop-file-install
in the %install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.
[+] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream...
Well, the first package v0.7.5 provided by the upstream developers came without
a license declaration. But it was updated recently without pushing the version
number. Somewhat odd though, but now we have a valid license.
[+] SHOULD: Timestamps of files should be preserved.
[+] SHOULD: The reviewer should test that the package builds in mock.
Builds without errors.
[+] SHOULD: The reviewer should test that the package functions as described.
Works perfectly.
[+] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin ...
[.] SHOULD: Your package should contain man pages for binaries/scripts.
-
PACKAGE APPROVED
-
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
__
[Bug 714382] Review Request: aldabra-theme-gnome - Aldabra theme pack for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714382 --- Comment #8 from Mohamed El Morabity 2011-06-21 15:43:49 EDT --- Thank you very much for your review :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714382] Review Request: aldabra-theme-gnome - Aldabra theme pack for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714382 Mohamed El Morabity changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714382] Review Request: aldabra-theme-gnome - Aldabra theme pack for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714382 --- Comment #9 from Mohamed El Morabity 2011-06-21 15:45:10 EDT --- New Package SCM Request === Package Name: aldabra-theme-gnome Short Description: Aldabra theme pack for GNOME Owners: melmorabity Branches: f15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714382] Review Request: aldabra-theme-gnome - Aldabra theme pack for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714382 --- Comment #10 from Jon Ciesla 2011-06-21 16:10:03 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714382] Review Request: aldabra-theme-gnome - Aldabra theme pack for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714382 --- Comment #11 from Fedora Update System 2011-06-21 16:39:15 EDT --- aldabra-theme-gnome-0.7.5-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/aldabra-theme-gnome-0.7.5-1.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714382] Review Request: aldabra-theme-gnome - Aldabra theme pack for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714382 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714382] Review Request: aldabra-theme-gnome - Aldabra theme pack for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714382 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System 2011-06-23 23:50:04 EDT --- aldabra-theme-gnome-0.7.5-1.fc15 has been pushed to the Fedora 15 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714382] Review Request: aldabra-theme-gnome - Aldabra theme pack for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714382 --- Comment #13 from Fedora Update System 2011-07-04 14:58:31 EDT --- aldabra-theme-gnome-0.7.5-1.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714382] Review Request: aldabra-theme-gnome - Aldabra theme pack for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714382 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||aldabra-theme-gnome-0.7.5-1 ||.fc15 Resolution||ERRATA Last Closed||2011-07-04 14:58:37 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
