[Bug 714491] Review Request: xmodconfig - A graphical front end for xmodmap
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714491 Volker Fröhlich volke...@gmx.at changed: What|Removed |Added Status|NEW |CLOSED Blocks||201449(FE-DEADREVIEW) Resolution||NOTABUG Last Closed||2012-02-12 11:35:30 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714491] Review Request: xmodconfig - A graphical front end for xmodmap
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714491 --- Comment #10 from Volker Fröhlich volke...@gmx.at 2011-12-13 14:34:27 EST --- Any news here? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714491] Review Request: xmodconfig - A graphical front end for xmodmap
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714491 --- Comment #9 from Volker Fröhlich volke...@gmx.at 2011-09-16 17:04:27 EDT --- Did you try to find a sponsor yet? http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714491] Review Request: xmodconfig - A graphical front end for xmodmap
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714491 --- Comment #8 from Yanchuan Nian yanch...@nfs-china.com 2011-06-29 09:02:02 EDT --- Thanks for all the help.New specfile and package http://k002.kiwi6.com/hotlink/3hul1mci0d/xmodconfig.spec http://k002.kiwi6.com/hotlink/92z1m4l2ne/xmodconfig-0.2.0-0.3.beta.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714491] Review Request: xmodconfig - A graphical front end for xmodmap
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=714491
Volker Fröhlich volke...@gmx.at changed:
What|Removed |Added
CC||volke...@gmx.at
--- Comment #6 from Volker Fröhlich volke...@gmx.at 2011-06-27 17:02:58 EDT
---
Don't install README. It only contains information on installing.
There should only be a space between BuildRequires -- no comma. It's even nicer
to put each on a separate line.
I agree with Damian on the comment. Try to rephrase that and maybe split the
sentence in two.
If you don't want to maintain this package in EPEL5 or older, you can drop the
clean section, omit the rm buildroot and remove the BuildRoot definition.
You can leave out defattr in general.
Maybe make a comment on why you rm -rf %{buildroot}%{_docdir}.
Besides these things, that are mostly not blockers, I think the file is fine.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714491] Review Request: xmodconfig - A graphical front end for xmodmap
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714491 --- Comment #7 from Yanchuan Nian yanch...@nfs-china.com 2011-06-27 21:03:30 EDT --- Sorry I'm busy these days. I will update the package as soon as possible, maybe this evening or tomorrow.Thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714491] Review Request: xmodconfig - A graphical front end for xmodmap
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714491 --- Comment #5 from Damian L Brasher fed...@interlinux.org.uk 2011-06-26 09:13:55 EDT --- Informal review comment, The description is not completely clear, ...keyboard-mapping `as you can use only one application to do anything needed to use xmodmap`, including... I am not sure what you mean between the `` do you mean; there is only one application to achieve the functionality, or; you can only use one application to achieve this functionality? (rpmlint was clean for the spec file and rpmlint SRPMS/xmodconfig-0.2.0-0.2.beta.fc15.src.rpm gave three spelling warnings) Damian Brasher -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714491] Review Request: xmodconfig - A graphical front end for xmodmap
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714491 --- Comment #4 from Yanchuan Nian yanch...@nfs-china.com 2011-06-21 08:53:28 EDT --- Hi Veeti, Thanks for your comment.New updated srpm and spec: http://k002.kiwi6.com/hotlink/ay64znuzpv/xmodconfig.spec http://k002.kiwi6.com/hotlink/br3f6seag8/xmodconfig-0.2.0-0.2.beta.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714491] Review Request: xmodconfig - A graphical front end for xmodmap
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714491 Veeti Paananen veeti.paana...@rojekti.fi changed: What|Removed |Added CC||veeti.paana...@rojekti.fi --- Comment #3 from Veeti Paananen veeti.paana...@rojekti.fi 2011-06-20 17:58:43 EDT --- Just commenting: you might want to change the SourceForge URL to follow this format: http://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714491] Review Request: xmodconfig - A graphical front end for xmodmap
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714491 Yanchuan Nian yanch...@nfs-china.com changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714491] Review Request: xmodconfig - A graphical front end for xmodmap
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714491 --- Comment #2 from Yanchuan Nian yanch...@nfs-china.com 2011-06-19 12:39:08 EDT --- Sorry for the wrong links. https://bugzilla.redhat.com/show_bug.cgi?id=711764 https://bugzilla.redhat.com/show_bug.cgi?id=708664 I will continue to make comments on other tictets. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714491] Review Request: xmodconfig - A graphical front end for xmodmap
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714491 --- Comment #1 from Yanchuan Nian yanch...@nfs-china.com 2011-06-19 12:20:21 EDT --- Here are two packages I have reviewed. https://bugzilla.redhat.com/show_bug.cgi?id=708664 https://bugzilla.redhat.com/show_bug.cgi?id=708664 Thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
