[Bug 716808] Review Request: grapefruit - Python module for color information

2011-07-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716808

--- Comment #16 from Rahul Sundaram methe...@gmail.com 2011-07-10 02:29:52 
EDT ---

I am afraid,  this package has been to marked dead and another review request
needs to be filed with a name change since this is a python module and must be
named python-grapefruit instead

http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28python_modules.29

http://fedoraproject.org/wiki/How_to_remove_a_package_at_end_of_life

My bad for noticing this before.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716808] Review Request: grapefruit - Python module for color information

2011-07-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716808

--- Comment #14 from Rahul Sundaram methe...@gmail.com 2011-07-09 04:44:27 
EDT ---

Are you going to build this package?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716808] Review Request: grapefruit - Python module for color information

2011-07-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716808

Rahul Sundaram methe...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE
Last Closed||2011-07-09 06:34:13

--- Comment #15 from Rahul Sundaram methe...@gmail.com 2011-07-09 06:34:13 
EDT ---

Apparently build has already been done.  Closing

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716808] Review Request: grapefruit - Python module for color information

2011-06-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716808

--- Comment #9 from pjp pj.pan...@yahoo.co.in 2011-06-29 02:25:16 EDT ---

  Hey, I tried the same again, but it's still not matching the md5sum check.



$ svn export -r 31 http://grapefruit.googlecode.com/svn/trunk/ grapefruit-0.1a3
$ tar -cJf grapefruit-0.1a3svn31.tar.xz grapefruit-0.1a3/
$ md5sum grapefruit-0.1a3svn31.tar.xz \
 rpmbuild/SOURCES/grapefruit-0.1a3svn31.tar.xz 
4d9c982724afc6c042304e6b35520d22  grapefruit-0.1a3svn31.tar.xz
0efef90d4a28dec4e32452bdedb0922b  rpmbuild/SOURCES/grapefruit-0.1a3svn31.tar.xz



Let's see, please try to do this simple test

===

$ echo 'hello, world'  1
$ tar -cjf 1.tar.bz2 1

$ scp 1.tar.bz2 to a different machine,
$ ssh to that machine
$ tar -xjf 1.tar.bz2
$ tar -cjf 2.tar.bz2 1

$ md5sum 1.tar.bz2 2.tar.bz2

===

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716808] Review Request: grapefruit - Python module for color information

2011-06-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716808

--- Comment #10 from pjp pj.pan...@yahoo.co.in 2011-06-29 05:00:49 EDT ---
[X] Package name - ok.
[X] Package group - ok.
[X] Build successful - ok.

[X] rpmlint SRPMS/grapefruit-0.1a3-4.20110627svn31.fc14.src.rpm
grapefruit.src: W: invalid-url Source0: grapefruit-0.1a3svn31.tar.xz
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

  - ok, for the SPEC file provides URL to a SVN repository to create tarball.

[X] rpmlint RPMS/noarch/grapefruit-0.1a3-4.20110627svn31.fc14.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

  - ok.

[X] Licence ASL 2.0 - ok.
[X] Install/Un-install - ok.

$ rpm -ivh grapefruit-0.1a3-4.20110627svn31.fc14.noarch.rpm
Preparing...### [100%]
   1:grapefruit ### [100%]
$ rpm -qa | grep -i grapefruit
grapefruit-0.1a3-4.20110627svn31.fc14.noarch
$ rpm -ev grapefruit-0.1a3-4.20110627svn31.fc14
$ rpm -qa | grep -i grapefruit
$ 


Looks good.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716808] Review Request: grapefruit - Python module for color information

2011-06-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716808

pjp pj.pan...@yahoo.co.in changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #11 from pjp pj.pan...@yahoo.co.in 2011-06-29 05:25:59 EDT ---
Approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716808] Review Request: grapefruit - Python module for color information

2011-06-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716808

--- Comment #12 from Praveen Kumar kumarpraveen.nit...@gmail.com 2011-06-29 
07:16:30 EDT ---
New Package SCM Request
===
Package Name: grapefruit
Short Description: Python module for color information
Owners: kumarpraveen
Branches: f14 f15 fl6

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716808] Review Request: grapefruit - Python module for color information

2011-06-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716808

Praveen Kumar kumarpraveen.nit...@gmail.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716808] Review Request: grapefruit - Python module for color information

2011-06-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716808

--- Comment #13 from Jon Ciesla l...@jcomserv.net 2011-06-29 08:27:05 EDT ---
Git done (by process-git-requests).

Don't request f16, it currently == devel and is automatic.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716808] Review Request: grapefruit - Python module for color information

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716808

--- Comment #4 from Praveen Kumar kumarpraveen.nit...@gmail.com 2011-06-28 
03:30:21 EDT ---
(In reply to comment #3)
 [X] rpmlint RPMS/noarch/grapefruit-0.1a3-2.20110627svn31.fc14.noarch.rpm 
 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
 
   - ok.
 
   [?] md5sum/sha1sum of the sources in the SRPM and the one accessible
   from URL - https://code.google.com/p/grapefruit/downloads/list - do 
   NOT
  
  may be because I exported latest upstream.
 
 I tried the following
 
 $ svn export -r 31 http://grapefruit.googlecode.com/svn/trunk/ 
 grapefruit-0.1a3
 $ tar -czvf grapefruit-0.1a3svn31.tar.gz grapefruit-0.1a3/
 $
 $ md5sum grapefruit-0.1a3svn31.tar.gz \
  rpmbuild/SOURCES/grapefruit-0.1a3svn31.tar.gz 
 497f9c6af0063f4c866c7883cc14f8cd  grapefruit-0.1a3svn31.tar.gz
 2692d795fc5f3ea5af032c034a56cc3d  
 rpmbuild/SOURCES/grapefruit-0.1a3svn31.tar.gz
 
 The second one is from the SRPM.
Thanks for pointing out now it's fixed.
Updated SPEC : http://kumarpraveen.fedorapeople.org/grapefruit/grapefruit.spec
SRPM :
http://kumarpraveen.fedorapeople.org/grapefruit/grapefruit-0.1a3-3.20110627svn31.fc15.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716808] Review Request: grapefruit - Python module for color information

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716808

--- Comment #5 from pjp pj.pan...@yahoo.co.in 2011-06-28 08:51:06 EDT ---
 Thanks for pointing out now it's fixed.
 Updated SPEC : http://kumarpraveen.fedorapeople.org/grapefruit/grapefruit.spec
 SRPM : 
 http://kumarpraveen.fedorapeople.org/grapefruit/grapefruit-0.1a3-3.20110627svn31.fc15.src.rpm

  Hey, I tried the same sequence again, but it again shows different md5sums
for the two tarballs.

I think the - .gz - compression changes the tarball every time you create it.

=

$ echo 'hello, world'  1
$ tar -czf 1.tar.gz 1
$ tar -czf 2.tar.gz 1
$ md5sum 1.tar.gz 2.tar.gz 
12ef3047bf3a93b99fd82e57eb7eeef9  1.tar.gz
6eec3830961866140011554f20bc48fb  2.tar.gz

=

I'll suggest change the compression to .bz2 or .xz as

.xz - $ tar -cJvf grapefruit-0.1a3svn31.tar.xz grapefruit-0.1a3/
.bz2 - $ tar -cjvf grapefruit-0.1a3svn31.tar.bz2 grapefruit-0.1a3/

Please notice the capital(-J) and small(-j) in the options above.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716808] Review Request: grapefruit - Python module for color information

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716808

--- Comment #6 from Praveen Kumar kumarpraveen.nit...@gmail.com 2011-06-28 
09:11:24 EDT ---
(In reply to comment #5)
   Hey, I tried the same sequence again, but it again shows different md5sums
 for the two tarballs.
 
 I think the - .gz - compression changes the tarball every time you create it.
 
 =
 
 $ echo 'hello, world'  1
 $ tar -czf 1.tar.gz 1
 $ tar -czf 2.tar.gz 1
 $ md5sum 1.tar.gz 2.tar.gz 
 12ef3047bf3a93b99fd82e57eb7eeef9  1.tar.gz
 6eec3830961866140011554f20bc48fb  2.tar.gz
 
 =
 
 I'll suggest change the compression to .bz2 or .xz as
 
 .xz - $ tar -cJvf grapefruit-0.1a3svn31.tar.xz grapefruit-0.1a3/
 .bz2 - $ tar -cjvf grapefruit-0.1a3svn31.tar.bz2 grapefruit-0.1a3/
 
 Please notice the capital(-J) and small(-j) in the options above.

Thanks for suggesting, made .xz tarball this time.
SPEC URL: http://kumarpraveen.fedorapeople.org/grapefruit/grapefruit.spec
SRPM URL:
http://kumarpraveen.fedorapeople.org/grapefruit/grapefruit-0.1a3-4.20110627svn31.fc15.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716808] Review Request: grapefruit - Python module for color information

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716808

Rahul Sundaram methe...@gmail.com changed:

   What|Removed |Added

 CC||methe...@gmail.com

--- Comment #7 from Rahul Sundaram methe...@gmail.com 2011-06-28 16:36:25 EDT 
---
Hate to be a stickler but using the same wording in two different changelog
isn't a good idea.  You might want to fix the last entry to note that you
changed the archive format or something else.  Don't have to bump the release. 
You are free to fix this before importing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716808] Review Request: grapefruit - Python module for color information

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716808

--- Comment #8 from Praveen Kumar kumarpraveen.nit...@gmail.com 2011-06-28 
22:44:28 EDT ---
(In reply to comment #7)
 Hate to be a stickler but using the same wording in two different changelog
 isn't a good idea.  You might want to fix the last entry to note that you
 changed the archive format or something else.  Don't have to bump the 
 release. 
 You are free to fix this before importing.

Thanks,I just forgot, now fixed. I don't think I need to update release for
that. 
SPEC URL : http://kumarpraveen.fedorapeople.org/grapefruit/grapefruit.spec
SRPM URL :
http://kumarpraveen.fedorapeople.org/grapefruit/grapefruit-0.1a3-4.20110627svn31.fc15.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716808] Review Request: grapefruit - Python module for color information

2011-06-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716808

Praveen Kumar kumarpraveen.nit...@gmail.com changed:

   What|Removed |Added

   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716808] Review Request: grapefruit - Python module for color information

2011-06-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716808

pjp pj.pan...@yahoo.co.in changed:

   What|Removed |Added

 CC||pj.pan...@yahoo.co.in
 AssignedTo|nob...@fedoraproject.org|pj.pan...@yahoo.co.in

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716808] Review Request: grapefruit - Python module for color information

2011-06-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716808

Rahul Sundaram methe...@gmail.com changed:

   What|Removed |Added

 Blocks||699336

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716808] Review Request: grapefruit - Python module for color information

2011-06-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716808

pjp pj.pan...@yahoo.co.in changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #1 from pjp pj.pan...@yahoo.co.in 2011-06-27 15:24:58 EDT ---

[X] Package name - ok.
[?] Package group not specified.
[X] Build successful - ok.
[?] $ rpmlint SRPMS/grapefruit-0.1a3-1.20110627svn31.fc14.src.rpm

grapefruit.src: W: invalid-url Source0: grapefruit-0.1a3svn31.tar.gz
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

   - Please provide valid source URL.


[X] $ rpmlint RPMS/noarch/grapefruit-0.1a3-1.20110627svn31.fc14.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

   - ok.

[X] License ASL 2.0 - ok
[?] md5sum/sha1sum of the sources in the SRPM and the one accessible
from URL - https://code.google.com/p/grapefruit/downloads/list - do NOT
match.

[X] Install/Un-install - ok.

Overall good. Nevertheless, please do fix the minor glitches like RPM groups
and source URL.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716808] Review Request: grapefruit - Python module for color information

2011-06-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716808

--- Comment #2 from Praveen Kumar kumarpraveen.nit...@gmail.com 2011-06-27 
21:50:49 EDT ---
(In reply to comment #1)
 [X] Package name - ok.
 [?] Package group not specified.

done

 [X] Build successful - ok.
 [?] $ rpmlint SRPMS/grapefruit-0.1a3-1.20110627svn31.fc14.src.rpm
 
 grapefruit.src: W: invalid-url Source0: grapefruit-0.1a3svn31.tar.gz
 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
 
- Please provide valid source URL.

I export this source using svn and I already specified how I made tarball

 [X] $ rpmlint RPMS/noarch/grapefruit-0.1a3-1.20110627svn31.fc14.noarch.rpm 
 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
 
- ok.
 
 [X] License ASL 2.0 - ok
 [?] md5sum/sha1sum of the sources in the SRPM and the one accessible
 from URL - https://code.google.com/p/grapefruit/downloads/list - do NOT
 match.

may be because I exported latest upstream.

 
 [X] Install/Un-install - ok.
 
 Overall good. Nevertheless, please do fix the minor glitches like RPM groups
 and source URL.
Updated SPEC : http://kumarpraveen.fedorapeople.org/grapefruit/grapefruit.spec
Updated SRPM :
http://kumarpraveen.fedorapeople.org/grapefruit/grapefruit-0.1a3-2.20110627svn31.fc15.src.rpm

Thanks for reviewing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716808] Review Request: grapefruit - Python module for color information

2011-06-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716808

--- Comment #3 from pjp pj.pan...@yahoo.co.in 2011-06-28 01:28:28 EDT ---
[X] rpmlint RPMS/noarch/grapefruit-0.1a3-2.20110627svn31.fc14.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

  - ok.

  [?] md5sum/sha1sum of the sources in the SRPM and the one accessible
  from URL - https://code.google.com/p/grapefruit/downloads/list - do NOT
 
 may be because I exported latest upstream.

I tried the following

$ svn export -r 31 http://grapefruit.googlecode.com/svn/trunk/ grapefruit-0.1a3
$ tar -czvf grapefruit-0.1a3svn31.tar.gz grapefruit-0.1a3/
$
$ md5sum grapefruit-0.1a3svn31.tar.gz \
 rpmbuild/SOURCES/grapefruit-0.1a3svn31.tar.gz 
497f9c6af0063f4c866c7883cc14f8cd  grapefruit-0.1a3svn31.tar.gz
2692d795fc5f3ea5af032c034a56cc3d  rpmbuild/SOURCES/grapefruit-0.1a3svn31.tar.gz

The second one is from the SRPM.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review