[Bug 717345] csync2-1.34 - cluster synchronization tool

2011-07-20 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717345

Luis Bazan lba...@bakertillypanama.com changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||NOTABUG
Last Closed||2011-07-20 16:31:45

--- Comment #9 from Luis Bazan lba...@bakertillypanama.com 2011-07-20 
16:31:45 EDT ---
Found the package is in Fedora and I become a comaintainer

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 717345] csync2-1.34 - cluster synchronization tool

2011-07-14 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717345

--- Comment #8 from Luis Bazan lba...@bakertillypanama.com 2011-07-14 
13:42:25 EDT ---
SPEC URL:http://lbazan.fedorapeople.org/csync2.spec
SRPM URL:http://lbazan.fedorapeople.org/csync2-1.34-7.fc15.src.rpm

Url: fixed

remove documents ChangeLog, NEWS, TODO and INSTALL contain nothing

add paper.pdf

change to  %{_mandir}/man1/csync2.1.*

BuildRequires change to one per line

fixed incoherent version in changelog

$ rpmlint -n csync2.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ rpmlint csync2.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ rpmlint csync2-1.34-7.fc15.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint -v csync2-1.34-7.fc15.src.rpm 
csync2.src: I: checking
csync2.src: I: checking-url http://oss.linbit.com/csync2/ (timeout 10 seconds)
csync2.src: I: checking-url http://oss.linbit.com/csync2/csync2-1.34.tar.gz
(timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint -i csync2-1.34-7.fc15.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 717345] csync2-1.34 - cluster synchronization tool

2011-07-10 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717345

--- Comment #7 from Volker Fröhlich volke...@gmx.at 2011-07-10 15:06:02 EDT 
---
Please leave one blank line between changelog entries. It's better legible.

You may need xinetd, but not as a BuildRequires. Putting that as a changelog
entry, by the way, doesn't help. Please note all relevant edits to the spec
file in the changelog. (The changelog entries also don't require a full stop,
when they are not sentences.)

The link to the Redhat tutorial in README is dead. As this file heavily
suggests to read paper.pdf, I think you should include it. The main
configuration file also refers to it. The configuration file example should
probably be changed to the reflect the situation in Fedora: /etc/apache doesn't
exist and sites are managed differently, apache2ctl doesn't exist.

You should probably put disable = yes in the xinetd configuration, for security
reasons. Also set default to off.

Please use the macro _sharedstatedir instead of %{_var}/lib. Also use the name
macro to replace csync2 in the files section, the source URL and in the
install section.

You should also try tun run rpmlint after installing the package. This yields:

csync2.x86_64: W: incoherent-version-in-changelog 1.35-6 ['1.34-6.fc15',
'1.34-6']
csync2.x86_64: E: incorrect-fsf-address /usr/share/doc/csync2-1.34/COPYING
csync2.x86_64: W: no-manual-page-for-binary csync2-compare
1 packages and 0 specfiles checked; 1 errors, 2 warnings.

Are there any SELinux issues, by the way?

Please also respond to the other questions and issues I raised in comment #2!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 717345] csync2-1.34 - cluster synchronization tool

2011-07-08 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717345

--- Comment #6 from Luis Bazan lba...@bakertillypanama.com 2011-07-08 
15:09:12 EDT ---

SRPM: http://lbazan.fedorapeople.org/csync2-1.34-6.fc15.src.rpm

SPEC: http://lbazan.fedorapeople.org/csync2.spec

1. mkdir -p $RPM_BUILD_ROOT%{_var}/lib/csync2 I remove this line is not
necessary.

2. xinetd is necessary, I can not remove.


$ rpmlint -v csync2-1.34-6.fc15.src.rpm 
csync2.src: I: checking
csync2.src: I: checking-url http://oss.linbit.com/csync2/ (timeout 10 seconds)
csync2.src: I: checking-url http://oss.linbit.com/csync2/csync2-1.34.tar.gz
(timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.


$ rpmlint -v csync2.spec 
csync2.spec: I: checking-url http://oss.linbit.com/csync2/csync2-1.34.tar.gz
(timeout 10 seconds)
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 717345] csync2-1.34 - cluster synchronization tool

2011-06-29 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717345

--- Comment #4 from Luis Bazan lba...@bakertillypanama.com 2011-06-29 
15:31:03 EDT ---
http://lbazan.fedorapeople.org/csync2.spec
http://lbazan.fedorapeople.org/csync2-1.34-5.fc15.src.rpm

$ rpmlint -v csync2-1.34-5.fc15.src.rpm
csync2.src: I: checking
csync2.src: I: checking-url http://oss.linbit.com/csync2/ (timeout 10 seconds)
csync2.src: I: checking-url http://oss.linbit.com/csync2/csync2-1.34.tar.gz
(timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.


$ rpmlint -v csync2.spec 
csync2.spec: I: checking-url http://oss.linbit.com/csync2/csync2-1.34.tar.gz
(timeout 10 seconds)
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

change to  %{_mandir}/man1/csync2.1.*

remove make clean

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 717345] csync2-1.34 - cluster synchronization tool

2011-06-29 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717345

--- Comment #5 from Volker Fröhlich volke...@gmx.at 2011-06-29 17:51:44 EDT 
---
The URL works fine for my rpmlint.

What about the other comments?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 717345] csync2-1.34 - cluster synchronization tool

2011-06-28 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717345

--- Comment #1 from Luis Bazan lba...@bakertillypanama.com 2011-06-28 
12:08:24 EDT ---
http://koji.fedoraproject.org/koji/taskinfo?taskID=3166843

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 717345] csync2-1.34 - cluster synchronization tool

2011-06-28 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717345

Volker Fröhlich volke...@gmx.at changed:

   What|Removed |Added

 CC||volke...@gmx.at

--- Comment #2 from Volker Fröhlich volke...@gmx.at 2011-06-28 17:34:52 EDT 
---
URL is supposed to be the website of the project.

Please inform upstream, that the postal address of the FSF has changed and
should be updated.

ChangeLog, NEWS, TODO and INSTALL contain nothing useful.

Better use %{_mandir}/man1/csync2.1.* instead of %{_mandir}/man1/csync2.1.gz.

You can leave out defattr.

The _sharedstatedir macro is substituted with /var/lib. Please use -p along
with install to preserve the timestamps.

Why do you run make clean?

You can also leave out the build target all, as it is the first target, thus
default. mkdir -p $RPM_BUILD_ROOT%{_var}/lib/csync2 also seems to be
dispensable.

I think, BuildRequires one per line is more legible. BR xinetd doesn't seem to
be necessary.

I guess you're aiming for EPEL. There is no sqlite2 package there.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 717345] csync2-1.34 - cluster synchronization tool

2011-06-28 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717345

Guillermo Gómez guillermo.go...@gmail.com changed:

   What|Removed |Added

 CC||guillermo.go...@gmail.com

--- Comment #3 from Guillermo Gómez guillermo.go...@gmail.com 2011-06-28 
17:37:11 EDT ---
Please remember to incluse rpmlint on your requests.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review