[Bug 717748] Review Request: UST - LTTng Userspace Tracer
https://bugzilla.redhat.com/show_bug.cgi?id=717748 --- Comment #8 from Yannick Brosseau yannick.bross...@gmail.com --- Updating this request with the latest LTTng-UST package. SPEC: http://www.dorsal.polymtl.ca/~ybrosseau/fedora/SPECS/lttng-ust.spec SRPMS: http://www.dorsal.polymtl.ca/~ybrosseau/fedora/SRPMS/lttng-ust-2.0.3-1.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717748] Review Request: UST - LTTng Userspace Tracer
https://bugzilla.redhat.com/show_bug.cgi?id=717748 Scott Tsai scottt...@gmail.com changed: What|Removed |Added CC||scottt...@gmail.com Assignee|nob...@fedoraproject.org|scottt...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717748] Review Request: UST - LTTng Userspace Tracer
https://bugzilla.redhat.com/show_bug.cgi?id=717748 Yannick Brosseau yannick.bross...@gmail.com changed: What|Removed |Added Depends On|717337 | -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717748] Review Request: UST - LTTng Userspace Tracer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717748 --- Comment #7 from Yannick Brosseau yannick.bross...@gmail.com 2012-02-27 10:07:06 EST --- A new version will be released soon. I'll post a new package then... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717748] Review Request: UST - LTTng Userspace Tracer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717748 Michael Schwendt mschwe...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|mschwe...@gmail.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717748] Review Request: UST - LTTng Userspace Tracer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717748 Michael Schwendt mschwe...@gmail.com changed: What|Removed |Added Status|ASSIGNED|NEW CC|mschwe...@gmail.com | Blocks|177841(FE-NEEDSPONSOR) | AssignedTo|mschwe...@gmail.com |nob...@fedoraproject.org -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717748] Review Request: UST - LTTng Userspace Tracer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717748 --- Comment #6 from Yannick Brosseau yannick.bross...@gmail.com 2011-10-12 11:13:11 EDT --- Here's an updated version following your comments. (With a new upstream release) SPEC: http://www.dorsal.polymtl.ca/~ybrosseau/fedora/SPECS/ust.spec SRPM: http://www.dorsal.polymtl.ca/~ybrosseau/fedora/SRPMS/ust-0.15-1.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717748] Review Request: UST - LTTng Userspace Tracer
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=717748
Michael Schwendt mschwe...@gmail.com changed:
What|Removed |Added
CC||mschwe...@gmail.com
--- Comment #5 from Michael Schwendt mschwe...@gmail.com 2011-09-18 12:11:30
EDT ---
A first brief look:
License: LGPLv2
File 'COPYING' and the source file headers explicitly mention any later
version, so:
License: LGPLv2+
BuildRoot:%{_tmppath}/%{name}-%{version}-build
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
Requires: liburcu = 0.6.2
https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires
%package -n libust-devel
...
Requires: liburcu-devel
Requires: libust = %{version}-%{release}
Requires: libustinstr-malloc = %{version}-%{release}
Requires: libustfork = %{version}-%{release}
Requires: libustconsumer = %{version}-%{release}
Requires: libustctl = %{version}-%{release}
https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package
%configure --disable-silent-rules --disable-dependency-tracking
...
make CFLAGS=$RPM_OPT_FLAGS %{?_smp_mflags}
Since %configure already passes on the CFLAGS (see 'rpm --eval %configure'), is
the extra CFLAGS definition when running Make necessary?
%clean
rm -rf %buildroot
https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean
%post -n ust
/sbin/ldconfig
/usr/sbin/install-info /usr/share/doc/ust.info.gz
%preun -n ust
/usr/sbin/install-info --delete /usr/share/doc/ust.info.gz
https://fedoraproject.org/wiki/Packaging:Guidelines#Scriptlets
%{_libdir}/libust.a
https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries
%{_datadir}/info/ust.info.gz
There also is %{_infodir} which is set by %configure, too.
%files
Sometimes you use -n to explicitly specify the full package name (e.g. %post -n
ust), here you don't. Then you also omit the -n for the base package's %post,
%preun and %postun scriptlet sections for consistency.
https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation
Files COPYING, README and TODO could be included.
It seems the test suite currently cannot be run. If it could be run during the
build process, it would make sense to create a %check section for it.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717748] Review Request: UST - LTTng Userspace Tracer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717748 --- Comment #4 from Yannick Brosseau yannick.bross...@gmail.com 2011-09-02 16:59:12 EDT --- A small update here: SPEC: http://www.dorsal.polymtl.ca/~ybrosseau/fedora/SPECS/ust.spec SRPM: http://www.dorsal.polymtl.ca/~ybrosseau/fedora/SRPMS/ust-0.14-3.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717748] Review Request: UST - LTTng Userspace Tracer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717748 --- Comment #3 from Yannick Brosseau yannick.bross...@gmail.com 2011-07-05 13:49:18 EDT --- Thanks, I'll look into it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717748] Review Request: UST - LTTng Userspace Tracer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717748 Paolo Bonzini pbonz...@redhat.com changed: What|Removed |Added CC||pbonz...@redhat.com --- Comment #2 from Paolo Bonzini pbonz...@redhat.com 2011-07-01 08:24:02 EDT --- Have you consider putting UST in the Fedora 16 features, so that it is advertised in the release notes? You still have almost two weeks. See http://fedoraproject.org/wiki/Features/Policy for more information on the process, it is lighter-weight than it seems! ;) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717748] Review Request: UST - LTTng Userspace Tracer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717748 Yannick Brosseau yannick.bross...@gmail.com changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717748] Review Request: UST - LTTng Userspace Tracer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717748 Yannick Brosseau yannick.bross...@gmail.com changed: What|Removed |Added Depends on||717337 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717748] Review Request: UST - LTTng Userspace Tracer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717748 --- Comment #1 from Yannick Brosseau yannick.bross...@gmail.com 2011-06-29 16:44:06 EDT --- I've an new SRPMS: http://www.dorsal.polymtl.ca/~ybrosseau/fedora/SRPMS/ust-0.14-2.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
