[Bug 718502] Review Request: Temperature.app - Window Maker applet which fetches local temperature information
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=718502
Mohamed El Morabity changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||pikachu.2...@gmail.com
--- Comment #4 from Mohamed El Morabity 2011-11-19
21:15:37 EST ---
The packaging looks quite good and the application seems to work.
Anyway:
- dockapps.org seems dead unfortunately; is there an alternate place where the
WM applet are now available?
- in %install, you don't have to refer to %{_builddir} to manually install
files:
install -p -m 755 %{name} %{buildroot}%{_bindir}
You can even discard all the mkdir commands, since install can create the
destination directories on the fly:
%install
install -D -p -m 755 %{name} %{buildroot}%{_bindir}/%{name}
install -D -p -m 755 %{SOURCE1} %{buildroot}%{_mandir}/man1/%{name}.1.gz
- about the man page: where does it come from? If you didn't write it, you
should specify its source.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 718502] Review Request: Temperature.app - Window Maker applet which fetches local temperature information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=718502 --- Comment #5 from Mario Blättermann 2011-11-20 17:48:08 EST --- Here's the new spec: http://mariobl.fedorapeople.org/Review/SPECS/Temperature.app.spec But there remains the problem with the dead source location. The dockapps.org registration is expired, and the domain has been moved to a domain parking system, that's why I don't expect to get it back in the nearest future. In other cases, I've used the source pool at the Debian servers, but there's no such package. Well, there's another pool for unmaintained dockapps at http://repo.or.cz/w/dockapps.git, perhaps I should use it. It also includes some bugfixes, seems to be the best way for me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 718502] Review Request: Temperature.app - Window Maker applet which fetches local temperature information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=718502 Mario Blättermann changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|pikachu.2...@gmail.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 718502] Review Request: Temperature.app - Window Maker applet which fetches local temperature information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=718502 --- Comment #6 from Mohamed El Morabity 2011-11-30 19:17:05 EST --- (In reply to comment #5) > Well, there's another pool for unmaintained dockapps at > http://repo.or.cz/w/dockapps.git, perhaps I should use it. It also includes > some bugfixes, seems to be the best way for me. That seems good to me too. That's a guarantee to have maintained sources. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 718502] Review Request: Temperature.app - Window Maker applet which fetches local temperature information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=718502 --- Comment #7 from Mario Blättermann 2011-12-14 08:57:56 EST --- The download URL is up again! It's now a subdomain of windowmaker.org. New spec: http://mariobl.fedorapeople.org/Review/SPECS/Temperature.app.spec Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3584320 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 718502] Review Request: Temperature.app - Window Maker applet which fetches local temperature information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=718502 --- Comment #8 from Mohamed El Morabity 2011-12-16 05:56:36 EST --- (In reply to comment #7) > The download URL is up again! It's now a subdomain of windowmaker.org. Great news :) About the man page: you should provide it uncompressed: when building a RPM, man pages are automatically compressed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 718502] Review Request: Temperature.app - Window Maker applet which fetches local temperature information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=718502 --- Comment #9 from Mario Blättermann 2011-12-28 15:54:53 EST --- OK, the manpage is now uncompressed. Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/Temperature.app.spec SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/Temperature.app-1.5-7.fc15.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3608803 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 718502] Review Request: Temperature.app - Window Maker applet which fetches local temperature information
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=718502
Mohamed El Morabity changed:
What|Removed |Added
Flag||fedora-review?
--- Comment #10 from Mohamed El Morabity 2011-12-29
17:50:11 EST ---
Here is the review:
+:ok, =:needs attention, -:needs fixing
MUST Items:
[-] MUST: rpmlint must be run on every package.
Temperature.app.src: I: enchant-dictionary-not-found de
Temperature.app.src: W: invalid-url URL:
http://www.dockapps.windowmaker.org/file.php/id/86
Temperature.app.src: W: invalid-url Source0:
http://www.dockapps.windowmaker.org/download.php/id/816/Temperature.app-1.5.tar.gz
Temperature.app.x86_64: W: invalid-url URL:
http://www.dockapps.windowmaker.org/file.php/id/86
Temperature.app.x86_64: W: spurious-executable-perm
/usr/share/man/man1/Temperature.app.1.gz
Temperature.app.x86_64: E: incorrect-fsf-address
/usr/share/doc/Temperature.app-1.5/COPYING
Temperature.app-debuginfo.x86_64: W: invalid-url URL:
http://www.dockapps.windowmaker.org/file.php/id/86
Temperature.app-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/Temperature.app-1.5/Xpm.cc
Temperature.app-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/Temperature.app-1.5/Xpm.h
Temperature.app-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/Temperature.app-1.5/Temperature.h
Temperature.app-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/Temperature.app-1.5/Temperature.cc
Temperature.app-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/Temperature.app-1.5/Main.cc
3 packages and 0 specfiles checked; 6 errors, 5 warnings.
>>The warnings can be safely ignored, except the one about the permissions on
>>Temperature.app; fix it as below in %install:
install -D -p -m 644 %{SOURCE1} %{buildroot}%{_mandir}/man1/%{name}.1
>>The source URL must be fixed too : it has no « www » in fact.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL.
>>MD5 sum=e8d294085ebbe062f0d7b02dfb1d1071 OK
[+] MUST: The package must successfully compile and build into binary rpms on
at least one supported architecture.
[+] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[+] MUST: All build dependencies must be listed in BuildRequires
[+] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro.
[+] MUST: Every binary RPM package which stores shared library files (not just
symlinks) in any of the dynamic linker's default paths, must call ldconfig in
%post and %postun.
[+] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A package must not contain any duplicate files in the %files listing.
[+] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example.
[+] MUST: Each package must consistently use macros, as described in the macros
section of Packaging Guidelines.
[+] MUST: The package must contain code, or permissible content. This is
described in detail in the code vs. content section of Packaging Guidelines.
[+] MUST: Large documentation files should go in a doc subpackage.
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[+] MUST: Header files must be in a -devel package.
[+] MUST: Static libraries must be in a -static package.
[+] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.
[+] MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release}
[+] MUST: Packages must NOT contai
[Bug 718502] Review Request: Temperature.app - Window Maker applet which fetches local temperature information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=718502 --- Comment #11 from Mario Blättermann 2012-01-07 20:03:15 EST --- The issues are fixed now. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3628228 Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/Temperature.app.spec SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/Temperature.app-1.5-8.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 718502] Review Request: Temperature.app - Window Maker applet which fetches local temperature information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=718502 Mohamed El Morabity changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #12 from Mohamed El Morabity 2012-01-08 07:23:31 EST --- APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 718502] Review Request: Temperature.app - Window Maker applet which fetches local temperature information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=718502 Mario Blättermann changed: What|Removed |Added Flag||fedora-cvs? --- Comment #14 from Mario Blättermann 2012-01-08 08:05:06 EST --- New Package SCM Request === Package Name: Temperature.app Short Description: Window Maker applet which fetches local temperature information Owners: mariobl Branches: f16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 718502] Review Request: Temperature.app - Window Maker applet which fetches local temperature information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=718502 --- Comment #13 from Mario Blättermann 2012-01-08 08:00:52 EST --- Many thanks for your approval! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 718502] Review Request: Temperature.app - Window Maker applet which fetches local temperature information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=718502 --- Comment #15 from Jon Ciesla 2012-01-08 17:05:30 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 718502] Review Request: Temperature.app - Window Maker applet which fetches local temperature information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=718502 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 718502] Review Request: Temperature.app - Window Maker applet which fetches local temperature information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=718502 --- Comment #16 from Fedora Update System 2012-01-13 17:10:09 EST --- Temperature.app-1.5-8.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/Temperature.app-1.5-8.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 718502] Review Request: Temperature.app - Window Maker applet which fetches local temperature information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=718502 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #17 from Fedora Update System 2012-01-15 15:05:08 EST --- Temperature.app-1.5-8.fc16 has been pushed to the Fedora 16 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 718502] Review Request: Temperature.app - Window Maker applet which fetches local temperature information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=718502 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||Temperature.app-1.5-8.fc16 Resolution||ERRATA Last Closed||2012-01-23 17:02:44 --- Comment #18 from Fedora Update System 2012-01-23 17:02:44 EST --- Temperature.app-1.5-8.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 718502] Review Request: Temperature.app - Window Maker applet which fetches local temperature information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=718502 --- Comment #1 from Mario Blättermann 2011-07-03 13:04:21 EDT --- I've just written a manpage to make rpmlint happy and added it to the package: Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/Temperature.app.spec SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/Temperature.app-1.5-2.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 718502] Review Request: Temperature.app - Window Maker applet which fetches local temperature information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=718502 --- Comment #2 from Mario Blättermann 2011-07-04 15:08:47 EDT --- The "Group" tag was missing. New files: Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/Temperature.app.spec SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/Temperature.app-1.5-3.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 718502] Review Request: Temperature.app - Window Maker applet which fetches local temperature information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=718502 --- Comment #3 from Mario Blättermann 2011-07-17 12:19:17 EDT --- I've completed and tweaked the manpage a bit: Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/Temperature.app.spec SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/Temperature.app-1.5-4.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
