[Bug 719908] Review Request: rubygem-multi_json - A gem to provide swappable JSON backends
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719908 --- Comment #11 from Vít Ondruch vondr...@redhat.com 2012-01-30 03:34:58 EST --- (In reply to comment #10) Did this make it into F16? No. I am not pushing new packages into older releases without reasons. Do you like it in F16? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719908] Review Request: rubygem-multi_json - A gem to provide swappable JSON backends
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719908 Michael Stahnke mastah...@gmail.com changed: What|Removed |Added CC||mastah...@gmail.com --- Comment #10 from Michael Stahnke mastah...@gmail.com 2012-01-30 00:18:43 EST --- Did this make it into F16? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719908] Review Request: rubygem-multi_json - A gem to provide swappable JSON backends
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719908 --- Comment #9 from Jon Ciesla l...@jcomserv.net 2011-11-14 10:46:47 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719908] Review Request: rubygem-multi_json - A gem to provide swappable JSON backends
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719908 Vít Ondruch vondr...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2011-11-14 11:21:45 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719908] Review Request: rubygem-multi_json - A gem to provide swappable JSON backends
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719908 Bohuslav Kabrda bkab...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #7 from Bohuslav Kabrda bkab...@redhat.com 2011-11-14 02:02:25 EST --- Everything looks fine now, package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719908] Review Request: rubygem-multi_json - A gem to provide swappable JSON backends
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719908 --- Comment #6 from Vít Ondruch vondr...@redhat.com 2011-11-11 09:28:44 EST --- Great, the OkJson was granted exception for bundling. So here are the latest packages, which reflect your comments: Spec URL: http://people.redhat.com/vondruch/rubygem-multi_json.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-multi_json-1.0.3-2.fcf17.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3507536 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719908] Review Request: rubygem-multi_json - A gem to provide swappable JSON backends
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719908 Bohuslav Kabrda bkab...@redhat.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|bkab...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719908] Review Request: rubygem-multi_json - A gem to provide swappable JSON backends
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719908 --- Comment #5 from Vít Ondruch vondr...@redhat.com 2011-10-24 08:17:40 EDT --- Unfortunately authors of both, multi_json and OkJson are pretty happy with the state of matter, therefore I am asking FPC for exception for OkJson as a copy lib [1]. Lets see what will follow ... [1] https://fedorahosted.org/fpc/ticket/113 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719908] Review Request: rubygem-multi_json - A gem to provide swappable JSON backends
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719908 Bohuslav Kabrda bkab...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||bkab...@redhat.com Flag||fedora-review? --- Comment #2 from Bohuslav Kabrda bkab...@redhat.com 2011-10-21 04:55:55 EDT --- I'm taking this one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719908] Review Request: rubygem-multi_json - A gem to provide swappable JSON backends
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719908
--- Comment #3 from Bohuslav Kabrda bkab...@redhat.com 2011-10-21 05:22:58
EDT ---
- I'm not sure whether marking %{geminstdir}/Rakefile as %doc is appropriate.
In my opinion, Rakefile is not documentation (although it is not needed for
runtime and should stay in the documentation subpackage).
- Okjson (the fallback json engine for multi_json) seems to be bundled from
https://github.com/kr/okjson, but the author of okjson says that his library is
meant for vendoring. I think that unbundling okjson wouldn't make much sense in
this case (therefore I don't suggest any change to your specfile, I just think
it's worth mentioning here) - what is your opinion on this matter? I'd like to
make this clear before I approve your package.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719908] Review Request: rubygem-multi_json - A gem to provide swappable JSON backends
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719908
--- Comment #4 from Vít Ondruch vondr...@redhat.com 2011-10-21 09:42:29 EDT
---
(In reply to comment #3)
- I'm not sure whether marking %{geminstdir}/Rakefile as %doc is appropriate.
In my opinion, Rakefile is not documentation (although it is not needed for
runtime and should stay in the documentation subpackage).
You are right. Fixed.
- Okjson (the fallback json engine for multi_json) seems to be bundled from
https://github.com/kr/okjson, but the author of okjson says that his library
is
meant for vendoring. I think that unbundling okjson wouldn't make much sense
in
this case (therefore I don't suggest any change to your specfile, I just think
it's worth mentioning here) - what is your opinion on this matter? I'd like to
make this clear before I approve your package.
Sorry, I did not noticed :( This is my opinion:
https://github.com/kr/okjson/issues/2
https://github.com/intridea/multi_json/issues/30
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719908] Review Request: rubygem-multi_json - A gem to provide swappable JSON backends
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719908 Vít Ondruch vondr...@redhat.com changed: What|Removed |Added Blocks|727155 | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719908] Review Request: rubygem-multi_json - A gem to provide swappable JSON backends
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719908 Vít Ondruch vondr...@redhat.com changed: What|Removed |Added Blocks||727155 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719908] Review Request: rubygem-multi_json - A gem to provide swappable JSON backends
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719908 Vít Ondruch vondr...@redhat.com changed: What|Removed |Added Blocks||738744 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719908] Review Request: rubygem-multi_json - A gem to provide swappable JSON backends
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719908 Vít Ondruch vondr...@redhat.com changed: What|Removed |Added CC||fot...@redhat.com --- Comment #1 from Vít Ondruch vondr...@redhat.com 2011-09-21 02:05:57 EDT --- *** Bug 738721 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
