[Bug 719975] Review Request: rubygem-chunky_png - Pure ruby library for read/write, chunk-level access to PNG files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719975 Mo Morsi mmo...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Mo Morsi mmo...@redhat.com 2011-07-20 09:59:53 EDT --- Looks good. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719975] Review Request: rubygem-chunky_png - Pure ruby library for read/write, chunk-level access to PNG files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719975 Chris Lalancette clala...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Chris Lalancette clala...@redhat.com 2011-07-20 10:04:40 EDT --- New Package SCM Request === Package Name: rubygem-chunky_png Short Description: Pure ruby library for read/write, chunk-level access to PNG files Owners: clalance mmorsi -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719975] Review Request: rubygem-chunky_png - Pure ruby library for read/write, chunk-level access to PNG files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719975 --- Comment #6 from Jon Ciesla l...@jcomserv.net 2011-07-20 11:46:52 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719975] Review Request: rubygem-chunky_png - Pure ruby library for read/write, chunk-level access to PNG files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719975 Chris Lalancette clala...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2011-07-20 13:36:35 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719975] Review Request: rubygem-chunky_png - Pure ruby library for read/write, chunk-level access to PNG files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719975 --- Comment #3 from Chris Lalancette clala...@redhat.com 2011-07-19 15:13:52 EDT --- (In reply to comment #2) Overall looks good. Koji build is green: http://koji.fedoraproject.org/koji/taskinfo?taskID=3199631 Specific notes: - the requires rubygem(rake) and rubygem(rspec) should be changed to buildrequires. Since the gem ships w/ a spec suite, it should be invoked in a %check section I tried doing this, but I haven't been able to successfully run the test suite. I'm not sure if the version of rspec is too old, or what, but it always fails to load some files. I've removed the two buildrequires for now, and we can revisit it later on. - need a Requires: ruby(abi) = 1.8 and a BuildRequires: ruby Fixed. - include a --ri flag in the gem install command Fixed. - rpmlint complains about the following hidden files which should be removed: .yardopts, .gitignore, .infinity_test (not sure what the last one is and/or if it's needed) Removed. - the following files should be marked as %doc in the %files section: spec/ directory, license, readme, rakefile, chunky_png.gemspec, benchmarks Fixed. - consider dropping the also have a look at oilypng... blurb from the package description Removed. New SRPM: http://people.redhat.com/clalance/rubygem-chunky_png/rubygem-chunky_png-1.2.0-2.fc14.src.rpm New SPEC: http://people.redhat.com/clalance/rubygem-chunky_png/rubygem-chunky_png.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719975] Review Request: rubygem-chunky_png - Pure ruby library for read/write, chunk-level access to PNG files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719975 Mo Morsi mmo...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||mmo...@redhat.com AssignedTo|nob...@fedoraproject.org|mmo...@redhat.com --- Comment #1 from Mo Morsi mmo...@redhat.com 2011-07-14 17:35:36 EDT --- Taking this one -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719975] Review Request: rubygem-chunky_png - Pure ruby library for read/write, chunk-level access to PNG files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719975 Mo Morsi mmo...@redhat.com changed: What|Removed |Added Flag||fedora-review? --- Comment #2 from Mo Morsi mmo...@redhat.com 2011-07-14 17:40:18 EDT --- Overall looks good. Koji build is green: http://koji.fedoraproject.org/koji/taskinfo?taskID=3199631 Specific notes: - the requires rubygem(rake) and rubygem(rspec) should be changed to buildrequires. Since the gem ships w/ a spec suite, it should be invoked in a %check section - need a Requires: ruby(abi) = 1.8 and a BuildRequires: ruby - include a --ri flag in the gem install command - rpmlint complains about the following hidden files which should be removed: .yardopts, .gitignore, .infinity_test (not sure what the last one is and/or if it's needed) - the following files should be marked as %doc in the %files section: spec/ directory, license, readme, rakefile, chunky_png.gemspec, benchmarks - consider dropping the also have a look at oilypng... blurb from the package description -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
