[Bug 720085] Review Request: perl-Net-FTP-AutoReconnect - FTP client class with automatic reconnect on failure
https://bugzilla.redhat.com/show_bug.cgi?id=720085 --- Comment #20 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720085] Review Request: perl-Net-FTP-AutoReconnect - FTP client class with automatic reconnect on failure
https://bugzilla.redhat.com/show_bug.cgi?id=720085 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720085] Review Request: perl-Net-FTP-AutoReconnect - FTP client class with automatic reconnect on failure
https://bugzilla.redhat.com/show_bug.cgi?id=720085 Bernard Johnson bjohn...@symetrix.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #19 from Bernard Johnson bjohn...@symetrix.com --- Package Change Request == Package Name: perl-Net-FTP-AutoReconnect New Branches: epel7 Owners: bjohnson InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720085] Review Request: perl-Net-FTP-AutoReconnect - FTP client class with automatic reconnect on failure
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720085 --- Comment #17 from Fedora Update System upda...@fedoraproject.org 2011-08-09 17:58:24 EDT --- perl-Net-FTP-AutoReconnect-0.3-3.el6 has been pushed to the Fedora EPEL 6 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720085] Review Request: perl-Net-FTP-AutoReconnect - FTP client class with automatic reconnect on failure
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720085 --- Comment #18 from Fedora Update System upda...@fedoraproject.org 2011-08-09 17:58:59 EDT --- perl-Net-FTP-AutoReconnect-0.3-3.el5 has been pushed to the Fedora EPEL 5 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720085] Review Request: perl-Net-FTP-AutoReconnect - FTP client class with automatic reconnect on failure
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720085 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|perl-Net-FTP-AutoReconnect- |perl-Net-FTP-AutoReconnect- |0.3-3.fc14 |0.3-3.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720085] Review Request: perl-Net-FTP-AutoReconnect - FTP client class with automatic reconnect on failure
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720085 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|perl-Net-FTP-AutoReconnect- |perl-Net-FTP-AutoReconnect- |0.3-3.el6 |0.3-3.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720085] Review Request: perl-Net-FTP-AutoReconnect - FTP client class with automatic reconnect on failure
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720085 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2011-08-01 21:54:50 EDT --- perl-Net-FTP-AutoReconnect-0.3-3.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720085] Review Request: perl-Net-FTP-AutoReconnect - FTP client class with automatic reconnect on failure
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720085 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||perl-Net-FTP-AutoReconnect- ||0.3-3.fc15 Resolution||ERRATA Last Closed||2011-08-01 21:54:55 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720085] Review Request: perl-Net-FTP-AutoReconnect - FTP client class with automatic reconnect on failure
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720085 --- Comment #16 from Fedora Update System upda...@fedoraproject.org 2011-08-01 22:10:10 EDT --- perl-Net-FTP-AutoReconnect-0.3-3.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720085] Review Request: perl-Net-FTP-AutoReconnect - FTP client class with automatic reconnect on failure
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720085 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|perl-Net-FTP-AutoReconnect- |perl-Net-FTP-AutoReconnect- |0.3-3.fc15 |0.3-3.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720085] Review Request: perl-Net-FTP-AutoReconnect - FTP client class with automatic reconnect on failure
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720085 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2011-07-22 15:28:54 EDT --- perl-Net-FTP-AutoReconnect-0.3-3.el6 has been pushed to the Fedora EPEL 6 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720085] Review Request: perl-Net-FTP-AutoReconnect - FTP client class with automatic reconnect on failure
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720085 --- Comment #9 from Jon Ciesla l...@jcomserv.net 2011-07-20 06:03:54 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720085] Review Request: perl-Net-FTP-AutoReconnect - FTP client class with automatic reconnect on failure
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720085 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720085] Review Request: perl-Net-FTP-AutoReconnect - FTP client class with automatic reconnect on failure
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720085 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2011-07-20 23:27:29 EDT --- perl-Net-FTP-AutoReconnect-0.3-3.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/perl-Net-FTP-AutoReconnect-0.3-3.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720085] Review Request: perl-Net-FTP-AutoReconnect - FTP client class with automatic reconnect on failure
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720085 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2011-07-20 23:27:38 EDT --- perl-Net-FTP-AutoReconnect-0.3-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Net-FTP-AutoReconnect-0.3-3.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720085] Review Request: perl-Net-FTP-AutoReconnect - FTP client class with automatic reconnect on failure
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720085 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2011-07-20 23:25:00 EDT --- perl-Net-FTP-AutoReconnect-0.3-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/perl-Net-FTP-AutoReconnect-0.3-3.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720085] Review Request: perl-Net-FTP-AutoReconnect - FTP client class with automatic reconnect on failure
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720085 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2011-07-20 23:26:04 EDT --- perl-Net-FTP-AutoReconnect-0.3-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/perl-Net-FTP-AutoReconnect-0.3-3.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720085] Review Request: perl-Net-FTP-AutoReconnect - FTP client class with automatic reconnect on failure
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720085 Richard Shaw hobbes1...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #7 from Richard Shaw hobbes1...@gmail.com 2011-07-19 10:05:22 EDT --- +: OK -: must be fixed =: should be fixed (at your discretion) ?: Question or clairification needed N: not applicable MUST: [+] rpmlint output: shown in comment: No warnings or errors. [+] follows package naming guidelines [+] spec file base name matches package name [+] package meets the packaging guidelines [+] package uses a Fedora approved license: GPL+ or Artistic [+] license field matches the actual license. [N] license file is included in %doc [+] spec file is in American English [+] spec file is legible [+] sources match upstream: md5sums match (0e25887641efe59b6fd2dd6964fb77a7) [+] package builds on at least one primary arch: Tested F14 [N] appropriate use of ExcludeArch [+] all build requirements in BuildRequires [N] spec file handles locales properly [N] ldconfig in %post and %postun [+] no bundled copies of system libraries [N] no relocatable packages [+] package owns all directories that it creates [+] no files listed twice in %files [+] proper permissions on files [+] consistent use of macros [+] code or permissible content [N] large documentation in -doc [+] no runtime dependencies in %doc [N] header files in -devel [N] static libraries in -static [N] .so in -devel [N] -devel requires main package [+] package contains no libtool archives [N] package contains a desktop file, uses desktop-file-install/validate [+] package does not own files/dirs owned by other packages [+] all filenames in UTF-8 SHOULD: [N] query upstream for license text [N] description and summary contains available translations [+] package builds in mock [+] package builds on all supported arches [?] package functions as described: Provides requirement for BackupPC [+] sane scriptlets [N] subpackages require the main package [N] placement of pkgconfig files [N] file dependencies versus package dependencies [N] package contains man pages for binaries/scripts *** APPROVED *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720085] Review Request: perl-Net-FTP-AutoReconnect - FTP client class with automatic reconnect on failure
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720085 Bernard Johnson bjohn...@symetrix.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #8 from Bernard Johnson bjohn...@symetrix.com 2011-07-20 00:24:57 EDT --- New Package SCM Request === Package Name: perl-Net-FTP-AutoReconnect Short Description: This is a FTP client class with automatic reconnect on failure. Owners: bjohnson Branches: f14, f15, el5, el6 InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720085] Review Request: perl-Net-FTP-AutoReconnect - FTP client class with automatic reconnect on failure
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720085 --- Comment #2 from Damian L Brasher fed...@interlinux.org.uk 2011-07-18 07:58:13 EDT --- Confirmed OK. SRPM rpmlint perl-Net-FTP-AutoReconnect-0.3-2.fc14.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. SPEC rpmlint perl-Net-FTP-AutoReconnect.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. I'm a new reviewer, so if these comments are mis-placed please bear with me. The %defattr(-,root,root,-) section could be removed. This is now default so will be ignored. (See Packaging Guidelines, section File Permissions) Not a MUST, but I was unable to find the Licence files in Net-FTP-AutoReconnect-0.3.tar.gz Regards Damian -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720085] Review Request: perl-Net-FTP-AutoReconnect - FTP client class with automatic reconnect on failure
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720085 Richard Shaw hobbes1...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||hobbes1...@gmail.com AssignedTo|nob...@fedoraproject.org|hobbes1...@gmail.com Flag||fedora-review? --- Comment #3 from Richard Shaw hobbes1...@gmail.com 2011-07-18 09:26:56 EDT --- I'll take this one. This is my first Perl module so bear with me. Standard question: Will this be built for EPEL 5? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720085] Review Request: perl-Net-FTP-AutoReconnect - FTP client class with automatic reconnect on failure
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720085 --- Comment #4 from Bernard Johnson bjohn...@symetrix.com 2011-07-18 10:26:03 EDT --- (In reply to comment #2) The %defattr(-,root,root,-) section could be removed. This is now default so will be ignored. (See Packaging Guidelines, section File Permissions) The intention is to push this package back as far as RHEL 4 which only has RPM 4.3.x. I'd like it to still build correctly on any platform version that it's pushed to. I was unable to find the Licence files in Net-FTP-AutoReconnect-0.3.tar.gz There is no individual license file. The license is in lib/Net/FTP/AutoReconnect.pm under Copyright. (In reply to comment #3) Standard question: Will this be built for EPEL 5? The intention is to push it into both RHEL 4/5. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720085] Review Request: perl-Net-FTP-AutoReconnect - FTP client class with automatic reconnect on failure
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720085 --- Comment #5 from Richard Shaw hobbes1...@gmail.com 2011-07-18 10:47:14 EDT --- Spec review results: Everything looked good but I have some questions about the %files section: %files %defattr(-,root,root,-) %doc %{perl_vendorlib}/* %{_mandir}/man3/*.3* %doc t 1. Is there something special about having two %doc sections, one of which is blank? 2. Is %{perl_vendorlib}/* appropriate? $ rpm -qlp perl-Net-FTP-AutoReconnect-0.3-2.fc14.noarch.rpm /usr/share/doc/perl-Net-FTP-AutoReconnect-0.3 /usr/share/doc/perl-Net-FTP-AutoReconnect-0.3/t /usr/share/doc/perl-Net-FTP-AutoReconnect-0.3/t/00compile.t /usr/share/man/man3/Net::FTP::AutoReconnect.3pm.gz /usr/share/perl5/Net /usr/share/perl5/Net/FTP /usr/share/perl5/Net/FTP/AutoReconnect.pm This causes the package to own the directories: /usr/share/perl/Net and /usr/share/perl/Net/FTP Is this standard practice for perl modules? Thanks, Richard -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720085] Review Request: perl-Net-FTP-AutoReconnect - FTP client class with automatic reconnect on failure
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720085 --- Comment #6 from Bernard Johnson bjohn...@symetrix.com 2011-07-18 11:34:24 EDT --- (In reply to comment #5) 1. Is there something special about having two %doc sections, one of which is blank? That's an oversight that I will fix. I quickly added a %doc on the last build but didn't notice there was an existing %doc entry. 2. Is %{perl_vendorlib}/* appropriate? Is this standard practice for perl modules? Yes, documented here: http://fedoraproject.org/wiki/Packaging:Perl#Directory_Ownership -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720085] Review Request: perl-Net-FTP-AutoReconnect - FTP client class with automatic reconnect on failure
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720085 --- Comment #1 from Bernard Johnson bjohn...@symetrix.com 2011-07-18 00:56:15 EDT --- Spec URL: http://fedorapeople.org/~bjohnson/perl-Net-FTP-AutoReconnect.spec SRPM URL: http://fedorapeople.org/~bjohnson/perl-Net-FTP-AutoReconnect-0.3-2.fc14.src.rpm * Sun Jul 17 2011 Bernard Johnson bjohn...@symetrix.com - 0.3-2 - add test cases for doc -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720085] Review Request: perl-Net-FTP-AutoReconnect - FTP client class with automatic reconnect on failure
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720085 Bernard Johnson bjohn...@symetrix.com changed: What|Removed |Added Blocks||627373 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review