[Bug 724924] Review Request: cookcc - Lexer and Parser Generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724924 Marek Goldmann mgold...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Blocks|652183(FE-JAVASIG) | Resolution||RAWHIDE Last Closed||2011-10-07 09:29:14 --- Comment #11 from Marek Goldmann mgold...@redhat.com 2011-10-07 09:29:14 EDT --- Thanks for git, closing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724924] Review Request: cookcc - Lexer and Parser Generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724924 --- Comment #10 from Jon Ciesla l...@jcomserv.net 2011-10-03 08:19:15 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724924] Review Request: cookcc - Lexer and Parser Generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724924 Marek Goldmann mgold...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Marek Goldmann mgold...@redhat.com 2011-10-02 05:17:28 EDT --- Thanks for review! New Package SCM Request === Package Name: cookcc Short Description: Lexer and Parser Generator Owners:goldmann -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724924] Review Request: cookcc - Lexer and Parser Generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724924 Tomas Radej tra...@redhat.com changed: What|Removed |Added CC||dw...@infradead.org Component|Package Review |0x --- Comment #8 from Tomas Radej tra...@redhat.com 2011-09-27 04:04:36 EDT --- Looks good now. *** APPROVED *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724924] Review Request: cookcc - Lexer and Parser Generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724924 Tomas Radej tra...@redhat.com changed: What|Removed |Added Component|0x |Package Review -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724924] Review Request: cookcc - Lexer and Parser Generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724924 Tomas Radej tra...@redhat.com changed: What|Removed |Added Flag||fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724924] Review Request: cookcc - Lexer and Parser Generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724924 --- Comment #6 from Tomas Radej tra...@redhat.com 2011-09-26 09:57:49 EDT --- Package Review == Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Rpmlint output: cookcc.noarch: W: no-documentation cookcc.src: W: invalid-url Source0: cookcc-0.3.3.tar.xz cookcc-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs - Java docs, Java-docs, Avocados 3 packages and 0 specfiles checked; 0 errors, 3 warnings. [x] Package is named according to the Package Naming Guidelines[1]. [x] Spec file name must match the base package name, in the format %{name}.spec. [x] Package meets the Packaging Guidelines[2]. [x] Package successfully compiles and builds into binary rpms. [x] Buildroot definition is not present [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines[3,4]. [x] License field in the package spec file matches the actual license. License type: BSD [!] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [!] All independent sub-packages have license of their own [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines[5]. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] File sections do not contain %defattr(-,root,root,-) unless changed with good reason [x] Permissions on files are set properly. [x] Package does NOT have a %clean section which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). (not needed anymore) [x] Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT mixing) [x] Package contains code, or permissable content. [-] Fully versioned dependency in subpackages, if present. [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. [x] Javadoc documentation files are generated and included in -javadoc subpackage [x] Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks) [x] Packages have proper BuildRequires/Requires on jpackage-utils [x] Javadoc subpackages have Require: jpackage-utils [-] Package uses %global not %define [x] If package uses tarball from VCS include comment how to re-create that tarball (svn export URL, git clone URL, ...) [x] If source tarball includes bundled jar/class files these need to be removed prior to building [x] All filenames in rpm packages must be valid UTF-8. [x] Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details) [x] If package contains pom.xml files install it (including depmaps) even when building with ant [x] pom files has correct add_maven_depmap === Maven === [x] Use %{_mavenpomdir} macro for placing pom files instead of %{_datadir}/maven2/poms [-] If package uses -Dmaven.test.skip=true explain why it was needed in a comment [-] If package uses custom depmap -Dmaven.local.depmap.file=* explain why it's needed in a comment [x] Package DOES NOT use %update_maven_depmap in %post/%postun [x] Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-utils for %update_maven_depmap macro === Other suggestions === [x] If possible use upstream build method (maven/ant/javac) [x] Avoid having BuildRequires on exact NVR unless necessary [x] Package has BuildArch: noarch (if possible) [x] Latest version is packaged. *** ISSUES *** - License file is contained in the source package, but is not in %doc in either the main or the javadoc package -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724924] Review Request: cookcc - Lexer and Parser Generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724924 --- Comment #7 from Marek Goldmann mgold...@redhat.com 2011-09-26 12:25:18 EDT --- Fixed! Spec URL: http://goldmann.fedorapeople.org/package_review/cookcc/3/cookcc.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/cookcc/3/cookcc-0.3.3-3.fc17.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724924] Review Request: cookcc - Lexer and Parser Generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724924 --- Comment #4 from Marek Goldmann mgold...@redhat.com 2011-09-22 08:02:33 EDT --- Updated. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3370073 Spec URL: http://goldmann.fedorapeople.org/package_review/cookcc/2/cookcc.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/cookcc/2/cookcc-0.3.3-2.fc17.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724924] Review Request: cookcc - Lexer and Parser Generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724924 Tomas Radej tra...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||tra...@redhat.com AssignedTo|nob...@fedoraproject.org|tra...@redhat.com --- Comment #5 from Tomas Radej tra...@redhat.com 2011-09-22 10:48:26 EDT --- Taking this one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724924] Review Request: cookcc - Lexer and Parser Generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724924 Marek Goldmann mgold...@redhat.com changed: What|Removed |Added Blocks||727171 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724924] Review Request: cookcc - Lexer and Parser Generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724924 Bug 724924 depends on bug 724914, which changed state. Bug 724914 Summary: Review Request: cookxml - Dynamic XML data binding tool https://bugzilla.redhat.com/show_bug.cgi?id=724914 What|Old Value |New Value Status|NEW |ASSIGNED Status|ASSIGNED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724924] Review Request: cookcc - Lexer and Parser Generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724924 --- Comment #3 from Alexander Kurtakov akurt...@redhat.com 2011-07-29 05:15:59 EDT --- Please add a javadoc subpackage before the review. It should be a fairly easy ant target and you might send it upstream too. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724924] Review Request: cookcc - Lexer and Parser Generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724924 Marek Goldmann mgold...@redhat.com changed: What|Removed |Added Blocks||652183(FE-JAVASIG) Depends on||724914 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724924] Review Request: cookcc - Lexer and Parser Generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724924 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added CC||akurt...@redhat.com --- Comment #1 from Alexander Kurtakov akurt...@redhat.com 2011-07-22 07:27:33 EDT --- No javadoc subpackage? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724924] Review Request: cookcc - Lexer and Parser Generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724924 --- Comment #2 from Marek Goldmann mgold...@redhat.com 2011-07-22 08:44:04 EDT --- (In reply to comment #1) No javadoc subpackage? Correct, build script doesn't build them. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review