[Bug 725837] Review Request: hexglass - Block falling puzzle game based on a hexagonal grid
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=725837 Mario Blättermann changed: What|Removed |Added Status|NEW |ASSIGNED CC||mari...@freenet.de AssignedTo|nob...@fedoraproject.org|mari...@freenet.de Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 725837] Review Request: hexglass - Block falling puzzle game based on a hexagonal grid
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=725837 --- Comment #1 from Martin Gieseking 2011-07-29 03:01:32 EDT --- Spec URL: http://mgieseki.fedorapeople.org/hexglass/hexglass.spec SRPM URL: http://mgieseki.fedorapeople.org/hexglass/hexglass-1.2.1-2.fc15.src.rpm A few minor changes: - added Group field - changed GenericName in .desktop file to "Block falling game" -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 725837] Review Request: hexglass - Block falling puzzle game based on a hexagonal grid
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=725837
Mario Blättermann changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #2 from Mario Blättermann 2011-07-29 15:24:48
EDT ---
Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3237950
$ rpmlint -i -v *
hexglass.i686: I: checking
hexglass.i686: I: checking-url http://code.google.com/p/hexglass (timeout 10
seconds)
hexglass.i686: W: no-manual-page-for-binary hexglass
Each executable in standard binary directories should have a man page.
hexglass.src: I: checking
hexglass.src: I: checking-url http://code.google.com/p/hexglass (timeout 10
seconds)
hexglass.src: I: checking-url
http://hexglass.googlecode.com/files/hexglass-1.2.1.tar.gz (timeout 10 seconds)
hexglass.src: W: invalid-url Source0:
http://hexglass.googlecode.com/files/hexglass-1.2.1.tar.gz HTTP Error 404: Not
Found
The value should be a valid, public HTTP, HTTPS, or FTP URL.
hexglass.x86_64: I: checking
hexglass.x86_64: I: checking-url http://code.google.com/p/hexglass (timeout 10
seconds)
hexglass.x86_64: W: no-manual-page-for-binary hexglass
Each executable in standard binary directories should have a man page.
hexglass-debuginfo.i686: I: checking
hexglass-debuginfo.i686: I: checking-url http://code.google.com/p/hexglass
(timeout 10 seconds)
hexglass-debuginfo.x86_64: I: checking
hexglass-debuginfo.x86_64: I: checking-url http://code.google.com/p/hexglass
(timeout 10 seconds)
hexglass.spec: I: checking-url
http://hexglass.googlecode.com/files/hexglass-1.2.1.tar.gz (timeout 10 seconds)
hexglass.spec: W: invalid-url Source0:
http://hexglass.googlecode.com/files/hexglass-1.2.1.tar.gz HTTP Error 404: Not
Found
The value should be a valid, public HTTP, HTTPS, or FTP URL.
5 packages and 1 specfiles checked; 0 errors, 4 warnings.
Googlecode fails again with the download. No problem, the source package is
available, though.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
GPLv3+
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ md5sum *
408148e6b05065d12edd7066b929465b hexglass-1.2.1.tar.gz
408148e6b05065d12edd7066b929465b hexglass-1.2.1.tar.gz.packaged
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
- See Koji build above.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[+] MUST: The spec file MUST handle locales properly.
[+] MUST: If a package installs files below %{_datadir}/icons, the icon cache
must be updated.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates.
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Packages must not provide RPM dependency information when that
information is not global in nature, or are otherwise handled.
[.] MUST: When filtering automatically generated RPM dependency information,
the filtering system implemented by Fedora must be used.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), ...
[.] MUST: devel packages must require the base package using a fully versioned
dependency.
[.] MUST: Packages must NOT contain any .la libtool archives.
[+] MUST: Packages containing GUI applications must include a %{name}.desktop
file
[+] MUST: .desktop files must be properly installed with desktop-file
[Bug 725837] Review Request: hexglass - Block falling puzzle game based on a hexagonal grid
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=725837 --- Comment #3 from Mario Blättermann 2011-07-29 15:32:26 EDT --- BTW, what about to add a German summary and description? Summary(de):Puzzlespiel mit fallenden Blöcken in einem sechseckigen Raster %description -l de HexGlass ist ein Tetris-ähnliches Puzzlespiel. Zehn verschiedene Blocktypen fallen fortwährend nach unten und müssen so angeordnet werden, dass horizontale Zeilen aus sechseckigen Elementen gebildet werden. Durch Vervollständigen einer Zeile verschwinden die Blöcke, wodurch die übrigen nach unten verschoben werden. Mit steigendem Schwierigkeitsgrad fallen die Blöcke schneller. Das Spiel ist vorbei, sobald das Spielfeld vollständig gefüllt ist und keine Blöcke mehr fallen können. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 725837] Review Request: hexglass - Block falling puzzle game based on a hexagonal grid
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=725837 Martin Gieseking changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Martin Gieseking 2011-07-29 16:08:39 EDT --- Mario, thank you for the review and the German translations. I'll add them before checking in the package. New Package SCM Request === Package Name: hexglass Short Description: Block falling puzzle game based on a hexagonal grid Owners: mgieseki Branches: f15 f16 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 725837] Review Request: hexglass - Block falling puzzle game based on a hexagonal grid
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=725837 --- Comment #5 from Jon Ciesla 2011-07-30 10:38:42 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 725837] Review Request: hexglass - Block falling puzzle game based on a hexagonal grid
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=725837 --- Comment #6 from Fedora Update System 2011-07-30 11:40:57 EDT --- hexglass-1.2.1-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/hexglass-1.2.1-3.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 725837] Review Request: hexglass - Block falling puzzle game based on a hexagonal grid
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=725837 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 725837] Review Request: hexglass - Block falling puzzle game based on a hexagonal grid
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=725837 --- Comment #7 from Fedora Update System 2011-07-30 11:41:05 EDT --- hexglass-1.2.1-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/hexglass-1.2.1-3.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 725837] Review Request: hexglass - Block falling puzzle game based on a hexagonal grid
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=725837 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System 2011-08-01 16:15:19 EDT --- hexglass-1.2.1-3.fc16 has been pushed to the Fedora 16 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 725837] Review Request: hexglass - Block falling puzzle game based on a hexagonal grid
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=725837 --- Comment #9 from Fedora Update System 2011-08-09 23:24:43 EDT --- hexglass-1.2.1-3.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 725837] Review Request: hexglass - Block falling puzzle game based on a hexagonal grid
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=725837 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||hexglass-1.2.1-3.fc15 Resolution||ERRATA Last Closed||2011-08-09 23:24:49 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 725837] Review Request: hexglass - Block falling puzzle game based on a hexagonal grid
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=725837 Fedora Update System changed: What|Removed |Added Fixed In Version|hexglass-1.2.1-3.fc15 |hexglass-1.2.1-3.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 725837] Review Request: hexglass - Block falling puzzle game based on a hexagonal grid
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=725837 --- Comment #10 from Fedora Update System 2011-08-22 11:22:32 EDT --- hexglass-1.2.1-3.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
