[Bug 728506] Review Request: rubygem-i18n_data - Country/language names and 2-letter-code pairs, in 85 languages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728506 Vít Ondruch changed: What|Removed |Added Blocks||705510 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728506] Review Request: rubygem-i18n_data - Country/language names and 2-letter-code pairs, in 85 languages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728506 Bohuslav Kabrda changed: What|Removed |Added CC||bkab...@redhat.com AssignedTo|nob...@fedoraproject.org|bkab...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728506] Review Request: rubygem-i18n_data - Country/language names and 2-letter-code pairs, in 85 languages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728506 Bohuslav Kabrda changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728506] Review Request: rubygem-i18n_data - Country/language names and 2-letter-code pairs, in 85 languages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728506 --- Comment #1 from Bohuslav Kabrda 2011-09-23 07:27:36 EDT --- * I would consider moving README.markdown into the main package, as it contains information about licensing, which I think should be present in the main package. * Moving VERSION file to doc subpackage results in error when trying to use the library (without doc subpackage installed): require 'i18n_data' Errno::ENOENT: No such file or directory - /usr/lib/ruby/gems/1.8/gems/i18n_data-0.2.7/lib/../VERSION from /usr/lib/ruby/gems/1.8/gems/i18n_data-0.2.7/lib/i18n_data.rb:2:in `read' (if you examine lib/i18_data.rb, you'll notice, that it tries to read the version from the VERSION file). So i recommend moving VERSION file into the main package. * I'd rethink including Requires: rubygem(activesupport), as the library works with file data provider by default, so the user doesn't necessarily need activesupport, which is only required by live data provider. My own recommendation is to remove this require. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728506] Review Request: rubygem-i18n_data - Country/language names and 2-letter-code pairs, in 85 languages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728506 --- Comment #2 from Vít Ondruch 2011-09-23 09:06:20 EDT --- (In reply to comment #1) > * I would consider moving README.markdown into the main package, as it > contains > information about licensing, which I think should be present in the main > package. DONE > * Moving VERSION file to doc subpackage results in error when trying to use > the > library (without doc subpackage installed): > > require 'i18n_data' > Errno::ENOENT: No such file or directory - > /usr/lib/ruby/gems/1.8/gems/i18n_data-0.2.7/lib/../VERSION > from /usr/lib/ruby/gems/1.8/gems/i18n_data-0.2.7/lib/i18n_data.rb:2:in `read' > > (if you examine lib/i18_data.rb, you'll notice, that it tries to read the > version from the VERSION file). So i recommend moving VERSION file into the > main package. Good spot! Thank you. > * I'd rethink including Requires: rubygem(activesupport), as the library works > with file data provider by default, so the user doesn't necessarily need > activesupport, which is only required by live data provider. My own > recommendation is to remove this require. You are right. Less requires is better. Spec URL: http://people.redhat.com/vondruch/rubygem-i18n_data.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-i18n_data-0.2.7-2.fcf17.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3372233 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728506] Review Request: rubygem-i18n_data - Country/language names and 2-letter-code pairs, in 85 languages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728506 --- Comment #3 from Bohuslav Kabrda 2011-09-26 01:39:38 EDT --- Everything looks fine now, this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728506] Review Request: rubygem-i18n_data - Country/language names and 2-letter-code pairs, in 85 languages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728506 Bohuslav Kabrda changed: What|Removed |Added Flag||fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728506] Review Request: rubygem-i18n_data - Country/language names and 2-letter-code pairs, in 85 languages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728506 Vít Ondruch changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Vít Ondruch 2011-09-27 13:36:33 EDT --- New Package SCM Request === Package Name: rubygem-i18n_data Short Description: Country/language names and 2-letter-code pairs, in 85 languages Owners: vondruch Branches: InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728506] Review Request: rubygem-i18n_data - Country/language names and 2-letter-code pairs, in 85 languages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728506 --- Comment #5 from Jon Ciesla 2011-09-27 14:13:08 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728506] Review Request: rubygem-i18n_data - Country/language names and 2-letter-code pairs, in 85 languages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728506 Vít Ondruch changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2011-09-30 12:54:04 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
