[Bug 728757] Review Request: gnumed - The gnumed client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728757 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2011-09-06 20:03:53 EDT --- gnumed-0.9.9-4.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728757] Review Request: gnumed - The gnumed client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728757 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||gnumed-0.9.9-4.fc15 Resolution||ERRATA Last Closed||2011-09-06 20:03:59 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728757] Review Request: gnumed - The gnumed client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728757 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2011-09-06 20:19:23 EDT --- gnumed-0.9.9-4.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728757] Review Request: gnumed - The gnumed client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728757 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|gnumed-0.9.9-4.fc15 |gnumed-0.9.9-4.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728757] Review Request: gnumed - The gnumed client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728757 --- Comment #16 from Fedora Update System upda...@fedoraproject.org 2011-09-06 23:42:39 EDT --- gnumed-0.9.9-4.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728757] Review Request: gnumed - The gnumed client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728757 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|gnumed-0.9.9-4.fc14 |gnumed-0.9.9-4.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728757] Review Request: gnumed - The gnumed client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728757 Miroslav Lichvar mlich...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #7 from Miroslav Lichvar mlich...@redhat.com 2011-08-17 09:12:46 EDT --- It looks good. Approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728757] Review Request: gnumed - The gnumed client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728757 Ankur Sinha sanjay.an...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #8 from Ankur Sinha sanjay.an...@gmail.com 2011-08-17 10:40:32 EDT --- Thank you for the review Miroslav :) New Package SCM Request === Package Name: gnumed Short Description: The gnumed client Owners: ankursinha Branches: f14 f15 f16 InitialCC: susmit mrceresa -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728757] Review Request: gnumed - The gnumed client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728757 --- Comment #9 from Jon Ciesla l...@jcomserv.net 2011-08-17 10:48:55 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728757] Review Request: gnumed - The gnumed client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728757 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2011-08-17 12:16:23 EDT --- gnumed-0.9.9-4.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/gnumed-0.9.9-4.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728757] Review Request: gnumed - The gnumed client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728757 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2011-08-17 12:16:31 EDT --- gnumed-0.9.9-4.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/gnumed-0.9.9-4.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728757] Review Request: gnumed - The gnumed client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728757 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728757] Review Request: gnumed - The gnumed client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728757 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2011-08-17 12:16:40 EDT --- gnumed-0.9.9-4.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/gnumed-0.9.9-4.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728757] Review Request: gnumed - The gnumed client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728757 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2011-08-17 16:24:52 EDT --- gnumed-0.9.9-4.fc16 has been pushed to the Fedora 16 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728757] Review Request: gnumed - The gnumed client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728757 --- Comment #5 from Ankur Sinha sanjay.an...@gmail.com 2011-08-16 13:00:41 EDT --- Hello, Completed spec with corrections: http://ankursinha.fedorapeople.org/gnumed/gnumed.spec http://ankursinha.fedorapeople.org/gnumed/gnumed-0.9.9-4.fc15.src.rpm Thanks! Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728757] Review Request: gnumed - The gnumed client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728757 --- Comment #6 from Ankur Sinha sanjay.an...@gmail.com 2011-08-16 13:13:56 EDT --- * Mon Aug 15 2011 Ankur Sinha ankursinha AT fedoraproject DOT org - 0.9.9-4 - Improve the Requires - Mailed upstream requesting update of the FSF address - Added a wrapper - Added more binaries. Refer for file list: - http://packages.debian.org/sid/all/gnumed-client/filelist -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728757] Review Request: gnumed - The gnumed client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728757 --- Comment #4 from Ankur Sinha sanjay.an...@gmail.com 2011-08-15 07:13:06 EDT --- I've mailed upstream requesting info on the extra man pages and the summary. Upstream has already clarified that the license is GPLv2, I've included the required email as reference. The included license file is GPLv2 also, so this is okay now. I've also requested them to update the FSF address, however most likely that will go into the next release. I've corrected the Requires after a quick dialogue with upstream. The python explicit requires are required IIRC, the others a tools that will be needed to use gnumed-client properly, for example xsane for scanning. I'm waiting for upstream to reply and will present the complete spec asap. Thanks Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728757] Review Request: gnumed - The gnumed client
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728757
--- Comment #3 from Miroslav Lichvar mlich...@redhat.com 2011-08-10 09:38:50
EDT ---
Review follows.
MUST items:
- rpmlint output is ok
gnumed.noarch: W: name-repeated-in-summary C gnumed
gnumed.noarch: W: spelling-error %description -l en_US sebastian - Sebastian
gnumed.noarch: W: spelling-error %description -l en_US hilbert - Hilbert,
filbert, Dilbert
gnumed.noarch: W: spelling-error %description -l en_US gmx - gm, gm x
gnumed.noarch: W: spelling-error %description -l en_US karsten - Kirsten
gnumed.noarch: E: incorrect-fsf-address
/usr/share/doc/gnumed-0.9.9/GnuPublicLicense.txt
gnumed.src: W: name-repeated-in-summary C gnumed
gnumed.src: W: spelling-error %description -l en_US wxpython - python, Python
gnumed.src: W: spelling-error %description -l en_US sebastian - Sebastian
gnumed.src: W: spelling-error %description -l en_US hilbert - Hilbert,
filbert, Dilbert
gnumed.src: W: spelling-error %description -l en_US gmx - gm, gm x
gnumed.src: W: spelling-error %description -l en_US karsten - Kirsten
3 packages and 0 specfiles checked; 1 errors, 11 warnings.
Please ask upstream to update the FSF address and consider expanding the
summary a bit. Not blockers.
- package is named according to the Package Naming Guidelines
- the spec file name matches the base package %{name}
? the package meets the Packaging Guidelines
- some Requires seem odd, are aspell, file, mx, kdepim, texlive really
needed?
- is there a point in installing man pages for binaries that are not
packaged?
? the license is GPL, but the version is unclear. The sources only mention GPL.
Please ask upstream to add a README file to clarify under which GPL version
it's licensed or include an email with their response, as stated in the Fedora
Licensing Guidelines.
- the package is licensed with a Fedora approved license and meets the
Licensing Guidelines (GPLv?)
? the License field in the package spec file may not match the actual license
(unknown yet)
- file containing the text of the license(s) for the package is included in
%doc
- the spec file is written in American English
- the spec file for the package is legible
- I'd suggest to wrap the installation of locales in a for loop
- the source used to build the package matches the upstream source, as provided
in the spec URL
ec0abfd95dcf8b5cfbca5368dcfcc99d gnumed-client.0.9.9.tgz
- the package successfully compiles and builds into binary rpms on at least one
primary architecture (x86_64)
- all build dependencies are listed in BuildRequires, except for any that are
listed in the exceptions section of the Packaging Guidelines
- the spec file handles locales properly
- the package doesn't bundle copies of system libraries
- the package owns all directories that it creates or depends on packages that
provide them
- the package does not list a file more than once in the spec file's %files
listings
- permissions on files are set properly
- the package consistently uses macros
- the package contains code, or permissable content
- all filenames in rpm packages are valid UTF-8
SHOULD items:
- the package builds in mock
- the package contains man pages for binaries/scripts
- I've not tested whether the package functions as described
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728757] Review Request: gnumed - The gnumed client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728757 Miroslav Lichvar mlich...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||mlich...@redhat.com AssignedTo|nob...@fedoraproject.org|mlich...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728757] Review Request: gnumed - The gnumed client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728757 --- Comment #2 from Ankur Sinha sanjay.an...@gmail.com 2011-08-09 15:05:40 EDT --- Hello, Updated spec/srpm: http://ankursinha.fedorapeople.org/gnumed/gnumed-0.9.9-2.fc15.src.rpm http://ankursinha.fedorapeople.org/gnumed/gnumed.spec * Tue Aug 09 2011 Ankur Sinha ankursinha AT fedoraproject DOT org - 0.9.9-2 - Remove doc dependency - Put man pages in correct sub packages - Merge subpackages, modularity isn't really required here, let docs be. - Correct license Thanks, Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728757] Review Request: gnumed - The gnumed client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728757 Ankur Sinha sanjay.an...@gmail.com changed: What|Removed |Added CC||thinklinux@gmail.com Blocks||673841(fedora-medical) Alias||gnumed -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728757] Review Request: gnumed - The gnumed client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728757 --- Comment #1 from Ankur Sinha sanjay.an...@gmail.com 2011-08-07 04:55:47 EDT --- http://koji.fedoraproject.org/koji/taskinfo?taskID=3256619 Koji scratch build. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
