[Bug 729681] Review Request: maven-reporting-exec - classes managing report plugin execution
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=729681 Tomas Radej changed: What|Removed |Added Blocks||652183(FE-JAVASIG) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 729681] Review Request: maven-reporting-exec - classes managing report plugin execution
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=729681 Alexander Kurtakov changed: What|Removed |Added Status|NEW |ASSIGNED CC||akurt...@redhat.com AssignedTo|nob...@fedoraproject.org|akurt...@redhat.com --- Comment #1 from Alexander Kurtakov 2011-08-10 15:01:50 EDT --- I would do this one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 729681] Review Request: maven-reporting-exec - classes managing report plugin execution
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=729681
--- Comment #2 from Alexander Kurtakov 2011-08-11
08:18:28 EDT ---
Package Review
==
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[!] Rpmlint output:
maven-reporting-exec.i686: E: no-binary
maven-reporting-exec-debuginfo.i686: E: empty-debuginfo-package
I see no reason for this package to not be noarch
[x] Package is named according to the Package Naming Guidelines[1].
[x] Spec file name must match the base package name, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines[2].
[x] Package successfully compiles and builds into binary rpms.
[x] Buildroot definition is not present
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging
Guidelines[3,4].
[x] License field in the package spec file matches the actual license.
License type: ASL 2.0
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] All independent sub-packages have license of their own
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
MD5SUM this package:ddc79b59dcacc6d6d8ff8951b422f1f8
MD5SUM upstream package:ddc79b59dcacc6d6d8ff8951b422f1f8
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines[5].
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] File sections do not contain %defattr(-,root,root,-) unless changed with
good reason
[x] Permissions on files are set properly.
[x] Package does NOT have a %clean section which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT). (not needed anymore)
[x] Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT
mixing)
[x] Package contains code, or permissable content.
[x] Fully versioned dependency in subpackages, if present.
[x] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
[x] Javadoc documentation files are generated and included in -javadoc
subpackage
[x] Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks)
[x] Packages have proper BuildRequires/Requires on jpackage-utils
[x] Javadoc subpackages have Require: jpackage-utils
[x] Package uses %global not %define
[-] If package uses tarball from VCS include comment how to re-create that
tarball (svn export URL, git clone URL, ...)
[-] If source tarball includes bundled jar/class files these need to be
removed prior to building
[x] All filenames in rpm packages must be valid UTF-8.
[x] Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details)
[x] If package contains pom.xml files install it (including depmaps) even when
building with ant
[x] pom files has correct add_maven_depmap
=== Maven ===
[x] Use %{_mavenpomdir} macro for placing pom files instead of
%{_datadir}/maven2/poms
[x] If package uses "-Dmaven.test.skip=true" explain why it was needed in a
comment
[x] If package uses custom depmap "-Dmaven.local.depmap.file=*" explain why
it's needed in a comment
[x] Package DOES NOT use %update_maven_depmap in %post/%postun
[x] Packages DOES NOT have Requires(post) and Requires(postun) on
jpackage-utils for %update_maven_depmap macro
=== Other suggestions ===
[x] If possible use upstream build method (maven/ant/javac)
[x] Avoid having BuildRequires on exact NVR unless necessary
[!] Package has BuildArch: noarch (if possible)
[x] Latest version is packaged.
[x] Reviewer should test that the package builds in mock.
=== Issues ===
1. Is there a reason for this package to not be noarch. I don't see any please
fix it unless you have a reason
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 729681] Review Request: maven-reporting-exec - classes managing report plugin execution
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=729681 --- Comment #3 from Tomas Radej 2011-08-11 08:33:00 EDT --- Created attachment 517788 --> https://bugzilla.redhat.com/attachment.cgi?id=517788 Fixed BuildArch -> noarch -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 729681] Review Request: maven-reporting-exec - classes managing report plugin execution
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=729681 Tomas Radej changed: What|Removed |Added Attachment #517788|Fixed BuildArch -> noarch |maven-reporting-exec-1.0.1- description||1.src.rpm Fixed BuildArch ||-> noarch --- Comment #4 from Tomas Radej 2011-08-11 08:35:32 EDT --- Comment on attachment 517788 --> https://bugzilla.redhat.com/attachment.cgi?id=517788 maven-reporting-exec-1.0.1-1.src.rpm Fixed BuildArch -> noarch Fixed Issue 1 - changed architecture to noarch -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 729681] Review Request: maven-reporting-exec - classes managing report plugin execution
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=729681 --- Comment #5 from Tomas Radej 2011-08-11 08:47:56 EDT --- Fixed issue 1 - changed architecture to noarch SRPM URL: http://tradej.fedorapeople.org/maven-reporting-exec-1.0.1-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 729681] Review Request: maven-reporting-exec - classes managing report plugin execution
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=729681 --- Comment #6 from Tomas Radej 2011-08-11 08:56:56 EDT --- Fixed issue 1 - changed architecture to noarch Spec URL: http://tradej.fedorapeople.org/maven-reporting-exec.spec SRPM URL: http://tradej.fedorapeople.org/maven-reporting-exec-1.0.1-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 729681] Review Request: maven-reporting-exec - classes managing report plugin execution
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=729681 Alexander Kurtakov changed: What|Removed |Added Attachment #517788|0 |1 is obsolete|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 729681] Review Request: maven-reporting-exec - classes managing report plugin execution
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=729681 Alexander Kurtakov changed: What|Removed |Added Flag||fedora-review+ --- Comment #7 from Alexander Kurtakov 2011-08-11 09:00:45 EDT --- Looks good now. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 729681] Review Request: maven-reporting-exec - classes managing report plugin execution
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=729681 Tomas Radej changed: What|Removed |Added Flag||fedora-cvs? --- Comment #8 from Tomas Radej 2011-08-11 09:31:27 EDT --- New Package SCM Request === Package Name: maven-reporting-exec Short Description: Classes to manage report plugin executions with Maven 3 Owners: tradej Branches: fc15 InitialCC: akurtakov -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 729681] Review Request: maven-reporting-exec - classes managing report plugin execution
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=729681 --- Comment #9 from Jon Ciesla 2011-08-11 09:42:22 EDT --- Git done (by process-git-requests). Corrected fc15 to f15, added f16. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 729681] Review Request: maven-reporting-exec - classes managing report plugin execution
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=729681 Tomas Radej changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Last Closed||2011-08-11 12:11:43 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 729681] Review Request: maven-reporting-exec - classes managing report plugin execution
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=729681 --- Comment #10 from Fedora Update System 2011-08-15 04:21:58 EDT --- maven-reporting-exec-1.0.1-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/maven-reporting-exec-1.0.1-3.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 729681] Review Request: maven-reporting-exec - classes managing report plugin execution
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=729681 Alexander Kurtakov changed: What|Removed |Added Blocks|652183(FE-JAVASIG) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 729681] Review Request: maven-reporting-exec - classes managing report plugin execution
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=729681 --- Comment #11 from Fedora Update System 2011-08-30 16:45:36 EDT --- maven-reporting-exec-1.0.1-3.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 729681] Review Request: maven-reporting-exec - classes managing report plugin execution
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=729681 Fedora Update System changed: What|Removed |Added Fixed In Version||maven-reporting-exec-1.0.1- ||3.fc16 Resolution|NEXTRELEASE |ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
