[Bug 730232] Review Request: jboss-servlet-3.0-api - Java Servlet 3.0 API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730232 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||jboss-servlet-3.0-api-1.0.1 ||-1.fc17 Resolution||ERRATA Last Closed||2012-04-11 21:53:44 --- Comment #15 from Fedora Update System 2012-04-11 21:53:44 EDT --- jboss-servlet-3.0-api-1.0.1-1.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730232] Review Request: jboss-servlet-3.0-api - Java Servlet 3.0 API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730232 --- Comment #14 from Fedora Update System 2012-03-19 06:13:26 EDT --- jboss-servlet-3.0-api-1.0.1-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/jboss-servlet-3.0-api-1.0.1-1.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730232] Review Request: jboss-servlet-3.0-api - Java Servlet 3.0 API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730232 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System 2012-03-16 15:04:46 EDT --- jboss-servlet-3.0-api-1.0.1-0.1.20120312gitd4b6f2.fc17 has been pushed to the Fedora 17 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730232] Review Request: jboss-servlet-3.0-api - Java Servlet 3.0 API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730232 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730232] Review Request: jboss-servlet-3.0-api - Java Servlet 3.0 API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730232 --- Comment #12 from Fedora Update System 2012-03-13 09:39:59 EDT --- jboss-servlet-3.0-api-1.0.1-0.1.20120312gitd4b6f2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/jboss-servlet-3.0-api-1.0.1-0.1.20120312gitd4b6f2.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730232] Review Request: jboss-servlet-3.0-api - Java Servlet 3.0 API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730232 --- Comment #11 from Jon Ciesla 2012-03-13 09:01:21 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730232] Review Request: jboss-servlet-3.0-api - Java Servlet 3.0 API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730232 Marek Goldmann changed: What|Removed |Added Blocks|652183(FE-JAVASIG) | Flag||fedora-cvs? --- Comment #10 from Marek Goldmann 2012-03-13 03:10:57 EDT --- Thanks for review! New Package SCM Request === Package Name: jboss-servlet-3.0-api Short Description: Java Servlet 3.0 API Owners:goldmann Branches: f17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730232] Review Request: jboss-servlet-3.0-api - Java Servlet 3.0 API
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=730232
Andy Grimm changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #9 from Andy Grimm 2012-03-12 13:34:05 EDT ---
Package Review
==
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Rpmlint output:
jboss-servlet-3.0-api.src: W: invalid-url URL: http://www.jboss.org HTTP Error
403: Forbidden
jboss-servlet-3.0-api.src: W: invalid-url Source0:
jboss-servlet-3.0-api-1.0.1.20120312gitd4b6f2.tar.xz
jboss-servlet-3.0-api.noarch: W: invalid-url URL: http://www.jboss.org HTTP
Error 403: Forbidden
jboss-servlet-3.0-api.noarch: E: incorrect-fsf-address
/usr/share/doc/jboss-servlet-3.0-api-1.0.1/LICENSE
jboss-servlet-3.0-api-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs
-> Java docs, Java-docs, Avocados
jboss-servlet-3.0-api-javadoc.noarch: W: invalid-url URL: http://www.jboss.org
HTTP Error 403: Forbidden
jboss-servlet-3.0-api-javadoc.noarch: E: incorrect-fsf-address
/usr/share/doc/jboss-servlet-3.0-api-javadoc-1.0.1/LICENSE
3 packages and 0 specfiles checked; 2 errors, 5 warnings.
The FSF address should be fixed by upstream. All other warnings are normal.
[x] Package is named according to the Package Naming Guidelines[1].
[x] Spec file name must match the base package name, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines[2].
[x] Package successfully compiles and builds into binary rpms.
[x] Buildroot definition is not present
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging
Guidelines[3,4].
[x] License field in the package spec file matches the actual license.
License type: CDDL
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] All independent sub-packages have license of their own
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
Git source (unpacked tarball matches)
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines[5].
[x] Package must own all directories that it creates or must require other
packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] File sections do not contain %defattr(-,root,root,-) unless changed with
good reason
[x] Permissions on files are set properly.
[x] Package does NOT have a %clean section which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT). (not needed anymore)
[x] Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT
mixing)
[x] Package contains code, or permissable content.
[-] Fully versioned dependency in subpackages, if present.
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
[x] Javadoc documentation files are generated and included in -javadoc
subpackage
[x] Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks)
[x] Packages have proper BuildRequires/Requires on jpackage-utils
[x] Javadoc subpackages have Require: jpackage-utils
[x] Package uses %global not %define
[x] If package uses tarball from VCS include comment how to re-create that
tarball (svn export URL, git clone URL, ...)
[-] If source tarball includes bundled jar/class files these need to be
removed prior to building
[x] All filenames in rpm packages must be valid UTF-8.
[x] Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details)
[x] If package contains pom.xml files install it (including depmaps) even when
building with ant
[x] pom files has correct add_maven_depmap
=== Maven ===
[x] Use %{_mavenpomdir} macro for placing pom files instead of
%{_datadir}/maven2/poms
[-] If package uses "-Dmaven.test.skip=true" explain why it was needed in a
comment
[-] If package uses custom depmap "-Dmaven.local.depmap.file=*" explain why
it's needed in a comment
[x] Package DOES NOT use %update_maven_depmap in %post/%postun
[x] Packages DOES NOT have Requires(post) and Requires(postun) on
jpackage-utils for %update_maven_depmap macro
=== Other suggestions ===
[x] If possible use upstream build method (maven/ant/javac)
[x] Avoid having BuildRequires on exact NVR unless necessary
[x] Package has BuildArch: noarch (if possible)
[x] Latest version is packaged.
[x] Reviewer should test that the package builds in mock.
Tested on: http://koji.fedoraproject.org/koji/taskinfo?
[Bug 730232] Review Request: jboss-servlet-3.0-api - Java Servlet 3.0 API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730232 Andy Grimm changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #7 from Andy Grimm 2012-03-12 12:20:09 EDT --- Fixes look good. *** APPROVED *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730232] Review Request: jboss-servlet-3.0-api - Java Servlet 3.0 API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730232 Andy Grimm changed: What|Removed |Added Flag|fedora-review+ |fedora-review? --- Comment #8 from Andy Grimm 2012-03-12 12:20:42 EDT --- OOPS! Wrong review! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730232] Review Request: jboss-servlet-3.0-api - Java Servlet 3.0 API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730232 Andy Grimm changed: What|Removed |Added Status|NEW |ASSIGNED CC||agr...@gmail.com AssignedTo|nob...@fedoraproject.org|agr...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730232] Review Request: jboss-servlet-3.0-api - Java Servlet 3.0 API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730232 --- Comment #6 from Marek Goldmann 2012-03-12 05:49:06 EDT --- Spec URL: http://goldmann.fedorapeople.org/package_review/jboss-servlet-3.0-api/2/jboss-servlet-3.0-api.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/jboss-servlet-3.0-api/2/jboss-servlet-3.0-api-1.0.1-0.1.20120312gitd4b6f2.fc17.src.rpm Updated files after license cleanup + spec file cleanup itself. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730232] Review Request: jboss-servlet-3.0-api - Java Servlet 3.0 API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730232 Richard Fontana changed: What|Removed |Added Blocks|182235(FE-Legal)| --- Comment #5 from Richard Fontana 2012-03-09 00:47:23 EST --- (In reply to comment #1) > According to the license headers this is not LGPLv2+ but every file is mix of > GPLv2(only) and ASL 2.0 which are known to be incompatible. I would wait for > legal but according to me this cannot go into Fedora. While this is certainly odd, I see various ways of conceptually resolving any supposed license incompatibility. The easiest may be to assume that all code is CDDL. It is significant that the nominal copyright holder clearly saw no problem with incorporating Apache License 2.0 code into files licensed under CDDL/GPLv2. Lifting FE-Legal. Marek, the only real issue here is that the License tag should be changed from "LGPLv2+" to "CDDL". -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730232] Review Request: jboss-servlet-3.0-api - Java Servlet 3.0 API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730232 Ricardo Arguello changed: What|Removed |Added Blocks||801651 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730232] Review Request: jboss-servlet-3.0-api - Java Servlet 3.0 API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730232 Ivan Afonichev changed: What|Removed |Added CC||ivan.afonic...@gmail.com --- Comment #4 from Ivan Afonichev 2011-11-08 11:57:44 EST --- Is there something that is absent on tomcat-servlet-3.0-api https://admin.fedoraproject.org/pkgdb/acls/name/tomcat ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730232] Review Request: jboss-servlet-3.0-api - Java Servlet 3.0 API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730232 --- Comment #3 from Marek Goldmann 2011-11-04 08:17:45 EDT --- Ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730232] Review Request: jboss-servlet-3.0-api - Java Servlet 3.0 API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730232 Bug 730232 depends on bug 730226, which changed state. Bug 730226 Summary: Review Request: jboss-specs-parent - JBoss Specification API Parent POM https://bugzilla.redhat.com/show_bug.cgi?id=730226 What|Old Value |New Value Resolution||RAWHIDE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730232] Review Request: jboss-servlet-3.0-api - Java Servlet 3.0 API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730232 --- Comment #2 from Marek Goldmann 2011-10-02 03:49:23 EDT --- Rich, Could you please clarify licensing for this package? Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730232] Review Request: jboss-servlet-3.0-api - Java Servlet 3.0 API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730232 Alexander Kurtakov changed: What|Removed |Added CC||akurt...@redhat.com --- Comment #1 from Alexander Kurtakov 2011-09-27 03:32:28 EDT --- Why does jboss needs to copy every api in its own repo? According to the license headers this is not LGPLv2+ but every file is mix of GPLv2(only) and ASL 2.0 which are known to be incompatible. I would wait for legal but according to me this cannot go into Fedora. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730232] Review Request: jboss-servlet-3.0-api - Java Servlet 3.0 API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730232 Richard Fontana changed: What|Removed |Added CC||rfont...@redhat.com Blocks||182235(FE-Legal) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730232] Review Request: jboss-servlet-3.0-api - Java Servlet 3.0 API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730232 Marek Goldmann changed: What|Removed |Added Blocks||730233 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730232] Review Request: jboss-servlet-3.0-api - Java Servlet 3.0 API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730232 Marek Goldmann changed: What|Removed |Added Blocks||652183(FE-JAVASIG) Depends on||730226 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
