[Bug 731972] Review Request: cab - Haskell Cabal package maintenance program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731972 Jens Petersen changed: What|Removed |Added CC||fedora-haskell-list@redhat. ||com Depends on||648093(ghc-attoparsec-enum) Blocks||634048(Haskell-pkg-reviews) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 731972] Review Request: cab - Haskell Cabal package maintenance program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731972 Lakshmi Narasimhan changed: What|Removed |Added Status|NEW |ASSIGNED CC||lakshminaras2...@gmail.com AssignedTo|nob...@fedoraproject.org|lakshminaras2...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 731972] Review Request: cab - Haskell Cabal package maintenance program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731972 Jens Petersen changed: What|Removed |Added Depends on||740283(ghc-attoparsec-enum) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 731972] Review Request: cab - Haskell Cabal package maintenance program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731972 Bug 731972 depends on bug 648093, which changed state. Bug 648093 Summary: Review Request: ghc-attoparsec-enumerator - Convert an Attoparsec parser into an iteratee https://bugzilla.redhat.com/show_bug.cgi?id=648093 What|Old Value |New Value Resolution||DUPLICATE Status|NEW |CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 731972] Review Request: cab - Haskell Cabal package maintenance program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731972 --- Comment #1 from Jens Petersen 2011-09-21 10:37:31 EDT --- Update to latest release: Spec: http://petersen.fedorapeople.org/reviews/cab/cab.spec Srpm: http://petersen.fedorapeople.org/reviews/cab/cab-0.1.6-1.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 731972] Review Request: cab - Haskell Cabal package maintenance program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731972 Jens Petersen changed: What|Removed |Added Alias||cab -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 731972] Review Request: cab - Haskell Cabal package maintenance program
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731972
Lakshmi Narasimhan changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #2 from Lakshmi Narasimhan 2011-09-27
15:04:24 EDT ---
[+]MUST: rpmlint must be run on every package. The output should be posted in
the review.
rpmlint -i *.rpm ../cab.spec
cab.i686: W: spelling-error %description -l en_US ghc -> chg
The value of this tag appears to be misspelled. Please double-check.
cab.i686: W: no-manual-page-for-binary cab
Each executable in standard binary directories should have a man page.
cab.src: W: spelling-error %description -l en_US ghc -> chg
The value of this tag appears to be misspelled. Please double-check.
2 packages and 1 specfiles checked; 0 errors, 3 warnings.
[+]MUST: The package must be named according to the Package Naming Guidelines.
[+]MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec
[+]MUST: The package must meet the Packaging Guidelines.
Naming-Yes
Version-release - Matches
No prebuilt external bits - OK
Spec legibity - OK
Package template - OK
Arch support - OK
Libexecdir - OK
rpmlint - yes
changelogs - OK
Source url tag - OK, validated.
Build Requires list - OK
Summary and description - OK
API documentation - OK, none available
[+]MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
License is BSD
[+]MUST: The License field in the package spec file must match the actual
license.
[+]MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
LICENSE file is included
[+]MUST: The spec file must be written in American English.
[+]MUST: The spec file for the package MUST be legible.
[+]MUST: The sources used to build the package must match the upstream
source,as provided in the spec URL. Reviewers should use md5sum for this task.
md5sum cab-0.1.6-1.fc15.src/cab-0.1.6.tar.gz
2b595a8413e31a7d34cfd10761caa636 cab-0.1.6-1.fc15.src/cab-0.1.6.tar.gz
md5sum cab-0.1.6.tar.gz
2b595a8413e31a7d34cfd10761caa636 cab-0.1.6.tar.gz
[+]MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
Built on i686.
[+]MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[+]MUST: All build dependencies must be listed in BuildRequires.
[NA]MUST: The spec file MUST handle locales properly using the %find_lang macro
[NA]MUST: Packages stores shared library files must call ldconfig in %post and
%postun.
[+]MUST: Packages must NOT bundle copies of system libraries.
Checked with rpmquery --list
[NA]MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review.
[+]MUST: A package must own all directories that it creates.
Checked with rpmquery --whatprovides
[+]MUST: A Fedora package must not list a file more than once in the spec
file's %files listings.
[+]MUST: Permissions on files must be set properly.
Checked with ls -lR
[+]MUST: Each package must consistently use macros.
[+]MUST: The package must contain code, or permissible content.
[NA]MUST: Large documentation files must go in a -doc subpackage.
[+]MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[NA]MUST: Header files must be in a -devel package.
[NA]MUST: Static libraries must be in a -static package.
[NA]MUST: If a package contains library files with a suffix
(e.g.libfoo.so.1.1), then library files that end in .so (without suffix) must
go in a -devel package.
[NA]MUST: devel packages must require the base package using a fully versioned
dependency: Requires: {name} = %{version}-%{release}
[NA]MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
[NA]MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section
[+]MUST: Packages must not own files or directories already owned by other
packages.
[+]MUST: All filenames in rpm packages must be valid UTF-8.
Should items
[+]SHOULD: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[+]SHOULD: The reviewer should test that the package functions as described.
Installed the package. No issues.Ran the program "cab". No issues.
[+]SHOULD: If scriptlets are used,
[Bug 731972] Review Request: cab - Haskell Cabal package maintenance program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731972 --- Comment #3 from Lakshmi Narasimhan 2011-09-28 01:18:13 EDT --- Mail sent to upstream requesting them to include license header in each of the source files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 731972] Review Request: cab - Haskell Cabal package maintenance program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731972 Jens Petersen changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Jens Petersen 2011-09-28 02:02:25 EDT --- Thanks for the review. New Package SCM Request === Package Name: cab Short Description: Haskell cabal wrapper program Owners: petersen Branches: f14 f15 f16 InitialCC: haskell-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 731972] Review Request: cab - Haskell Cabal package maintenance program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731972 --- Comment #5 from Jon Ciesla 2011-09-28 07:59:07 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 731972] Review Request: cab - Haskell Cabal package maintenance program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731972 --- Comment #6 from Jens Petersen 2011-09-29 06:56:05 EDT --- Built for rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=3388004 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 731972] Review Request: cab - Haskell Cabal package maintenance program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731972 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 731972] Review Request: cab - Haskell Cabal package maintenance program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731972 --- Comment #7 from Fedora Update System 2011-09-30 03:16:43 EDT --- cab-0.1.6-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/cab-0.1.6-1.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 731972] Review Request: cab - Haskell Cabal package maintenance program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731972 --- Comment #9 from Fedora Update System 2011-09-30 03:17:11 EDT --- cab-0.1.6-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/cab-0.1.6-1.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 731972] Review Request: cab - Haskell Cabal package maintenance program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731972 --- Comment #8 from Fedora Update System 2011-09-30 03:16:52 EDT --- cab-0.1.6-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/cab-0.1.6-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 731972] Review Request: cab - Haskell Cabal package maintenance program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731972 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System 2011-09-30 14:47:23 EDT --- cab-0.1.6-1.fc16 has been pushed to the Fedora 16 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 731972] Review Request: cab - Haskell Cabal package maintenance program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731972 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||cab-0.1.6-1.fc15 Resolution||ERRATA Last Closed||2011-10-09 02:50:43 --- Comment #11 from Fedora Update System 2011-10-09 02:50:43 EDT --- cab-0.1.6-1.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 731972] Review Request: cab - Haskell Cabal package maintenance program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731972 Fedora Update System changed: What|Removed |Added Fixed In Version|cab-0.1.6-1.fc15|cab-0.1.6-1.fc14 Bug 731972 depends on bug 740283, which changed state. Bug 740283 Summary: Review Request: ghc-attoparsec-enumerator - Haskell attoparsec to enumerator library https://bugzilla.redhat.com/show_bug.cgi?id=740283 What|Old Value |New Value Resolution||ERRATA Status|ON_QA |CLOSED --- Comment #12 from Fedora Update System 2011-10-09 02:53:54 EDT --- cab-0.1.6-1.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 731972] Review Request: cab - Haskell Cabal package maintenance program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731972 Fedora Update System changed: What|Removed |Added Fixed In Version|cab-0.1.6-1.fc14|cab-0.1.6-1.fc16 --- Comment #13 from Fedora Update System 2011-10-09 15:38:50 EDT --- cab-0.1.6-1.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
