[Bug 733925] Review Request: libdatrie - double-array trie implementation library
https://bugzilla.redhat.com/show_bug.cgi?id=733925 Christopher Meng cicku...@gmail.com changed: What|Removed |Added CC||cicku...@gmail.com Resolution|NOTABUG |DUPLICATE --- Comment #8 from Christopher Meng cicku...@gmail.com --- *** This bug has been marked as a duplicate of bug 1062542 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 733925] Review Request: libdatrie - double-array trie implementation library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=733925 Aurimas Černius auri...@gmail.com changed: What|Removed |Added Flags|needinfo?(auri...@gmail.com | |) | --- Comment #7 from Aurimas Černius auri...@gmail.com --- I'm afraid I don't have enough time for this, so I think I better spend my time contributing where I do now. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ip3uyPnIxGa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 733925] Review Request: libdatrie - double-array trie implementation library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=733925 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Status|NEW |CLOSED Blocks|177841 (FE-NEEDSPONSOR) |201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Last Closed||2012-12-16 16:54:22 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XTdmY2JAE4a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 733925] Review Request: libdatrie - double-array trie implementation library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=733925 --- Comment #6 from Matthias Runge mru...@redhat.com --- Any progress here? Aurimas, are you still interested? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YT0IZibnhBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 733925] Review Request: libdatrie - double-array trie implementation library
https://bugzilla.redhat.com/show_bug.cgi?id=733925 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Flags||needinfo?(auri...@gmail.com ||) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 733925] Review Request: libdatrie - double-array trie implementation library
https://bugzilla.redhat.com/show_bug.cgi?id=733925 Matthias Runge mru...@matthias-runge.de changed: What|Removed |Added CC||mru...@matthias-runge.de --- Comment #5 from Matthias Runge mru...@matthias-runge.de --- Aurimas, you should especially read https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group To show, you're familiar with packaging guidelines, you should do a few (5-10, depending on the your sponsor) inofficial reviews. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 733925] Review Request: libdatrie - double-array trie implementation library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=733925 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added CC||rdie...@math.unl.edu --- Comment #4 from Rex Dieter rdie...@math.unl.edu 2012-04-19 16:04:07 EDT --- fyi, in the future, when making modifications/updates to your packaging, bump Release, and make sure to include a changelog entry detailing the changes. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 733925] Review Request: libdatrie - double-array trie implementation library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=733925 --- Comment #3 from Aurimas Černius auri...@gmail.com 2011-09-11 10:29:03 EDT --- I've uploaded the updated spec and SRPM, the same links as in the first post. Below is the output of rpmlint for all rpms: $ rpmlint libdatrie-0.2.4-2.fc15.i686.rpm libdatrie.i686: W: spelling-error %description -l en_US trie - tire, true, tie libdatrie.i686: W: spelling-error %description -l en_US Trie - Teri, Brie, Erie 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmlint libdatrie-debuginfo-0.2.4-2.fc15.i686.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint libdatrie-devel-0.2.4-2.fc15.i686.rpm libdatrie-devel.i686: W: no-documentation libdatrie-devel.i686: W: no-manual-page-for-binary trietool-0.2 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmlint libdatrie-doc-0.2.4-2.fc15.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint libdatrie-0.2.4-2.fc15.src.rpm libdatrie.src: W: spelling-error %description -l en_US trie - tire, true, tie libdatrie.src: W: spelling-error %description -l en_US Trie - Teri, Brie, Erie 1 packages and 0 specfiles checked; 0 errors, 2 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 733925] Review Request: libdatrie - double-array trie implementation library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=733925
--- Comment #2 from Michael Schwendt mschwe...@gmail.com 2011-09-03 04:57:35
EDT ---
Please at least skim over the following pages, especially with regard to search
terms relevant to your package. For example, you could have searched for a
section covering static and shared libraries:
https://fedoraproject.org/wiki/Packaging:ReviewGuidelines
https://fedoraproject.org/wiki/Packaging:Guidelines
https://fedoraproject.org/wiki/Packaging:NamingGuidelines
http://fedoraproject.org/wiki/Licensing#SoftwareLicenses
* MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
Which does not imply that only a reviewer should do this. It's a tool for
packagers.
Libdatrie-0.2.4-1.src.rpm
rpmlint says something about this.
Name: libdatrie
Group: Development/Libraries
Base library packages typically go into group System Environment/Libraries.
https://fedoraproject.org/wiki/Packaging:DistTag
Release: 1
https://fedoraproject.org/wiki/Packaging/NamingGuidelines
https://fedoraproject.org/wiki/Packaging:DistTag
If you don't like the dist tag, a brief rationale would be appreciated.
Summary: An Implementation of Double-Array Trie
In the installer and package tools, leading An, A, The merely decrease
readability. Many book/report titles also omit them to be even more concise.
Summary: Implementation of Double-Array Trie
License: LGPLv2.1+
rpmlint says something about this.
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
%install
rm -rf %{buildroot}
%clean
rm -rf %{buildroot}
https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean
%package devel
Summary: Development files for libdatrie
Notice you don't have a leading article here either. ;)
Requires: libdatrie
https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package
%defattr(-,root,root,-)
Either at the beginning of all sections or omitted because of:
http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions
%{_libdir}/libdatrie.so.1*
https://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries
%{_libdir}/libdatrie.a
%{_libdir}/libdatrie.la
https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries
%package doc
Requires: libdatrie
Clearly the documentation subpackage does not depend on the library. See also:
https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires
Group: Development/Libraries
https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation
%files doc
%{_datadir}/doc/datrie/
%{_datadir}/doc/libdatrie/
Any particular reason why the documentation is not put into
%{_defaultdocdir}/%{name}-%{version} - but split up into two directories plus
the base library package adding another doc directory?
%doc AUTHORS COPYING README
What about file NEWS?
%{_datadir}/man/man1/trietool-0.2.1.gz
There is %{_mandir} = %{_datadir}/man
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 733925] Review Request: libdatrie - double-array trie implementation library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=733925 Aurimas Černius auri...@gmail.com changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) --- Comment #1 from Aurimas Černius auri...@gmail.com 2011-08-28 12:41:51 EDT --- Added FE-NEEDSPONSOR to blocks, since it's my first package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
