[Bug 735554] Review Request: floppy-support - Load floppy driver at boot time
https://bugzilla.redhat.com/show_bug.cgi?id=735554 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- floppy-support-1.0.0-4.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 735554] Review Request: floppy-support - Load floppy driver at boot time
https://bugzilla.redhat.com/show_bug.cgi?id=735554 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-09-08 22:46:47 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- floppy-support-1.0.0-4.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 735554] Review Request: floppy-support - Load floppy driver at boot time
https://bugzilla.redhat.com/show_bug.cgi?id=735554 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- floppy-support-1.0.0-4.fc16 has been pushed to the Fedora 16 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 735554] Review Request: floppy-support - Load floppy driver at boot time
https://bugzilla.redhat.com/show_bug.cgi?id=735554 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- floppy-support-1.0.0-4.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 735554] Review Request: floppy-support - Load floppy driver at boot time
https://bugzilla.redhat.com/show_bug.cgi?id=735554 Bruno Wolff III br...@wolff.to changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 735554] Review Request: floppy-support - Load floppy driver at boot time
https://bugzilla.redhat.com/show_bug.cgi?id=735554 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 735554] Review Request: floppy-support - Load floppy driver at boot time
https://bugzilla.redhat.com/show_bug.cgi?id=735554 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 735554] Review Request: floppy-support - Load floppy driver at boot time
https://bugzilla.redhat.com/show_bug.cgi?id=735554 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- floppy-support-1.0.0-4.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/floppy-support-1.0.0-4.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 735554] Review Request: floppy-support - Load floppy driver at boot time
https://bugzilla.redhat.com/show_bug.cgi?id=735554 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- floppy-support-1.0.0-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/floppy-support-1.0.0-4.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 735554] Review Request: floppy-support - Load floppy driver at boot time
https://bugzilla.redhat.com/show_bug.cgi?id=735554 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- floppy-support-1.0.0-4.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/floppy-support-1.0.0-4.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 735554] Review Request: floppy-support - Load floppy driver at boot time
https://bugzilla.redhat.com/show_bug.cgi?id=735554
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||mario.blaetterm...@gmail.co
||m
Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co
||m
Flags||fedora-review+
--- Comment #5 from Mario Blättermann mario.blaetterm...@gmail.com ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4423589
$ rpmlint -i -v *
floppy-support.src: I: checking
floppy-support.src: W: no-url-tag
The URL tag is missing.
floppy-support.src:38: W: libdir-macro-in-noarch-package (main package)
%{_libdir}/../lib/modules-load.d/floppy.conf
The %{_libdir} or %{_lib} macro was found in a noarch package in a section
that gets included in binary packages. This is most likely an error because
these macros are expanded on the build host and their values vary between
architectures, probably resulting in a package that does not work properly on
all architectures at runtime. Investigate whether the package is really
architecture independent or if some other dir/macro should be instead.
floppy-support.src: W: no-%build-section
The spec file does not contain a %build section. Even if some packages don't
directly need it, section markers may be overridden in rpm's configuration to
provide additional under the hood functionality, such as injection of
automatic -debuginfo subpackages. Add the section, even if empty.
floppy-support.noarch: I: checking
floppy-support.noarch: W: no-url-tag
The URL tag is missing.
floppy-support.noarch: W: only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.
floppy-support.noarch: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.
2 packages and 0 specfiles checked; 0 errors, 6 warnings.
As already discussed in the previous comments, we can ignore the rpmlint
issues.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
MIT
[+] MUST: The License field in the package spec file must match the actual
license.
[.] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[.] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[.] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package.
[Bug 735554] Review Request: floppy-support - Load floppy driver at boot time
https://bugzilla.redhat.com/show_bug.cgi?id=735554 --- Comment #6 from Bruno Wolff III br...@wolff.to --- It does look like I should add an empty %build section though based on the rpmlint message. (I don't remember seeing that detailed of a message previously.) Thanks for the review. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 735554] Review Request: floppy-support - Load floppy driver at boot time
https://bugzilla.redhat.com/show_bug.cgi?id=735554 --- Comment #7 from Mario Blättermann mario.blaetterm...@gmail.com --- (In reply to comment #6) It does look like I should add an empty %build section though based on the rpmlint message. (I don't remember seeing that detailed of a message previously.) Thanks for the review. It's not really needed, but according to the verbose rpmlint output you should do so. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 735554] Review Request: floppy-support - Load floppy driver at boot time
https://bugzilla.redhat.com/show_bug.cgi?id=735554 --- Comment #8 from Bruno Wolff III br...@wolff.to --- I'll also add a requires for systemd. Because it uses /usr/lib regardless of arch, I don't want to try requiring the directory. Besides, for the forseable future nothing else is going to provide that directory. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 735554] Review Request: floppy-support - Load floppy driver at boot time
https://bugzilla.redhat.com/show_bug.cgi?id=735554 Bruno Wolff III br...@wolff.to changed: What|Removed |Added Flags||fedora-cvs+ --- Comment #9 from Bruno Wolff III br...@wolff.to --- New Package SCM Request === Package Name: floppy-support Short Description: Load floppy driver at boot time Owners: bruno Branches: f16, f17, f18, devel InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 735554] Review Request: floppy-support - Load floppy driver at boot time
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=735554
Michal Schmidt mschm...@redhat.com changed:
What|Removed |Added
CC||mschm...@redhat.com
--- Comment #1 from Michal Schmidt mschm...@redhat.com 2011-09-05 02:11:13
EDT ---
You don't want to use %{_libdir}, because the path should be /usr/lib/... on
all architectures.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 735554] Review Request: floppy-support - Load floppy driver at boot time
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=735554 Bruno Wolff III br...@wolff.to changed: What|Removed |Added CC||br...@wolff.to --- Comment #2 from Bruno Wolff III br...@wolff.to 2011-09-05 09:36:29 EDT --- What is the correct way to handle this case? I was hoping doing a noarch build would handle it. I tried using /usr/lib and rpmlint regarded it as an error, so I am guessing that isn't correct either? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 735554] Review Request: floppy-support - Load floppy driver at boot time
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=735554
--- Comment #3 from Michal Schmidt mschm...@redhat.com 2011-09-05 09:58:52
EDT ---
The owner of the dir, systemd, uses:
%{_libdir}/../lib/modules-load.d
I'd just use /usr/lib/modules-load.d or %{_usr}/lib/modules-load.d and ignore
the rpmlint error. I don't know what's considered more correct.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 735554] Review Request: floppy-support - Load floppy driver at boot time
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=735554 --- Comment #4 from Bruno Wolff III br...@wolff.to 2011-09-05 10:20:09 EDT --- Thanks. I changed it to match what systemd does an uploaded an updated spec file and a new SRPM at http://bruno.fedorapeople.org/floppy-support-1.0.0-2.fc17.src.rpm. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
