[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717 Jens Petersen changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717 --- Comment #59 from Jens Petersen --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717 Dennis van Dok changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #58 from Dennis van Dok --- Package Change Request == Package Name: lcmaps New Branches: epel7 Owners: dennisvd I would like lcmaps to go to EPEL7 as well. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717 --- Comment #56 from Fedora Update System --- lcmaps-1.6.1-7.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717 --- Comment #57 from Fedora Update System --- lcmaps-1.6.1-7.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717 --- Comment #55 from Fedora Update System --- lcmaps-1.6.1-7.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/lcmaps-1.6.1-7.el5 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717 --- Comment #54 from Fedora Update System --- lcmaps-1.6.1-7.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/lcmaps-1.6.1-7.el6 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717 Fedora Update System changed: What|Removed |Added Fixed In Version|lcmaps-1.6.1-6.fc18 |lcmaps-1.6.1-6.fc19 --- Comment #53 from Fedora Update System --- lcmaps-1.6.1-6.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717 Fedora Update System changed: What|Removed |Added Fixed In Version|lcmaps-1.6.1-6.fc20 |lcmaps-1.6.1-6.fc18 --- Comment #52 from Fedora Update System --- lcmaps-1.6.1-6.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||lcmaps-1.6.1-6.fc20 Resolution|--- |ERRATA Last Closed||2013-11-23 22:52:57 --- Comment #51 from Fedora Update System --- lcmaps-1.6.1-6.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #50 from Fedora Update System --- lcmaps-1.6.1-6.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717 --- Comment #48 from Fedora Update System --- lcmaps-1.6.1-6.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/lcmaps-1.6.1-6.fc19 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717 --- Comment #47 from Fedora Update System --- lcmaps-1.6.1-6.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/lcmaps-1.6.1-6.fc20 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717 --- Comment #49 from Fedora Update System --- lcmaps-1.6.1-6.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/lcmaps-1.6.1-6.el6 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717 --- Comment #46 from Fedora Update System --- lcmaps-1.6.1-6.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/lcmaps-1.6.1-6.fc18 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717 --- Comment #45 from Fedora Update System --- lcmaps-1.6.1-6.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/lcmaps-1.6.1-6.el5 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717 --- Comment #44 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717 Dennis van Dok changed: What|Removed |Added Flags||fedora-cvs? --- Comment #43 from Dennis van Dok --- New Package SCM Request === Package Name: lcmaps Short Description: Grid (X.509) and VOMS credentials to local account mapping service Owners: dennisvd Branches: f18 f19 f20 el5 el6 InitialCC: -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717 --- Comment #42 from Dennis van Dok --- Thanks, Orion! And to the other reviewers as well! -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717 Orion Poplawski changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Flags||fedora-review+ --- Comment #41 from Orion Poplawski --- Great. Approved. Welcome aboard! Don't hesitate to contact me if you have any questions. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717
--- Comment #40 from Dennis van Dok ---
(In reply to Orion Poplawski from comment #39)
> Still need to add %{?_isa} to these so you bring in the proper architecture:
>
> Requires: globus-gssapi-gsi-devel
> Requires: openssl-devel
OK, fixed.
> (Also, even EPEL5 doesn't need %defattr() - that's a bug in fedora-review)
I removed them again.
New Spec URL: http://software.nikhef.nl/temporary/fedora-review/lcmaps.spec
New SRPM URL:
http://software.nikhef.nl/temporary/fedora-review/lcmaps-1.6.1-6.fc19.src.rpm
--
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717
--- Comment #39 from Orion Poplawski ---
Still need to add %{?_isa} to these so you bring in the proper architecture:
Requires: globus-gssapi-gsi-devel
Requires: openssl-devel
https://fedoraproject.org/wiki/Packaging:Guidelines#Requires
But that I think is the last thing.
(Also, even EPEL5 doesn't need %defattr() - that's a bug in fedora-review)
--
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717 --- Comment #38 from Dennis van Dok --- New Spec URL: http://software.nikhef.nl/temporary/fedora-review/lcmaps.spec New SRPM URL: http://software.nikhef.nl/temporary/fedora-review/lcmaps-1.6.1-5.fc19.src.rpm I'm getting the impression you keep seeing outdated versions of the spec file. Maybe it's the version control system acting up. I've put new ones up on the above location. The Obsoletes/Provides are in place, as are the requires on pkgconfig. Please try this version! Thanks, Dennis -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717
--- Comment #37 from Orion Poplawski ---
- EPEL5: Package requires pkgconfig, if .pc files are present.
Now you've removed these, which were needed for EPEL5:
# the pkgconfig requirement is only necessary for EPEL5 and below;
# it's automatic for Fedora and EPEL6.
%if %{?rhel}%{!?rhel:0} <= 5
Requires: pkgconfig
%endif
- EPEL5: Package does run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
I can't upgrade from your previous packages:
Error: Package: lcmaps-without-gsi-devel-1.6.1-1.fc21.x86_64
(@/lcmaps-without-gsi-devel-1.6.1-1.fc21.x86_64)
Requires: lcmaps-basic-interface = 1.6.1-1.fc21
Removing: lcmaps-basic-interface-1.6.1-1.fc21.noarch
(@/lcmaps-basic-interface-1.6.1-1.fc21.noarch)
lcmaps-basic-interface = 1.6.1-1.fc21
Obsoleted By: lcmaps-common-devel-1.6.1-4.fc19.x86_64
(/lcmaps-common-devel-1.6.1-4.fc19.x86_64)
lcmaps-basic-interface = 1.6.1-4.fc19
You could try using --skip-broken to work around the problem
Error: Package: lcmaps-openssl-interface-1.6.1-1.fc21.noarch
(@/lcmaps-openssl-interface-1.6.1-1.fc21.noarch)
Requires: lcmaps-basic-interface = 1.6.1-1.fc21
Removing: lcmaps-basic-interface-1.6.1-1.fc21.noarch
(@/lcmaps-basic-interface-1.6.1-1.fc21.noarch)
lcmaps-basic-interface = 1.6.1-1.fc21
Obsoleted By: lcmaps-common-devel-1.6.1-4.fc19.x86_64
(/lcmaps-common-devel-1.6.1-4.fc19.x86_64)
lcmaps-basic-interface = 1.6.1-4.fc19
If there are lcmaps-without-gsi-devel and lcmaps-openssl-interface packages out
in the wild, you will want to obsolete/provide them.
--
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717 --- Comment #36 from Dennis van Dok --- New SRPM URL: http://www.nikhef.nl/~dennisvd/lcmaps-1.6.1-4.fc19.src.rpm New Spec URL: https://ndpfsvn.nikhef.nl/ro/mwsec/packaging/fedora/branches/rawhide/lcmaps.spec OK, here goes. Happy reviewing! -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717
--- Comment #35 from Dennis van Dok ---
(In reply to Orion Poplawski from comment #34)
> > No, are the -devel packages noarch now? The only thing I see is that they
> > have a requires on some packages without %{?_isa}; is that harmful?
>
> Yes, they have "BuildArch: noarch" in their declarations.
I removed them from the Spec file on Oct 30th. The latest SRPM should be ok...
In any case, hang on while I address a few last issues:
- Put the BuildRoot and %clean section back in for EPEL5;
- include some Provides for the *-interface packages to be backward compatible
with the earlier setup of packages. This way our own packaging won't outright
conflict with Fedora's; this is a transitional thing that can go away once
we've cleaned all our packages of the *-interface dependencies.
--
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717
--- Comment #34 from Orion Poplawski ---
(In reply to Dennis van Dok from comment #33)
> Perhaps the --as-needed did the trick after all? I'm running fedora-review
> on f19, I'm not sure I should expect the same results.
Ah, yes --as-needed would have done it.
> > Finally - are you *sure* you want to keep the -devel packages as noarch?
>
> No, are the -devel packages noarch now? The only thing I see is that they
> have a requires on some packages without %{?_isa}; is that harmful?
Yes, they have "BuildArch: noarch" in their declarations. See comment #24 for
issues with the noarch deps. It would be better to be arch and depend on the
arch specific deps.
--
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717
--- Comment #33 from Dennis van Dok ---
(In reply to Orion Poplawski from comment #32)
> The libdl dep should be handled like other library dep - a true/false macro
> should be added to the AC_CHECK_LIB() call (see the call for crypto a little
> below) to set a DL_LIBS variable which would only be added to those link
> lines that need it.
The next release will address this issue.
> Although I'm not seeing any more unused lib dep rpmlint
> messages myself on F20, so I'm not sure it is necessary.
Perhaps the --as-needed did the trick after all? I'm running fedora-review on
f19, I'm not sure I should expect the same results.
> FWIW - If you still want to target EPEL5, you'll need BuildRoot and %clean.
> If not, I would drop the conditionals for %{rhel}<=5.
Yes, we do aim for EPEL5. So I'll fix this.
> Finally - are you *sure* you want to keep the -devel packages as noarch?
No, are the -devel packages noarch now? The only thing I see is that they have
a requires on some packages without %{?_isa}; is that harmful?
--
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717
--- Comment #32 from Orion Poplawski ---
Thank you for putting in the effort to address the linking issues and working
with upstreams - it is really appreciated.
The libdl dep should be handled like other library dep - a true/false macro
should be added to the AC_CHECK_LIB() call (see the call for crypto a little
below) to set a DL_LIBS variable which would only be added to those link lines
that need it. Although I'm not seeing any more unused lib dep rpmlint messages
myself on F20, so I'm not sure it is necessary.
FWIW - If you still want to target EPEL5, you'll need BuildRoot and %clean. If
not, I would drop the conditionals for %{rhel}<=5.
Finally - are you *sure* you want to keep the -devel packages as noarch?
Michael has pointed out some of the drawbacks to that, and the gains are very
little.
--
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717 --- Comment #31 from Dennis van Dok --- New SRPM URL: http://www.nikhef.nl/~dennisvd/lcmaps-1.6.1-2.fc19.src.rpm I've reduced the number of packages as suggested. The only thing that's still not OK is the unused-direct-shlib-dependencies. We don't really know how to fix all of these. - the libssl dependency is due to a bug in the voms-2.0.pc file which sets a Requires on openssl instead of a Requires.private[1]. I've contacted the packager about this. - the libvomsapi dependency is partly our own fault, a new release will fix this - the libdl dependency is due to AC_CHECK_LIB([dl], [dlopen]), which adds it to LIBS which is used for all libraries - the remaining libraries come from putting ./liblcmaps.la in the LIBADD for the interface libraries, which causes all the dependent libraries of liblcmaps to be linked with the interface libraries as well. This seems to be a bug in libtool; Debian uses a patch on libtool prevent linking[2]. 1. https://github.com/italiangrid/voms/issues/7 2. http://bugs.debian.org/cgi-bin/bugreport.cgi?archive=yes&bug=522663 Any suggestions on how to address these issues is welcome. In any case, I hope they aren't showstoppers. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717 Christopher Meng changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | Status|ASSIGNED|NEW -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rzcXbu8yVf&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717 Michael Schwendt changed: What|Removed |Added CC|bugs.mich...@gmx.net| --- Comment #14 from Michael Schwendt --- Some suggestions: * Run "fedora-review -b 736717". It will evaluate the "Spec URL:" and "SRPM URL:" lines in the bugzilla comments, download the files, do test-builds with Mock, and perform a couple of checks on the package. Examine the generated report, fix errors, try to complete missing tests with the help of https://fedoraproject.org/wiki/Packaging:ReviewGuidelines * Run rpmlint (or rpmlint -i for more helpful output) on the src.rpm and all built rpms. Feel free to ignore obvious false positives in the report, but fix anything else. Preferably add a comment here about whether/when you think what rpmlint reports is correct or incorrect. * For test-builds, you can submit a scratch-build in the Fedora build system (koji). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=R5ifLMRaky&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717 --- Comment #13 from Dennis van Dok --- (In reply to Christopher Meng from comment #12) > I strongly recommend you should first care about rawhide, then care about > EPEL. I never suggested anything to the contrary. > And I don't support targeting EL5, but all these are up to you, I can't > force you doing anything. I'm afraid I don't follow. > Hope you can find a sponsor quickly. Thanks. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1te15gQKr9&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717 Christopher Meng changed: What|Removed |Added CC||cicku...@gmail.com --- Comment #12 from Christopher Meng --- I strongly recommend you should first care about rawhide, then care about EPEL. And I don't support targeting EL5, but all these are up to you, I can't force you doing anything. Hope you can find a sponsor quickly. Best Regards. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zvEPkTc2pf&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717 Michael Schwendt changed: What|Removed |Added Flags|needinfo?(bugs.michael@gmx. | |net)| --- Comment #11 from Michael Schwendt --- It's okay if packagers target everything from EPEL5 up to Rawhide and keep old stuff such as the BuildRoot definition. It's also okay if they use conditionals, https://fedoraproject.org/wiki/Packaging:DistTag#Conditionals however that isn't highly recommended for various reasons. The spec file can become much more readible, if it doesn't contain many conditional sections. And conditional sections often get out-of-date, because you would update/upgrade Fedora more often than EPEL, and then you would need to test everything for all conditional target dists, too. And, of course, the spec files for different dist releases are stored in separate git branches. [...] In the Fedora Package Review queue, all tickets are set to "Version: Rawhide", regardless of whether they will be published for older Fedora branches and EPEL after approval. If a new package is made only for EPEL (I could imagine that), the submitter should be explicit about that. It could be that a reviewer will ask why the package would not be published for a Fedora dist. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Vz4mVbhx0F&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717 Veaceslav Mindru changed: What|Removed |Added CC||bugs.mich...@gmx.net Flags||needinfo?(bugs.michael@gmx. ||net) --- Comment #10 from Veaceslav Mindru --- Hello Dennis , Probably i was mistaken by Version: rawhide Hardware: All Linux and i took it as targeted for EPEL6 last Released Fedora. In case you want to go only with EPEL5 than this is fine , if you want to go with EPEL6 than you will have to rewrite and as far as i understand they will go separate it. If i am not mistaken EPEL5 ended on Fedora 12 or 13. Let's wait until someone else will review it and advice how to proceed. VM -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NOixTcVATQ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717 Dennis van Dok changed: What|Removed |Added Flags|needinfo?(dennisvd@nikhef.n | |l) | --- Comment #9 from Dennis van Dok --- (In reply to Veaceslav Mindru from comment #8) > Are you still interested to package this ? If yes you will have to adjust > the SPEC file. stuff like buildroot are deprecated after EPEL5. Please let > me know if you are interested and we can try to get some attention to review > this. Yes, I am still interested. Note that this is just the first package and it's accompanied by a couple of plug-in packages. What exactly is wrong with buildroot? According to https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag this is still required for EPEL5 and I'd like this to go to EPEL5 if possible. Thanks, dennis -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zdH52Gzro0&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717 Veaceslav Mindru changed: What|Removed |Added CC||mind...@gmail.com --- Comment #8 from Veaceslav Mindru --- >The spec file is >http://software.nikhef.nl/dist/redhat/el5/mwsec/SPECS/lcmaps.spec >The SRPM is >http://software.nikhef.nl/dist/redhat/el5/mwsec/SRPMS/lcmaps-1.5.5-1.el5.src.rpm Are you still interested to package this ? If yes you will have to adjust the SPEC file. stuff like buildroot are deprecated after EPEL5. Please let me know if you are interested and we can try to get some attention to review this. VM -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qoJXfCAOG2&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=736717 Jason Tibbitts changed: What|Removed |Added Flags||needinfo?(dennisvd@nikhef.n ||l) --- Comment #7 from Jason Tibbitts --- I am triaging old review tickets. I apologize that it has been so long since anyone looked at this ticket, but there are more packages submitted now than the pool of reviewers can handle, and some tickets fall through the cracks. In order to keep the queue manageable, we need to occasionally find tickets which are not reviewable so as to not waste what reviewer time is available. Accordingly, I'm pinging this ticket and setting NEEDINFO. If you are still interested in having your package reviewed, please do the following: * Make sure your package still reflects the current status of its upstream. * Check that your package still builds on current Fedora releases. * Audit your package versus the current status of the packaging guidelines, current rpmlint and current fedora-review tools. And, finally, reply, making sure that the NEEDINFO flag gets cleared so that this ticket reappears in the review queue. I can't promise a review if you reply, but by closing out the stale tickets we can devote extra attention to the ones which aren't stale. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bp2aYRcYrk&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717 Steve Traylen changed: What|Removed |Added Flags|fedora-review? | -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
https://bugzilla.redhat.com/show_bug.cgi?id=736717 --- Comment #6 from Dennis van Dok --- The lcmaps package has been extensively updated upstream; once more I would like to request for a review for inclusion in Fedora. The spec file is http://software.nikhef.nl/dist/redhat/el5/mwsec/SPECS/lcmaps.spec The SRPM is http://software.nikhef.nl/dist/redhat/el5/mwsec/SRPMS/lcmaps-1.5.5-1.el5.src.rpm I've done a self-review and there still are some known issues: - rpmlint gives many warnings about the interface packages, because they aren't recognised as devel packages. There are several features that set the interface packages apart from -devel packages: + there are interface packages for each interface of LCMAPS + they are architecture independent + they do not depend on the base package + they do not even depend on a particular version of the base package - The documentation is somewhat outdated. If these issues are real blockers for adoption, let me know. Otherwise I would really appreciate it if someone would take a look. PS a functional test of the software isn't exactly trivial. It is a core component of a security framework, and without clients and plug-ins it doesn't do a whole lot. But I can't get any of the other stuff in without first having lcmaps in place. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=736717
--- Comment #5 from Dennis van Dok 2011-10-25 17:58:41 EDT
---
Hi Steve,
thanks for your thorough reporting. I will give some short and direct answers
now, but some things need more looking into and discussion with the developers.
a) the spec file permission; don't know how it happened but will look into it.
b) I'll look into the use of %{name} in the spec file.
1) the call to exit we got for free from flex, in case the parser bails out
over some weird error condition. We will fix this if we haven't already.
2+3) I will clarify in the spec file what the rationale is behind having a
'interface' package rather than a 'devel' package. The gist of it is that a
developer of a client program would not need to link his work with lcmaps.so,
because that is delayed until run-time. Only the header files are needed. The
header files are split up because some depend on openssl, and some on globus,
but we don't want to force a developer to install the globus dependencies if he
doesn't really need them.
At run-time, liblcmaps.so is required for dlopen, so this shouldn't be in the
devel package. This leaves the devel package to be virtually empty.
Technically the interface packages could be renamed devel packages, but the
current user base knows and uses the interface packages already.
The licence file seems to be a leftover from the previous funding projects, I
will have to discuss whether we can simply replace it with the normal ASL2.0
text.
I will get back soon, and update the package.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=736717
--- Comment #4 from Steve Traylen 2011-10-25 16:28:05
EDT ---
rpmlint lcmaps.spec is clean
$ rpmlint ./lcmaps-1.4.31-5.fc15.src.rpm
lcmaps.src: W: strange-permission lcmaps.spec 0600L
Please change the permissions on the input files to the .src.rpm
$ rpmlint./noarch/lcmaps-basic-interface-1.4.31-5.fc15.noarch.rpm \
./noarch/lcmaps-globus-interface-1.4.31-5.fc15.noarch.rpm \
./noarch/lcmaps-openssl-interface-1.4.31-5.fc15.noarch.rpm \
./x86_64/lcmaps-1.4.31-5.fc15.x86_64.rpm \
./x86_64/lcmaps-debuginfo-1.4.31-5.fc15.x86_64.rpm \
./x86_64/lcmaps-devel-1.4.31-5.fc15.x86_64.rpm \
Full in to these types:
(1)
lcmaps.x86_64: W: shared-lib-calls-exit /usr/lib64/liblcmaps.so.0.0.0
exit@GLIBC_2.2.5
Is this something you can look at, it's genrally considered bad practise,
at least submit a bug upstream.
(2)
lcmaps.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/liblcmaps_return_poolindex.so
So you mention these in the .spec file that they are dlopened. It
it only your application that opens them? Can they be moved out
of lib to say copy httpd's /usr/lib64/httpd/modules style, e.g
/usr/lib64/lcmaps/modules, this is a suggestion rather than a requirement.
(3)
lcmaps-basic-interface.noarch: W: devel-file-in-non-devel-package
/usr/include/lcmaps/lcmaps_basic.h
This is quite odd, why are these not just in the devel package? especially
given that you just require it anyway.
[yes] specfiles match: lcmaps.spec.
[yes] source files match upstream:
$ md5sum ../SOURCES/lcmaps-1.4.31.tar.gz lcmaps-1.4.31.tar.gz
ab2dcdb2679c8b8e1c7ae6570fbc3bc5 ../SOURCES/lcmaps-1.4.31.tar.gz
ab2dcdb2679c8b8e1c7ae6570fbc3bc5 lcmaps-1.4.31.tar.gz
[yes] package meets naming and versioning guidelines.
[no] spec is properly named, cleanly written, and uses macros consistently.
You use both lcmaps and %{name} quite a bit through the package. I would
drop one of them. Proberly name since it seems unlikely that this will
be useful for anything else.
[yes] dist tag is present.
[yes] build root is correct.
[?] license field matches the actual license, ASL2.0 all the code
is headed well. However the LICENSE file is not the ASL2.0 I am familiar
with. Do you believe with this file this still complies to the ASL2.0, what
is this text.
[? but probably] license is open source-compatible.
[yes] license text included in package.
[no] latest version is being packaged.
1.4.34 appears to be available.
[yes] BuildRequires are proper.
Builds okay in mock
[yes] compiler flags are appropriate.
[yes] %clean is present. (But not needed anymore)
[yes] package builds in mock. tested F15.
[not-checked-yet] package installs properly.
[no] rpmlint is silent.
See comments above.
[not-checked-yet] final provides and requires are sane
Waiting on more comments about the '-interface' packages.
I don't understand the 'interface' packages.
[none] %check is present and all tests pass:
[yes] owns the directories it creates.
[yes] doesn't own any directories it shouldn't.
[yes] no duplicates in %files.
[yes] file permissions are appropriate.
[yes] scriptlets match those on ScriptletSnippets page.
[yes] documentation is small, so no -docs subpackage is necessary.
[yes] %docs are not necessary for the proper functioning of the package.
[?] pkgconfig files. You have requires pkgconfig, this is only needed
on RHEL5.
[yes] no libtool .la droppings.
[none] desktop files valid and installed properly.
So the main questions are , what are those 'interface' packages, can't
these just all go in devel?
The odd LICENSE file which is not ASL2.0.
Steve.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=736717 --- Comment #3 from Dennis van Dok 2011-09-14 05:31:47 EDT --- For the purpose of sponsoring, here's a link to a review I've done: https://bugzilla.redhat.com/show_bug.cgi?id=697326#c5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=736717 --- Comment #2 from Dennis van Dok 2011-09-13 08:25:22 EDT --- Hi Al, thanks for your comment. You are right about the differences in the SRPM and the spec file, this was unintended. The release tag was a leftover from an experiment. I've fixed both issues. New SRPM: http://software.nikhef.nl/dist/redhat/el5/mwsec/SRPMS/lcmaps-1.4.31-5.el5.src.rpm New SPEC: http://software.nikhef.nl/dist/redhat/el5/mwsec/SPECS/lcmaps.spec Thanks, Dennis -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=736717 Al Reay changed: What|Removed |Added CC||alre...@gmail.com --- Comment #1 from Al Reay 2011-09-12 18:52:14 EDT --- Hi Dennis, I'm not authorized to sponsor you but I'll happily help review your SRPM. * rpmlint on your .spec file reports: lcmaps.spec:241: W: macro-in-%changelog %post maybe change that comment to read "-added ldconfig to 'postun' section * The spec file you've linked is different to that included in the SRPM. In the linked spec file you've got a 'release' variable that is based off the current date (with resolution down to the minute). This means that you get a differently versioned package basically everytime you rebuild it. I'm pretty sure this is not going to be acceptable to the Fedora packagers. I think that packages are routinely rebuilt (for different architectures, releases etc) and that this will just cause a constant stream of updates to be applied to clients using the software even when no changes have occurred. Apologies if I've misunderstood something here. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=736717 Steve Traylen changed: What|Removed |Added Status|NEW |ASSIGNED CC||steve.tray...@cern.ch Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=736717 Dennis van Dok changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
