[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=737401 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-12-20 10:38:00 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UyPyh7fCDr&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=737401 --- Comment #32 from Fedora Update System --- saga-2.0.8-5.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QAJRK2GHz4&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
https://bugzilla.redhat.com/show_bug.cgi?id=737401 --- Comment #31 from Fedora Update System --- saga-2.0.8-5.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
https://bugzilla.redhat.com/show_bug.cgi?id=737401 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
https://bugzilla.redhat.com/show_bug.cgi?id=737401 --- Comment #30 from Fedora Update System --- saga-2.0.8-5.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/saga-2.0.8-5.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
https://bugzilla.redhat.com/show_bug.cgi?id=737401 --- Comment #29 from Fedora Update System --- saga-2.0.8-5.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/saga-2.0.8-5.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
https://bugzilla.redhat.com/show_bug.cgi?id=737401 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
https://bugzilla.redhat.com/show_bug.cgi?id=737401 --- Comment #28 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
https://bugzilla.redhat.com/show_bug.cgi?id=737401 Volker Fröhlich changed: What|Removed |Added Flags||fedora-cvs? --- Comment #27 from Volker Fröhlich --- New Package SCM Request === Package Name: saga Short Description: Geographic information system with an API for processing geodata Owners: volter Branches: f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
https://bugzilla.redhat.com/show_bug.cgi?id=737401 --- Comment #26 from Volker Fröhlich --- Hooray, thanks a lot for your patience! -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
https://bugzilla.redhat.com/show_bug.cgi?id=737401 Jerry James changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #25 from Jerry James --- It's about time for this package to see the light of day, don't you think? :-) This package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
https://bugzilla.redhat.com/show_bug.cgi?id=737401 --- Comment #24 from Volker Fröhlich --- http://www.geofrogger.net/review/saga.spec http://www.geofrogger.net/review/saga-2.0.8-5.fc16.src.rpm 1 through 5 addressed -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
https://bugzilla.redhat.com/show_bug.cgi?id=737401
Jerry James changed:
What|Removed |Added
Flags|needinfo?(loganjerry@gmail. |
|com)|
--- Comment #23 from Jerry James ---
Thanks for the reminder, Volker. Life is busy and stuff slides off of my
radar. It's been so long, and there have been so many changes, that I'm going
to do another full review.
Executive summary of everything below:
(1) Change %{?isa} to %{?_isa} everywhere in the spec file.
(2) Determine the effect on the license of these files:
(a) src/saga_core/saga_odbc/otlv4.h (ISC license, shipped in -devel)
(b) src/modules_projection/pj_proj4/pj_proj4/MLB_Interface.h (GPL v2, no
"or any later version" clause).
(3) Document the license breakdown in a comment just above the License tag.
(4) Convert % to %% on line 9 of the spec file (macros in comments).
(5) The unused direct shared library dependencies can be fixed by linking with
-Wl,--as-needed. However, libtool likes to push all -W options, including
this one, *after* the list of libraries to link, defeating its purpose. I
like to use this in my spec files, after running configure, to get around
that problem and fix the rpath problem at the same time:
# Get rid of undesirable hardcoded rpaths; workaround libtool reordering
# -Wl,--as-needed after all the libraries.
sed -e 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g' \
-e 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' \
-e 's|^LTCC="gcc"|LTCC="gcc -Wl,--as-needed"|' \
-e 's|^CC="g++"|CC="g++ -Wl,--as-needed"|' \
-i libtool
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
= MUST items =
C/C++:
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
[!]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install if there is
such a file.
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[!]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in %package
devel, %package python
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: Large documentation files are in a -doc subpackage, if required.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"ISC", "GPL (v2 or later)", "LGPL", "GPL (v2)", "Unknown or generated". 5
files have unknown license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[!]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
https://bugzilla.redhat.com/show_bug.cgi?id=737401 Volker Fröhlich changed: What|Removed |Added Flags||needinfo?(loganjerry@gmail. ||com) --- Comment #22 from Volker Fröhlich --- Just a friendly reminder -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
https://bugzilla.redhat.com/show_bug.cgi?id=737401 --- Comment #21 from Volker Fröhlich --- Sorry, that was my mistake! I uploaded a spec file that had a draft patch to work around the proj problem. I removed it and it's building fine now: http://www.geofrogger.net/review/saga.spec http://www.geofrogger.net/review/saga-2.0.8-4.fc16.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=4573430 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
https://bugzilla.redhat.com/show_bug.cgi?id=737401 --- Comment #20 from Jerry James --- Building with mock against Rawhide RPMs still fails with proj errors. The version currently in Rawhide is 4.8.0-3. What version fixes the problem, and when do you expect it to be available in Rawhide? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
https://bugzilla.redhat.com/show_bug.cgi?id=737401 --- Comment #19 from Volker Fröhlich --- The proj issue is solved. I also followed your two suggestions. http://www.geofrogger.net/review/saga.spec http://www.geofrogger.net/review/saga-2.0.8-3.fc16.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
https://bugzilla.redhat.com/show_bug.cgi?id=737401 Volker Fröhlich changed: What|Removed |Added Depends On||830496 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=737401 Bug 737401 depends on bug 812137, which changed state. Bug 812137 Summary: Review Request: polyclipping - Polygon clipping library https://bugzilla.redhat.com/show_bug.cgi?id=812137 What|Old Value |New Value Status|NEW |ASSIGNED Status|ASSIGNED|MODIFIED Status|MODIFIED|ON_QA Resolution||ERRATA Status|ON_QA |CLOSED --- Comment #18 from Volker Fröhlich 2012-05-11 16:05:11 EDT --- Frank Warmerdam, one of the Proj developers, said, we should just install projects.h in 4.8, if it causes us any trouble. He's aware of the problem and seeking a solution. I'll post a new package as soon as I can. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=737401
--- Comment #17 from Jerry James 2012-04-24 15:17:55 EDT
---
Great, you've done a lot of work on this. Let me know when the Proj 4.8 issue
is resolved and I'll give it a try. In the meantime, here are a couple of
comments from scanning the spec file.
First, the dos2unix BR is usually unnecessary. Most of the time, something
like this will do the same job:
sed -i 's/\r//' AUTHORS
Second, you can't use the Provides filtering method you are using. See
https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering#Usage
for the reason why. However, you can use RPM 4.9 filtering; see
https://fedorahosted.org/fpc/ticket/76. In your case, you can replace the
filter statements with this (just before %prep):
%global __provides_exclude_from ^%{python_sitearch}/.*\\.so$
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=737401 --- Comment #16 from Volker Fröhlich 2012-04-22 12:46:28 EDT --- http://www.geofrogger.net/review/saga.spec http://www.geofrogger.net/review/saga-2.0.8-2.fc16.src.rpm Notice, this won't build in Rawhide because of issues with Proj 4.8 (see specfile) and because libpolyclipping is still on review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=737401 --- Comment #15 from Volker Fröhlich 2012-04-13 17:25:04 EDT --- Rawhide seems to be broken right now, so I built in F17: http://koji.fedoraproject.org/koji/taskinfo?taskID=3989496 Vigra 1.8 has a slight API change, that caused the problem. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=737401 --- Comment #14 from Volker Fröhlich 2012-04-12 16:43:46 EDT --- I already managed to build a working SAGA with all system-wide libraries. I'll now try to get those changes upstream and I'll have a look at the possible fftw issue. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=737401 Volker Fröhlich changed: What|Removed |Added Depends on||812137 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=737401 Bug 737401 depends on bug 767082, which changed state. Bug 767082 Summary: Review Request: wxpropgrid - A property sheet control for wxWidgets https://bugzilla.redhat.com/show_bug.cgi?id=767082 What|Old Value |New Value Status|NEW |ASSIGNED Status|ASSIGNED|MODIFIED Status|MODIFIED|ON_QA Resolution||ERRATA Status|ON_QA |CLOSED --- Comment #13 from Volker Fröhlich 2012-03-29 16:30:06 EDT --- I created a CMake file for Polyclipping. Polyclipping had no build system so far and the author said, he'd integrate it, but had no time himself. Polyclipping will therefore be a shared library. I recently submitted the file and am waiting for his response. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=737401 Volker Fröhlich changed: What|Removed |Added Depends on||767082 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=737401 --- Comment #12 from Jerry James 2012-01-23 17:33:59 EST --- Great! Thanks for posting updates. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=737401 --- Comment #11 from Volker Fröhlich 2012-01-23 11:45:07 EST --- I patched Saga to use the system-wide wxpropgrid, but the patch is not ready for upstream so far. Only polyclipping should be left now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=737401 --- Comment #10 from Volker Fröhlich 2011-12-13 02:46:09 EST --- wxpropgrid is on review: https://bugzilla.redhat.com/show_bug.cgi?id=767082 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=737401 Jerry James changed: What|Removed |Added Flag||fedora-review? --- Comment #9 from Jerry James 2011-11-24 16:02:56 EST --- Thanks for the update. If you'd like to swap some more reviews to get other components into Fedora, I'd be happy to do so. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=737401 Bug 737401 depends on bug 747849, which changed state. Bug 747849 Summary: Review Request: e00compr - Library to compress and uncompress E00 files https://bugzilla.redhat.com/show_bug.cgi?id=747849 What|Old Value |New Value Resolution||ERRATA Status|ON_QA |CLOSED --- Comment #8 from Volker Fröhlich 2011-11-24 14:08:46 EST --- Upstream has replaced the GPC polygon clipper with a free alternative, I'll also have to package. Spot regards Dxflib not free, so we'll keep it excluded. Upstream might also consider to replace Firelib. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=737401 --- Comment #7 from Volker Fröhlich 2011-11-01 18:17:08 EDT --- And lovely "not free for commercial use"-GPC polygon clipper is in it as well, sigh! At least I managed to use system-wide e00compr and wxpropgrid so far. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=737401 Volker Fröhlich changed: What|Removed |Added Depends on||747849 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=737401
--- Comment #6 from Jerry James 2011-10-10 23:22:10 EDT
---
Oops, my mistake. I kicked off a mock build for fedora-rawhide-i386 and forgot
to go back and look at it. The "package builds in mock" item above is actually
a lie. The mock build failed, like this:
/bin/sh ../../../../libtool --tag=CXX --mode=compile g++
-DPACKAGE_NAME=\"saga
\" -DPACKAGE_TARNAME=\"saga\" -DPACKAGE_VERSION=\"2.0.7\"
-DPACKAGE_STRING=\"sag
a\ 2.0.7\" -DPACKAGE_BUGREPORT=\"BUG-REPORT-ADDRESS\" -DPACKAGE_URL=\"\"
-DPACKA
GE=\"saga\" -DVERSION=\"2.0.7\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1
-DHAVE_SYS
_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1
-DHAVE_STRINGS_H
=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1
-DLT
_OBJDIR=\".libs/\" -DSTDC_HEADERS=1 -DHAVE_FLOAT_H=1 -DHAVE_MALLOC_H=1
-DHAVE_ME
MORY_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_UNISTD_H=1 -DHAVE_WCHAR_H=1
-DHAVE__BOOL=1 -DHAVE_STDBOOL_H=1 -DHAVE_STDLIB_H=1 -DHAVE_MALLOC=1
-DHAVE_STDLI
B_H=1 -DHAVE_REALLOC=1 -DLSTAT_FOLLOWS_SLASHED_SYMLINK=1 -DHAVE_VPRINTF=1
-DHAVE
_MEMMOVE=1 -DHAVE_MEMSET=1 -DHAVE_MODF=1 -DHAVE_STRCHR=1 -DHAVE_STRDUP=1
-DHAVE_
STRERROR=1 -DHAVE_STRRCHR=1 -DHAVE_STRSTR=1 -DHAVE_STRTOL=1
-DHAVE_PYTHON=\"2.7\
" -I.-fPIC -I../../../../src/saga_core -D_SAGA_LINUX -D_TYPEDEF_BYTE
-D_TYPE
DEF_WORD -D_SAGA_UNICODE -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2
-fexception
s -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i686 -mtune=atom
-fas
ynchronous-unwind-tables -c -o vigra_smoothing.lo vigra_smoothing.cpp
vigra_fft.cpp:390:2: warning: "/*" within comment [-Wcomment]
vigra_fft.cpp: In function 'bool Copy_ComplexGrid_SAGA_to_VIGRA(CSG_Grid&,
CSG_G
rid&, vigra::FFTWComplexImage&, bool)':
vigra_fft.cpp:92:29: error: missing template arguments before '(' token
vigra_fft.cpp: In member function 'virtual bool
CViGrA_FFT_Inverse::On_Execute()
':
vigra_fft.cpp:299:99: error: type/value mismatch at argument 1 in template
param
eter list for 'template struct std::multiplies'
vigra_fft.cpp:299:99: error: expected a type, got 'FFTWComplex'
vigra_fft.cpp: In member function 'virtual bool
CViGrA_FFT_Filter::On_Execute()'
:
vigra_fft.cpp:522:99: error: type/value mismatch at argument 1 in template
param
eter list for 'template struct std::multiplies'
vigra_fft.cpp:522:99: error: expected a type, got 'FFTWComplex'
make[4]: *** [vigra_fft.lo] Error 1
make[4]: *** Waiting for unfinished jobs
Could this be due to the recent fftw update? I don't have this problem
building on Fedora 15.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=737401
--- Comment #5 from Jerry James 2011-10-10 20:52:33 EDT
---
Great. I pulled his new build of g2clib from koji and did the two fixes I
requested by hand for this review.
+: OK
-: must be fixed
=: should be fixed (at your discretion)
N: not applicable
MUST:
[=] rpmlint output:
saga.x86_64: W: spelling-error Summary(en_US) geodata -> gestate
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_gdi-2.0.7.so
/usr/lib64/libwx_gtk2u_richtext-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_gdi-2.0.7.so
/usr/lib64/libwx_gtk2u_aui-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_gdi-2.0.7.so
/usr/lib64/libwx_gtk2u_xrc-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_gdi-2.0.7.so
/usr/lib64/libwx_gtk2u_qa-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_gdi-2.0.7.so
/usr/lib64/libwx_gtk2u_html-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_gdi-2.0.7.so
/usr/lib64/libwx_gtk2u_adv-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_gdi-2.0.7.so
/usr/lib64/libwx_baseu_xml-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_gdi-2.0.7.so
/usr/lib64/libwx_baseu_net-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_gdi-2.0.7.so
/usr/lib64/libhpdf-2.1.0.so
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_api-2.0.7.so
/usr/lib64/libwx_gtk2u_richtext-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_api-2.0.7.so
/usr/lib64/libwx_gtk2u_aui-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_api-2.0.7.so
/usr/lib64/libwx_gtk2u_xrc-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_api-2.0.7.so
/usr/lib64/libwx_gtk2u_qa-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_api-2.0.7.so
/usr/lib64/libwx_gtk2u_html-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_api-2.0.7.so
/usr/lib64/libwx_gtk2u_adv-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_api-2.0.7.so
/usr/lib64/libwx_baseu_net-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_api-2.0.7.so
/usr/lib64/libhpdf-2.1.0.so
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_odbc-2.0.7.so
/usr/lib64/libwx_gtk2u_richtext-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_odbc-2.0.7.so
/usr/lib64/libwx_gtk2u_aui-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_odbc-2.0.7.so
/usr/lib64/libwx_gtk2u_xrc-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_odbc-2.0.7.so
/usr/lib64/libwx_gtk2u_qa-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_odbc-2.0.7.so
/usr/lib64/libwx_gtk2u_html-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_odbc-2.0.7.so
/usr/lib64/libwx_gtk2u_adv-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_odbc-2.0.7.so
/usr/lib64/libwx_gtk2u_core-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_odbc-2.0.7.so
/usr/lib64/libwx_baseu_xml-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_odbc-2.0.7.so
/usr/lib64/libwx_baseu_net-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_odbc-2.0.7.so
/usr/lib64/libwx_baseu-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_odbc-2.0.7.so
/usr/lib64/libhpdf-2.1.0.so
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_odbc-2.0.7.so
/lib64/libm.so.6
saga-python.x86_64: W: no-documentation
saga-devel.x86_64: W: no-documentation
saga.spec:9: W: macro-in-comment %{name}
saga.spec:9: W: macro-in-comment %{name}
saga.spec:9: W: macro-in-comment %{version}
saga.spec: W: invalid-url Source0: saga_2.0.7-fedora.tar.gz
3 packages and 1 specfiles checked; 0 errors, 36 warnings.
The spelling warning is bogus. Can you do anything about this unused direct
shared library dependencies? They should be dropped from the respective
library link commands, if possible. Also, please fix the 3 macro-in-comment
warnings in the spec file by doubling the % characters on that line.
[+] follows package naming guidelines
[+] spec file base name matches package name
[+] package meets the packaging guidelines
[+] package uses a Fedora approved license
[-] license field matches the actual license: licensecheck shows the following:
there are some MIT-licensed files in
src/modules_io/esri_e00/io_esri_e00/e00compr;
some files are GPLv2, not GPLv2+, such as
src/modules_projection/pj_proj4/pj_proj4/crs_base.h;
there is a BSD-licensed file: src/saga_core/saga_odbc/otlv4.h; and
there are wxWindows licensed files
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=737401 --- Comment #4 from Volker Fröhlich 2011-10-10 11:01:14 EDT --- Orion was so kind to rebuild the package with fpic. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=737401 --- Comment #3 from Volker Fröhlich 2011-10-09 09:30:43 EDT --- Thank you for your help, Jerry! I solved the ODBC issue and reported it as well. I also did what you suggested for g2clib. The problem here is, g2clib is not compiled with fPIC, which seems to break compiling Saga on 64 bit systems. I made a build with fPIC on my machine and it seems to work fine now. I asked Orion, who is the maintainer, if he would mind to build the package with fPIC. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=737401 Jerry James changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|loganje...@gmail.com --- Comment #2 from Jerry James 2011-10-07 18:02:37 EDT --- Since I started the original review, I guess I should see it through to the bitter end. :-) I see a couple of problems in the build I just did. First, configure says: checking for SQLFetch in -lodbc... no which is wrong. We do have SQLFetch in that library. Checking further, I see this in config.log: configure:15378: gcc -o conftest -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic conftest.c -lodbc ODBC \(libodbc\) library not found >&5 gcc: error: ODBC: No such file or directory gcc: error: \(libodbc\): No such file or directory gcc: error: library: No such file or directory gcc: error: not: No such file or directory gcc: error: found: No such file or directory That's because this line in configure.in has one too many commas: AC_CHECK_LIB([odbc], [SQLFetch], ODBCFOUND=1,,[ODBC \(libodbc\) library not found]) Change the double-comma in front of the error message to a single comma, and all is well. Second, saga-2.0.7-g2clib.patch is wrong, in two ways. It is wrong, because it assumes that libgrib2c.a is available in /usr/lib64. On 32-bit systems, it isn't; it is in /usr/lib. Second, it is wrong because the -L flag tells the linker *a directory* in which to look for libraries, not the name of an actual library. The end result is that the contents of libgrib2c.a are not in libio_grid_grib2.so. Using readelf, you can see that libio_grid_grib2.so contains references to g2_free and g2_getfld, both of which are marked undefined. To fix both problems, change the patch to add "-lgrib2c" to AM_LDFLAGS instead of the current "-L...". The linker will use a static library to satisfy a link request such as this when it cannot find a shared library. Things look pretty good in general, otherwise. If you can get me a package that fixes those two problems, I'll do a full review on it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=737401 Ken Dreyer changed: What|Removed |Added CC||cristian.bal...@gmail.com --- Comment #1 from Ken Dreyer 2011-10-04 20:26:10 EDT --- *** Bug 478743 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
