[Bug 742996] Review Request: libpwquality - A library for password generation and password quality checking
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=742996 --- Comment #8 from Jon Ciesla 2011-12-12 21:18:27 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 742996] Review Request: libpwquality - A library for password generation and password quality checking
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=742996 Tomas Mraz changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Comment #7 from Tomas Mraz 2011-12-12 16:10:58 EST --- Package Change Request == Package Name: libpwquality New Branches: el5 el6 Owners: tmraz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 742996] Review Request: libpwquality - A library for password generation and password quality checking
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=742996 Tomas Mraz changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Last Closed||2011-10-12 09:03:35 --- Comment #6 from Tomas Mraz 2011-10-12 09:03:35 EDT --- Built in rawhide. In F16 it will be built later. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 742996] Review Request: libpwquality - A library for password generation and password quality checking
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=742996 --- Comment #5 from Jon Ciesla 2011-10-11 15:40:06 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 742996] Review Request: libpwquality - A library for password generation and password quality checking
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=742996 Tomas Mraz changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Tomas Mraz 2011-10-11 15:18:49 EDT --- New Package SCM Request === Package Name: libpwquality Short Description: A library for password generation and password quality checking Owners: tmraz Branches: f16 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 742996] Review Request: libpwquality - A library for password generation and password quality checking
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=742996 Miloslav Trmač changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #3 from Miloslav Trmač 2011-10-11 14:50:22 EDT --- Thanks, accepted. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 742996] Review Request: libpwquality - A library for password generation and password quality checking
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=742996
Tomas Mraz changed:
What|Removed |Added
Flag|needinfo?(tm...@redhat.com) |
--- Comment #2 from Tomas Mraz 2011-10-10 14:02:10 EDT ---
(In reply to comment #1)
>
> > libpwquality-devel.x86_64: W: no-documentation
> oh well... upstream issue
I plan to add some documentation in future. Currently the API is at least
partially documented in the comments in the public header file.
> > libpwquality.x86_64: W: no-manual-page-for-binary pwscore
> > libpwquality.x86_64: W: no-manual-page-for-binary pwmake
> upstream issue, however would be good to fix soonish
Yeah, I plan to add the manpage soon.
> Needs fixing:
> * Doesn't build in koji
> At least missing BuildRequires: pam-devel
Fixed. Now I verified that it builds in mock.
> * Licensing problems/uncertainty:
> * License field says (BSD and GPLv2+)
> * Licensing guidelines require using "or" for dual licensing
> * Source files allow BSD or referenced GPL (note: not GPLv2, not GPL+!)
> * COPYING contains the same reference to GPL without v2/+, but includes
> text of GPLv2
Fixed to 'BSD or GPL+' which is correct according to the License guidelines.
> * Source URL incorrect
Fixed.
> * Per "File and Directory Ownership" (gdm example), there should be
> > Requires: pam
> for {/etc,%_libdir}/security instead of relying on the automatic libpam
> dependency.
Fixed.
> Not sure:
> * I'm not quite happy about
> > ln -sf ../../%{_lib}/libpwquality.so.*.* libpwquality.so
> this only works for some values of %{_libdir}. Using an absolute symlink
> would be more general - OTOH this is not really a concern for Fedora
I do not think we care about hypotetical or third party distributions. This is
Fedora packaging and if %{_libdir} changes significantly we will have to change
the spec probably anyway.
> * If you plan to maintain ChangeLog, please include it in %doc
There is nothing meaningful in it yet. I plan to generate more meaningful
changelog from upstream hg commits.
> Notes:
> * Unnecessary
> > Requires(postun): /sbin/ldconfig
> - the -p interpreter is added automatically
Removed.
> * BuildRoot: is unnecessary
Removed.
> * %global is preferred over %define
Replaced.
> * Consider using (make install ... INSTALL='install -p') to preserve
> timestamps
Added.
Spec URL: http://people.redhat.com/~tmraz/testing/libpwquality.spec
SRPM URL:
http://people.redhat.com/~tmraz/testing/libpwquality-0.9-2.fc17.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 742996] Review Request: libpwquality - A library for password generation and password quality checking
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=742996
Miloslav Trmač changed:
What|Removed |Added
Flag||needinfo?(tm...@redhat.com)
--- Comment #1 from Miloslav Trmač 2011-10-10 09:46:36 EDT ---
rpmlint:
> libpwquality.src: W: spelling-error %description -l en_US cracklib -> crack
> lib, crack-lib, crackling
> libpwquality-devel.x86_64: W: spelling-error %description -l en_US pwquality
> -> quality
> libpwquality.x86_64: W: spelling-error %description -l en_US cracklib ->
> crack lib, crack-lib, crackling
false positives
> libpwquality-devel.x86_64: W: no-documentation
oh well... upstream issue
> libpwquality.x86_64: W: no-manual-page-for-binary pwscore
> libpwquality.x86_64: W: no-manual-page-for-binary pwmake
upstream issue, however would be good to fix soonish
Needs fixing:
* Doesn't build in koji
At least missing BuildRequires: pam-devel
* Licensing problems/uncertainty:
* License field says (BSD and GPLv2+)
* Licensing guidelines require using "or" for dual licensing
* Source files allow BSD or referenced GPL (note: not GPLv2, not GPL+!)
* COPYING contains the same reference to GPL without v2/+, but includes
text of GPLv2
* Source URL incorrect
* Per "File and Directory Ownership" (gdm example), there should be
> Requires: pam
for {/etc,%_libdir}/security instead of relying on the automatic libpam
dependency.
Not sure:
* I'm not quite happy about
> ln -sf ../../%{_lib}/libpwquality.so.*.* libpwquality.so
this only works for some values of %{_libdir}. Using an absolute symlink
would be more general - OTOH this is not really a concern for Fedora
* If you plan to maintain ChangeLog, please include it in %doc
Notes:
* Unnecessary
> Requires(postun): /sbin/ldconfig
- the -p interpreter is added automatically
* BuildRoot: is unnecessary
* %global is preferred over %define
* Consider using (make install ... INSTALL='install -p') to preserve timestamps
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 742996] Review Request: libpwquality - A library for password generation and password quality checking
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=742996 Miloslav Trmač changed: What|Removed |Added Status|NEW |ASSIGNED CC||m...@redhat.com AssignedTo|nob...@fedoraproject.org|m...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
