[Bug 743612] Review Request: lbdb - collect email addresses from several sources and offer them in mutt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=743612 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|lbdb-0.38-2.fc17|lbdb-0.38-2.fc16 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2012-03-17 19:39:20 EDT --- lbdb-0.38-2.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 743612] Review Request: lbdb - collect email addresses from several sources and offer them in mutt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=743612 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version||lbdb-0.38-2.fc17 Resolution|NEXTRELEASE |ERRATA --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2012-03-13 14:31:17 EDT --- lbdb-0.38-2.fc17 has been pushed to the Fedora 17 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 743612] Review Request: lbdb - collect email addresses from several sources and offer them in mutt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=743612 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2012-03-07 03:20:03 EST --- lbdb-0.38-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/lbdb-0.38-2.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 743612] Review Request: lbdb - collect email addresses from several sources and offer them in mutt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=743612 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2012-03-07 03:22:29 EST --- lbdb-0.38-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/lbdb-0.38-2.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 743612] Review Request: lbdb - collect email addresses from several sources and offer them in mutt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=743612 Michael Scherer m...@zarb.org changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|m...@zarb.org -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 743612] Review Request: lbdb - collect email addresses from several sources and offer them in mutt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=743612 Christophe Fergeau cferg...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Christophe Fergeau cferg...@redhat.com 2012-03-06 15:27:49 EST --- New Package SCM Request === Package Name: lbdb Short Description: collect email addresses from several sources and offer them in mutt Owners: teuf Branches: f17 f16 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 743612] Review Request: lbdb - collect email addresses from several sources and offer them in mutt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=743612 --- Comment #7 from Jon Ciesla limburg...@gmail.com 2012-03-06 16:21:44 EST --- Git done (by process-git-requests). Michael, please take ownership of review BZs, thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 743612] Review Request: lbdb - collect email addresses from several sources and offer them in mutt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=743612 Christophe Fergeau cferg...@redhat.com changed: What|Removed |Added Status|NEW |CLOSED Resolution||NEXTRELEASE Last Closed||2012-03-06 17:26:46 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 743612] Review Request: lbdb - collect email addresses from several sources and offer them in mutt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=743612 Michael Scherer m...@zarb.org changed: What|Removed |Added Flag||fedora-review? --- Comment #3 from Michael Scherer m...@zarb.org 2012-03-04 09:16:15 EST --- Christophe, any news ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 743612] Review Request: lbdb - collect email addresses from several sources and offer them in mutt
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=743612
--- Comment #4 from Christophe Fergeau cferg...@redhat.com 2012-03-04
09:42:29 EST ---
Updated the .spec at http://teuf.fedorapeople.org/reviews/lbdb/lbdb.spec , new
srpm at http://teuf.fedorapeople.org/reviews/lbdb/lbdb-0.38-2.fc16.src.rpm
* Sun Mar 04 2012 Christophe Fergeau cferg...@redhat.com - 0.38-2
- add %%{?dist} in release
- remove use of BuildRoot:
- remove use of %%defattr
- remove usage instruction from %%description
- comment patches
I haven't commented about whether the patches have been sent upstream or not
because I don't know, I carried them from the openSUSE package.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 743612] Review Request: lbdb - collect email addresses from several sources and offer them in mutt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=743612 Michael Scherer m...@zarb.org changed: What|Removed |Added CC||m...@zarb.org --- Comment #2 from Michael Scherer m...@zarb.org 2012-01-20 12:24:29 EST --- A few remark : - patchs are not commented, and I think they should explain why they are here, and if pushed upstream or not - Buildroot: should be removed - I think %defattr is deprecated as well - %dist is missing from release I am not sure that the authors name and the setup instruction belong to %description. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 743612] Review Request: lbdb - collect email addresses from several sources and offer them in mutt
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=743612
Matthieu Saulnier casper.le.fan...@gmail.com changed:
What|Removed |Added
CC||casper.le.fan...@gmail.com
--- Comment #1 from Matthieu Saulnier casper.le.fan...@gmail.com 2011-10-05
12:48:10 EDT ---
Hello
This is an informal review
[X] rpmlint must be run on every package.
[X] The package must be named according to the Package Naming Guidelines.
[X] The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[X] The package must meet the Packaging Guidelines.
[X] The package must be licensed with a Fedora approved license and meet the
[X] The License field in the package spec file must match the actual license.
[X] If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for
the package must be included in %doc.
[X] The spec file must be written in American English.
[X] The spec file for the package MUST be legible.
[X] The sources used to build the package must match the upstream source, as
provided in the spec URL.
Upstream md5sum: a8e65f1400c90818ff324dc4fd67eba2
Package md5sum: a8e65f1400c90818ff324dc4fd67eba2
[X] The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
Build successful on Fedora 15 x86_64
[NA] If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[NA] All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional.
[NA] The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[NA] Every binary RPM package (or subpackage) which stores shared library
files(not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.
[X] Packages must NOT bundle copies of system libraries.
[NA] If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[X] A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does
create that directory.
[X] A Fedora package must not list a file more than once in the spec file's
%files listings.
[X] Permissions on files must be set properly. Executables should be set with
executable permissions, for example. Every %files section must include a
%defattr(...) line.
[X] Each package must consistently use macros.
[X] The package must contain code, or permissable content.
[NA] Large documentation files must go in a -doc subpackage.
[X] If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present.
[NA] Header files must be in a -devel package.
[NA] Static libraries must be in a -static package.
[NA] If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
package.
[NA] In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release}.
[X] Packages must NOT contain any .la libtool archives, these must be removed
in the spec if they are built.
[NA] Packages containing GUI applications must include a %{name}.desktop file,
and that file must be properly installed with desktop-file-install in the
%install section.
[X] Packages must not own files or directories already owned by other
packages.
[X] All filenames in rpm packages must be valid UTF-8.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
