[Bug 751568] Review Request: libgxps - library for handling and rendering XPS documents

2011-12-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=751568

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||libgxps-0.2.0-1.fc16
 Resolution||ERRATA
Last Closed||2011-12-11 16:52:21

--- Comment #16 from Fedora Update System upda...@fedoraproject.org 
2011-12-11 16:52:21 EST ---
libgxps-0.2.0-1.fc16 has been pushed to the Fedora 16 stable repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 751568] Review Request: libgxps - library for handling and rendering XPS documents

2011-12-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=751568

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|libgxps-0.2.0-1.fc16|libgxps-0.2.0-1.fc15

--- Comment #17 from Fedora Update System upda...@fedoraproject.org 
2011-12-11 16:55:28 EST ---
libgxps-0.2.0-1.fc15 has been pushed to the Fedora 15 stable repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 751568] Review Request: libgxps - library for handling and rendering XPS documents

2011-12-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=751568

--- Comment #15 from Fedora Update System upda...@fedoraproject.org 
2011-12-01 07:41:09 EST ---
libgxps-0.2.0-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/libgxps-0.2.0-1.fc15

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 751568] Review Request: libgxps - library for handling and rendering XPS documents

2011-12-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=751568

--- Comment #14 from Fedora Update System upda...@fedoraproject.org 
2011-12-01 07:31:51 EST ---
libgxps-0.2.0-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/libgxps-0.2.0-1.fc16

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 751568] Review Request: libgxps - library for handling and rendering XPS documents

2011-11-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=751568

Jon Ciesla l...@jcomserv.net changed:

   What|Removed |Added

 Status|NEW |MODIFIED
 CC||l...@jcomserv.net
   Flag||fedora-review?

--- Comment #3 from Jon Ciesla l...@jcomserv.net 2011-11-23 09:23:21 EST ---
Good:

- rpmlint checks return:

libgxps.x86_64: W: spelling-error Summary(en_US) GObject - G Object, Object
The value of this tag appears to be misspelled. Please double-check.

Ignore.

libgxps.x86_64: E: incorrect-fsf-address /usr/share/doc/libgxps-0.1.0/COPYING
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

Fix at your convenience, not a blocker.

3 packages and 0 specfiles checked; 1 errors, 1 warnings.

- package meets naming guidelines
- package meets packaging guidelines
- license ( LGPLv2+ ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

EXTRA STUFF FOR PACKAGES WITH DEVEL
==

- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r 

Otherwise it's perfect.  Given the practice review, I think I'd like to see one
more practice review, and if that's good then I'll be willing to sponsor you
and approve this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 751568] Review Request: libgxps - library for handling and rendering XPS documents

2011-11-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=751568

--- Comment #4 from Tom Hughes t...@compton.nu 2011-11-23 09:29:43 EST ---
I did actually do another review today - it's this one:
https://bugzilla.redhat.com/show_bug.cgi?id=756321

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 751568] Review Request: libgxps - library for handling and rendering XPS documents

2011-11-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=751568

--- Comment #5 from Tom Hughes t...@compton.nu 2011-11-23 09:37:42 EST ---
I've reported the FSF address issue upstream at
https://bugzilla.gnome.org/show_bug.cgi?id=664644 but it seems that FSF don't
publish an updated LGPLv2 so they may not want to change it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 751568] Review Request: libgxps - library for handling and rendering XPS documents

2011-11-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=751568

--- Comment #6 from Jon Ciesla l...@jcomserv.net 2011-11-23 09:48:23 EST ---
Looks great, do you have a FAS account yet?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 751568] Review Request: libgxps - library for handling and rendering XPS documents

2011-11-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=751568

--- Comment #7 from Tom Hughes t...@compton.nu 2011-11-23 09:52:41 EST ---
Yes - tomh is my FAS account.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 751568] Review Request: libgxps - library for handling and rendering XPS documents

2011-11-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=751568

--- Comment #8 from Jon Ciesla l...@jcomserv.net 2011-11-23 09:58:38 EST ---
Added, sponsored, package APPROVED.  Welcome, use your powers for good, etc. 
Please feel free to ask any questions if you run into trouble or are curious
about anything.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 751568] Review Request: libgxps - library for handling and rendering XPS documents

2011-11-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=751568

Jon Ciesla l...@jcomserv.net changed:

   What|Removed |Added

 Blocks|177841(FE-NEEDSPONSOR)  |

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 751568] Review Request: libgxps - library for handling and rendering XPS documents

2011-11-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=751568

Jon Ciesla l...@jcomserv.net changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 751568] Review Request: libgxps - library for handling and rendering XPS documents

2011-11-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=751568

Tom Hughes t...@compton.nu changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #9 from Tom Hughes t...@compton.nu 2011-11-23 10:14:53 EST ---
New Package SCM Request
===
Package Name: libgxps
Short Description: library for handling and rendering XPS documents
Owners: tomh
Branches: f15 f16
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 751568] Review Request: libgxps - library for handling and rendering XPS documents

2011-11-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=751568

--- Comment #10 from Jon Ciesla l...@jcomserv.net 2011-11-23 10:23:34 EST ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 751568] Review Request: libgxps - library for handling and rendering XPS documents

2011-11-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=751568

Jon Ciesla l...@jcomserv.net changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|l...@jcomserv.net

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 751568] Review Request: libgxps - library for handling and rendering XPS documents

2011-11-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=751568

--- Comment #11 from Fedora Update System upda...@fedoraproject.org 
2011-11-23 11:14:34 EST ---
libgxps-0.1.0-2.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/libgxps-0.1.0-2.fc16

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 751568] Review Request: libgxps - library for handling and rendering XPS documents

2011-11-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=751568

--- Comment #12 from Fedora Update System upda...@fedoraproject.org 
2011-11-23 11:23:49 EST ---
libgxps-0.1.0-2.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/libgxps-0.1.0-2.fc15

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 751568] Review Request: libgxps - library for handling and rendering XPS documents

2011-11-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=751568

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #13 from Fedora Update System upda...@fedoraproject.org 
2011-11-23 18:28:26 EST ---
libgxps-0.1.0-2.fc15 has been pushed to the Fedora 15 testing repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 751568] Review Request: libgxps - library for handling and rendering XPS documents

2011-11-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=751568

Tom Hughes t...@compton.nu changed:

   What|Removed |Added

 Blocks||177841(FE-NEEDSPONSOR)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 751568] Review Request: libgxps - library for handling and rendering XPS documents

2011-11-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=751568

Andy Grover agro...@redhat.com changed:

   What|Removed |Added

 CC||agro...@redhat.com

--- Comment #1 from Andy Grover agro...@redhat.com 2011-11-05 17:03:17 EDT ---
one small nit on the subpackage requires:

http://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package

Requires: %{name}%{?_isa} = %{version}-%{release}

otherwise looks very good to me!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 751568] Review Request: libgxps - library for handling and rendering XPS documents

2011-11-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=751568

--- Comment #2 from Tom Hughes t...@compton.nu 2011-11-05 18:35:41 EDT ---
I've updated the spec file with that change. New spec file and SRPM are here:

http://download.compton.nu/rpms/libgxps.spec
http://download.compton.nu/rpms/libgxps-0.1.0-2.fc15.src.rpm

I've also raised #751582 to suggest that the template for libraries in
rpmdevtool be changed to reflect this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review