[Bug 752454] Review Request: qca-cyrus-sasl - Cyrus-SASL plugin for the Qt Cryptographic Architecture
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752454 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version||clementine-0.7.1-4.fc16.1 Resolution|RAWHIDE |ERRATA --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2012-01-19 16:56:29 EST --- clementine-0.7.1-4.fc16.1, tomahawk-0.3.3-4.fc16, libechonest-1.2.1-1.fc16, qca-cyrus-sasl-2.0.0-0.3.beta3.fc16, jreen-1.0.1-4.fc16, iris-1.0.0-0.10.20110904svn812.fc16, qtweetlib-0.3.0-1.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752454] Review Request: qca-cyrus-sasl - Cyrus-SASL plugin for the Qt Cryptographic Architecture
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752454 --- Comment #6 from Fedora Update System upda...@fedoraproject.org 2012-01-10 18:04:55 EST --- clementine-0.7.1-4.fc16.1,tomahawk-0.3.3-4.fc16,libechonest-1.2.1-1.fc16,qca-cyrus-sasl-2.0.0-0.3.beta3.fc16,jreen-1.0.1-4.fc16,iris-1.0.0-0.10.20110904svn812.fc16,qtweetlib-0.3.0-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/clementine-0.7.1-4.fc16.1,tomahawk-0.3.3-4.fc16,libechonest-1.2.1-1.fc16,qca-cyrus-sasl-2.0.0-0.3.beta3.fc16,jreen-1.0.1-4.fc16,iris-1.0.0-0.10.20110904svn812.fc16,qtweetlib-0.3.0-1.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752454] Review Request: qca-cyrus-sasl - Cyrus-SASL plugin for the Qt Cryptographic Architecture
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752454 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2012-01-09 08:47:56 --- Comment #5 from Rex Dieter rdie...@math.unl.edu 2012-01-09 08:47:56 EST --- imported into rawhide. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752454] Review Request: qca-cyrus-sasl - Cyrus-SASL plugin for the Qt Cryptographic Architecture
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752454 --- Comment #4 from Jon Ciesla limburg...@gmail.com 2012-01-08 17:08:47 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752454] Review Request: qca-cyrus-sasl - Cyrus-SASL plugin for the Qt Cryptographic Architecture v2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752454 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks||731456(jreen) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752454] Review Request: qca-cyrus-sasl - Cyrus-SASL plugin for the Qt Cryptographic Architecture v2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752454 Magnus Tuominen magnus.tuomi...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||magnus.tuomi...@gmail.com AssignedTo|nob...@fedoraproject.org|magnus.tuomi...@gmail.com Flag||fedora-review? --- Comment #1 from Magnus Tuominen magnus.tuomi...@gmail.com 2012-01-07 11:29:28 EST --- Review coming soon. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752454] Review Request: qca-cyrus-sasl - Cyrus-SASL plugin for the Qt Cryptographic Architecture v2
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752454
Magnus Tuominen magnus.tuomi...@gmail.com changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #2 from Magnus Tuominen magnus.tuomi...@gmail.com 2012-01-07
12:21:48 EST ---
review, looking good:
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
rpmlint -iv qca-cyrus-sasl.spec
qca-cyrus-sasl.spec:34: W: configure-without-libdir-spec
A configure script is run without specifying the libdir. configure options
must be augmented with something like --libdir=%{_libdir} whenever the script
supports it.
qca-cyrus-sasl.spec: I: checking-url
http://delta.affinix.com/download/qca/2.0/plugins/qca-cyrus-sasl-2.0.0-beta3.tar.bz2
(timeout 10 seconds)
0 packages and 1 specfiles checked; 0 errors, 1 warnings.
rpmlint ../RPMS/x86_64/qca-cyrus-sasl-*.rpm
qca-cyrus-sasl.x86_64: E: incorrect-fsf-address
/usr/share/doc/qca-cyrus-sasl-2.0.0/COPYING
2 packages and 0 specfiles checked; 1 errors, 0 warnings.
rpmlint -iv ../SRPMS/qca-cyrus-sasl-2.0.0-0.2.beta3.fc16.src.rpm
qca-cyrus-sasl.src: I: checking
qca-cyrus-sasl.src: I: checking-url http://delta.affinix.com/qca/ (timeout 10
seconds)
qca-cyrus-sasl.src:34: W: configure-without-libdir-spec
A configure script is run without specifying the libdir. configure options
must be augmented with something like --libdir=%{_libdir} whenever the script
supports it.
qca-cyrus-sasl.src: I: checking-url
http://delta.affinix.com/download/qca/2.0/plugins/qca-cyrus-sasl-2.0.0-beta3.tar.bz2
(timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
OK
MUST: The package must be named according to the Package Naming Guidelines.
OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
OK
MUST: The package must meet the Packaging Guidelines.
OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK
MUST: The License field in the package spec file must match the actual license.
OK
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
OK
MUST: The spec file must be written in American English.
OK
MUST: The spec file for the package MUST be legible.
OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
src.rpm: db51df751478f60416659809e11990fd
upstream: db51df751478f60416659809e11990fd
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
OK
MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
OK
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
OK
MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
OK
MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
OK
MUST: Packages must NOT bundle copies of system libraries.
OK
MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
OK
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory.
OK
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. (Notable exception: license texts in specific situations)
OK
MUST: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. Every %files section must include a
%defattr(...) line.
OK
MUST: Each package must consistently use macros.
OK
MUST:
[Bug 752454] Review Request: qca-cyrus-sasl - Cyrus-SASL plugin for the Qt Cryptographic Architecture
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752454 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Summary|Review Request: |Review Request: |qca-cyrus-sasl - Cyrus-SASL |qca-cyrus-sasl - Cyrus-SASL |plugin for the Qt |plugin for the Qt |Cryptographic Architecture |Cryptographic Architecture |v2 | Flag||fedora-cvs? --- Comment #3 from Rex Dieter rdie...@math.unl.edu 2012-01-07 13:52:39 EST --- Thanks! New Package SCM Request === Package Name: qca-cyrus-sasl Short Description: Curus-SASL plugin for the Qt Cryptographic Architecture Owners: rdieter Branches: f15 f16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752454] Review Request: qca-cyrus-sasl - Cyrus-SASL plugin for the Qt Cryptographic Architecture v2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752454 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks||656997(kde-reviews) Alias||qca-cyrus-sasl -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
