[Bug 752909] Review Request: libverto - Main loop abstraction library

2011-11-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=752909

--- Comment #3 from Nathaniel McCallum nathan...@natemccallum.com 2011-11-11 
12:34:46 EST ---
Fixed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 752909] Review Request: libverto - Main loop abstraction library

2011-11-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=752909

--- Comment #4 from Nathaniel McCallum nathan...@natemccallum.com 2011-11-11 
13:23:03 EST ---
Spec: http://npmccallum.fedorapeople.org/libverto/libverto.spec
SRPM: http://npmccallum.fedorapeople.org/libverto/libverto-0.2.1-2.fc16.src.rpm
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3508201

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 752909] Review Request: libverto - Main loop abstraction library

2011-11-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=752909

--- Comment #6 from Stephen Gallagher sgall...@redhat.com 2011-11-11 13:32:44 
EST ---
New Package SCM Request
===
Package Name: libverto
Short Description: Main loop abstraction library
Owners: npmccallum
Branches: f16
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 752909] Review Request: libverto - Main loop abstraction library

2011-11-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=752909

Stephen Gallagher sgall...@redhat.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+, fedora-cvs?

--- Comment #5 from Stephen Gallagher sgall...@redhat.com 2011-11-11 13:31:03 
EST ---
Package is approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 752909] Review Request: libverto - Main loop abstraction library

2011-11-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=752909

--- Comment #7 from Jon Ciesla l...@jcomserv.net 2011-11-11 13:36:22 EST ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 752909] Review Request: libverto - Main loop abstraction library

2011-11-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=752909

Nathaniel McCallum nathan...@natemccallum.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE
Last Closed||2011-11-11 17:17:59

--- Comment #8 from Nathaniel McCallum nathan...@natemccallum.com 2011-11-11 
17:17:59 EST ---
Thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 752909] Review Request: libverto - Main loop abstraction library

2011-11-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=752909

--- Comment #1 from Nathaniel McCallum nathan...@natemccallum.com 2011-11-10 
14:01:40 EST ---
Koji build against f17 available here:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3505386

Also, this package is a new dependency of mit krb5 1.10.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 752909] Review Request: libverto - Main loop abstraction library

2011-11-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=752909

Stephen Gallagher sgall...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||sgall...@redhat.com
 AssignedTo|nob...@fedoraproject.org|sgall...@redhat.com
   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 752909] Review Request: libverto - Main loop abstraction library

2011-11-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=752909

--- Comment #2 from Stephen Gallagher sgall...@redhat.com 2011-11-10 16:46:09 
EST ---
[sgallagh@sgallagh520 review]$ rpmlint ~/rpmbuild/RPMS/x86_64/*.rpm
libverto.x86_64: W: spelling-error %description -l en_US io - oi, Io, ii
libverto-devel.x86_64: W: no-documentation
libverto-glib.x86_64: W: summary-not-capitalized C glib module for libverto
libverto-glib.x86_64: W: no-documentation
libverto-glib-devel.x86_64: W: no-documentation
libverto-libev.x86_64: W: summary-not-capitalized C libev module for libverto
libverto-libev.x86_64: W: spelling-error %description -l en_US io - oi, Io, ii
libverto-libev.x86_64: W: no-documentation
libverto-libev-devel.x86_64: W: spelling-error %description -l en_US io - oi,
Io, ii
libverto-libev-devel.x86_64: W: no-documentation
libverto-libevent.x86_64: W: summary-not-capitalized C libevent module for
libverto
libverto-libevent.x86_64: W: no-documentation
libverto-libevent-devel.x86_64: W: no-documentation
libverto-tevent.x86_64: W: summary-not-capitalized C tevent module for libverto
libverto-tevent.x86_64: W: spelling-error %description -l en_US io - oi, Io,
ii
libverto-tevent.x86_64: W: no-documentation
libverto-tevent-devel.x86_64: W: no-documentation
11 packages and 0 specfiles checked; 0 errors, 17 warnings.

MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name}%{?_isa} =
%{version}-%{release}

This is not met. The {?_isa} is missing.

So, fix that one minor issue and I will approve this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review