[Bug 753016] gcr - A library for bits of crypto UI and parsing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753016 Matthias Clasen changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2011-12-22 09:13:09 --- Comment #12 from Matthias Clasen 2011-12-22 09:13:09 EST --- build underway -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753016] gcr - A library for bits of crypto UI and parsing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753016 Tom Hughes changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|t...@compton.nu --- Comment #11 from Tom Hughes 2011-12-22 08:25:06 EST --- I thought I had... To be more precise I thought setting the state to ASSIGNED assigned it to the person making that change, at least by default. Apparently I was wrong, at least in this particular implementation of bugzilla. Done now anyway. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753016] gcr - A library for bits of crypto UI and parsing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753016 --- Comment #10 from Jon Ciesla 2011-12-22 08:18:49 EST --- Git done (by process-git-requests). Tom, please take ownership of review BZs. Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753016] gcr - A library for bits of crypto UI and parsing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753016 Matthias Clasen changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753016] gcr - A library for bits of crypto UI and parsing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753016 --- Comment #9 from Matthias Clasen 2011-12-21 17:00:43 EST --- New Package SCM Request === Package Name: gcr Short Description: A library for bits of crypto UI and parsing Owners: mclasen, tbzatek Branches: InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753016] gcr - A library for bits of crypto UI and parsing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753016 Tom Hughes changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #8 from Tom Hughes 2011-12-21 14:39:04 EST --- Looks good. Package is approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753016] gcr - A library for bits of crypto UI and parsing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753016 --- Comment #7 from Matthias Clasen 2011-12-21 13:48:00 EST --- http://mclasen.fedorapeople.org/gcr.spec http://mclasen.fedorapeople.org/gcr-3.3.3.1-3.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753016] gcr - A library for bits of crypto UI and parsing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753016 --- Comment #6 from Tom Hughes 2011-12-21 13:31:58 EST --- Sure it's OK not to require some of those, but if you do that then you have to own the directory instead, as described in the packaging guidelines here: https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753016] gcr - A library for bits of crypto UI and parsing
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=753016
--- Comment #5 from Matthias Clasen 2011-12-21 12:45:59
EST ---
http://mclasen.fedorapeople.org/gcr.spec
http://mclasen.fedorapeople.org/gcr-3.3.3.1-2.fc16.src.rpm
I've deleted the rpaths.
As for the directories,
- hicolor-icon-theme is a dependency of gtk3
- shared-mime-info gets pulled in by glib2
- dbus is a dependency of systemd, so kinda unavoidable
- gtk-doc has been ruled by the packaging committee to be ok to omit
- GConf2 is pretty much in the same situation as gtk-doc, I'd say.
gcr does not actually use GConf, it merely installs convert files
to trigger conversion of preexisting gconf keys to gsettings. The
directory it installs those conversion files in is pure 'file drop',
much like %{_datadir}/gtk-doc/html. And given that the purpose
of these conversion files is to help getting rid of GConf, it
would be just wrong to add a GConf dependency for them.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753016] gcr - A library for bits of crypto UI and parsing
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=753016
--- Comment #4 from Tom Hughes 2011-12-21 10:52:19 EST ---
Mostly looks good, just a couple more comments:
MUST Package requires other packages for directories it uses.
MUST Package must own all directories that it creates.
need GConf2 for %{_datadir}/GConf/gsettings
need hicolor-icon-theme for %{_datadir}/icons/hicolor
need shared-mime-info for %{_datadir}/mime/packages
need dbus for %{_datadir}/dbus-1/services
need gtk-doc for %{_datadir}/gtk-doc/html
Some of those may already be required indirectly, but I haven't found a goot
way to work our the full list of indirect requirements.
MUST Rpath absent or only used for internal libs.
MUST Rpmlint output is silent.
gcr.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libgcr-3.so.1.0.0
['/usr/lib64']
gcr.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/gcr-viewer ['/usr/lib64']
gcr.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libgcr-base-3.so.1.0.0
['/usr/lib64']
gcr.x86_64: E: binary-or-shlib-defines-rpath /usr/libexec/gcr-prompter
['/usr/lib64']
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753016] gcr - A library for bits of crypto UI and parsing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753016 --- Comment #3 from Matthias Clasen 2011-12-21 08:58:53 EST --- Updated again for gcr-3.3.3.1. The build fix is no longer needed, and the license thing has been fixed upstream. http://mclasen.fedorapeople.org/gcr.spec http://mclasen.fedorapeople.org/gcr-3.3.3.1-1.fc16.src.rpm Can we wrap this up soon ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753016] gcr - A library for bits of crypto UI and parsing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753016 --- Comment #2 from Matthias Clasen 2011-12-16 12:40:51 EST --- I've filed an upstream bug about the minor license inconsistencies: https://bugzilla.gnome.org/show_bug.cgi?id=666378 Here is an updated srpm for gcr-3.3.2.1. Also added a comment about the patch. http://mclasen.fedorapeople.org/gcr.spec http://mclasen.fedorapeople.org/gcr-3.3.2.1-1.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753016] gcr - A library for bits of crypto UI and parsing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753016 Tom Hughes changed: What|Removed |Added Status|NEW |ASSIGNED CC||t...@compton.nu Flag||fedora-review? --- Comment #1 from Tom Hughes 2011-12-16 06:23:35 EST --- Initial review comments: MUST License field in the package spec file matches the actual license gcr/icons/render-icons.py is LGPLv3 / CC-BY-SA 3.0 gcr/gcr-menu-button.c is GPLv2 gcr/gcr-collection-model.c is GPLv2 gcr/gcr-collection-model.h is GPLv2 gck/pkcs11n.h is MPLv1.1 MUST Rpmlint output is silent gcr.x86_64: E: incorrect-fsf-address /usr/share/doc/gcr-3.3.1/COPYING gcr.x86_64: W: no-manual-page-for-binary gcr-viewer gcr-devel.x86_64: E: incorrect-fsf-address /usr/include/gcr-3/gcr/gcr-key-widget.h [ repeated for many other header files ] gcr-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gcr-3.3.1/gcr/gcr-unlock-options-widget.h [ repeated for many other source files ] SHOULD Patches link to upstream bugs/comments/lists or are otherwise justified No explanation for gcr-fix.patch -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
