[Bug 755104] Review Request: condor-wallaby - condor related tools for interacting with wallaby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755104 --- Comment #11 from Fedora Update System 2012-01-25 17:35:14 EST --- condor-wallaby-4.1.2-3.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755104] Review Request: condor-wallaby - condor related tools for interacting with wallaby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755104 --- Comment #10 from Fedora Update System 2012-01-25 17:30:51 EST --- condor-wallaby-4.1.2-3.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755104] Review Request: condor-wallaby - condor related tools for interacting with wallaby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755104 --- Comment #8 from Fedora Update System 2012-01-11 16:44:06 EST --- condor-wallaby-4.1.2-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/condor-wallaby-4.1.2-3.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755104] Review Request: condor-wallaby - condor related tools for interacting with wallaby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755104 --- Comment #9 from Fedora Update System 2012-01-11 16:44:56 EST --- condor-wallaby-4.1.2-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/condor-wallaby-4.1.2-3.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755104] Review Request: condor-wallaby - condor related tools for interacting with wallaby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755104 --- Comment #7 from Fedora Update System 2012-01-10 15:36:23 EST --- condor-wallaby-4.1.2-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/condor-wallaby-4.1.2-2.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755104] Review Request: condor-wallaby - condor related tools for interacting with wallaby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755104 Robert Rati changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution||NEXTRELEASE Last Closed||2012-01-10 15:33:27 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755104] Review Request: condor-wallaby - condor related tools for interacting with wallaby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755104 --- Comment #6 from Fedora Update System 2012-01-10 15:35:15 EST --- condor-wallaby-4.1.2-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/condor-wallaby-4.1.2-2.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755104] Review Request: condor-wallaby - condor related tools for interacting with wallaby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755104 --- Comment #5 from Jon Ciesla 2012-01-10 12:13:19 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755104] Review Request: condor-wallaby - condor related tools for interacting with wallaby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755104 Robert Rati changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Robert Rati 2012-01-10 11:56:42 EST --- New Package SCM Request === Package Name: condor-wallaby Short Description: condor specific tools for interacting with wallaby Owners: rrati Branches: f15 f16 InitialCC: matt -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755104] Review Request: condor-wallaby - condor related tools for interacting with wallaby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755104 Nuno Santos changed: What|Removed |Added Status|ASSIGNED|MODIFIED Flag||fedora-review+ --- Comment #3 from Nuno Santos 2012-01-10 11:49:35 EST --- I've checked the fixes and have re-reviewed the affected parts: OK - MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. md5sums match: $ rpm2cpio condor-wallaby-4.1.2-2.fc15.src.rpm | cpio -ivd ; md5sum condor-wallaby-4.1.2.tar.gz 0001-Packaging-improvements-for-building-on-fedora.patch 0002-Packaging-fixes.patch 0003-Workflow-and-packaging-improvements.patch 0004-Bumped-spec-to-4.1.2-2.patch condor-wallaby-4.1.2.tar.gz condor-wallaby.spec 261 blocks 2bc4dfcf7e6e3368c8a33d43af29406f condor-wallaby-4.1.2.tar.gz $ wget https://fedorahosted.org/releases/g/r/grid/condor-wallaby-4.1.2.tar.gz ; md5sum condor-wallaby-4.1.2.tar.gz --2012-01-10 11:38:51-- https://fedorahosted.org/releases/g/r/grid/condor-wallaby-4.1.2.tar.gz Resolving fedorahosted.org... 66.135.62.191 Connecting to fedorahosted.org|66.135.62.191|:443... connected. HTTP request sent, awaiting response... 200 OK Length: 51416 (50K) [application/x-gzip] Saving to: “condor-wallaby-4.1.2.tar.gz” 100%[==>] 51,416 199K/s in 0.3s 2012-01-10 11:38:52 (199 KB/s) - “condor-wallaby-4.1.2.tar.gz” saved [51416/51416] 2bc4dfcf7e6e3368c8a33d43af29406f condor-wallaby-4.1.2.tar.gz OK - MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. $ mock -r fedora-rawhide-i386 condor-wallaby-4.1.2-2.fc15.src.rpm INFO: mock.py version 1.1.18 starting... State Changed: init plugins INFO: selinux enabled State Changed: start INFO: Start(condor-wallaby-4.1.2-2.fc15.src.rpm) Config(fedora-rawhide-i386) State Changed: lock buildroot State Changed: clean INFO: chroot (/var/lib/mock/fedora-rawhide-i386) unlocked and deleted State Changed: unlock buildroot State Changed: init State Changed: lock buildroot Mock Version: 1.1.18 INFO: Mock Version: 1.1.18 INFO: calling preinit hooks INFO: enabled root cache INFO: root cache aged out! cache will be rebuilt INFO: enabled yum cache State Changed: cleaning yum metadata INFO: enabled ccache State Changed: running yum State Changed: creating cache State Changed: unlock buildroot INFO: Installed packages: State Changed: setup State Changed: build INFO: Done(condor-wallaby-4.1.2-2.fc15.src.rpm) Config(fedora-rawhide-i386) 4 minutes 16 seconds INFO: Results and/or logs in: /var/lib/mock/fedora-rawhide-i386/result State Changed: end OK - MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review. $ rpmlint /var/lib/mock/fedora-rawhide-i386/result/condor-wallaby*.rpm condor-wallaby.src:41: W: unversioned-explicit-obsoletes condor-remote-configuration condor-wallaby.src:61: W: unversioned-explicit-obsoletes condor-remote-configuration-server condor-wallaby-client.noarch: W: non-conffile-in-etc /etc/condor/config.d/99configd.config condor-wallaby-client.noarch: W: no-manual-page-for-binary condor_configd 2 packages and 0 specfiles checked; 0 errors, 4 warnings. (Warnings have been explained in earlier comments) * tarfile issue has been fixed as well: $ tar -xvzf condor-wallaby-4.1.2.tar.gz condor-wallaby-4.1.2/ condor-wallaby-4.1.2/LICENSE-2.0.txt condor-wallaby-4.1.2/Makefile condor-wallaby-4.1.2/README condor-wallaby-4.1.2/condor-wallaby.spec condor-wallaby-4.1.2/condor_configd condor-wallaby-4.1.2/condor_configure_pool condor-wallaby-4.1.2/condor_configure_store condor-wallaby-4.1.2/config/ condor-wallaby-4.1.2/config/99configd.config condor-wallaby-4.1.2/config/pidkill.bat condor-wallaby-4.1.2/doc/ condor-wallaby-4.1.2/doc/condor_configure_pool.1 condor-wallaby-4.1.2/doc/condor_configure_store.1 condor-wallaby-4.1.2/module/ condor-wallaby-4.1.2/module/WallabyHelpers.py condor-wallaby-4.1.2/module/WallabyTypes.py condor-wallaby-4.1.2/module/__init__.py condor-wallaby-4.1.2/module/exceptions.py condor-wallaby-4.1.2/test/ condor-wallaby-4.1.2/test/override.param condor-wallaby-4.1.2/test/override/ condor-wallaby-4.1.2/test/override/.gitignore condor-wallaby-4.1.2/test/store.rb condor-wallaby-4.1.2/test/test_driver.py condor-wallaby-4.1.2/test/test_procedures.txt == It all looks good now, package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail
[Bug 755104] Review Request: condor-wallaby - condor related tools for interacting with wallaby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755104 --- Comment #2 from Robert Rati 2012-01-06 11:27:21 EST --- Fixed the issues, with a few exceptions. The obsolete not provided is for a package that never existed in fedora. I've handled it with a conditional for the binaries, but the srpm will still show the warning. I've also changed the config without noreplace file to a regular non-config file. The file is in /etc, but contains condor config snipets that shouldn't be edited by the user. If the user wants to modify things, they should create their own config file and have it parsed last. Spec URL: http://rrati.fedorapeople.org/condor-wallaby.spec SRPM URL: http://rrati.fedorapeople.org/condor-wallaby-4.1.2-2.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755104] Review Request: condor-wallaby - condor related tools for interacting with wallaby
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755104
Nuno Santos changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||nsan...@redhat.com
AssignedTo|nob...@fedoraproject.org|nsan...@redhat.com
--- Comment #1 from Nuno Santos 2011-12-22 10:58:19 EST ---
I've reviewed the package, comments below in the guidelines template:
See notes - MUST: rpmlint must be run on the source rpm and all binary rpms the
build produces. The output should be posted in the review.
$ rpmlint /var/lib/mock/fedora-rawhide-i386/result/condor-wallaby*.rpm
condor-wallaby.src:36: W: unversioned-explicit-obsoletes
condor-remote-configuration
condor-wallaby.src:54: W: unversioned-explicit-obsoletes
condor-remote-configuration-server
condor-wallaby.src: W: no-%build-section
condor-wallaby.src: W: invalid-url Source0: condor-wallaby-4.1.2.tar.gz
condor-wallaby-client.noarch: W: obsolete-not-provided
condor-remote-configuration
condor-wallaby-client.noarch: W: conffile-without-noreplace-flag
/etc/condor/config.d/99configd.config
condor-wallaby-client.noarch: W: no-manual-page-for-binary condor_configd
2 packages and 0 specfiles checked; 0 errors, 7 warnings.
NOTES: no build section, invalid url for source, obsolete not provided, and
config file without noreplace flag warnings should be fixed
OK - MUST: The package must be named according to the Package Naming Guidelines
.
OK - MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.
OK - MUST: The package must meet the Packaging Guidelines .
OK (ASL 2.0) - MUST: The package must be licensed with a Fedora approved
license and meet the Licensing Guidelines .
OK - MUST: The License field in the package spec file must match the actual
license.
OK - MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
OK - MUST: The spec file must be written in American English.
OK - MUST: The spec file for the package MUST be legible.
See notes - MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task.
If no upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
NOTES: unable to check md5sums, is it possible to get the tarfile upstream?
OK - MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
$ mock -r fedora-rawhide-i386 condor-wallaby-4.1.2-1.fc15.src.rpm
INFO: mock.py version 1.1.18 starting...
State Changed: init plugins
INFO: selinux enabled
State Changed: start
INFO: Start(condor-wallaby-4.1.2-1.fc15.src.rpm) Config(fedora-rawhide-i386)
State Changed: lock buildroot
State Changed: clean
INFO: chroot (/var/lib/mock/fedora-rawhide-i386) unlocked and deleted
State Changed: unlock buildroot
State Changed: init
State Changed: lock buildroot
Mock Version: 1.1.18
INFO: Mock Version: 1.1.18
INFO: calling preinit hooks
INFO: enabled root cache
State Changed: unpacking root cache
INFO: enabled yum cache
State Changed: cleaning yum metadata
INFO: enabled ccache
State Changed: running yum
State Changed: unlock buildroot
INFO: Installed packages:
State Changed: setup
State Changed: build
INFO: Done(condor-wallaby-4.1.2-1.fc15.src.rpm) Config(fedora-rawhide-i386) 2
minutes 17 seconds
INFO: Results and/or logs in: /var/lib/mock/fedora-rawhide-i386/result
State Changed: end
NA - MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
OK - MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
NA - MUST: The spec file MUST handle locales properly. This is done by using
the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
NA - MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
OK - MUST: Packages must NOT bundle copies of system libraries.
NA - MUST: If the package is designed to be reloc
