[Bug 756445] Review Request: tor-arm - Terminal status monitor for Tor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756445 Fedora Update System changed: What|Removed |Added Fixed In Version|tor-arm-1.4.4.1-12.fc15 |tor-arm-1.4.4.1-12.fc17 --- Comment #24 from Fedora Update System 2012-05-04 19:06:17 EDT --- tor-arm-1.4.4.1-12.fc17 has been pushed to the Fedora 17 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756445] Review Request: tor-arm - Terminal status monitor for Tor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756445 Fedora Update System changed: What|Removed |Added Fixed In Version|tor-arm-1.4.4.1-12.fc16 |tor-arm-1.4.4.1-12.fc15 --- Comment #23 from Fedora Update System 2012-05-03 18:54:32 EDT --- tor-arm-1.4.4.1-12.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756445] Review Request: tor-arm - Terminal status monitor for Tor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756445 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||tor-arm-1.4.4.1-12.fc16 Resolution||ERRATA Last Closed||2012-05-03 18:51:54 --- Comment #22 from Fedora Update System 2012-05-03 18:51:54 EDT --- tor-arm-1.4.4.1-12.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756445] Review Request: tor-arm - Terminal status monitor for Tor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756445 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #21 from Fedora Update System 2012-05-02 16:32:43 EDT --- tor-arm-1.4.4.1-12.fc17 has been pushed to the Fedora 17 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756445] Review Request: tor-arm - Terminal status monitor for Tor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756445 --- Comment #20 from Fedora Update System 2012-05-02 11:30:08 EDT --- tor-arm-1.4.4.1-12.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/tor-arm-1.4.4.1-12.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756445] Review Request: tor-arm - Terminal status monitor for Tor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756445 --- Comment #19 from Fedora Update System 2012-05-02 11:25:34 EDT --- tor-arm-1.4.4.1-12.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/tor-arm-1.4.4.1-12.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756445] Review Request: tor-arm - Terminal status monitor for Tor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756445 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756445] Review Request: tor-arm - Terminal status monitor for Tor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756445 --- Comment #18 from Fedora Update System 2012-05-02 03:44:46 EDT --- tor-arm-1.4.4.1-12.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/tor-arm-1.4.4.1-12.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756445] Review Request: tor-arm - Terminal status monitor for Tor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756445 --- Comment #17 from Jon Ciesla 2012-04-29 16:56:14 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756445] Review Request: tor-arm - Terminal status monitor for Tor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756445 --- Comment #16 from Juan Orti Alcaine 2012-04-29 15:18:41 EDT --- New Package SCM Request === Package Name: tor-arm Short Description: Terminal status monitor for Tor Owners: jorti Branches: f15 f16 f17 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756445] Review Request: tor-arm - Terminal status monitor for Tor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756445 Juan Orti Alcaine changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756445] Review Request: tor-arm - Terminal status monitor for Tor
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=756445
Brendan Jones changed:
What|Removed |Added
Flag||fedora-review+
--- Comment #15 from Brendan Jones 2012-04-27
11:23:14 EDT ---
This package is APPROVED.
You can safely ignore all issues below.
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
C/C++
[x]: MUST Header files in -devel subpackage, if present.
[x]: MUST Package does not contain any libtool archives (.la)
[x]: MUST Package does not contain kernel modules.
[x]: MUST Package contains no static executables.
[x]: MUST Rpath absent or only used for internal libs.
[x]: MUST Package is not relocatable.
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[!]: MUST Buildroot is not present
Note: Buildroot is not needed unless packager plans to package for EPEL5
This is OK
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean is needed only if supporting EPEL
This is OK
[ ]: MUST Sources contain only permissible code or content.
[!]: MUST Each %files section contains %defattr if rpm < 4.4
Note: defattr() present in %files section. This is OK if packaging
for EPEL5. Otherwise not needed
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package contains a properly installed %{name}.desktop using desktop-
file-install file if it is a GUI application.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Fully versioned dependency in subpackages, if present.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf is only needed if supporting EPEL5
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST License file installed when any subpackage combination is installed.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.
rpmlint tor-arm-1.4.4.1-12.fc18.src.rpm
tor-arm.src: W: spelling-error %description -l en_US anonymizing ->
anatomizing, canonizing, anodizing
tor-arm.src: W: spelling-error %description -l en_US tty -> try, ttys, atty
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
rpmlint tor-arm-1.4.4.1-12.fc18.noarch.rpm
tor-arm.noarch: W: spelling-error %description -l en_US anonymizing ->
anatomizing, canonizing, anodizing
tor-arm.noarch: W: spelling-error %description -l en_US tty -> try, ttys, atty
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
rpmlint tor-arm-devel-1.4.4.1-12.fc18.noarch.rpm
tor-arm-devel.noarch: W: spelling-error %description -l en_US setuid -> setup
tor-arm-devel.noarch: W: spelling-error %description -l en_US config -> con
fig, con-fig, configure
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
This is OK
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
/home/bsjones/rpmbuild/SPECS/arm-1.4.4.1.tar.bz2 :
MD5SUM this package : a3bb93f7d7589bbc54c9b2d4e24d878b
MD5SUM upstream package : a3bb93f7d7589bbc54c9b2d4e24d878b
[x]: MUST Spec file is legible and writt
[Bug 756445] Review Request: tor-arm - Terminal status monitor for Tor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756445 Juan Orti Alcaine changed: What|Removed |Added Depends on||756443, 756435 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756445] Review Request: tor-arm - Terminal status monitor for Tor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756445 --- Comment #14 from Juan Orti Alcaine 2012-04-25 17:06:44 EDT --- Spec: https://github.com/jorti/arm-fedora-package/raw/v1.4.4.1-12/SPECS/tor-arm.spec SRPM: https://github.com/jorti/arm-fedora-package/raw/v1.4.4.1-12/SRPMS/tor-arm-1.4.4.1-12.fc16.src.rpm I will leave the datadir as is, I've done some tests and it breaks in several ways. I have created the devel subpackage with the example source code, and added the wildcard to the man page. Hope everything is ok. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756445] Review Request: tor-arm - Terminal status monitor for Tor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756445 --- Comment #13 from Brendan Jones 2012-04-25 07:43:08 EDT --- Looking good for approval, just use .* instead .gz for your man file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756445] Review Request: tor-arm - Terminal status monitor for Tor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756445 --- Comment #12 from Brendan Jones 2012-04-25 07:36:09 EDT --- OK, up to you. Unless it will cause issues with dependant packages, I'd still recommend prefixing with tor-, but I will leave it up to you to decide. Main package should not contain *.c or *.h files, create a -devel sub-package instead requiring the main package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756445] Review Request: tor-arm - Terminal status monitor for Tor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756445 --- Comment #11 from Juan Orti Alcaine 2012-04-25 04:07:47 EDT --- (In reply to comment #10) > I'm not comfortable with the name of the binary or the datadir directory given > the recent push for arm as a primary arch, can we use the package name > instead, > or will this cause problems? I'm not sure about the implications of changing the name of the directory, also in Debian it's packaged this way without problem. For example you don't have a binary called x86_64. I would prefer staying close to upstream in the directory layout. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756445] Review Request: tor-arm - Terminal status monitor for Tor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756445 --- Comment #10 from Brendan Jones 2012-04-24 22:39:18 EDT --- I'm not comfortable with the name of the binary or the datadir directory given the recent push for arm as a primary arch, can we use the package name instead, or will this cause problems? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756445] Review Request: tor-arm - Terminal status monitor for Tor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756445 Brendan Jones changed: What|Removed |Added Status|NEW |ASSIGNED CC||brendan.jones...@gmail.com AssignedTo|nob...@fedoraproject.org|brendan.jones...@gmail.com --- Comment #9 from Brendan Jones 2012-04-24 21:27:32 EDT --- I will take this review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756445] Review Request: tor-arm - Terminal status monitor for Tor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756445 Juan Orti Alcaine changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756445] Review Request: tor-arm - Terminal status monitor for Tor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756445 --- Comment #8 from Juan Orti Alcaine 2012-04-19 11:55:36 EDT --- I have removed the Tor onion from the icon because there are some trademark issues with it. Now the icon is only based in the Oxygen theme, which is dual licensed with Creative Common Attribution-ShareAlike 3.0 License or the GNU Library General Public License. http://www.oxygen-icons.org/ Hope everything is allright now. SPEC: https://raw.github.com/jorti/arm-fedora-package/v1.4.4.1-10/SPECS/tor-arm.spec SRPM: https://github.com/jorti/arm-fedora-package/raw/v1.4.4.1-10/SRPMS/tor-arm-1.4.4.1-10.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756445] Review Request: tor-arm - Terminal status monitor for Tor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756445 --- Comment #7 from Juan Orti Alcaine 2012-04-19 07:37:13 EDT --- I have updated the build/install commands as you said and removed TorCtl afterwards. Also I have included a desktop file and a icon, I asked upstream about including them in future releases. SPEC: https://github.com/jorti/arm-fedora-package/raw/v1.4.4.1-9/SPECS/tor-arm.spec SRPM: https://github.com/jorti/arm-fedora-package/raw/v1.4.4.1-9/SRPMS/tor-arm-1.4.4.1-9.fc16.src.rpm Rpmlint output: tor-arm.src: W: spelling-error %description -l en_US anonymizing -> anatomizing, canonizing, anodizing tor-arm.src: W: spelling-error %description -l en_US tty -> try, ttys, atty tor-arm.noarch: W: spelling-error %description -l en_US anonymizing -> anatomizing, canonizing, anodizing tor-arm.noarch: W: spelling-error %description -l en_US tty -> try, ttys, atty 2 packages and 1 specfiles checked; 0 errors, 4 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756445] Review Request: tor-arm - Terminal status monitor for Tor
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=756445
Tom "spot" Callaway changed:
What|Removed |Added
CC||tcall...@redhat.com
--- Comment #6 from Tom "spot" Callaway 2012-04-16
16:38:47 EDT ---
I'm not sure why this package doesn't look like this:
%build
%{__python} setup.py build
%install
rm -rf %{buildroot}
%{__python} setup.py install --skip-build --root=%{buildroot}
(The Python packaging guidelines need an overhaul, I know, but this is the
default for noarch python packages that have setup.py.)
Are you doing this to avoid having it include its local copy of TorCtl?
Seems like it might be easier to simply add:
# This lives in pytorctl
rm -rf %{buildroot}%{_datadir}/%{realname}/TorCtl
*
Also, there should probably be a tor-arm.desktop file which runs arm -g.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756445] Review Request: tor-arm - Terminal status monitor for Tor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756445 --- Comment #5 from Juan Orti Alcaine 2012-04-12 07:57:19 EDT --- (In reply to comment #4) > I think the code should go in %doc, since that's a example. I moved it to %doc SPEC: https://raw.github.com/jorti/arm-fedora-package/v1.4.4.1-8/SPECS/tor-arm.spec SRPM: https://github.com/jorti/arm-fedora-package/raw/v1.4.4.1-8/SRPMS/tor-arm-1.4.4.1-8.fc16.src.rpm Rpmlint output: tor-arm.noarch: W: spelling-error %description -l en_US anonymizing -> anatomizing, canonizing, anodizing tor-arm.noarch: W: spelling-error %description -l en_US tty -> try, ttys, atty tor-arm.src: W: spelling-error %description -l en_US anonymizing -> anatomizing, canonizing, anodizing tor-arm.src: W: spelling-error %description -l en_US tty -> try, ttys, atty 2 packages and 1 specfiles checked; 0 errors, 4 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756445] Review Request: tor-arm - Terminal status monitor for Tor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756445 Michael Scherer changed: What|Removed |Added CC||m...@zarb.org --- Comment #4 from Michael Scherer 2012-03-04 14:15:29 EST --- I think the code should go in %doc, since that's a example. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756445] Review Request: tor-arm - Terminal status monitor for Tor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756445 --- Comment #3 from Juan Orti Alcaine 2011-12-22 08:14:50 EST --- A new update to the package: Spec URL: https://raw.github.com/jorti/arm-fedora-package/v1.4.4.1-7/SPECS/tor-arm.spec SRPM URL: https://github.com/jorti/arm-fedora-package/raw/v1.4.4.1-7/SRPMS/tor-arm-1.4.4.1-7.fc16.src.rpm The rpmlint output is: $ rpmlint RPMS/noarch/tor-arm-1.4.4.1-7.fc16.noarch.rpm SRPMS/tor-arm-1.4.4.1-7.fc16.src.rpm SPECS/tor-arm.spec tor-arm.noarch: W: spelling-error %description -l en_US anonymizing -> anatomizing, canonizing, anodizing tor-arm.noarch: W: spelling-error %description -l en_US tty -> try, ttys, atty tor-arm.noarch: W: devel-file-in-non-devel-package /usr/share/arm/resources/torrcOverride/override.c tor-arm.noarch: W: devel-file-in-non-devel-package /usr/share/arm/resources/torrcOverride/override.h tor-arm.src: W: spelling-error %description -l en_US anonymizing -> anatomizing, canonizing, anodizing tor-arm.src: W: spelling-error %description -l en_US tty -> try, ttys, atty 2 packages and 1 specfiles checked; 0 errors, 6 warnings. About the devel-file-in-non-devel-package warning, it's the source code of a wrapper provided as example if you want to run arm as root to be able to reconfigure the daemon it connects to. I'm not very sure what to do about this, I left it untouched. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756445] Review Request: tor-arm - Terminal status monitor for Tor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756445 --- Comment #2 from Juan Orti Alcaine 2011-12-14 05:37:15 EST --- I have updated the Spec file: Spec URL: https://raw.github.com/jorti/arm-fedora-package/v1.4.4.1-6/SPECS/tor-arm.spec SRPM URL: https://github.com/jorti/arm-fedora-package/raw/v1.4.4.1-6/SRPMS/tor-arm-1.4.4.1-6.fc16.src.rpm Rpmlint output: $ rpmlint SPECS/tor-arm.spec RPMS/noarch/tor-arm-1.4.4.1-6.fc16.noarch.rpm SRPMS/tor-arm-1.4.4.1-6.fc16.src.rpm tor-arm.noarch: W: spelling-error %description -l en_US anonymizing -> anatomizing, canonizing, anodizing tor-arm.noarch: W: spelling-error %description -l en_US tty -> try, ttys, atty tor-arm.noarch: W: devel-file-in-non-devel-package /usr/share/arm/resources/torrcOverride/override.c tor-arm.noarch: W: devel-file-in-non-devel-package /usr/share/arm/resources/torrcOverride/override.h tor-arm.src: W: spelling-error %description -l en_US anonymizing -> anatomizing, canonizing, anodizing tor-arm.src: W: spelling-error %description -l en_US tty -> try, ttys, atty 2 packages and 1 specfiles checked; 0 errors, 6 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756445] Review Request: tor-arm - Terminal status monitor for Tor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756445 --- Comment #1 from Juan Orti Alcaine 2011-11-23 11:09:55 EST --- I have separated in different packages some libraries needed by this program. They are waiting for review too: cagraph: https://bugzilla.redhat.com/show_bug.cgi?id=756443 pytorctl: https://bugzilla.redhat.com/show_bug.cgi?id=756435 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756445] Review Request: tor-arm - Terminal status monitor for Tor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756445 Juan Orti Alcaine changed: What|Removed |Added CC||j.orti.alca...@gmail.com Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
