[Bug 756776] Review Request: mingw-libosinfo - MinGW Windows libvirt virtualization library
https://bugzilla.redhat.com/show_bug.cgi?id=756776 Fedora Update System changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA Last Closed||2012-09-23 01:05:57 --- Comment #11 from Fedora Update System --- mingw-libosinfo-0.2.0-1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756776] Review Request: mingw-libosinfo - MinGW Windows libvirt virtualization library
https://bugzilla.redhat.com/show_bug.cgi?id=756776 --- Comment #10 from Fedora Update System --- mingw-libosinfo-0.2.0-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/mingw-libosinfo-0.2.0-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756776] Review Request: mingw-libosinfo - MinGW Windows libvirt virtualization library
https://bugzilla.redhat.com/show_bug.cgi?id=756776 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756776] Review Request: mingw-libosinfo - MinGW Windows libvirt virtualization library
https://bugzilla.redhat.com/show_bug.cgi?id=756776 --- Comment #9 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756776] Review Request: mingw-libosinfo - MinGW Windows libvirt virtualization library
https://bugzilla.redhat.com/show_bug.cgi?id=756776 Daniel Berrange changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Daniel Berrange --- New Package SCM Request === Package Name: mingw-libosinfo Short Description: Library for managing OS information for virtualization Owners: berrange Branches: f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756776] Review Request: mingw-libosinfo - MinGW Windows libvirt virtualization library
https://bugzilla.redhat.com/show_bug.cgi?id=756776
Erik van Pienbroek changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #7 from Erik van Pienbroek ---
$ rpmlint mingw-libosinfo.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpmlint mingw-libosinfo-0.1.2-2.fc17.src.rpm
mingw-libosinfo.src: W: spelling-error Summary(en_US) virtualization ->
visualization, actualization, vitalization
mingw-libosinfo.src: W: spelling-error %description -l en_US virtualization ->
visualization, actualization, vitalization
mingw-libosinfo.src: W: spelling-error %description -l en_US hypervisor ->
hyper visor, hyper-visor, supervisory
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
$ rpmlint mingw32-libosinfo-0.1.2-2.fc17.noarch.rpm
mingw64-libosinfo-0.1.2-2.fc17.noarch.rpm
mingw32-libosinfo.noarch: W: manpage-not-compressed gz
/usr/i686-w64-mingw32/sys-root/mingw/share/man/man1/osinfo-detect.1
mingw32-libosinfo.noarch: W: manpage-not-compressed gz
/usr/i686-w64-mingw32/sys-root/mingw/share/man/man1/osinfo-query.1
mingw32-libosinfo.noarch: W: manpage-not-compressed gz
/usr/i686-w64-mingw32/sys-root/mingw/share/man/man1/osinfo-db-validate.1
mingw32-libosinfo.noarch: W: spelling-error Summary(en_US) virtualization ->
visualization, actualization, vitalization
mingw32-libosinfo.noarch: W: spelling-error %description -l en_US
virtualization -> visualization, actualization, vitalization
mingw32-libosinfo.noarch: W: spelling-error %description -l en_US hypervisor ->
hyper visor, hyper-visor, supervisory
mingw64-libosinfo.noarch: W: manpage-not-compressed gz
/usr/x86_64-w64-mingw32/sys-root/mingw/share/man/man1/osinfo-query.1
mingw64-libosinfo.noarch: W: manpage-not-compressed gz
/usr/x86_64-w64-mingw32/sys-root/mingw/share/man/man1/osinfo-db-validate.1
mingw64-libosinfo.noarch: W: manpage-not-compressed gz
/usr/x86_64-w64-mingw32/sys-root/mingw/share/man/man1/osinfo-detect.1
mingw64-libosinfo.noarch: W: spelling-error Summary(en_US) virtualization ->
visualization, actualization, vitalization
mingw64-libosinfo.noarch: W: spelling-error %description -l en_US
virtualization -> visualization, actualization, vitalization
mingw64-libosinfo.noarch: W: spelling-error %description -l en_US hypervisor ->
hyper visor, hyper-visor, supervisory
2 packages and 0 specfiles checked; 0 errors, 12 warnings.
$ rpm --query --requires mingw32-libosinfo
mingw32(kernel32.dll)
mingw32(libgio-2.0-0.dll)
mingw32(libglib-2.0-0.dll)
mingw32(libgobject-2.0-0.dll)
mingw32(libosinfo-1.0-0.dll)
mingw32(libxml2-2.dll)
mingw32(msvcrt.dll)
mingw32-crt
mingw32-filesystem >= 83
pkgconfig
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1
$ rpm --query --requires mingw64-libosinfo
mingw64(kernel32.dll)
mingw64(libgio-2.0-0.dll)
mingw64(libglib-2.0-0.dll)
mingw64(libgobject-2.0-0.dll)
mingw64(libosinfo-1.0-0.dll)
mingw64(libxml2-2.dll)
mingw64(msvcrt.dll)
mingw64-crt
mingw64-filesystem >= 83
pkgconfig
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1
$ rpm --query --provides mingw32-libosinfo
mingw32(libosinfo-1.0-0.dll)
mingw32-libosinfo = 0.1.2-2.fc17
$ rpm --query --provides mingw64-libosinfo
mingw64(libosinfo-1.0-0.dll)
mingw64-libosinfo = 0.1.2-2.fc17
$ wget --quiet
https://fedorahosted.org/releases/l/i/libosinfo/libosinfo-0.1.2.tar.gz -O - |
md5sum
f4bd25987a1576e7408d3635da6fb342 -
$ md5sum libosinfo-0.1.2.tar.gz
f4bd25987a1576e7408d3635da6fb342 libosinfo-0.1.2.tar.gz
+ OK
! Needs to be looked into
/ Not applicable
[+] Compliant with generic Fedora Packaging Guidelines
[+] Source package name is prefixed with 'mingw-'
[+] Spec file starts with %{?mingw_package_header}
[+] BuildRequires: mingw32-filesystem >= 95 is in the .spec file
[+] BuildRequires: mingw64-filesystem >= 95 is in the .spec file
[+] Spec file contains %package sections for both mingw32 and mingw64 packages
[+] Binary mingw32 and mingw64 packages are noarch
[+] Spec file contains %{?mingw_debug_package} after the %description section
[+] Uses one of the macros %mingw_configure, %mingw_cmake, or %mingw_cmake_kde4
to configure the package
[+] Uses the macro %mingw_make to build the package
[+] Uses the macro %mingw_make to install the package
[/] If package contains translations, the %mingw_find_lang macro must be used
[+] No binary package named mingw-$pkgname is generated
[!] Libtool .la files are not bundled
[+] .def files are not bundled
[!] Man pages which duplicate native package are not bundled
[+] Info files which duplicate native package are not bundled
[+] Provides of the binary mingw32 and mingw64 packages are equal
[+] Requires of the binary mingw32 and mingw64 packages are equal
Your package currently also bundles li
[Bug 756776] Review Request: mingw-libosinfo - MinGW Windows libvirt virtualization library
https://bugzilla.redhat.com/show_bug.cgi?id=756776 --- Comment #6 from Daniel Berrange --- Updated SRPM + specfile with those changes applied http://berrange.fedorapeople.org/review/mingw-libosinfo/mingw-libosinfo-0.1.2-2.fc18.src.rpm http://berrange.fedorapeople.org/review/mingw-libosinfo/mingw-libosinfo.spec -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756776] Review Request: mingw-libosinfo - MinGW Windows libvirt virtualization library
https://bugzilla.redhat.com/show_bug.cgi?id=756776 --- Comment #5 from Erik van Pienbroek --- Okay, let's go: - The BuildRoot tag is not needed any more with modern RPM, so it can be removed - The Requires: pkgconfig is currently mentioned in the global section (the mingw-libosinfo). However, as no mingw-libosinfo binary rpm is generated, this Requires flag doesn't have any effect. You might want to move it to the %package sections for the mingw32-libosinfo and mingw64-libosinfo packages - The quotes which you used in the %mingw_make_install "DESTDIR=$RPM_BUILD_ROOT" aren't needed any more and can be removed - The %defattr tags in the %files sections is also unneeded with modern RPM -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756776] Review Request: mingw-libosinfo - MinGW Windows libvirt virtualization library
https://bugzilla.redhat.com/show_bug.cgi?id=756776 Daniel Berrange changed: What|Removed |Added Summary|Review Request: |Review Request: |mingw32-libosinfo - MinGW |mingw-libosinfo - MinGW |Windows libvirt |Windows libvirt |virtualization library |virtualization library -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
