[Bug 759760] Review Request: perl-Encode-JIS2K - JIS X 0212 (aka JIS 2000) Encodings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=759760 --- Comment #5 from Jon Ciesla limburg...@gmail.com 2011-12-22 08:21:33 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 759760] Review Request: perl-Encode-JIS2K - JIS X 0212 (aka JIS 2000) Encodings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=759760 Xavier Bachelot xav...@bachelot.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2011-12-22 14:28:52 --- Comment #6 from Xavier Bachelot xav...@bachelot.org 2011-12-22 14:28:52 EST --- Imported and built for Rawhide, F16, F15, EL6 and EL5. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 759760] Review Request: perl-Encode-JIS2K - JIS X 0212 (aka JIS 2000) Encodings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=759760 Ville Skyttä ville.sky...@iki.fi changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #3 from Ville Skyttä ville.sky...@iki.fi 2011-12-21 16:59:11 EST --- Looks good. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 759760] Review Request: perl-Encode-JIS2K - JIS X 0212 (aka JIS 2000) Encodings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=759760 Xavier Bachelot xav...@bachelot.org changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Xavier Bachelot xav...@bachelot.org 2011-12-21 17:02:46 EST --- Thanks for the review, Ville. New Package SCM Request === Package Name: perl-Encode-JIS2K Short Description: JIS X 0212 (aka JIS 2000) Encodings Owners: xavierb Branches: f15 f16 el5 el6 InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 759760] Review Request: perl-Encode-JIS2K - JIS X 0212 (aka JIS 2000) Encodings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=759760 Ville Skyttä ville.sky...@iki.fi changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|ville.sky...@iki.fi Flag||fedora-review? --- Comment #1 from Ville Skyttä ville.sky...@iki.fi 2011-12-20 16:15:37 EST --- * Why include the ucm dir in docs? I think it's essentially 1.2M of source code that's not useful when installed. * Package is uninstallable after being built in Rawhide, it requires perl(Encode::JIS2K::2022JP3) which isn't provided by the package itself nor anything else in Fedora. Just a hunch, maybe the package declaration at top of lib/Encode/JIS2K/2022JP3.pm should be Encode::JIS2K::2022JP3 instead of Encode::JIS7::2022JP3. See the rpmdevtools perl spec template, following it would have prevented these issues: * perl-Encode-JIS2K.x86_64: E: zero-length /usr/lib64/perl5/vendor_perl/auto/Encode/JIS2K/JIS2K.bs * OPTIMIZE=$RPM_OPT_FLAGS missing from Makefile.PL line. * Unnecessary ownership of /usr/lib64/perl5/vendor_perl/auto dir, already owned by perl-libs. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 759760] Review Request: perl-Encode-JIS2K - JIS X 0212 (aka JIS 2000) Encodings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=759760 Ville Skyttä ville.sky...@iki.fi changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 759760] Review Request: perl-Encode-JIS2K - JIS X 0212 (aka JIS 2000) Encodings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=759760 --- Comment #2 from Xavier Bachelot xav...@bachelot.org 2011-12-20 19:11:07 EST --- Thanks Ville. I should have been more careful when cpanspec detected this module as noarch... Same for the other package. Bad package declaration filed upstream at https://rt.cpan.org/Public/Bug/Display.html?id=73401 New version : Spec URL: http://www.bachelot.org/fedora/SPECS/perl-Encode-JIS2K.spec SRPM URL: http://www.bachelot.org/fedora/SRPMS/perl-Encode-JIS2K-0.02-2.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
