[Bug 760153] Review Request: xcb-util-wm - Client and window-manager helper library on top of libxcb

2012-04-13 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=760153

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||xcb-util-wm-0.3.8-2.fc17
 Resolution||ERRATA
Last Closed||2012-04-14 00:30:08

--- Comment #6 from Fedora Update System upda...@fedoraproject.org 2012-04-14 
00:30:08 EDT ---
xcb-util-wm-0.3.8-2.fc17 has been pushed to the Fedora 17 stable repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 760153] Review Request: xcb-util-wm - Client and window-manager helper library on top of libxcb

2012-04-06 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=760153

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #5 from Fedora Update System upda...@fedoraproject.org 2012-04-06 
19:23:52 EDT ---
xcb-util-wm-0.3.8-2.fc17 has been pushed to the Fedora 17 testing repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 760153] Review Request: xcb-util-wm - Client and window-manager helper library on top of libxcb

2012-04-05 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=760153

--- Comment #4 from Fedora Update System upda...@fedoraproject.org 2012-04-05 
10:29:47 EDT ---
xcb-util-wm-0.3.8-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/xcb-util-wm-0.3.8-2.fc17

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 760153] Review Request: xcb-util-wm - Client and window-manager helper library on top of libxcb

2012-04-05 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=760153

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 760153] Review Request: xcb-util-wm - Client and window-manager helper library on top of libxcb

2012-04-03 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=760153

Thomas Moschny thomas.mosc...@gmx.de changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #2 from Thomas Moschny thomas.mosc...@gmx.de 2012-04-03 03:14:04 
EDT ---
Thanks for the review spot!

New Package SCM Request
===
Package Name: xcb-util-wm
Short Description: Client and window-manager helper library on top of libxcb
Owners: thm
Branches: f17
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 760153] Review Request: xcb-util-wm - Client and window-manager helper library on top of libxcb

2012-04-03 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=760153

--- Comment #3 from Jon Ciesla limburg...@gmail.com 2012-04-03 09:55:00 EDT 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 760153] Review Request: xcb-util-wm - Client and window-manager helper library on top of libxcb

2012-04-02 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=760153

Tom spot Callaway tcall...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||tcall...@redhat.com
 AssignedTo|nob...@fedoraproject.org|tcall...@redhat.com
   Flag||fedora-review+

--- Comment #1 from Tom spot Callaway tcall...@redhat.com 2012-04-02 
16:02:23 EDT ---
Review
===

There are some minor cleanups you can make like:

* drop rm -rf %{buildroot} from %install
* drop default defattr lines
* drop BuildRoot line
* Use %{name}%{?_isa} instead of just %{name} in explicit Requires:
* Fix the devel description (s/xcb-utilwm/xcb-util-wm).

But all of those are minor. Just consider making those changes before
committing.

Good:

- rpmlint checks return:
xcb-util-wm.src: W: spelling-error Summary(en_US) libxcb - Libby
xcb-util-wm.src: W: spelling-error %description -l en_US ewmh - whew
xcb-util-wm.src: W: spelling-error %description -l en_US icccm - ICC
xcb-util-wm.x86_64: W: spelling-error Summary(en_US) libxcb - Libby
xcb-util-wm.x86_64: W: spelling-error %description -l en_US ewmh - whew
xcb-util-wm.x86_64: W: spelling-error %description -l en_US icccm - ICC
xcb-util-wm-devel.x86_64: W: spelling-error Summary(en_US) vm - cm, v, m
xcb-util-wm-devel.x86_64: W: spelling-error %description -l en_US utilwm -
utility

All safe to ignore.

- package meets naming guidelines
- package meets packaging guidelines
- license (MIT) OK, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r 

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review