[Bug 766932] Review Request: icfg - utiltiy for scriptable editing of network interface files
https://bugzilla.redhat.com/show_bug.cgi?id=766932 Terje Røsten changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2013-11-24 08:43:00 --- Comment #22 from Terje Røsten --- Package seems to imported and available in repos, closing ticket. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 766932] Review Request: icfg - utiltiy for scriptable editing of network interface files
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=766932
Terje Røsten changed:
What|Removed |Added
CC||terje...@phys.ntnu.no
--- Comment #1 from Terje Røsten 2011-12-13 08:21:25
EST ---
> Requires: python
# Might not needed, rpm find requirement of /usr/bin/python any way.
>mkdir -p $RPM_BUILD_ROOT/usr/bin
>mkdir -p $RPM_BUILD_ROOT/usr/share/man/man1
>install -m755 -p src/icfg $RPM_BUILD_ROOT/usr/bin/icfg
> install -m644 -p doc/icfg.1 $RPM_BUILD_ROOT/usr/share/man/man1/icfg.1
# Would use macros and -D option and reduce to:
install -m755 -D -p src/icfg $RPM_BUILD_ROOT%{_bindir}/icfg
install -m644 -D -p doc/icfg.1 $RPM_BUILD_ROOT%{_mandir}/man1/icfg.1
# Copyright headers missing in icfg script, add?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 766932] Review Request: icfg - utiltiy for scriptable editing of network interface files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=766932 Itamar Reis Peixoto changed: What|Removed |Added CC||ita...@ispbrasil.com.br AssignedTo|nob...@fedoraproject.org|ita...@ispbrasil.com.br Flag||fedora-review? --- Comment #2 from Itamar Reis Peixoto 2011-12-21 14:14:44 EST --- ok, I will take a look and I will review it if works for me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 766932] Review Request: icfg - utiltiy for scriptable editing of network interface files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=766932 --- Comment #3 from Itamar Reis Peixoto 2011-12-21 14:33:35 EST --- please explain for me how can I add a vlan10 into interface p1p1 ? I like the vlans interfaces called vlan10, vlan20, etc.. ( VLAN_PLUS_VID_NO_PAD ) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 766932] Review Request: icfg - utiltiy for scriptable editing of network interface files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=766932 Neil Horman changed: What|Removed |Added AssignedTo|ita...@ispbrasil.com.br |j...@redhat.com --- Comment #4 from Neil Horman 2011-12-22 10:24:51 EST --- Thank you for your offer, but I've already made a deal to have jcm review this, and I've started reviewing his bug, so I'd just as soon he did the official review on this. You're of course welcome to review/comment as well. To answer your question, the man page should have examples of this, if it doesn't I'll add it. But the command would be something like: icfg -c -i vlan10 -t vlan -s PHYSDEV=eth0 Replace vlan10 and eth0 of course with the appropriate corresponding vlan and physical device names that you want. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 766932] Review Request: icfg - utiltiy for scriptable editing of network interface files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=766932 --- Comment #5 from Neil Horman 2011-12-22 10:25:51 EST --- Terje, I'll fix those, along with whatever else jcm finds, thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 766932] Review Request: icfg - utiltiy for scriptable editing of network interface files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=766932 --- Comment #6 from Neil Horman 2011-12-28 10:23:38 EST --- ping, jcm, thought you were going to look at this over the weekend. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 766932] Review Request: icfg - utiltiy for scriptable editing of network interface files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=766932 --- Comment #7 from Jon Masters 2012-01-02 17:19:43 EST --- I am presently completing the review, sorry about that. Should have some comments for you in a few. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 766932] Review Request: icfg - utiltiy for scriptable editing of network interface files
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=766932
--- Comment #8 from Jon Masters 2012-01-02 18:26:48 EST ---
Terje raised the main issues I had already. Python dep might be extraneous.
Also very unlikely but I'm honestly not sure if SysV is a legacy trademark. Its
use is so profuse that I don't intend to object to it, just mention it here.
Summary: I think otherwise this package is ready, so it passes review. However
I am unable to set the flag (due to a quirk of BZ) so I filed a request with
rel-eng just now that they do so on my behalf.
Review
--
* PASS: rpmlint must be run on the source rpm and all binary rpms the build
produces
- The output pertains to a few false-positive spelling "errors", none
of
which are actual errors. Therefore this part of the test is passed.
** The output should be posted in the review:
$ rpmlint icfg-0.9-1.fc15.src.rpm
icfg.src: W: spelling-error %description -l en_US sysconfig -> configure
icfg.src: W: spelling-error %description -l en_US kickstart -> kick start,
kick-start, kicks tart
icfg.src: W: spelling-error %description -l en_US scriptable -> scrip table,
scrip-table, script able
icfg.src: W: spelling-error %description -l en_US sed -> tied, ed, seed
icfg.src: W: spelling-error %description -l en_US awk -> awl, aw, wk
1 packages and 0 specfiles checked; 0 errors, 5 warnings.
$ rpmlint icfg-0.9-1.fc16.noarch.rpm
icfg.noarch: W: spelling-error %description -l en_US sysconfig -> configure
icfg.noarch: W: spelling-error %description -l en_US kickstart -> kick start,
kick-start, kicks tart
icfg.noarch: W: spelling-error %description -l en_US scriptable -> scrip table,
scrip-table, script able
icfg.noarch: W: spelling-error %description -l en_US sed -> tied, ed, seed
icfg.noarch: W: spelling-error %description -l en_US awk -> awl, aw, wk
1 packages and 0 specfiles checked; 0 errors, 5 warnings.
(additionally no errors detected during package build)
* The package must be named according to the Package Naming Guidelines: PASS
* The spec file name must match the base package %{name}.spec unles your
package has an exemption: PASS
* The package must meet the Packaging Guidelines
- Naming guidelines already confirmed
- Version and Release is consistent
- License is consistent with FPG
- Package is useful without external bits (just scripts, NA)
- No inclusion of pre-built binaries or libraries (noarch scripts!)
- Obfuscated Code Contest: not entered. SPEC is clean.
- Architecture support: noarch, and not limited
- FHS: use seems to be consistent
- Libexec: not applicable
- /run: not applicable
- Binaries not dependent upon separate libraries: correct
- rpmlint has already been run (above)
- Changelogs: appear to be correct
- No use of deprecated packager tag
- No use of deprecated vendor tag
- No use of deprecated copyright tag
- Summary does not end in a period
- No use of pre-requires
- Source URL is correct and works
- Buildroot tag is allowed and ignored
- Clean section is present and allowed
- No build requires
- No use of pre-requires
- No use of file requires
- Assume python binary dep not automatic??? (check)
- No use of autogenerated provide filtering
- Exception not applicable
- Summary: seems concise and reasonable
- Description: seems fine, is "SysV" a trademark?
- Encoding: meets the requirement for ASCII
- Documentation: is included using correct macro
- Compiler flags: not applicable
- PIE: not applicable
- Debuginfo packages: not applicable
- Devel packages: not applicable
- Pkgconfig files: not applicable
- Requiring base package: not applicable
- Shared libraries: not applicable
- Packaging static libraries: not applicable
- Statically linking executables: not applicable
- Duplication of system libraries: not appliable
- Beware of Rpath: not applicable
- Configuration files: not applicable
- Configuration of package managers: not applicable
- Systemd: not a startup service and not applicable
- Initscripts: not applicable
- Desktop files: not applicable
- Macro use is consistent
- Correct use of RPM_BUILD_ROOT macros
- No use of makeinstall macro (correct)
- No macros used in Summary and Description
- No improper use of _sourcedir macro
- No local or global macro defines
- No locale translations
- Preserve file timestamps - install command does so
- Parallel make is not applicable
- Scriptlets are not used
- Transactions are not manipulated
- Condition
[Bug 766932] Review Request: icfg - utiltiy for scriptable editing of network interface files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=766932 --- Comment #9 from Jon Masters 2012-01-02 18:28:30 EST --- Apologies for the delay in completing this. If you need any further assistance, I'll endeavor to turn it around swiftly. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 766932] Review Request: icfg - utiltiy for scriptable editing of network interface files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=766932 --- Comment #11 from Neil Horman 2012-01-02 21:13:44 EST --- nm, seems I'm able to do it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 766932] Review Request: icfg - utiltiy for scriptable editing of network interface files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=766932 Neil Horman changed: What|Removed |Added Flag|fedora-review? |fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 766932] Review Request: icfg - utiltiy for scriptable editing of network interface files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=766932 --- Comment #10 from Neil Horman 2012-01-02 21:12:32 EST --- Thank you, Jon, I appreciate the review. Terje's notes have been incorporated into the package already, and it appears that you have not other objections. If you could please set the fedora review flag to + so that I can get the SCM request submitted, I'd appreciate it. Thanks -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 766932] Review Request: icfg - utiltiy for scriptable editing of network interface files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=766932 Neil Horman changed: What|Removed |Added Flag||fedora-cvs? --- Comment #12 from Neil Horman 2012-01-02 21:16:35 EST --- New Package SCM Request === Package Name: icfg Short Description: sysv network configuration file command line editor Owners: nhor...@redhat.com, agosp...@redhat.com Branches: rawhide, fc16 InitialCC: nhor...@redhat.com, agosp...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 766932] Review Request: icfg - utiltiy for scriptable editing of network interface files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=766932 Itamar Reis Peixoto changed: What|Removed |Added Flag||needinfo?(nhor...@redhat.co ||m) --- Comment #13 from Itamar Reis Peixoto 2012-01-02 21:22:24 EST --- owners must be your fedora account username (fas) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 766932] Review Request: icfg - utiltiy for scriptable editing of network interface files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=766932 --- Comment #14 from Jon Masters 2012-01-02 21:28:43 EST --- Yea, per my email I was unable to set it as I have a BZ account (j...@redhat.com) that differs from my personal Fedora information and the various systems really don't like that. I guess I might just set everything to j...@redhat.com eventually. I filed a ticket before so I assume they'll just close that since you were able to set the flags now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 766932] Review Request: icfg - utiltiy for scriptable editing of network interface files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=766932 Neil Horman changed: What|Removed |Added Flag|needinfo?(nhor...@redhat.co | |m) | --- Comment #15 from Neil Horman 2012-01-03 06:42:45 EST --- New Package SCM Request === Package Name: icfg Short Description: sysv network configuration file command line editor Owners: nhorman Branches: rawhide, fc16 InitialCC: nhor...@redhat.com, agosp...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 766932] Review Request: icfg - utiltiy for scriptable editing of network interface files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=766932 --- Comment #16 from Jon Ciesla 2012-01-03 08:28:51 EST --- nhorman is not a valid FAS account. Use f16, not fc16. rawhide==devel, do not include, it's created by default. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 766932] Review Request: icfg - utiltiy for scriptable editing of network interface files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=766932 --- Comment #17 from Neil Horman 2012-01-03 08:46:10 EST --- Yes, nhorman is my fedora account username: https://admin.fedoraproject.org/accounts/user/view/nhorman I'm not sure what else you want, its worked perfectly well in the past: https://bugzilla.redhat.com/show_bug.cgi?id=491240 New Package SCM Request === Package Name: icfg Short Description: sysv network configuration file command line editor Owners: nhorman Branches: rawhide, f16 InitialCC: nhor...@redhat.com, agosp...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 766932] Review Request: icfg - utiltiy for scriptable editing of network interface files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=766932 Neil Horman changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 766932] Review Request: icfg - utiltiy for scriptable editing of network interface files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=766932 Jon Ciesla changed: What|Removed |Added CC||limburg...@gmail.com Flag|fedora-cvs? |fedora-cvs+ --- Comment #18 from Jon Ciesla 2012-01-03 10:25:40 EST --- Complete. Use FAS for initialCC, not email. agospoda isn't a valid FAS account. Also, don't include rawhide. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 766932] Review Request: icfg - utiltiy for scriptable editing of network interface files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=766932 --- Comment #19 from Andy Gospodarek 2012-01-03 11:11:29 EST --- (In reply to comment #18) > Use FAS for initialCC, not email. agospoda isn't a valid FAS account. The proper FAS account for 'agosp...@redhat.com' is gospo. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 766932] Review Request: icfg - utiltiy for scriptable editing of network interface files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=766932 --- Comment #20 from Itamar Reis Peixoto 2012-01-03 11:18:45 EST --- (In reply to comment #19) > (In reply to comment #18) > > Use FAS for initialCC, not email. agospoda isn't a valid FAS account. > > The proper FAS account for 'agosp...@redhat.com' is gospo. now is too late, request commit access here -> https://admin.fedoraproject.org/pkgdb/acls/name/icfg -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 766932] Review Request: icfg - utiltiy for scriptable editing of network interface files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=766932 Jon Masters changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #21 from Jon Masters 2012-02-12 14:15:22 EST --- Should we close this or set it to some state now? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
